D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

ntninja added a comment. Thanks, I'll keep that in mind for next time. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D12709 To: ntninja, dfaure Cc: dfaure, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

ntninja added inline comments. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:79 > What about this comment? Well, it isn't actually required and it compiles just fine with both canberra and phonon missing. REPOSITORY R289 KNotifications REVISION DETAIL

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

ntninja added a comment. Since these changes have been approved and marked read-to-land for quite some time, could this please be done soon? Thank you! REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D12709 To: ntninja, dfaure Cc: dfaure, apol,

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

ntninja updated this revision to Diff 46035. ntninja added a comment. Updated to latest KF5 version and probably fixed the issue mentioned in review – although I have no idea what it was. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12674?vs=33575=46035 REVISION DETAIL

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

ntninja added a reviewer: kde-frameworks-devel. REVISION DETAIL https://phabricator.kde.org/D12674 To: ntninja, kde-frameworks-devel Cc: kde-frameworks-devel, apol, ltoscano, cgiboudeaux, michaelh, ngraham, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

tundracomp added a comment. The target application I'm building has only very minimal dependencies on Qt (just QtCore + QtWidgets + PyQt5) and no real dependencies on KDE. The application only has a size footprint of about 6MiB, the required Qt libraries use about 10MiB of space, the

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

tundracomp added a comment. I build a Qt app with „just enough“ KDE-integration for the Flatpak sandbox where I have no use for this KPackage stuff. I know I could just include the install handlers in the build and drop them afterwards, but that would require a build KNS (and all of *its*

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

tundracomp added a comment. Oh, I see! This wasn't obvious to me. Is this better now? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D12674 To: tundracomp Cc: kde-frameworks-devel, apol, ltoscano, cgiboudeaux, michaelh, ngraham, bruns

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

tundracomp set the repository for this revision to R289 KNotifications. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D12674 To: tundracomp Cc: kde-frameworks-devel,

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

tundracomp added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Any review of this would be greatly apprechiated… REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D12709 To: tundracomp Cc:

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

tundracomp added a comment. Could I get a new review on this please!? REVISION DETAIL https://phabricator.kde.org/D12674 To: tundracomp Cc: ltoscano, cgiboudeaux, #frameworks, michaelh, ngraham, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

tundracomp created this revision. tundracomp added a project: Frameworks. Restricted Application added a subscriber: Frameworks. tundracomp requested review of this revision. REVISION SUMMARY Currently building the KPackage install handlers is mandatory when building the

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

tundracomp added a comment. I used the web interface and I wasn't able to find the „Update Diff“ button (why not update patch or update commit?) in the right box until now. It should be fixed now. REVISION DETAIL https://phabricator.kde.org/D12674 To: tundracomp Cc: ltoscano,

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

tundracomp updated this revision to Diff 33575. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12674?vs=33526=33575 REVISION DETAIL https://phabricator.kde.org/D12674 AFFECTED FILES CMakeLists.txt To: tundracomp Cc: ltoscano, cgiboudeaux, #frameworks, michaelh, bruns

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

tundracomp added inline comments. INLINE COMMENTS > cgiboudeaux wrote in CMakeLists.txt:68 > there are no component, why do you use this keyword ? removing 'REQUIRED' was > enough I added this keyword because Qt5TTS has it too. Anyways, how do I *update* a patch on this thing? Do I just use

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

tundracomp created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. tundracomp requested review of this revision. REVISION SUMMARY Usage of Phonon is already optional in the source code; this commit updates the CMake file