D11820: Handle properties with multiple values

astippich abandoned this revision. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: astippich, #baloo, #frameworks, michaelh Cc: bruns, astippich, mgallien, elvisangelaccio, gennad, domson, ashaposhnikov, spoorun, abrahams

D11820: Handle properties with multiple values

astippich commandeered this revision. astippich added a reviewer: michaelh. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: astippich, #baloo, #frameworks, michaelh Cc: bruns, astippich, mgallien, elvisangelaccio, gennad, domson, ashaposhnikov, spoorun,

D17302: Add test for adding properties to result

astippich added a comment. ping REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20942: Reorder includes

This revision was automatically updated to reflect the committed changes. Closed by commit R286:7be7da0ee6f9: Reorder includes (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20942?vs=57337=57391 REVISION DETAIL

D20942: Reorder includes

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Reorder includes to make EBN happy REPOSITORY R286 KFileMetaData

D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

astippich accepted this revision. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D20914 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D20913: [TagLibExtractor] Fix crash on invalid Speex files

astippich accepted this revision. astippich added a comment. Given the outcome, I wish I never added support for speex files to the extractor because it was "easy to add". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20913 To: bruns, #baloo, #frameworks,

D20877: Fix exivextractor crash with malformed files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:e227a7ce4587: Fix exivextractor crash with malformed files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20877?vs=57157=57212

D20877: Fix exivextractor crash with malformed files

astippich marked 2 inline comments as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20877 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

astippich updated this revision to Diff 57157. astippich marked an inline comment as done. astippich added a comment. - add line break REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20877?vs=57135=57157 BRANCH fix_exiv_crash REVISION DETAIL

D20877: Fix exivextractor crash with malformed files

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in exiv2extractor.cpp:303 > Shouldn't there be a check here as well? And probably move the > `ratio.second` to after its assignment and immediately return. Yep, forgot REPOSITORY R286

D20877: Fix exivextractor crash with malformed files

astippich updated this revision to Diff 57135. astippich added a comment. - also check for altitude ref REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20877?vs=57130=57135 BRANCH fix_exiv_crash REVISION DETAIL https://phabricator.kde.org/D20877

D20877: Fix exivextractor crash with malformed files

astippich added inline comments. INLINE COMMENTS > bruns wrote in exiv2extractor.cpp:299 > `!it->empty()` ? Unfortunately, empty() does not exist. Same was done in https://phabricator.kde.org/D16165 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20877 To:

D20877: Fix exivextractor crash with malformed files

astippich added a reviewer: bruns. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20877 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

astippich created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Prevent a segfault by explicitly checking everywhere for valid entries. BUG: 405210 REPOSITORY

D17302: Add test for adding properties to result

astippich updated this revision to Diff 56729. astippich added a comment. - Test result document REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17302?vs=52894=56729 BRANCH test_result REVISION DETAIL https://phabricator.kde.org/D17302 AFFECTED FILES

D20608: Declare properties as meta type

This revision was automatically updated to reflect the committed changes. Closed by commit R286:e869bac59302: Declare properties as meta type (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20608?vs=56387=56722 REVISION DETAIL

D20608: Declare properties as meta type

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Will be used in another test REPOSITORY R286 KFileMetaData

D20528: Change properties attributes for consistency

This revision was automatically updated to reflect the committed changes. Closed by commit R286:4808263e41bf: Change properties attributes for consistency (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20528?vs=56173=56385

D20529: add license to python test files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:eb9b1ef9b30d: add license to python test files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20529?vs=56174=56383 REVISION DETAIL

D19445: Handle variant list in formatting functions

This revision was automatically updated to reflect the committed changes. Closed by commit R286:ffdee4011145: Handle variant list in formatting functions (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19445?vs=55926=56384

D20526: fix extracting of some properties to match what was writen

astippich requested changes to this revision. astippich added a comment. This revision now requires changes to proceed. In D20526#449780 , @bruns wrote: > In D20526#449560 , @astippich wrote: > > >

D20523: Remove a dead declaration

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R824 Baloo Widgets BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D20523 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: gennad, domson, ashaposhnikov, astippich, spoorun,

D20529: add license to python test files

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY silence EBN REPOSITORY R286 KFileMetaData BRANCH py_license

D20528: Change properties attributes for consistency

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Move all the handling of (string-)lists into the member function,

D19445: Handle variant list in formatting functions

astippich added a dependent revision: D20528: Change properties attributes for consistency. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,

D20528: Change properties attributes for consistency

astippich added a dependency: D19445: Handle variant list in formatting functions. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20528 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D20526: fix extracting of some properties to match what was writen

astippich added a comment. IMHO for searching, the separation from a single string into multiple entries is the best thing to do, from a metadata editing point of view not so much. How about inserting the TStringList entry by entry, without using the contactsFromString method? That would

D20358: Force en locale for propertyinfotest

This revision was automatically updated to reflect the committed changes. Closed by commit R286:ccc0e0b9238e: Force en locale for propertyinfotest (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20358?vs=56002=56134 REVISION

D12222: baloodb: Use complete access filtering for all outputs

astippich added a comment. Herald added a subscriber: kde-frameworks-devel. @bruns this still applies cleanly to current master, do you think this and the dependent revision are still worth it to merge? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D1 To:

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich added a comment. And I propose a different one :) IMHO bundling these two is sub-optimal as it creates an unnecessary dependency on kde-specific libraries and limits its deployment. To me, this is the equivalent of bundling the audio thumbnailer with taglib. Well, if we

D20358: Force en locale for propertyinfotest

astippich updated this revision to Diff 56002. astippich added a comment. - add comment REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20358?vs=55760=56002 BRANCH fix_test REVISION DETAIL https://phabricator.kde.org/D20358 AFFECTED FILES

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich added a comment. It creates a dependency loop as you pointed out in the first comment REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson,

D20459: [balooctl] Extend options help text, improve error checking

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D20459 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov,

D19445: Handle variant list in formatting functions

astippich marked an inline comment as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

astippich updated this revision to Diff 55926. astippich added a comment. - remove unrequired parenthesis REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19445?vs=55326=55926 BRANCH generic_display_list REVISION DETAIL

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich added a comment. In D17500#447049 , @aacid wrote: > In D17500#446937 , @astippich wrote: > > > The plan I was about to propose is to move the thumbnailer to kdegraphics-thumbnailers and

D20358: Force en locale for propertyinfotest

astippich added a comment. It is a documentation bug. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20358 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich added a comment. The plan I was about to propose is to move the thumbnailer to kdegraphics-thumbnailers and remove it from the QMobipocket library, lifting the KIO dependency of QMobipocket. I think a KIO dependency for such a library is inconvenient. REPOSITORY R286

D17500: Restore mobipocket extractor

astippich updated this revision to Diff 55848. astippich added a comment. - rebase and update - update test - disable mobi extractor REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17500?vs=47335=55848 BRANCH mobi REVISION DETAIL

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich retitled this revision from "Restore mobipocket extractor" to "Get mobipocket extractor up-to-date, but keep disabled". astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc:

D20358: Force en locale for propertyinfotest

astippich added a comment. https://bugreports.qt.io/browse/QTBUG-75069 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20358 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code.

astippich added a comment. windows build fails https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/143/console REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20133 To: bruns, #baloo, #frameworks, #windows, #freebsd,

D19445: Handle variant list in formatting functions

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20358: Force en locale for propertyinfotest

astippich added a comment. There already was a bug report some time ago https://bugreports.qt.io/browse/QTBUG-15488 looks like it regressed. The given test in the bug report also does not work here. I will open a new one. REPOSITORY R286 KFileMetaData REVISION DETAIL

D20358: Force en locale for propertyinfotest

astippich updated this revision to Diff 55760. astippich added a comment. - use enum REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20358?vs=55684=55760 BRANCH fix_test REVISION DETAIL https://phabricator.kde.org/D20358 AFFECTED FILES

D11882: autotests: Use built executable instead of installed

astippich added a comment. @bruns this diff tries to accomplish the same as D19268 , and can be closed, right? REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11882 To: michaelh, elvisangelaccio, #baloo, #frameworks Cc:

D20345: Use compact Json format when converting query URLs

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH kio_search REVISION DETAIL https://phabricator.kde.org/D20345 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson,

D20364: Dont add default valued date filters to json

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH kio_search REVISION DETAIL https://phabricator.kde.org/D20364 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson,

D20358: Force en locale for propertyinfotest

astippich added inline comments. INLINE COMMENTS > bruns wrote in propertyinfotest.cpp:51 > This is somewhat strange ... > > According to > https://doc.qt.io/qt-5/qlocale.html#Language-enum > > > The "C" locale is identical in behavior to English/UnitedStates. > > So either "en" is not

D20360: Test all extractors with strict mime type

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0cfa32c2a376: Test all extractors with strict mime type (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20360?vs=55692=55703

D20328: [balooshow] Do not print a bogus warning for a non-indexed file

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. only one minor nitpick INLINE COMMENTS > main.cpp:136 > > +stream << "Url:" << url << "\n"; > stream << "GivenID: " << fid << " ActualID: " <<

D20360: Test all extractors with strict mime type

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Test all the extractors with the strictMimeType function

D20120: Use new mimetype helper in taglib extractor test

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0d9aebdd05b5: Use new mimetype helper in taglib extractor test (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20120?vs=55058=55691#toc REPOSITORY R286 KFileMetaData

D20120: Use new mimetype helper in taglib extractor test

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20120 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code.

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. Still kind of hard to read, especially on phabricator. Anyway, a definite improvement. Untested on anything besides linux REPOSITORY R286 KFileMetaData BRANCH master REVISION

D20359: Fix rating write for mp4 in newer TagLib versions

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY This fixes reading and writing rating via the mp4 rate atom. This

D20358: Force en locale for propertyinfotest

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Fix CI propertyinfotest REPOSITORY R286 KFileMetaData BRANCH

D20033: Default string formatting test to C locale, add localized run

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. works nicely! REPOSITORY R286 KFileMetaData BRANCH i18n REVISION DETAIL https://phabricator.kde.org/D20033 To: bruns, #baloo, #frameworks, ngraham, astippich Cc:

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

astippich added inline comments. INLINE COMMENTS > propertydata.cpp:88 > +if (it.value().isArray()) { > +const auto values = it.value().toArray(); > +for (const auto val : values) { Can you return arrays as lists here so that current behavior is unchanged, and

D18665: Cleanup taglib writer test

This revision was automatically updated to reflect the committed changes. Closed by commit R286:452edb1b4c80: Cleanup taglib writer test (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18665?vs=50711=55429 REVISION DETAIL

D18604: Implement support for writing rating information for taglib writer

This revision was automatically updated to reflect the committed changes. Closed by commit R286:8e79f7ce2b7c: Implement support for writing rating information for taglib writer (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D18603: Implement more tags for taglib writer

This revision was automatically updated to reflect the committed changes. Closed by commit R286:926c70460edc: Implement more tags for taglib writer (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18603?vs=55126=55427 REVISION

D18601: Rewrite taglib writer to use property interface

This revision was automatically updated to reflect the committed changes. Closed by commit R286:982ebe58b3c8: Rewrite taglib writer to use property interface (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18601?vs=55125=55426#toc REPOSITORY R286 KFileMetaData

D20121: Test ffmpeg extractor using mime type helper

This revision was automatically updated to reflect the committed changes. Closed by commit R286:25eca3185ffa: Test ffmpeg extractor using mime type helper (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20121?vs=55301=55425

D19445: Handle variant list in formatting functions

astippich updated this revision to Diff 55326. astippich added a comment. - rebase on master REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19445?vs=54956=55326 BRANCH generic_display_list REVISION DETAIL https://phabricator.kde.org/D19445

D20219: Propose Stefan Bruns as KFileMetaData maintainer

astippich added a comment. I think @bruns is much more qualified than me as a maintainer as I lack overall experience in programming. He still finds wrong stuff in almost any revision of mine :) also +1 for baloo REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL

D20121: Test ffmpeg extractor using mime type helper

astippich updated this revision to Diff 55301. astippich added a comment. - add friend and use member function REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20121?vs=55059=55301 BRANCH ffmpeg_mimetypes REVISION DETAIL

D18604: Implement support for writing rating information for taglib writer

astippich updated this revision to Diff 55298. astippich added a comment. - cleanup and formatting REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18604?vs=55127=55298 BRANCH rating_write2 REVISION DETAIL https://phabricator.kde.org/D18604

D20046: Verify mimetypes for all existing sample files, add some more

astippich added a comment. This causes one test failure on FreeBSD: https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/51/ REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20046 To: bruns, #baloo, #frameworks, astippich,

D20082: Safeguard against invalid files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1ac4253f3cf0: Safeguard against invalid files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20082?vs=54958=55296 REVISION DETAIL

D20138: Add a helper to determine actual supported parent mime type

astippich added a comment. Oh, another idea: Cannot this be used to determine that the extractor supports the inheriting mimetype as required in D20121 ? Would need to be public for this, though, or the test needs to be made a friend class. REPOSITORY

D20138: Add a helper to determine actual supported parent mime type

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. Forget my comment, I thought it would be possible to share some code with the ExtractorCollection, but the implementation is too different REPOSITORY R286 KFileMetaData REVISION

D18604: Implement support for writing rating information for taglib writer

astippich updated this revision to Diff 55127. astippich added a comment. - rebase - simplify id3 rating to array REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18604?vs=55056=55127 BRANCH rating_write2 REVISION DETAIL

D18603: Implement more tags for taglib writer

astippich updated this revision to Diff 55126. astippich added a comment. - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18603?vs=50705=55126 BRANCH enhance_taglibwriter2 REVISION DETAIL https://phabricator.kde.org/D18603 AFFECTED

D18603: Implement more tags for taglib writer

astippich marked an inline comment as done. REPOSITORY R286 KFileMetaData BRANCH enhance_taglibwriter2 REVISION DETAIL https://phabricator.kde.org/D18603 To: astippich, bruns, mgallien, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,

D18601: Rewrite taglib writer to use property interface

astippich updated this revision to Diff 55125. astippich added a comment. - check that file is valid - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18601?vs=50704=55125 BRANCH rewrite_taglib2 REVISION DETAIL

D20082: Safeguard against invalid files

astippich added a comment. ping. I would like to land this for KF 5.57 to fix crashes in the taglib extractors because of invalid files once and for all. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20082 To: astippich, bruns Cc: kde-frameworks-devel,

D19445: Handle variant list in formatting functions

astippich added a comment. ping. This will be beneficial for handling lists regardless of the discussion in D19087 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc:

D20138: Add a helper to determine actual supported parent mime type

astippich added a comment. Shouldn't this go into MimeUtils? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20138 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun,

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

astippich added a subscriber: mgallien. astippich added a comment. My main concern is that this changes current behavior and as such is not backwards compatible. The rest is a bonus. That is why my plan was to make the extractors output (string-)lists as outlined in T8196

D20121: Test ffmpeg extractor using mime type helper

astippich added inline comments. INLINE COMMENTS > ffmpegextractor.cpp:64 > QStringLiteral("video/x-msvideo"), > +QStringLiteral("video/x-theora+ogg"), > }; This is quite specific to the codec. ExtractorCollection should handle this case I think (mime type of file is more specific

D20121: Test ffmpeg extractor using mime type helper

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Use mime type helper to test ffmpeg extractor and add new mime

D20120: Use new mimetype helper in taglib extractor test

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Use the new mimetype helper in the taglib extractor test and fix

D18604: Implement support for writing rating information for taglib writer

astippich added a comment. After some thinking, I have split up the function for writing specific Ape and Vorbis tags, as many more tags like "Opus" etc. are in use for Vorbis tags and not for Ape, and can be easily added this way. I am still using the property map, though. Are you fine

D18604: Implement support for writing rating information for taglib writer

astippich updated this revision to Diff 55056. astippich added a comment. - split ape and vorbis tag writing functions REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18604?vs=50709=55056 BRANCH rating_write2 REVISION DETAIL

D17302: Add test for adding properties to result

astippich added a comment. In D17302#439605 , @bruns wrote: > IMHO this test is pointless, as the contents of the variant map is inaccessible, it is only an intermediate storage. The correct way to retrieve the data is via `Result::document()`.

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

astippich requested changes to this revision. astippich added a comment. This revision now requires changes to proceed. This still alters the map during deserialization. Lists are converted into multi single properties afterwards. As I said, due to backwards-compatibility lists should stay

D20011: Be more precise with mimetype detection

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a256687a1d11: Be more precise with mimetype detection (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20011?vs=54959=55055 REVISION DETAIL

D20011: Be more precise with mimetype detection

astippich edited the summary of this revision. astippich edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20011 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun,

D20011: Be more precise with mimetype detection

astippich updated this revision to Diff 54959. astippich added a comment. - use new mime type helper REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20011?vs=54649=54959 BRANCH mimetypes REVISION DETAIL https://phabricator.kde.org/D20011 AFFECTED FILES

D20082: Safeguard against invalid files

astippich added a comment. Seems like a good idea in general, and a patch for upstream to fix the crash was rejected. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20082 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov,

D20082: Safeguard against invalid files

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Invalid vorbis files may crash in taglib due to a dereference on

D17302: Add test for adding properties to result

astippich added a comment. ping? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

astippich updated this revision to Diff 54956. astippich marked an inline comment as done. astippich added a comment. - implement feedback REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19445?vs=54651=54956 BRANCH generic_display_list REVISION

D20012: Fix number localization for properties

This revision was automatically updated to reflect the committed changes. Closed by commit R286:607286e97229: Fix number localization for properties (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20012?vs=54950=54953 REVISION

D20013: Use Qt function for string list formatting

This revision was automatically updated to reflect the committed changes. Closed by commit R286:3a83a49a4350: Use Qt function for string list formatting (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20013?vs=54951=54954

D20013: Use Qt function for string list formatting

astippich added a comment. Is removing a string allowed during string freeze? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20013 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D19445: Handle variant list in formatting functions

astippich removed a dependent revision: D20013: Use Qt function for string list formatting. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,

D20013: Use Qt function for string list formatting

astippich removed a dependency: D19445: Handle variant list in formatting functions. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20013 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun,

<    1   2   3   4   5   6   7   8   9   10   >