Re: CI system maintainability

+1 for this. I think running tests before merging is more acceptable than having mandatory reviews. On 29 March 2019 11:10:52 GMT+00:00, Ovidiu-Florin Bogdan wrote: >Hello, > >A Merge Request in GitLab does not necessarily imply the need for a >review by e person. It can just run a pipeline to

D16344: Do not try to fallback to "less secure" protocols

stikonas added a comment. Line 89 in https://api.kde.org/frameworks/kio/html/ktcpsocket_8cpp_source.html suggests that it is the same as QSsl:SecureProtocols. Can you confirm that it works with TLSv1.2 only sites? (e.g. https://stikonas.eu:5281/admin/). Ideally we should test with

D13377: Fixup @since for skip switcher API

stikonas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D13377 To: fvogt, #plasma, stikonas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

stikonas added a comment. In D12311#252165 , @bruns wrote: > Resizing: http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Partition.html#gdbus-method-org-freedesktop-UDisks2-Partition.Resize Does not work well yet,

D12311: Align lock icon with bold message text; reduce overall size of dialog

stikonas added a comment. In D12311#250688 , @bruns wrote: > Gnome-disks does, and so do other programs. Gnome-disks uses UDisks to do everything and can't do anything on its own. So available features are very limited (not even resizing

D12311: Align lock icon with bold message text; reduce overall size of dialog

stikonas added a comment. In D12311#250660 , @bruns wrote: > No, thats completely off, as thats the action you are authorizing. > > > Authorization is required to format disk WDC WD10EZEX-08M2NA0 > > I want it to show what it is asking

D10495: Workaround to restore KF5 programs from system tray

stikonas abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D10495 To: stikonas, wbauer, #plasma, davidedmundson, volkov Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai,

D10518: Use QWidget to see if the window is visible

stikonas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D10518 To: apol, #frameworks, stikonas Cc: stikonas, michaelh

D10518: Use QWidget to see if the window is visible

stikonas accepted this revision. stikonas added a comment. This revision is now accepted and ready to land. Works for me. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D10518 To: apol, #frameworks, stikonas Cc: stikonas, michaelh

D10495: Workaround to restore KF5 programs from system tray

stikonas reclaimed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D10495 To: stikonas, wbauer, #plasma, davidedmundson, volkov Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai,

D10495: Workaround to restore KF5 programs from system tray

stikonas abandoned this revision. stikonas added a comment. Le's close it in favour of https://phabricator.kde.org/D10518 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D10495 To: stikonas, wbauer, #plasma, davidedmundson, volkov Cc: graesslin, #kwin,

D10495: Workaround to restore KF5 programs from system tray

stikonas updated this revision to Diff 27181. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10495?vs=27106=27181 REVISION DETAIL https://phabricator.kde.org/D10495 AFFECTED FILES src/kstatusnotifieritem.cpp To: stikonas, wbauer, #plasma,

D10495: Workaround to restore KF5 programs from system tray

stikonas added a comment. Well, basically when you click on any KF5 application (e.g. Konversation, KGpg, Akregator, etc...) in the system tray, nothing happens. This does no happen with Qt5-only programs. Clicking on system tray there always brings the window up. From what I can see

D10495: Workaround to restore KF5 programs from system tray

stikonas added a comment. This is more to start some discussion on system tray under Wayland. I'm not sure myself if this should be committed. I just use this workaround locally until winId() works on Wayland. REPOSITORY R289 KNotifications REVISION DETAIL

D10495: Workaround to restore KF5 programs from system tray

stikonas created this revision. stikonas added reviewers: wbauer, Plasma, davidedmundson, volkov. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. stikonas requested review of this revision. REVISION SUMMARY Currently

D4799: Delay notifications until desktop session has loaded

stikonas added a comment. This introduces a regression https://bugs.kde.org/show_bug.cgi?id=380974 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, dfaure, graesslin Cc: stikonas,

D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

stikonas accepted this revision. REPOSITORY R244 KCoreAddons BRANCH improveKAboutDataAPIDox REVISION DETAIL https://phabricator.kde.org/D5439 To: kossebau, #frameworks, aacid, mpyne, ltoscano, stikonas Cc: dfaure

D5405: Create desktop file name based on organization domain unless set explicitely

stikonas added a comment. > ! In https://phabricator.kde.org/D5405#101683, @graesslin wrote: > My comment was not meant as a stop-this-effort comment. If we can improve here to do more sane things I'm all for it. No, it's not your comment. We were discussing this on #kde-devel and it

D5405: Create desktop file name based on organization domain unless set explicitely

stikonas abandoned this revision. stikonas added a comment. Ok, so let us not change kcoreaddons now although it's still something that could have better default behaviour in KF6. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D5405 To: stikonas, mpyne,

D5405: Create desktop file name based on organization domain unless set explicitely

stikonas added a comment. In fact API documentation says explicitely that > IMPORTANT: if the organization domain is set, the .desktop file that describes your application should have an entry like X-DBUS-ServiceName=reversed_domain.kmyapp For instance kwrite passes

D5405: Create desktop file name based on organization domain unless set explicitely

stikonas added a comment. In https://phabricator.kde.org/D5405#101575, @mak wrote: > In https://phabricator.kde.org/D5405#101574, @ltoscano wrote: > > > I'm still confused. Documentation or not, bad usage or not, is it correct that desktop file name is constructed from both the

D5405: Create desktop file name based on organization domain unless set explicitely

stikonas created this revision. stikonas added a project: Plasma on Wayland. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY On Wayland icons are obtained from desktop files that are named

Re: Finding kdesu binary

> On Fri, Jan 29, 2016 at 3:33 PM, Andrius Štikonas > wrote: > > Hi, > > > > I would like to ask how do I find kdesu binary from the code (of > > partitionmanager). > > > > PartitionManager tries to restart itself with root privileges and tries to &g

Finding kdesu binary

Hi, I would like to ask how do I find kdesu binary from the code (of partitionmanager). PartitionManager tries to restart itself with root privileges and tries to rerun itself with kdesu, kdesudo or gksu... However, KF5 based kdesu is now in libexec, something like /usr/lib64/libexec/kf5/kdesu

Re: Finding kdesu binary

2016 m. sausio 29 d., penktadienis 17:30:32 GMT Aleix Pol rašė: > On Fri, Jan 29, 2016 at 5:03 PM, Andrius Štikonas <andr...@stikonas.eu> wrote: > >> On Fri, Jan 29, 2016 at 3:33 PM, Andrius Štikonas > >> wrote: > >> > Hi, > >> > > &g

KConfigXT for QGroupBox?

Dear all, Kdelibs4 had a widget called KButtonGroup. It is now deprecated in KDE Frameworks. The closest available replacement is QGroupBox. Unfortunately, I noticed that KConfigXT framework does not support it. It would be nice to have this feature... Kind regards, Andrius Štikonas P.S