Re: Breeze and ECM are incompatible for installing icons

On Friday, November 3, 2023 12:46:20 AM CET Albert Astals Cid wrote: > El dijous, 2 de novembre de 2023, a les 14:36:16 (CET), David Jarvie va > > escriure: > > Breeze installs its icons in a different directory structure from other > > icon themes, with the result that the ECM cmake command

Re : Re: KF6 meeting notes 2021-12-07

Le mercredi 8 décembre 2021 à 11:26 AM, David Redondo a écrit : > Am Dienstag, 7. Dezember 2021, 18:04:19 CET schrieb Volker Krause: > > > https://phabricator.kde.org/T11587 > > > > - there are bigger plans to rework color scheming, this needs more > > coordination with the effort to

Re: Respin request Kirigami

Le lundi 11 octobre 2021 à 12:56 PM, David Faure a écrit : > On lundi 11 octobre 2021 12:46:04 CEST Carl Schwan wrote: > > > I don't think it is so urgent that we need a 5.87.1 version of > > Kirigami. So it can't wait a month. > > Do you mean "it can't wait&qu

Re: Respin request Kirigami

Le lundi 11 octobre 2021 à 11:43 AM, David Faure a écrit : > On lundi 4 octobre 2021 12:39:35 CEST Carl Schwan wrote: > > > Please include > > https://invent.kde.org/frameworks/kirigami/-/commit/e7ffa04038307efef10c168 > > 2042e795d4a32a935 > > > > This fi

Respin request Kirigami

Hello, Please include https://invent.kde.org/frameworks/kirigami/-/commit/e7ffa04038307efef10c1682042e795d4a32a935 This fixes some nasty bugs for the Kirigami settings component. Carl Schwan https://carlschwan.eu

Re: QML API docs for C++ wrapper types?

Le vendredi 17 septembre 2021 à 3:23 PM, Volker Krause a écrit : > Hi, > do we have an example somewhere how to do API docs markup properly for C++ > wrappers for QML APIs? I don't think we have and it's currently with Doxygen a bit hard to do something similar to the Qt documentation with a

Re : KApiDox move from dedicated server to Jenkins

Le vendredi 10 septembre 2021 à 7:23 PM, Frederik Schwarzer a écrit : > Hi, Hi :D > we have been working on getting KApiDox to run on Jenkins. This work has > been taken way longer than I expected but has now reached a state close > to finished. :) > > So I would like to invite you to check

D28861: Sonnet add Malayalam trigram

ognarb added a subscriber: sandsmark. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28861 To: aiswaryak, #frameworks Cc: sandsmark, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29802: Require in-source build

ognarb accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb Cc: kde-frameworks-devel,

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

ognarb added a comment. In D29797#672263 , @kossebau wrote: > Thanks for the (first) review :) > > Open questions I have are these: > a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. +1 and also +1 for removing python2 support REPOSITORY R264 KApiDox BRANCH makedepworkwithpython3 REVISION DETAIL https://phabricator.kde.org/D29797 To: kossebau, #frameworks,

D29511: Label: Add ping-pong logic

ognarb requested changes to this revision. ognarb added a comment. This revision now requires changes to proceed. I'm not sure it is a good idea, but at least for me it break the clock in my panel. F8294594: vokoscreenNG-2020-05-07_17-49-49.mkv

D28811: Add drawer on mobile and clean code

This revision was automatically updated to reflect the committed changes. Closed by commit R264:e7645ba24570: Add drawer on mobile and clean code (authored by ognarb). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28811?vs=80229=81051#toc REPOSITORY R264 KApiDox CHANGES SINCE LAST

D29084: Make the HTML file template more useful

ognarb added a comment. In D29084#654489 , @gszymaszek wrote: > In D29084#654484 , @ognarb wrote: > > > - Don't include

D29084: Make the HTML file template more useful

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. Good idea to improve the default HTML file. Improvement ideas: - Don't include

D29049: add telephant icon

ognarb added a reviewer: muesli. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29049 To: mbruchert, muesli Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28811: Add drawer on mobile and clean code

ognarb added a comment. I now generate the CSS from aether-sass. The code can be found https://invent.kde.org/websites/aether-sass/-/blob/master/css/aether-sidebar.scss. And all tree wikis are using it. @ochurlaud should I create a sysadmin request for you to get access to the repo in

D28811: Add drawer on mobile and clean code

ognarb updated this revision to Diff 80229. ognarb added a comment. - Fix typo in path - Add information about there to find the source of the css files REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80228=80229 BRANCH flex-grid REVISION

D28811: Add drawer on mobile and clean code

ognarb updated this revision to Diff 80228. ognarb added a comment. This revision is now accepted and ready to land. - Use version from cdn REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80156=80228 BRANCH flex-grid REVISION DETAIL

D28811: Add drawer on mobile and clean code

ognarb added a comment. POC of sharing this code with the wikis: https://wikisandbox.kde.org/Welcome_to_KDE_TechBase REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To: ognarb, cblack, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack,

D28811: Add drawer on mobile and clean code

ognarb planned changes to this revision. ognarb added a comment. In D28811#648700 , @ochurlaud wrote: > I really dislike how you close brackets in css : it's more dense and harder to read. > > You indent sometimes with 1,2 or 3 spaces: it

D28811: Add drawer on mobile and clean code

ognarb retitled this revision from "WIP: Use CSS grid to improve layout" to "Add drawer on mobile and clean code". ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To:

D28811: WIP: Use CSS grid to improve layout

ognarb edited the summary of this revision. ognarb added reviewers: cblack, ochurlaud. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To: ognarb, cblack, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, michaelh,

D28811: WIP: Use CSS grid to improve layout

ognarb updated this revision to Diff 80156. ognarb added a comment. Add NoScript support REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80155=80156 BRANCH flex-grid REVISION DETAIL https://phabricator.kde.org/D28811 AFFECTED FILES

D28811: WIP: Use CSS grid to improve layout

ognarb updated this revision to Diff 80155. ognarb added a comment. - Add drawer on mobile (with JS) - Fix some layout issues REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80057=80155 BRANCH flex-grid REVISION DETAIL

D28811: WIP: Use CSS grid to improve layout

ognarb created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. ognarb requested review of this revision. REPOSITORY R264 KApiDox BRANCH flex-grid REVISION DETAIL https://phabricator.kde.org/D28811 AFFECTED

D28712: Redo api.kde.org to look more like Aether

ognarb accepted this revision. ognarb added a comment. LGTM REPOSITORY R264 KApiDox BRANCH cblack/aether (branched from master) REVISION DETAIL https://phabricator.kde.org/D28712 To: cblack, #vdg, ognarb, ochurlaud Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n,

D28712: Redo api.kde.org to look more like Aether

ognarb added a comment. Not tested yet but I like the style :) Though to be more consistent with the style used in other KDE websites, I would change the background color to #fff and use #f8f9fa for the sidebar. I also saw some alignment issues with the method args: F8227657:

D28712: Redo api.kde.org to look more like Aether

ognarb added a reviewer: ochurlaud. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28712 To: cblack, #vdg, ognarb, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D27851: Add rss icons in action

This revision was automatically updated to reflect the committed changes. Closed by commit R266:861f6ab52dc3: Add rss icons in action (authored by ognarb). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27851?vs=76976=76979 REVISION DETAIL

D27851: Add rss icons in action

ognarb edited the test plan for this revision. ognarb added a reviewer: ndavis. ognarb added a project: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27851 To: ognarb, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, trickyricky26,

D27851: Add rss icons in action

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. TEST PLAN Soon REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27851 AFFECTED FILES

D27601: KConfig: Convert to SPDX license statements

ognarb added inline comments. INLINE COMMENTS > cordlandwehr wrote in kcfg.xsd:20 > Actually, I though quite a time about this and at the end did a comparison of > the permissions specifically provided by this statement: use, copy and modify > (yet there is no explicit statement of

D27223: add kirigami-gallery icon

ognarb added a comment. In D27223#612284 , @mbruchert wrote: > I have no Idea why the diff deletes the ktrip icon. > unfortunately I cant fix that because I have no Idea how to do that with git. You can try to execute this git

D27434: Improve readme

ognarb added a comment. Maybe you could also mention the license and the maintainers in the README? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27434 To: nicolasfella, #frameworks, broulik Cc: ognarb, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27214: add puremaps icon

ognarb added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27214 To: mbruchert, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

ognarb added a reviewer: cullmann. ognarb added a comment. Adding a potential reviewer :) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar, mludwig, cullmann Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26010: Update the kiten log

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26010 To: ognarb Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26010: Update the kiten log

ognarb added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26010 To: ognarb, #breeze Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26010: Update the kiten log

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Mix the labplot icon and the hiraganas for kiten Another possibility would be to use the kile icon with the same

D24443: Add a plugin system

ognarb added inline comments. INLINE COMMENTS > dvratil wrote in calendarentry.h:63 > Use `std::unique_ptr const d` for automatic memory > management. This wasn't done, I still see `CalendarEntryPrivate *d;` > nicolasfella wrote in calendarplugin.h:39 > My idea was to be able to add a d-ptr

T11542: Remove KHTML

ognarb added a revision: D25714: Port away from deprecated KHtml. TASK DETAIL https://phabricator.kde.org/T11542 To: ognarb Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, davidre, GB_2, ahmadsamir, kpiwowarski, asturmlechner, cfeck, cullmann,

D25149: Add a new Template for KCM's.

ognarb added a comment. Another related todo would be to update/rewrite https://techbase.kde.org/Development/Tutorials/KCM_HowTo after this template is merged and include information about it ;) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25123: [WIP] New yakuake logo/icon

ognarb added a reviewer: hein. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, hein Cc: ognarb, ngraham, hein, kde-frameworks-devel, vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

ognarb added a comment. Instead of using uncrustify-kf5, shouldn't we use the clang-format file from T11214 ? REPOSITORY R374 KolourPaint REVISION DETAIL https://phabricator.kde.org/D24672 To: ahmadsamir, kde-frameworks-devel Cc: ognarb,

D24568: Provide clang-format target with a common KDE style file

ognarb added a comment. There is probably a way to run clang-format only on a patch. See http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting But should we not prefer running clang format one time, instead of having only some part of the code auto-formatted?

D24568: Provide clang-format target with a common KDE style file

ognarb added inline comments. INLINE COMMENTS > KDEClangFormat.cmake:11 > +# > +# :: > +# need doc REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann Cc: ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh,

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ognarb added inline comments. INLINE COMMENTS > kcategorydrawer.cpp:88 > +textRect.setTop(textRect.top() + 4); > +textRect.setLeft(textRect.left() + 8); > textRect.setHeight(fontMetrics.height()); Instead of using magic number, I would create a constant named padding.

D24390: Add more file and directories to exclude filters

ognarb added inline comments. INLINE COMMENTS > ngraham wrote in fileexcludefilters.cpp:137 > This one makes me a little nervous since it's a not-very-uncommon English > word, not something implicitly technical that we can be safe excluding. > > Is there any other way we could exclude the

D24390: Add more file and directories to exclude filters

ognarb added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24390 To: ognarb, #baloo Cc: kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D24390: Add more file and directories to exclude filters

ognarb created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. ognarb requested review of this revision. TEST PLAN None for the moment REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D24390

D21169: Add app icon for the Kirogi Drone control app

ognarb added a comment. kde.org/applications use the icons from breeze-icons. So I think it's worth adding to breeze-icons or improving how the icon are fetched in kde.org/applications. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21169 To: trickyricky26,

D19620: Use a searchbar similar to the one in okular

ognarb abandoned this revision. ognarb added a comment. I completly forgot about this patch and since KHTML is dead and is getting removed from most of our apps, it doesn't makes sence to land this patch. REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19620 To:

D24015: Added scripts to create a webfont out of all breeze action icons

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24015 To: fabianr, ndavis, ognarb Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2,

D24015: Added scripts to create a webfont out of all breeze action icons

ognarb added inline comments. INLINE COMMENTS > Gruntfile.js:13 > +types: 'eot,woff2,ttf,svg', > +optimize: false > +} why not true? REPOSITORY R266 Breeze Icons REVISION DETAIL

D22797: Fix typo - GridView -> ScrollView

This revision was automatically updated to reflect the committed changes. Closed by commit R296:2571616ec547: Fix typo - GridView - ScrollView (authored by ognarb). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22797?vs=62705=62708 REVISION DETAIL

D22797: Fix typo - GridView -> ScrollView

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Probably the result of a bad copy pasta ;) TEST PLAN Not tested REPOSITORY R296 KDeclarative BRANCH master

D22797: Fix typo - GridView -> ScrollView

ognarb added a reviewer: Plasma. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22797 To: ognarb, #plasma Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

ognarb updated this revision to Diff 59720. ognarb added a comment. Use more round corner. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59707=59720 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D21656: Create a breeze icon for kfourinline

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

ognarb updated this revision to Diff 59707. ognarb added a comment. Change color of some points REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59706=59707 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D21656: Create a breeze icon for kfourinline

ognarb updated this revision to Diff 59706. ognarb added a comment. Still works in progress (need to add the gradiend) but some improvement REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59372=59706 BRANCH master REVISION DETAIL

D21656: Create a breeze icon for kfourinline

ognarb updated this revision to Diff 59372. ognarb added a comment. Crop shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59371=59372 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D21656: Create a breeze icon for kfourinline

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

ognarb edited the test plan for this revision. ognarb added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D21574: Update KBruch icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:86d0782cf4e2: Update KBruch icon (authored by ognarb). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59187=59189 REVISION DETAIL

D21574: Update KBruch icon

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

ognarb updated this revision to Diff 59187. ognarb added a comment. - Optimize icon with scour-icon - Copy icon to breeze-dark - Remove png REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59131=59187 BRANCH kbruch REVISION DETAIL

D21574: Update KBruch icon

ognarb added a comment. In D21574#474171 , @ndavis wrote: > Wait, is this a PNG? This needs to be just an SVG. We don't ship PNGs in breeze-icons. Sorry it arc who also uploaded the png that I created for the review, I will fix it.

D21574: Update KBruch icon

ognarb updated this revision to Diff 59131. ognarb added a comment. Add shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59123=59131 BRANCH kbruch REVISION DETAIL https://phabricator.kde.org/D21574 AFFECTED FILES

D21574: Update KBruch icon

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

ognarb edited the test plan for this revision. ognarb added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Inspired from application-edu and cantor icon TEST PLAN Screenshot comming REPOSITORY R266 Breeze Icons BRANCH

D19771: Use placeholder instead of label

ognarb abandoned this revision. ognarb added a comment. I don't have time and the motivation for this revision anymore. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: dhaumann, cullmann, cfeck, loh.tar, ngraham,

D19771: Use placeholder instead of label

ognarb added a comment. Hi, I try to find time to look into it this weekend ;). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: dhaumann, cullmann, cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, domson,

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

ognarb added a comment. Why not mirror the Anjuta icon and use the same background color as the original Knights icon? So that it looks closer to the original. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21218 To: ngraham, #vdg Cc: ognarb,

D19895: Use https for links in the UI and documentation

ognarb added a comment. I made sure that all the links are still working. So +1 INLINE COMMENTS > kproxydlg.ui:45 > Automatic detection is performed using the bWeb Proxy Auto-Discovery > Protocol (WPAD)/b.p > -bNOTE:/b This option might not work properly or not work at > all in some

D19771: Use placeholder instead of label

ognarb added a comment. > I'm not aware of why we tend to use three dots instead of the real ellipsis character. Possibly because that character can be challenging to type. Best to follow the existing convention, I think. The advantage of using the unicode ellipsis character, is that

D19771: Use placeholder instead of label

ognarb added a task: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh,

D19620: Use a searchbar similar to the one in okular

ognarb updated this revision to Diff 53928. ognarb added a comment. Use Unicode ellipsis REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19620?vs=53906=53928 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 AFFECTED FILES

D19771: Use placeholder instead of label

ognarb planned changes to this revision. ognarb added a comment. Look likes I misread a part of the HIG: Since the placeholder won’t be visible anymore as soon as the user types, you should only use it on standalone input elements, not in groups of input elements such as forms. So the

D19771: Use placeholder instead of label

ognarb updated this revision to Diff 53922. ognarb added a comment. Use proper Unicode ellipsis REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19771?vs=53919=53922 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19771 AFFECTED FILES

D19771: Use placeholder instead of label

ognarb added a reviewer: VDG. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19771: Use placeholder instead of label

ognarb edited the summary of this revision. ognarb added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann,

D19771: Use placeholder instead of label

ognarb created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. ognarb requested review of this revision. REVISION SUMMARY See https://hig.kde.org/style/writing/placeholder.html Also change Find -> Search in Search and

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

ognarb updated this revision to Diff 53906. ognarb added a comment. Remove icon to option button REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19620?vs=53505=53906 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 AFFECTED FILES

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19557: Update design to look more similar to kde.org

This revision was automatically updated to reflect the committed changes. Closed by commit R238:a67daca8199c: Update design to look more similar to kde.org (authored by ognarb). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53616=53617 REVISION

D19557: Update design to look more similar to kde.org

ognarb added a comment. In D19557#428634 , @ltoscano wrote: > Thank you! And sorry for the ping-pong. No problems ;) Thanks for the review. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL

D19557: Update design to look more similar to kde.org

ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation, yurchor, ltoscano Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh,

D19557: Update design to look more similar to kde.org

ognarb updated this revision to Diff 53616. ognarb added a comment. Don't change image link and remove kde.png REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53603=53616 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557

D19557: Update design to look more similar to kde.org

ognarb retitled this revision from "Update css" to "Update design to look more similar to kde.org". ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg,

D19557: Update css

ognarb added a comment. In D19557#428618 , @ltoscano wrote: > In D19557#428617 , @ognarb wrote: > > > They use the old link for the image, also the jpg version instead of the png. I tested with new

D19557: Update css

ognarb added a comment. In D19557#428614 , @ltoscano wrote: > No, wait a minute. What happens with pages which are not regenerated? They use the old link for the image, also the jpg version instead of the png. I tested with new page and

  1   2   >