cgiboudeaux added a comment.
-1. They don't match the ECM coding style and code quality (doc, license,
endif(), pkgconfig...)
And :
> kdelibs4support/cmake/modules/FindGLIB2.cmake
> ecm/attic/modules/FindGLIB2.cmake
These two are there for legacy purpose.
> phonon/cmake/
cgiboudeaux added inline comments.
INLINE COMMENTS
> KDECMakeSettings.cmake:361
> +function(_find_json_recipe json_recipe)
> +execute_process(COMMAND git ls-files *org.kde.*.json
> +OUTPUT_VARIABLE json
find_package(Git)
if(Git_FOUND)
execute_process(COMMAND GIT_EXECUTABLE...
else(
cgiboudeaux added a comment.
In https://phabricator.kde.org/D7198#134234, @cgiboudeaux wrote:
> Fixed with
https://phabricator.kde.org/R240:7e7b6da8c66b7ecf1c21f330c31ffe7975259498
(+ https://phabricator.kde.org/R240:ef01c93637e1840ee701673970a371c011e36a40)
REPOSITORY
R240 Ext
cgiboudeaux added a comment.
Fixed with
https://phabricator.kde.org/R240:7e7b6da8c66b7ecf1c21f330c31ffe7975259498
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7198
To: dfaure, cgiboudeaux, kfunk
Cc: aacid, kfunk, #frameworks, #build_system
cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7198
To: dfaure, cgiboudeaux
Cc: #frameworks, #build_system
Hi,
CMake 3.8 comes with a change that could break compilation under certain
circumstances.(*)
in CMake < 3.8, automoc'ed files are stored in .
Starting with CMake 3.8, they're now created in :
/_autogen/include
What does it change ?
In most cases, nothing. moc files will be re-created.
The
Hi,
On mercredi 29 juin 2016 11:22:30 CEST Harald Sitter wrote:
> Hola!
>
> So, I just noticed that KDED's cmake package is inconsistently named.
>
> cmake/KF5DocTools/
> versus
> cmake/KDED/
>
> Is there a reason for this? Are we going to change this for KF6?
>
No and that sounds curious. KD
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123082/#review77839
---
Ship it!
Ship It!
- Christophe Giboudeaux
On March 20
> On March 18, 2015, 7:40 p.m., Christophe Giboudeaux wrote:
> > KF5KrossConfig.cmake.in, line 9
> > <https://git.reviewboard.kde.org/r/123031/diff/1/?file=355503#file355503line9>
> >
> > Are you sure ?
> >
> > ./ui/actioncollectio
g/r/123031/#comment53326>
Are you sure ?
./ui/actioncollectionview.h:27:#include
- Christophe Giboudeaux
On March 18, 2015, 5:34 p.m., Hrvoje Senjan wrote:
>
> ---
> This is an automatically generated e-mail.
LOADED DICTIONARY:
/usr/share/hunspell/fr_FR.aff
/usr/share/hunspell/fr_FR.dic
src/plugins/hunspell/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122987/#comment53312>
endif()
- Christophe Giboudeaux
On March 17, 2015, 1:09 p.m., Eugene Sh
> On nov. 3, 2014, 7:59 après-midi, Christophe Giboudeaux wrote:
> > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the
> > facebook resource builds fine without this patch).
> >
> > KF5PimUtilsTargets.cmake sets this:
> > set_targ
> On nov. 3, 2014, 7:59 après-midi, Christophe Giboudeaux wrote:
> > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the
> > facebook resource builds fine without this patch).
> >
> > KF5PimUtilsTargets.cmake sets this:
> > set_targ
> On nov. 3, 2014, 7:59 après-midi, Christophe Giboudeaux wrote:
> > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the
> > facebook resource builds fine without this patch).
> >
> > KF5PimUtilsTargets.cmake sets this:
> > set_targ
> On nov. 3, 2014, 7:59 après-midi, Christophe Giboudeaux wrote:
> > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the
> > facebook resource builds fine without this patch).
> >
> > KF5PimUtilsTargets.cmake sets this:
> > set_targ
-------
>
> (Updated June 30, 2014, 9:53 p.m.)
>
>
> Review request for KDE Frameworks, Polkit Qt, Aleix Pol Gonzalez, and
> Christophe Giboudeaux.
>
>
> Repository: polkit-qt-1
>
>
> Description
>
_PUBLIC
gui/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119043/#comment42702>
LINK_PRIVATE
- Christophe Giboudeaux
On June 30, 2014, 8:28 p.m., Hrvoje Senjan wrote:
>
> ---
> This is an autom
changing the paths, fixing the 'Requires:' lines would be a good idea.
The rest looks correct.
- Christophe Giboudeaux
On June 30, 2014, 6:19 p.m., Hrvoje Senjan wrote:
>
> ---
> This is an automatically generated e-ma
way, generated headers (e.g: kcfg files) don't have to be treated manually.
Diffs
-
modules/ECMGenerateHeaders.cmake 739c211
Diff: https://git.reviewboard.kde.org/r/117155/diff/
Testing
---
Thanks,
Christophe Giboudeaux
__
Diffs
-
modules/ECMGenerateHeaders.cmake 739c211
Diff: https://git.reviewboard.kde.org/r/117155/diff/
Testing
---
Thanks,
Christophe Giboudeaux
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/lis
org/r/117012/#comment37772>
(Most of) the other frameworks do the opposite: install the regular headers
in INCLUDE_INSTALL_DIR/.
What about changing the line above to have everything installed in
INCLUDE_INSTALL_DIR/KJsEmbed instead?
- Christophe Giboudeaux
On March 24, 2
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115379/#review48557
---
Ship it!
Ship It!
- Christophe Giboudeaux
On Jan. 29
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115140/#review47802
---
Ship it!
Ship It!
- Christophe Giboudeaux
On Jan. 20
, you could just remove
these lines.
- Christophe Giboudeaux
On Jan. 20, 2014, 9:59 a.m., Stefano Avallone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115087/#review47615
---
Ship it!
Ship It!
- Christophe Giboudeaux
On Jan. 17
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115086/#review47607
---
Ship it!
Ship It!
- Christophe Giboudeaux
On Jan. 17
94ad675
Diff: https://git.reviewboard.kde.org/r/114524/diff/
Testing
---
Built and installed all the framework modules in different prefixes without
issue.
The commit is already in the split kdoctools repo.
Thanks,
Christophe Giboudeaux
___
Kde
On Wednesday 18 December 2013 19:50:58 Alex Merry wrote:
> On 18/12/13 17:54, Aurélien Gâteau wrote:
> > We need to have at least a COPYING file in there, with the full content of
> > the license.
>
> I believe this was already done before the split.
>
I added COPYING files in each frameworks which
installed all the framework modules in different prefixes without
issue.
The commit is already in the split kdoctools repo.
Thanks,
Christophe Giboudeaux
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114521/#review45884
---
Ship it!
Ship It!
- Christophe Giboudeaux
On Dec. 17, 2013
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114522/#review45886
---
Ship it!
Ship It!
- Christophe Giboudeaux
On Dec. 17, 2013
kdnssd for headers ? (same thing line 89)
If you choose the later, the camelcased files in kde4support need to be
changed as well
- Christophe Giboudeaux
On Dec. 17, 2013, 4:43 p.m., Aurélien Gâteau wrote:
>
> ---
> This is a
change
tier1/itemmodels/autotests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/114518/#comment32740>
you didn't rename the macro
tier1/itemmodels/CMakeLists.txt
<http://git.reviewboard.kde.org/r/114518/#comment32741>
project(KItemModels)
- Christophe Giboud
/diff/
Testing
---
Thanks,
Christophe Giboudeaux
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
s always use CMAKE_INSTALL_PREFIX,
> default path is important only for people how build for themself. If someone
> want to build for himself he will prefer Qt prefix. Anyway I very doubt that
> he want to install in /usr/local, more likely he will use
> CMAKE_INSTALL_PREFIX with othe
s always use CMAKE_INSTALL_PREFIX,
> default path is important only for people how build for themself. If someone
> want to build for himself he will prefer Qt prefix. Anyway I very doubt that
> he want to install in /usr/local, more likely he will use
> CMAKE_INSTALL_PREFIX with othe
> On Sept. 1, 2013, 5:16 p.m., David Faure wrote:
> > Looks fine to me.
>
> Ivan Romanov wrote:
> I don't agree with this patch. I didn't get any notification about this.
> So I very ask you before do any changes in cmake rules talk with me. It is
> important for me.
>
> David Faure wrote
with https://git.reviewboard.kde.org/r/111937 without the
'find_package(LibAttica NO_MODULE) line'.
Thanks,
Christophe Giboudeaux
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-
://git.reviewboard.kde.org/r/112038/diff/
Testing
---
Konsole build with https://git.reviewboard.kde.org/r/111937 without the
'find_package(LibAttica NO_MODULE) line'.
Thanks,
Christophe Giboudeaux
___
Kde-frameworks-devel mailing list
Kde-
---
Konsole build with https://git.reviewboard.kde.org/r/111937 without the
'find_package(LibAttica NO_MODULE) line'.
Thanks,
Christophe Giboudeaux
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.o
://git.reviewboard.kde.org/r/111937 without the
'find_package(LibAttica NO_MODULE) line'.
Thanks,
Christophe Giboudeaux
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
g/r/111080/#comment26924>
Please add INCLUDE_QUIET_PACKAGES to your feature_summary calls.
one could believe that "WHAT ALL" prints all but that doesn't include
packages searched using the QUIET keyword
- Christophe Giboudeaux
On July 23, 2013, 8:02 a.m.,
On Monday 03 June 2013 12:34:46 David Faure wrote:
> On Monday 20 May 2013 11:53:18 Alexander Neundorf wrote:
> > there was a review request for a find-module for libusb1 here a few days
> > ago, which we have already in e-c-m, but he can't use it because it is
> > not
> > released
>
> Could we m
> On Dec. 26, 2012, 9:12 a.m., Christophe Giboudeaux wrote:
> > knewstuff/knewstuff3/CMakeLists.txt, line 21
> > <http://git.reviewboard.kde.org/r/107911/diff/1/?file=101183#file101183line21>
> >
> > endif()
> >
> > Plea
ts.txt
<http://git.reviewboard.kde.org/r/107911/#comment18267>
else()
knewstuff/knewstuff3/CMakeLists.txt
<http://git.reviewboard.kde.org/r/107911/#comment18268>
endif()
- Christophe Giboudeaux
On Dec. 25, 2012, 8:26 p
On Friday 10 August 2012 20:11:24 Alexander Neundorf wrote:
> -- Forwarded Message --
>
> Subject: [CMake] CMake 2.8.9 available for download
> Date: Thursday 09 August 2012, 23:17:04
> From: David Cole
> To: cm...@cmake.org
>
> On behalf of myself, Ken, Bill, Brad, Alex, Zach,
Hi,
On Friday 25 November 2011 02:24:55 Stephen Kelly wrote:
> == Communicating build parameters between modules ==
>
> Some people don't want to set custom parameters for certain install
> directories and have those locations picked up by other depending modules.
> Eg, if a custom value is set
301 - 347 of 347 matches
Mail list logo
