Re: Review Request 127923: Add support for custom emoticon sizes

2016-05-15 Thread David Gil Oliva
> On Mayo 15, 2016, 8:34 a.m., David Gil Oliva wrote: > > +1 > > > > Looks ok to me :-) ... when issue is fixed, of course - David --- This is an automatically generated e-mail. To reply, visit: https://git.

Re: Review Request 127923: Add support for custom emoticon sizes

2016-05-15 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127923/#review95477 --- +1 Looks ok to me :-) - David Gil Oliva On Mayo 15, 2016

Re: Review Request 123178: [KCompletion] Delete condition inside KLineEdit::keyPressEvent that is already checked in a former condition

2015-04-09 Thread David Gil Oliva
Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123178: [KCompletion] Delete condition inside KLineEdit::keyPressEvent that is already checked in a former condition

2015-04-07 Thread David Gil Oliva
the length of it and the number of conditions). Diffs (updated) - src/klineedit.cpp 7c2d0f9 Diff: https://git.reviewboard.kde.org/r/123178/diff/ Testing --- Tests pass Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde

Review Request 123178: [KCompletion] Delete condition inside KLineEdit::keyPressEvent that is already checked in a former condition

2015-03-29 Thread David Gil Oliva
Diff: https://git.reviewboard.kde.org/r/123178/diff/ Testing --- Tests pass Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KCompletion test failing

2015-03-26 Thread David Gil Oliva
Hi! The following test fails. From the message about QCollator, I suspect it is due to QCollator, not to KCompletion. Someone can give me a hint whether I am right? Thanks! david@nimfa:~/devel/kf5-development/build/frameworks/kcompletion/autotests$ ./kcompletioncoretest * Start testing

Re: Review Request 122462: [KCompletion] Fix typos in documentation

2015-02-19 Thread David Gil Oliva
/kcompletion.h a6ed372 src/kcompletion_p.h 138c228 src/kcompletionbase.h 6111f9a src/kcompletionbox.h 1759eba src/klineedit.h 460a2ae src/kzoneallocator_p.h 2d75a83 Diff: https://git.reviewboard.kde.org/r/122462/diff/ Testing --- None needed Thanks, David Gil Oliva

Re: Review Request 122462: [KCompletion] Fix typos in documentation

2015-02-17 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122462/#review76202 --- Ping? - David Gil Oliva On feb. 8, 2015, 10:46 p.m., David

Re: Review Request 122462: [KCompletion] Fix typos in documentation

2015-02-08 Thread David Gil Oliva
., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122462/ --- (Updated feb. 6, 2015, 11:03 p.m.) Review

Re: Review Request 122462: [KCompletion] Fix typos in documentation

2015-02-08 Thread David Gil Oliva
/kcompletion.h a6ed372 src/kcompletion_p.h 138c228 src/kcompletionbase.h 6111f9a src/kcompletionbox.h 1759eba src/klineedit.h 460a2ae src/kzoneallocator_p.h 2d75a83 Diff: https://git.reviewboard.kde.org/r/122462/diff/ Testing --- None needed Thanks, David Gil Oliva

Review Request 122462: [KCompletion] Fix typos in documentation

2015-02-06 Thread David Gil Oliva
/ Testing --- None needed Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Re: Compile KF5 into Docker

2015-01-07 Thread David Gil Oliva
Hi! 2015-01-07 2:25 GMT+01:00 Mathieu Tarral mathieu.tar...@gmail.com: Hi David, Le 04/01/2015 13:55, David Gil Oliva a écrit : Hi! El dia 04/01/2015 12:39, Mathieu Tarral mathieu.tar...@gmail.com mailto:mathieu.tar...@gmail.com va escriure: Hi, as you know, building KF5 from

Re: Review Request 121210: Provide an accessible name for KLed

2014-11-22 Thread David Gil Oliva
/#comment49498 It should be hidden behind the d-pointer. - David Gil Oliva On Nov. 22, 2014, 4:32 p.m., José Millán Soto wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121210

Re: Review Request 121210: Provide an accessible name for KLed

2014-11-22 Thread David Gil Oliva
On Nov. 22, 2014, 4:40 p.m., David Gil Oliva wrote: src/kled.h, line 257 https://git.reviewboard.kde.org/r/121210/diff/1/?file=329497#file329497line257 It should be hidden behind the d-pointer. José Millán Soto wrote: Why should it be hidden? As it is not a virtual

Re: How to port KTabBar::mouseMiddleClick?

2014-11-11 Thread David Gil Oliva
El 10/11/2014 19:19, Nicolás Alvarez nicolas.alva...@gmail.com escribió: 2014-11-09 7:28 GMT-03:00 Frank Reininghaus frank7...@googlemail.com: Hi, 2014-11-06 2:59 GMT+01:00 Milian Wolff: Hey all, what do I do to get middle-click-closes-tab in Qt 5 without KTabBar? Previously, we

Re: Review Request 120173: Add unicode emoticons to Glass theme

2014-09-13 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120173/#review66379 --- On set. 12, 2014, 9:17 p.m., David Gil Oliva wrote

Re: Review Request 120173: Add unicode emoticons to Glass theme

2014-09-13 Thread David Gil Oliva
/Glass/emoticons.xml dad55e2 Diff: https://git.reviewboard.kde.org/r/120173/diff/ Testing --- I tested with kemoticonstest, in the test folder. It doesn't work with Qt 5.2. It works with Qt 5.4. I haven't tested with Qt 5.3. Thanks, David Gil Oliva

Review Request 120173: Add unicode emoticons to Glass theme

2014-09-12 Thread David Gil Oliva
--- I tested with kemoticonstest, in the test folder. It doesn't work with Qt 5.2. It works with Qt 5.4. I haven't tested with Qt 5.3. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Error building KService

2014-09-05 Thread David Gil Oliva
Hi! I get this error when building KService. I don't quite get it, what it means. Could someone help me deciphering the error? Thanks! David Gil # kdesrc-build running: 'make' '-j2' # from directory: /home/david/devel/kf5-development/build/frameworks/kservice Scanning dependencies of target

Re: split kdepimlibs

2014-08-26 Thread David Gil Oliva
El 26/08/2014 15:49, Vishesh Handa m...@vhanda.in escribió: On Tuesday, August 26, 2014 11:50:50 AM Kevin Ottens wrote: gpgme++ kabc kalarmcal kblog kcalcore kcalutils This one looks like a dumping ground of random things. Maybe some of it should move in other

Re: Snippetextractor comments in framework examples

2014-08-11 Thread David Gil Oliva
Hi! El 11/08/2014 10:35, Rohan Garg ro...@kde.org escribió: Hi everyone As part of writing the KDE Frameworks 5 book, we were wondering if it's fine with all the framework maintainers if we started adding snippetextractor comments in the examples to be able to directly quote things in the

Re: KF5 is not longer building against Qt 5.4

2014-08-04 Thread David Gil Oliva
Hi! El 04/08/2014 17:02, Aleix Pol aleix...@kde.org escribió: Hi, I just found out that qMessageFormatString got renamed into qMessageFormatString, actually into qFormatLogMessage ;-) Cheers David Gil that's the commit message [1]. Anybody has a better solution than a good ol' ifdef?

Re: Minimum translation percentage for frameworks release

2014-07-31 Thread David Gil Oliva
Hi! El 31/07/2014 20:57, Alexander Potashev aspotas...@gmail.com escribió: 2014-07-31 21:32 GMT+04:00 Albert Astals Cid aa...@kde.org: So you have an application, let's say VLC that is using some KDE framework, now VLC itself is in catalan at 100%, but that KDE framework is in catalan

Re: Review Request 119417: kconfig: Fix QBasicAtomicInt being treated as int (reposted)

2014-07-25 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119417/#review63136 --- Ping? - David Gil Oliva On jul. 22, 2014, 11:35 p.m

Review Request 119417: kconfig: Fix QBasicAtomicInt being treated as int (reposted)

2014-07-22 Thread David Gil Oliva
whatsoever. Since this patch is needed to compile kconfig, I resend it. Diffs - src/core/kconfig.cpp 14a5d39 Diff: https://git.reviewboard.kde.org/r/119417/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde

Re: KConfig build fails

2014-07-15 Thread David Gil Oliva
Hi! 2014-07-15 17:16 GMT+02:00 Daniel Vrátil dvra...@redhat.com: On Tuesday 15 of July 2014 12:09:43 David Gil Oliva wrote: El 15/07/2014 10:02, David Faure fa...@kde.org escribió: On Tuesday 15 July 2014 00:51:20 David Gil Oliva wrote: Hi! 2014-07-15 0:19 GMT+02:00 Frank

Re: Review Request 119257: kconfig: Fix QBasicAtomicInt being treated as int.

2014-07-15 Thread David Gil Oliva
Gil Oliva On jul. 13, 2014, 4:11 p.m., Andreas Xavier wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119257

Re: KConfig build fails

2014-07-14 Thread David Gil Oliva
Hi! 2014-07-15 0:19 GMT+02:00 Frank Reininghaus frank7...@googlemail.com: Hi, 2014-07-14 23:21 GMT+02:00 David Gil Oliva: Hi! KConfig build fails with this messages, all of them related to QBasicAtomicInt. Are they KF5 bugs? probably this is the same issue that has been discussed

Error building cmake-git

2014-07-13 Thread David Gil Oliva
Hi! I'm trying to build KEmoticons and KCompletion with kdesrc-build, but it fails right from the cmake-git compilation. Its SHA1 ID is 6ac04aee51ab3cb9c05efb6f6195bf34f9609fae . This is the error that it gives: david@nimfa:~/devel/kf5-development/build/cmake-git$ make -j2 [ 1%] Built target

Re: OSX/CI system: kgeography build broken on branch frameworks

2014-07-10 Thread David Gil Oliva
Hi! El 10/07/2014 07:12, Marko Käning mk-li...@email.de escribió: Hi, I ran into a build failure with geography because of a missing docbook file. I began the port to kf5. I was waiting until August, which is when I'll have more time to finish it. Some parts need a rewriting and the family

Review Request 119186: Change KDE_NO_DEPRECATED to KEMOTICONS_NO_DEPRECATED

2014-07-08 Thread David Gil Oliva
--- Change KDE_NO_DEPRECATED to KEMOTICONS_NO_DEPRECATED Diffs - src/core/kemoticonsprovider.h cbf03b0 src/core/kemoticonstheme.h 6a38941 Diff: https://git.reviewboard.kde.org/r/119186/diff/ Testing --- It builds and tests pass. Thanks, David Gil Oliva

Re: Deprecation Defines

2014-07-08 Thread David Gil Oliva
Hi! 2014-07-07 23:39 GMT+02:00 David Faure fa...@kde.org: On Monday 05 May 2014 13:14:07 Alex Merry wrote: On 05/05/14 07:27, Matthew Dawson wrote: Hi all, I was looking into my frameworks, to prepare them for the 5.0. One thing was looking into was the deprecation defines. In

Review Request 119189: Change KDE_NO_DEPRECATED to KCOMPLETION_NO_DEPRECATED

2014-07-08 Thread David Gil Oliva
--- Change KDE_NO_DEPRECATED to KCOMPLETION_NO_DEPRECATED Diffs - src/ksortablelist.h 8f7c52c Diff: https://git.reviewboard.kde.org/r/119189/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 119189: Change KDE_NO_DEPRECATED to KCOMPLETION_NO_DEPRECATED

2014-07-08 Thread David Gil Oliva
marked as submitted. Review request for KDE Frameworks. Repository: kcompletion Description --- Change KDE_NO_DEPRECATED to KCOMPLETION_NO_DEPRECATED Diffs - src/ksortablelist.h 8f7c52c Diff: https://git.reviewboard.kde.org/r/119189/diff/ Testing --- Thanks, David Gil

Re: Review Request 119186: Change KDE_NO_DEPRECATED to KEMOTICONS_NO_DEPRECATED

2014-07-08 Thread David Gil Oliva
/diff/ Testing --- It builds and tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Deprecation Defines

2014-07-07 Thread David Gil Oliva
Hi! I'll do kcompletion and kemoticons. Cheers, David Gil El 07/07/2014 23:39, David Faure fa...@kde.org escribió: On Monday 05 May 2014 13:14:07 Alex Merry wrote: On 05/05/14 07:27, Matthew Dawson wrote: Hi all, I was looking into my frameworks, to prepare them for the 5.0. One

Re: Review Request 117799: Clean up private slots in KCompletion

2014-05-02 Thread David Gil Oliva
Hi! El 02/05/2014 10:19, Luca Beltrame lbeltr...@kde.org escribió: Commit Hook wrote: 210ed36c1ae1e3ce33fbd752e460651e31d1a37d by David Gil to branch clean_up_private_slots. Was this the right branch, or a mistake? Oops! Did I create a branch? :-O I did something wrong. I will fix it on

Re: Review Request 117799: Clean up private slots in KCompletion

2014-05-01 Thread David Gil Oliva
--- It builds. Autotests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117799: Clean up private slots in KCompletion

2014-04-30 Thread David Gil Oliva
to be pushed before beta2 I won't be able to do it from Friday on, since I will be some days offline. - David Gil Oliva On April 26, 2014, 11:23 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit

Review Request 117799: Clean up private slots in KCompletion

2014-04-26 Thread David Gil Oliva
/khistorycombobox.h ea56358 src/khistorycombobox.cpp 9e2f0be src/klineedit.h 705147d src/klineedit.cpp 9d02c12 src/klineedit_p.h e544224 Diff: https://git.reviewboard.kde.org/r/117799/diff/ Testing --- It builds. Autotests pass. Thanks, David Gil Oliva

Re: Review Request 117318: Move methods from KCompletionPrivate to KCompletionMatchesWrapper

2014-04-02 Thread David Gil Oliva
://git.reviewboard.kde.org/r/117318/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117318: Move methods from KCompletionPrivate to KCompletionMatchesWrapper

2014-04-01 Thread David Gil Oliva
--- Move methods from KCompletionPrivate to KCompletionMatchesWrapper, where they actually belong. Diffs - src/kcompletion.cpp 17142f2 src/kcompletion_p.h 1858f23 Diff: https://git.reviewboard.kde.org/r/117318/diff/ Testing --- It builds. Tests pass. Thanks, David Gil

Re: Review Request 117104: Remove KLineEdit::clear(): it doesn't seem to modify clipboard anymore

2014-03-27 Thread David Gil Oliva
-5475a8ac94b9__kline.cpp Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117036: Refactor private variables and parameters in KCompletionBase and KLineEdit

2014-03-27 Thread David Gil Oliva
src/kcompletionbase.cpp f1cf347 src/klineedit.h 723cb42 Diff: https://git.reviewboard.kde.org/r/117036/diff/ Testing --- It builds and tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 116969: Deprecate reset() in KHistoryComboBox and substitute it for resetIndex()

2014-03-27 Thread David Gil Oliva
- autotests/kcombobox_unittest.cpp 1479ae2 src/khistorycombobox.h d1f5eac src/khistorycombobox.cpp 80261ae Diff: https://git.reviewboard.kde.org/r/116969/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

2014-03-26 Thread David Gil Oliva
Hi! El 26/03/2014 13:04, Jos Poortvliet jospoortvl...@gmail.com escribió: On Monday 17 March 2014 18:15:09 Kevin Ottens wrote: Hello, Thanks for the feedback! Adding kde-promo in CC since it might have implications on future communication. Ok, reading the whole thing - it seems a

Re: Review Request 117042: Make KLineEdit::completionBox virtual so that konq can reimplement it

2014-03-26 Thread David Gil Oliva
/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117037: Refactor parameter names

2014-03-26 Thread David Gil Oliva
: https://git.reviewboard.kde.org/r/117037/diff/ Testing --- It builds and tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117040: Remove FIXME in KCompletion

2014-03-26 Thread David Gil Oliva
/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116969: Deprecate reset() in KHistoryComboBox and substitute it for resetIndex()

2014-03-26 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116969/#review54248 --- Ping? - David Gil Oliva On March 24, 2014, 9:45 p.m

Review Request 117104: Remove KLineEdit::clear(): it doesn't seem to modify clipboard anymore

2014-03-26 Thread David Gil Oliva
://git.reviewboard.kde.org/media/uploaded/files/2014/03/26/fdc5ab2a-01ab-4fec-b88a-8c694d562da9__kline.h kline.cpp https://git.reviewboard.kde.org/media/uploaded/files/2014/03/26/9e4e8cc1-c7d5-4b72-9058-5475a8ac94b9__kline.cpp Thanks, David Gil Oliva ___ Kde-frameworks

Re: Review Request 116887: Undeprecate setUrlDropsEnabled(bool) in KComboBox and KLineEdit

2014-03-24 Thread David Gil Oliva
. The compiler warnings about this deprecation disappear. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116969: Deprecate reset() in KHistoryComboBox and substitute it for resetIndex()

2014-03-24 Thread David Gil Oliva
/116969/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117036: Refactor private variables and parameters in KCompletionBase and KLineEdit

2014-03-24 Thread David Gil Oliva
://git.reviewboard.kde.org/r/117036/diff/ Testing --- It builds and tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117037: Refactor parameter names

2014-03-24 Thread David Gil Oliva
. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117040: Remove FIXME in KCompletion

2014-03-24 Thread David Gil Oliva
--- Remove FIXME in KCompletion. I have revised the API and I think it makes sense as it is. Diffs - src/kcompletion.h 3b3b0a6 Diff: https://git.reviewboard.kde.org/r/117040/diff/ Testing --- Thanks, David Gil Oliva ___ Kde

Review Request 117042: Make KLineEdit::completionBox virtual so that konq can reimplement it

2014-03-24 Thread David Gil Oliva
--- Make KLineEdit::completionBox virtual so that konq can reimplement it (as suggested in a comment) Diffs - src/klineedit.h 723cb42 Diff: https://git.reviewboard.kde.org/r/117042/diff/ Testing --- Thanks, David Gil Oliva

Review Request 117043: Add emission of KLineEdit::textEdited()

2014-03-24 Thread David Gil Oliva
b426767 Diff: https://git.reviewboard.kde.org/r/117043/diff/ Testing --- It builds Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116971: Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox

2014-03-23 Thread David Gil Oliva
/116971/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116966: Reorder private variables of KLineEditPrivate to avoid padding

2014-03-23 Thread David Gil Oliva
://git.reviewboard.kde.org/r/116966/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116960: @since KDE 4.1 - @since 4.1

2014-03-21 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116960/#review53708 --- Ship it! Ship It! - David Gil Oliva On March 21, 2014, 5

Re: Review Request 116960: @since KDE 4.1 - @since 4.1

2014-03-21 Thread David Gil Oliva
. Should I patch it (I'm about to modify that class) or will you do it? Ah! And thanks, BTW :-) - David Gil Oliva On March 21, 2014, 6:26 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 116939: Add deprecation info to kcombobox, kcompletionbase and klineedit

2014-03-21 Thread David Gil Oliva
--- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116966: Reorder private variables of KLineEditPrivate to avoid padding

2014-03-21 Thread David Gil Oliva
--- Reorder private variables of KLineEditPrivate to avoid padding. In my 32bits box the size goes down from 124 to 116. Diffs - src/klineedit_p.h 09cf8b4 Diff: https://git.reviewboard.kde.org/r/116966/diff/ Testing --- Thanks, David Gil Oliva

Review Request 116967: Fix doc in KUrlPixmapProvider

2014-03-21 Thread David Gil Oliva
--- Fix doc in KUrlPixmapProvider Diffs - src/widgets/kurlpixmapprovider.h 41ed05a Diff: https://git.reviewboard.kde.org/r/116967/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 116968: Fix doc in KToolBarLabelAction

2014-03-21 Thread David Gil Oliva
Description --- Fix doc in KToolBarLabelAction KHistoryCombo - KHistoryComboBox Diffs - src/ktoolbarlabelaction.h 3c6978e Diff: https://git.reviewboard.kde.org/r/116968/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel

Review Request 116969: Remove private reset() and move the implementation to the public reset() in KHistoryComboBox

2014-03-21 Thread David Gil Oliva
pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116970: Remove wish in KComboBox

2014-03-21 Thread David Gil Oliva
--- Remove wish in KComboBox Diffs - src/kcombobox.h 42de884 Diff: https://git.reviewboard.kde.org/r/116970/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 116971: Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox

2014-03-21 Thread David Gil Oliva
--- Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox Diffs - src/kcombobox.h 42de884 src/kcombobox.cpp 30edc1b Diff: https://git.reviewboard.kde.org/r/116971/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva

Review Request 116939: Add deprecation info to kcombobox, kcompletionbase and klineedit

2014-03-20 Thread David Gil Oliva
--- See summary Diffs - src/kcombobox.h eea930d src/kcompletionbase.h 8022214 src/klineedit.h 76a1f01 Diff: https://git.reviewboard.kde.org/r/116939/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-19 Thread David Gil Oliva
--- On March 18, 2014, 11:01 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-19 Thread David Gil Oliva
) - src/kcompletion.cpp 7396029 src/kcompletion_p.h e3fad26 Diff: https://git.reviewboard.kde.org/r/116886/diff/ Testing --- It builds. Autotests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-19 Thread David Gil Oliva
://git.reviewboard.kde.org/r/116886/diff/ Testing --- It builds. Autotests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116747: Clean up KCompletionBox

2014-03-18 Thread David Gil Oliva
to be normal methods, since they don't seem to be able to work as slots. Diffs - src/kcompletionbox.h 09b7527 src/kcompletionbox.cpp 92e87b3 Diff: https://git.reviewboard.kde.org/r/116747/diff/ Testing --- It builds and tests pass. Thanks, David Gil Oliva

Re: Review Request 116792: Fix deprecation warning in KComboBox and fix all KDE_NO_DEPRECATED

2014-03-18 Thread David Gil Oliva
/kcombobox.cpp 7195b3e src/kcompletion.h 387a05e src/klineedit.h c7c46b5 src/klineedit.cpp ae15093 Diff: https://git.reviewboard.kde.org/r/116792/diff/ Testing --- It builds and tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel

Re: Review Request 116684: Improve API in KCompletionBase

2014-03-18 Thread David Gil Oliva
- src/kcompletionbase.h 1dedd2d src/kcompletionbase.cpp 1e251d1 src/klineedit.cpp ae15093 Diff: https://git.reviewboard.kde.org/r/116684/diff/ Testing --- It compiles and (auto)tests pass without the conflicting part (to be uncommented). Thanks, David Gil Oliva

Review Request 116886: Refactor private variables of KCompletion

2014-03-18 Thread David Gil Oliva
Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-18 Thread David Gil Oliva
://git.reviewboard.kde.org/r/116886/diff/ Testing --- It builds. Autotests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116887: Undeprecate setUrlDropsEnabled(bool) in KComboBox and KLineEdit

2014-03-18 Thread David Gil Oliva
a one-line method for that. Diffs - src/klineedit.h 76a1f01 src/kcombobox.h eea930d src/kcombobox.cpp 30edc1b Diff: https://git.reviewboard.kde.org/r/116887/diff/ Testing --- It builds. The compiler warnings about this deprecation disappear. Thanks, David Gil Oliva

Re: Review Request 116747: Clean up KCompletionBox

2014-03-14 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/#review52928 --- On March 13, 2014, 10:13 p.m., David Gil Oliva wrote

Re: Review Request 116747: Clean up KCompletionBox

2014-03-14 Thread David Gil Oliva
methods, since they don't seem to be able to work as slots. Diffs (updated) - src/kcompletionbox.h 09b7527 src/kcompletionbox.cpp 92e87b3 Diff: https://git.reviewboard.kde.org/r/116747/diff/ Testing --- It builds and tests pass. Thanks, David Gil Oliva

Re: Review Request 116747: Clean up KCompletionBox

2014-03-13 Thread David Gil Oliva
. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116792: Fix deprecation warning in KComboBox and fix all KDE_NO_DEPRECATED

2014-03-13 Thread David Gil Oliva
Diff: https://git.reviewboard.kde.org/r/116792/diff/ Testing --- It builds and tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread David Gil Oliva
, if it's required for some reason. Also there's a typo in the method name. Alex Merry inlined deprecated methods in https://git.reviewboard.kde.org/r/116012 , so I thought that it was the way to go... On March 11, 2014, 11:17 p.m., David Gil Oliva wrote: Have you looked through

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread David Gil Oliva
, if it's required for some reason. Also there's a typo in the method name. David Gil Oliva wrote: Alex Merry inlined deprecated methods in https://git.reviewboard.kde.org/r/116012 , so I thought that it was the way to go... Alex Merry wrote: Well, there's a balance

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread David Gil Oliva
methods, since they don't seem to be able to work as slots. Diffs (updated) - src/kcompletionbox.h 09b7527 src/kcompletionbox.cpp 92e87b3 Diff: https://git.reviewboard.kde.org/r/116747/diff/ Testing --- It builds and tests pass. Thanks, David Gil Oliva

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread David Gil Oliva
, since they don't seem to be able to work as slots. Diffs (updated) - src/kcompletionbox.h 09b7527 src/kcompletionbox.cpp 92e87b3 Diff: https://git.reviewboard.kde.org/r/116747/diff/ Testing --- It builds and tests pass. Thanks, David Gil Oliva

Re: Review Request 116684: Improve API in KCompletionBase

2014-03-12 Thread David Gil Oliva
(updated) - src/kcompletionbase.h 1dedd2d src/kcompletionbase.cpp 1e251d1 src/klineedit.cpp ae15093 Diff: https://git.reviewboard.kde.org/r/116684/diff/ Testing --- It compiles and (auto)tests pass without the conflicting part (to be uncommented). Thanks, David Gil Oliva

Re: KF5 Update Meeting Minutes 2014-w11

2014-03-11 Thread David Gil Oliva
Hi! 2014-03-11 16:33 GMT+01:00 Kevin Ottens er...@kde.org: Hello everyone, This is the minutes of the Week 10 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, dfaure, mgraesslin, notmart, sebas, teo, tosky and myself.

Review Request 116747: Clean up KCompletionBox

2014-03-11 Thread David Gil Oliva
/kcompletionbox.h 09b7527 src/kcompletionbox.cpp 92e87b3 Diff: https://git.reviewboard.kde.org/r/116747/diff/ Testing --- It builds and tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: KF5 Update Meeting Minutes 2014-w11

2014-03-11 Thread David Gil Oliva
El 11/03/2014 22:58, Martin Klapetek martin.klape...@gmail.com escribió: On Tue, Mar 11, 2014 at 10:19 PM, David Gil Oliva davidgilol...@gmail.com wrote: Announcement: * Beta 1 will be tagged on March 28 instead of April 1st as planned earlier; Why is that? Are we in a hurry? Is the work

Review Request 116684: Improve API in KCompletionBase

2014-03-09 Thread David Gil Oliva
: https://git.reviewboard.kde.org/r/116684/diff/ Testing --- It compiles and (auto)tests pass without the conflicting part (to be uncommented). Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

2014-02-27 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115710/#review51125 --- On Feb. 25, 2014, 10:50 p.m., David Gil Oliva wrote

Re: Review Request 116064: @deprecated docs for KUrl methods that duplicate QUrl methods

2014-02-26 Thread David Gil Oliva
/#comment35726 I would say: @deprecated since 5.0, use Foo instead. - David Gil Oliva On Feb. 25, 2014, 11:03 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115984: Implement the d-pointer in KCompletionBase as in the other classes

2014-02-26 Thread David Gil Oliva
- src/kcompletionbase.h 105a6d0 src/kcompletionbase.cpp 66f9398 Diff: https://git.reviewboard.kde.org/r/115984/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 116062: Hide private slots in KCompletionBox and modify d-pointer in KCompletionMatches

2014-02-26 Thread David Gil Oliva
/kcompletionbox.cpp 571b02f src/kcompletionmatches.h 481a4b9 src/kcompletionmatches.cpp bc381b1 Diff: https://git.reviewboard.kde.org/r/116062/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list

Review Request 116062: Hide private slots in KCompletionBox and modify d-pointer in KCompletionMatches

2014-02-25 Thread David Gil Oliva
Diff: https://git.reviewboard.kde.org/r/116062/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

2014-02-25 Thread David Gil Oliva
/khistorycombobox.cpp 6f81dda Diff: https://git.reviewboard.kde.org/r/115710/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 115984: Implement the d-pointer in KCompletionBase as in the other classes

2014-02-25 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115984/#review50892 --- Ping? - David Gil Oliva On Feb. 24, 2014, 12:06 a.m

CMake error compiling kde-runtime

2014-02-23 Thread David Gil Oliva
Hi! I've removed the build and install folders of KF5. When running kdesrc-build, I get the following error in kde-runtime: # kdesrc-build running: 'cmake' '/home/david/devel/kf5-development/kde-runtime' '-DCMAKE_CXX_FLAGS:STRING=-pipe -DQT_STRICT_ITERATORS -DQURL_NO_CAST_FROM_STRING

  1   2   3   >