Re: Breeze and ECM are incompatible for installing icons

On 4 November 2023 14:53:42 GMT, Sune Vuorela wrote: > On 2023-11-03, David Jarvie wrote: > > I wanted to provide an icon that is visually compatible with the Breeze > > theme, and Breeze doesn't supply it. > > Did you consider submitting it to breeze ? > > I

Re: Breeze and ECM are incompatible for installing icons

On 3 November 2023 22:47:55 GMT, Albert Astals Cid wrote: > El divendres, 3 de novembre de 2023, a les 13:15:37 (CET), David Jarvie va > escriure: > > On 3 November 2023 09:13:15 GMT, Carl Schwan wrote: > > > On Friday, November 3, 2023 12:46:20 AM CET Albert Astals

Re: Breeze and ECM are incompatible for installing icons

On 3 November 2023 09:13:15 GMT, Carl Schwan wrote: > On Friday, November 3, 2023 12:46:20 AM CET Albert Astals Cid wrote: > > El dijous, 2 de novembre de 2023, a les 14:36:16 (CET), David Jarvie va > > > > escriure: > > > Breeze installs its icons in a diff

Breeze and ECM are incompatible for installing icons

tall_icons function isn't really acceptable. This should ideally be fixed one way or the other in time for the KF6 release. -- David Jarvie KAlarm author, KDE developer

Re: Opening files by mimetype instead of by file extension

XXX > because you can't do this" > > Is there something we could do at the KDE Frameworks level to support this > feature? > > Or should this be done in Qt? KFileCustomDialog lists by mimetype. -- David Jarvie. KDE developer. KAlarm author -- http://www.astrojar.org.uk/kalarm

Re: Updating our coding conventions and coding style for C++11

o = foo[bar]; > > > The common practice used in KDE seems to be: > > for (a:b) > > +1 > > Cheers > Kai Uwe -- David Jarvie. KDE developer. KAlarm author -- http://www.astrojar.org.uk/kalarm

Re: New framework: KCalCore

On 15 April 2019 13:25:56 BST, Allen Winter wrote: > On Monday, April 15, 2019 6:40:06 AM EDT Daniel Vrátil wrote: > > On Sunday, 14 April 2019 20:17:54 CEST David Faure wrote: > > > On dimanche 14 avril 2019 19:46:02 CEST David Jarvie wrote: > > > > On 14 April

Re: New framework: KCalCore

kes sense. KCalendar suggests it could be about calendar systems, so to avoid that confusion, perhaps call it KiCalendar? -- David Jarvie KAlarm author, KDE developer http://www.astrojar.org.uk/kalarm

Re: CI system maintainability

wants to review... I agree. Mandatory reviews might work if there is a team of active people working on a project, but if there is only one person with real knowledge of the code, or there is nobody else with much time to spare, who is going to do the review? It is likely to just sit waiting indefinitely. If getting code reviewed is too difficult, the developer may have to give up and abandon the project. Mandatory reviewing could only work if individual projects can decide whether to adopt it or not. -- David Jarvie KAlarm author, KDE developer http://www.astrojar.org.uk/kalarm

Re: Review Request 129709: Fix checking for valid date entered

marked as submitted. Review request for KDE Frameworks and John Layt. Changes --- Submitted with commit 1550b2c83f4842eb491b906ff7029fc11fd07d8a by David Jarvie to branch master. Repository: kwidgetsaddons Description --- Checks to determine whether an entered date is valid

Re: Review Request 129709: Fix checking for valid date entered

. The bugs described above are now fixed. Thanks, David Jarvie

Re: Review Request 129709: Fix checking for valid date entered

teKeywords. The bugs described above are now fixed. Thanks, David Jarvie

Re: Review Request 129709: Fix checking for valid date entered

o improved. Diffs (updated) - src/kdatecombobox.h d9a20ca src/kdatecombobox.cpp ad1d085 Diff: https://git.reviewboard.kde.org/r/129709/diff/ Testing --- Tested with KAlarm, including setting DateKeywords. The bugs described above are now fixed. Thanks, David Jarvie

Review Request 129709: Fix checking for valid date entered

g/r/129709/diff/ Testing --- Tested with KAlarm, including setting DateKeywords. The bugs described above are now fixed. Thanks, David Jarvie

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

> On Aug. 3, 2016, 10:18 p.m., David Edmundson wrote: > > src/mass.cpp, line 268 > > > > > > one of these should be "%1 stones" (with extra 's') No, it's normally 'stone' for the plural as well. - David

Re: Review Request 126813: Fix build with older polkit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126813/#review91431 --- Looks good. - David Jarvie On Jan. 21, 2016, 4:24 p.m

Re: Review Request 126813: Fix build with older polkit

`POLKIT_QT_1_COMPATIBILITY_MODE`. That could also be used to conditionally compile the code referencing `polkit_system_bus_name_get_user_sync`. - David Jarvie On Jan. 19, 2016, 1:09 p.m., Alex Richardson wrote: > > --- > This is an automatically generat

Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

/r/117604/diff/ Testing --- Tested for review 116951. Thanks, David Jarvie ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

/diff/ Testing --- Tested for review 116951. Thanks, David Jarvie ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

/ for KDE 4, except that the qDebug line has been uncommented on the grounds that it reports an error. Diffs - src/plugin/kdbusservicestarter.cpp 6f011bd Diff: https://git.reviewboard.kde.org/r/117604/diff/ Testing --- Tested for review 116951. Thanks, David Jarvie