Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

2016-11-16 Thread Heiko Tietze
er if it was also > top-aligned like the message icon? > > Heiko Tietze wrote: > Better you align it vertically with the left-hand topic icon meaning at > top. That would be also place this icon according the usual position. > > Elvis Angelaccio wrote: > This is h

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

2016-11-16 Thread Heiko Tietze
> On Nov. 16, 2016, 1:10 nachm., Christoph Feck wrote: > > Could you add a screen shot that shows actually wrapped text? > > Christoph Feck wrote: > Thanks, so the close icon is vertically centered. > > Heiko, do you agree that the close icon would look better if it was also >

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

2016-11-16 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129414/#review100877 --- Ship it! Ship It! - Heiko Tietze On Nov. 16, 2016, 11

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

2016-11-15 Thread Heiko Tietze
e expander and just accept the possible zero content. Alignment is relevant too meaning the anchored control must not have a large space to the collapsed list with hidden items. - Heiko Tietze On Nov. 15, 2016, 11:06 vorm., Elvis Angela

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

2016-11-15 Thread Heiko Tietze
be nice) - Heiko Tietze On Nov. 15, 2016, 9:53 vorm., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

2016-10-26 Thread Heiko Tietze
accio wrote: > Ah, sorry I didn't know that. Still, the conflict is caused by kconfig > itself and it's being worked around by applications. What should we do then? > > Heiko Tietze wrote: > This question was asked last year on the mailing list > https://mail.kde.org/piper

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

2016-10-25 Thread Heiko Tietze
accio wrote: > Ah, sorry I didn't know that. Still, the conflict is caused by kconfig > itself and it's being worked around by applications. What should we do then? > > Heiko Tietze wrote: > This question was asked last year on the mailing list > https://mail.kde.org/piper

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

2016-10-25 Thread Heiko Tietze
accio wrote: > Ah, sorry I didn't know that. Still, the conflict is caused by kconfig > itself and it's being worked around by applications. What should we do then? > > Heiko Tietze wrote: > This question was asked last year on the mailing list > https://mail.kde.org/piper

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

2016-10-24 Thread Heiko Tietze
accio wrote: > Ah, sorry I didn't know that. Still, the conflict is caused by kconfig > itself and it's being worked around by applications. What should we do then? > > Heiko Tietze wrote: > This question was asked last year on the mailing list > https://mail.kde.org/piper

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

2016-10-24 Thread Heiko Tietze
> On Okt. 24, 2016, 11 vorm., Albert Astals Cid wrote: > > -1 it's an established shortcut for cut too. even > > https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts lists it in "Cut > > the selection and store it in the clipboard" > > Elvis Angelaccio wrote: > Ah, sorry I didn't

Re: Review Request 128680: [KCharSelect] Add ToolButton for disabling characters not available in selected font

2016-09-13 Thread Heiko Tietze
> On Sept. 4, 2016, 2:34 vorm., Christoph Feck wrote: > > Andreas, any idea which icon the action could use? > > Andreas Kainz wrote: > I would use visibility and hint to show/hide the font's that are not > available in the selected font. will the font change to "not selected" grayed >

Re: Review Request 128680: [KCharSelect] Add ToolButton for dimming characters not available in selected font

2016-08-25 Thread Heiko Tietze
> On Aug. 25, 2016, 1:59 a.m., Christoph Feck wrote: > > Ping? Can someone please review? It already missed the tr deadline for > > 5.26, but maybe we can get this into 5.27. As far as I understand the change it will show tofu'ed characters in their intended appearance (the example is

Re: Review Request 128019: Remove F1 as standard shortcut for Help

2016-05-26 Thread Heiko Tietze
> On May 26, 2016, 7:49 a.m., Heiko Tietze wrote: > > What function would you like to invoke with F1? Close app? > > Albert Astals Cid wrote: > None, give it back to the apps so they can do whatever it wants with it, > like let's say F2 or F9 It was a rhetorical q

Re: Review Request 128019: Remove F1 as standard shortcut for Help

2016-05-26 Thread Heiko Tietze
? - Heiko Tietze On May 25, 2016, 11:01 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2016-02-29 Thread Heiko Tietze
> On Feb. 29, 2016, 10:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog?

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2015-12-27 Thread Heiko Tietze
close icon does not work (well) with colored backgrounds. - Heiko Tietze On Dec. 26, 2015, 10:18 a.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread Heiko Tietze
> On Dec. 25, 2015, 4:37 p.m., Kai Uwe Broulik wrote: > > Usability: I envisioned this to be used for auto-restarting shell services > > and not to be used by applications. > > Another interesting thought could be enabling this by default for all > > applications but for regular applications

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

2015-12-27 Thread Heiko Tietze
> On Dec. 27, 2015, 9:21 a.m., Heiko Tietze wrote: > > Perfect use of the message panel. However, the red close icon does not work > > (well) with colored backgrounds. > > Kai Uwe Broulik wrote: > Do we even need the close button to begin with? It's not like it >

Re: Review Request 125619: Refactor KNewPasswordDialog class

2015-11-19 Thread Heiko Tietze
> On Nov. 16, 2015, 12:56 p.m., Heiko Tietze wrote: > > Ship It! > > Elvis Angelaccio wrote: > I'm assuming that yours is a ship-it only from the usability side, right? Yes, UX only. No design comment from my side, but still with all of the previous conside

Re: Review Request 125619: Refactor KNewPasswordDialog class

2015-11-16 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/#review88425 --- Ship it! Ship It! - Heiko Tietze On Okt. 13, 2015, 1:33

Re: Review Request 125619: Refactor KNewPasswordDialog class

2015-10-13 Thread Heiko Tietze
from (e.g. "Dolphin wants to create a folder") and perhaps what account is referenced (e.g. or user's email address at the web page). The visual esthetics, in particular the big match icon, may be appreciated by someone else. - Heiko Tietze On Okt. 13, 2015, 1:33 nachm., Elvis Angela