Re: KDE Frameworks 6.0.0 tars

Hi Jonathan, We would also need a respin for KNewStuff to add this bugfix: https://invent.kde.org/frameworks/knewstuff/-/merge_requests/294 With the commit: https://invent.kde.org/frameworks/knewstuff/-/commit/a6a02162cd2c71fb986aadc77f3ce3cd32da7837 Thanks! El lun, 26 feb 2024 a las 20:02,

D29198: filenamesearch:/ define a title for the query

iasensio accepted this revision. iasensio added a comment. Sorry I missed the ping. Along with D29197 , it looks nice to me. INLINE COMMENTS > dolphinsearchbox.cpp:479 > +return i18nc("@title UDS_DISPLAY_NAME for a KIO directory listing. %1 is > the

D28457: kdirwatch: fix a recently introduced crash

iasensio accepted this revision. iasensio added a comment. This revision is now accepted and ready to land. Thanks! It fixes `BUG: 419428` REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28457 To: meven, bruns, #frameworks, iasensio Cc:

D28349: Fix Warnings

iasensio added a comment. In D28349#638395 , @bruns wrote: > @iasensio - are you using NFS? It's a NTFS partition using `fuseblk`, but anyway D28457 fixes the crash REPOSITORY R244 KCoreAddons

D28349: Fix Warnings

iasensio added a comment. I seemed to reach the unreachable when I tried to open an external HDD on dolphin: https://bugs.kde.org/show_bug.cgi?id=419428 `ASSERT failure in Q_UNREACHABLE(): "Q_UNREACHABLE was reached", file /home/isma/kde/src/kcoreaddons/src/lib/io/kdirwatch.cpp, line

D28197: [KSortFilterProxyModel QML] Make invalidateFilter public

iasensio added a dependent revision: D28152: [RFC] KWinRules KCM Redesign. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D28197 To: broulik, ahiemstra, davidedmundson, iasensio, kmaterka Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28197: [KSortFilterProxyModel QML] Make invalidateFilter public

iasensio accepted this revision. iasensio added a comment. It's working nicely, thanks! REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D28197 To: broulik, ahiemstra, davidedmundson, iasensio, kmaterka Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27795: Expose capture signal on KeySequenceItem

This revision was automatically updated to reflect the committed changes. Closed by commit R296:1a838e468d05: Expose capture signal on KeySequenceItem (authored by iasensio). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27795?vs=76808=76810 REVISION

D27795: Expose capture signal on KeySequenceItem

iasensio updated this revision to Diff 76808. iasensio marked an inline comment as done. iasensio added a comment. Add API comment REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27795?vs=76807=76808 BRANCH expose_capture REVISION DETAIL

D27795: Expose capture signal on KeySequenceItem

iasensio created this revision. iasensio added reviewers: Plasma, mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. iasensio requested review of this revision. REVISION SUMMARY Expose the signal `captureFinished` from the private helper

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

iasensio added a comment. Hi! This change fails to build for me, and also in CI (https://build.kde.org/view/Failing/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/409/console) kcoredirlister_p.h:148:37: error: field 'lstFilters' has incomplete type 'QVector' 09:29:39148 |

D24433: Move URL parsing methods from kioslave to query object

This revision was automatically updated to reflect the committed changes. Closed by commit R293:34e682a1c0ed: Move URL parsing methods from kioslave to query object (authored by iasensio). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24433?vs=71523=71531

D24433: Move URL parsing methods from kioslave to query object

iasensio updated this revision to Diff 71523. iasensio marked 5 inline comments as done. iasensio added a comment. - Use return statements REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24433?vs=69836=71523 BRANCH extend_query_url REVISION DETAIL

D25414: xattr: fix crash on dangling symlinks

This revision was automatically updated to reflect the committed changes. Closed by commit R286:4bb4195a6fc6: xattr: fix crash on dangling symlinks (authored by iasensio). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25414?vs=70035=71397 REVISION

D25414: xattr: fix crash on dangling symlinks

iasensio added a comment. Ping? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

D25414: xattr: fix crash on dangling symlinks

iasensio added inline comments. INLINE COMMENTS > bruns wrote in usermetadatawritertest.cpp:44 > You can just use the static overload and provide an invalid target name. > https://doc.qt.io/qt-5/qfile.html#link-1 You are right. I tried that with an empty string and it didn't work, but it does

D25414: xattr: fix crash on dangling symlinks

iasensio updated this revision to Diff 70035. iasensio marked an inline comment as done. iasensio added a comment. - Simplify symlink creation REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25414?vs=70031=70035 BRANCH fix_symlink REVISION DETAIL

D25414: xattr: fix crash on dangling symlinks

iasensio edited the test plan for this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh,

D25414: xattr: fix crash on dangling symlinks

iasensio updated this revision to Diff 70031. iasensio added a comment. - Use temporal symlink REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25414?vs=70029=70031 BRANCH fix_symlink REVISION DETAIL https://phabricator.kde.org/D25414 AFFECTED

D25414: xattr: fix crash on dangling symlinks

iasensio updated this revision to Diff 70029. iasensio marked 2 inline comments as done. iasensio added a comment. - Protect from size < 0 - Add test case for dangling symlink REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25414?vs=70019=70029

D25414: xattr: fix crash on dangling symlinks

iasensio edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh,

D25414: xattr: fix crash on dangling symlinks

iasensio edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

D25414: xattr: fix crash on dangling symlinks

iasensio created this revision. iasensio added a reviewer: astippich. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. iasensio requested review of this revision. REVISION SUMMARY When requesting metadata on a dangling symlink, the framestack ends

D24433: Move URL parsing methods from kioslave to query object

iasensio added inline comments. INLINE COMMENTS > bruns wrote in kio_search.cpp:88 > @broulik - why `endsWith()`? should I just change the comparisons to `path == ...`, just like the `/documents` one? REPOSITORY R293 Baloo BRANCH extend_query_url REVISION DETAIL

D24433: Move URL parsing methods from kioslave to query object

iasensio updated this revision to Diff 69836. iasensio added a comment. Remove extra spaces REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24433?vs=69613=69836 BRANCH extend_query_url REVISION DETAIL https://phabricator.kde.org/D24433 AFFECTED FILES

D24433: Move URL parsing methods from kioslave to query object

iasensio updated this revision to Diff 69613. iasensio marked 2 inline comments as done. iasensio added a comment. Simplify helper function REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24433?vs=67361=69613 BRANCH extend_query_url REVISION DETAIL

D24433: Move URL parsing methods from kioslave to query object

iasensio removed a dependent revision: D25130: [dolphin/search] Search by (multiple) tags. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D24433: Move URL parsing methods from kioslave to query object

iasensio added a dependent revision: D25130: [dolphin/search] Search by (multiple) tags. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D24433: Move URL parsing methods from kioslave to query object

iasensio added a comment. Friday ping  REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D24433: Move URL parsing methods from kioslave to query object

iasensio edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven Cc: kde-frameworks-devel, #dolphin, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D24433: Move URL parsing methods from kioslave to query object

iasensio created this revision. iasensio added reviewers: Baloo, meven. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. iasensio requested review of this revision. REVISION SUMMARY This allows for query objects generated from

D23103: Add decibel power units (dBW and multiples)

iasensio added a comment. Friendly ping REPOSITORY R292 KUnitConversion BRANCH log_power_units REVISION DETAIL https://phabricator.kde.org/D23103 To: iasensio, broulik, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23103: Add decibel power units (dBW and multiples)

iasensio marked an inline comment as done. iasensio added a comment. Well, in my field of work (telephony, radar and radio signal transmission) it makes totally sense (altought Terawatts would be major words ). It is a non trivial conversion that we make quite frequently. If the

D23103: Add decibel power units (dBW and multiples)

iasensio updated this revision to Diff 63588. iasensio added a comment. - Set frameworks version REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23103?vs=63575=63588 BRANCH log_power_units REVISION DETAIL https://phabricator.kde.org/D23103

D23103: Add decibel power units (dBW and multiples)

iasensio added a reviewer: broulik. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D23103 To: iasensio, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23103: Add decibel power units (dBW and multiples)

iasensio edited the test plan for this revision. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D23103 To: iasensio Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23103: Add decibel power units (dBW and multiples)

iasensio created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. iasensio requested review of this revision. REVISION SUMMARY Add decibel power units (dBW and mulitples) Decibel power units are widely used in the fields of signal