Re: Review Request 128466: Rename Checksums tab to Integrity

2016-07-18 Thread Ivan Čukić
> That's both, the order of the workflow as well as the logical order of > operation. 'Calculate' underneath would raise exactly the same question as I > put above: "...but but but ... it could not verify it without calculating it, > yet I have to hit a button t

Re: Review Request 128466: Rename Checksums tab to Integrity

2016-07-18 Thread Ivan Čukić
> That's both, the order of the workflow as well as the logical order of > operation. 'Calculate' underneath would raise exactly the same question as I > put above: "...but but but ... it could not verify it without calculating it, > yet I have to hit a button t

Re: Review Request 128466: Rename Checksums tab to Integrity

2016-07-18 Thread Ivan Čukić
> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Raising the requirement to Qt 5.5 ?

2016-07-16 Thread Ivan Čukić
Hi, As usual, I'm +1 for increasing the version we depend on. It would be cool if we were able to contact people/projects outside our community that use KF5. Jens of Meeting C++ held a small vote on Twitter regarding which version of Qt his followers use [1]. The results were as follows: 22% -

Re: KActivities outside of plasma5 sessions

2016-05-14 Thread Ivan Čukić
> Evidently, the (git) repositories aren't split up in categories. However, the > current release download is here > http://download.kde.org/stable/plasma/5.6.4/kactivitymanagerd-5.6.4.tar.xz Git repos do have categorization - kamd is under kde/workspace - defined in kde_projects.xml >> Because i

Re: KActivities outside of plasma5 sessions

2016-05-14 Thread Ivan Čukić
> from the framework to (IIRC) a dedicated plasma package. The daemon is in kactivitymanagerd repository, nothing to do with plasma. > It does however lead to messages like > KActivities: FATAL ERROR: Failed to contact the activity manager It is a qWarning message, you can disable it easily: >

Re: Review Request 126285: OS X build and warning fix

2016-05-04 Thread Ivan Čukić
the OSX API. - Ivan Čukić On April 29, 2016, 11:59 a.m., Samuel Gaist wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Taking over KRunner maintainership

2016-04-15 Thread Ivan Čukić
Hi Kai, Great news! Strangely enough, this is something I talked to Marco about during the CERN sprint, so it is nice to see that you are the maintainer both defacto and de jure :) As far as the architecture is concerned (Sprinter, or something else), that is probably worth looking into. I was pl

Re: kactivities: C++11 feature test broken

2016-04-03 Thread Ivan Čukić
Hi David, That is quite strange, since I'm regularly building more than a few projects with clang. I guess I'll remove the checks now that frameworks require compilers with basic c++11 support. Cheers Cheerio, Ivan -- KDE, ivan.cu...@kde.org, http://cukic.co/ gpg key id: 850B6F76 On 3 April 20

Re: Raising Qt requirement to Qt 5.4

2016-03-25 Thread Ivan Čukić
>> Is this documented in some wiki so we don't have to rely on people's memories >> or someone digging up the corresponding email thread? > > Good point. Any suggestion on where to document this? +1 since my gmail-search-foo was not up to the task - we have so many threads regarding compiler and Q

Re: Raising Qt requirement to Qt 5.4

2016-03-19 Thread Ivan Čukić
Hi all, IIRC, the last time we talked about this we decided (I'll try to find the e-mail thread when I get back home, IIRC the conclusion was by dfaure) on KF5 always support the two last versions of Qt. This was decided so that we do not need to have threads like these every time we want to incre

Re: KWayland as framework

2016-03-12 Thread Ivan Čukić
> Opinions? comments? +1 from me. I guess it needs to be reviewed before it is moved to frameworks, but that should not take much time (I'd say, it will take exactly two weeks ;) ) Cheers Ivan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@k

Re: Review Request 127187: Fix build for MSVC (2013) on Windows

2016-02-29 Thread Ivan Čukić
27;ve removed model_updaters from the ActivitiesModel. I have to say that I really hate MSVC... - Ivan Čukić On Feb. 29, 2016, 1:54 p.m., Thomas Friedrichsmeier wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: KActivities repository split

2016-02-18 Thread Ivan Čukić
Hi Albert, What schedule kio-extras have? Cheerio, Ivan p.s. I'm thinking more and more that kactivities-workspace repository might be a better solution ... -- KDE, ivan.cu...@kde.org, http://cukic.co/ gpg key id: 850B6F76 ___ Kde-frameworks-devel mai

KActivities repository split

2016-02-16 Thread Ivan Čukić
Hi everyone, As previously announced, KActivities has been split into a few separate repositories. This mail is mostly intended to notify our dear packagers of the change, and the plan for the transition period. KActivities framework 5.19 (as released a few days ago) contains everything that it u

Re: Review Request 126955: Fix crash in activities context menu

2016-02-02 Thread Ivan Čukić
> On Feb. 2, 2016, 7:49 a.m., David Faure wrote: > > Looks correct, although IMHO it's the code that creates a class, that > > should decide how it should get deleted, rather than the class itself > > deciding that (same reason why for widgets, WA_DeleteOnClose should be set > > after new, not

Re: Review Request 126945: Don't call exec() from QML

2016-02-02 Thread Ivan Čukić
should go via phabricator in the future - kactivities are in the process of repository splitting, the repository for this patch will be kde:kactivitymanagerd (I'll apply it to the repository when you push this) - Ivan Čukić On Feb. 2, 2016, 12:11 p.m., David Edmundson

Re: KActivitiesStats framework for review

2016-02-01 Thread Ivan Čukić
Hi Martin, I'll need to find a better file template plugin for Vim that loads per-project headers. It should be ok now - lgpl2, lgpl3 + e.V. clause. Cheers, Ivan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mai

KActivitiesStats framework for review

2016-02-01 Thread Ivan Čukić
Hi all, There is a new framework-to-be under review. Until now, it was used in plasma (and shipped with plasma, although it was developed in kactivities repository - strange setup, but we somehow managed). To avoid collisions, it was previously known under the KActivitiesExperimentalStats name, an

Re: Splitting KActivities, 2nd attempt...

2016-01-01 Thread Ivan Čukić
> Shouldn't the service be part of the framework? > How usable is the framework without the service? > Compiling is good, but running is even better :-) This is the reason why the split has not happened before. The purpose of the library is: [1] - to report document/resource events to the service

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

2015-12-28 Thread Ivan Čukić
e. (iirc, he is the kio maintainer) - Ivan Čukić On Dec. 28, 2015, 2:20 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

2015-12-22 Thread Ivan Čukić
> On Dec. 22, 2015, 4:59 p.m., Ivan Čukić wrote: > > The patch seems straight-forward. > > > > I can not find the reference that QRegularExpression is thread-safe (the > > most I see is 'all functions in this class are reentrant which is stated > > for

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

2015-12-22 Thread Ivan Čukić
reference that QRegularExpression is thread-safe (the most I see is 'all functions in this class are reentrant which is stated for QRegExp as well). The QRegExp vs QRegularExpression situation is quite confusing, but the later should be preferred in Qt 5.x - it is faster if nothing else. - Ivan

Re: Build and test failures with Qt 5.6 and Qt 5.3

2015-11-08 Thread Ivan Čukić
>> For how long are we going to support [Qt] 5.3? > > Good question. > > So that we don't need to reopen this discussion regularly, I would like to > suggest a general rule/policy: > > We will always support the last 3 Qt x.y releases. > > Right now that means 5.3 + 5.4 + 5.5. > > When 5.6 is out,

Splitting KActivities, 2nd attempt...

2015-11-08 Thread Ivan Čukić
Hi everybody, We have a few problems at the moment because all the activities components are in a single repository. Sometimes dependencies of the service creep up into the library, builds break because components that are meant only for Plasma start requiring Qt versions that Plasma require, whil

Re: Build and test failures with Qt 5.6 and Qt 5.3

2015-11-07 Thread Ivan Čukić
Ah, for the *** sake. My fault, I expected that the 'since' tag is missing from that one like it is for setClearColor and didn't check. I've removed the call in question when compiling against Qt 5.3. It will manifest as an issue for people that use dark colour scheme, but since the activities KC

Re: Build and test failures with Qt 5.6 and Qt 5.3

2015-11-07 Thread Ivan Čukić
> - [5.3] kactivities: won't build due to QQuickWidget::setClearColor which is > 5.4+ only. It should be ok now. I've added a work-around (essentially how the method is implemented in 5.4 and 5.5). Cheers, Ivan ___ Kde-frameworks-devel mailing list Kde-

Re: Build and test failures with Qt 5.6 and Qt 5.3

2015-11-07 Thread Ivan Čukić
>> - [5.3] kactivities: won't build due to QQuickWidget::setClearColor which >> is 5.4+ only. > > Ivan, can this be worked around? I'll have to check. (if nothing else, I'll disable that part - it is for the settings module, not really a part of the framework) For how long are we going to support

Re: Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled

2015-11-03 Thread Ivan Čukić
now. - Ivan Čukić On Oct. 28, 2015, 9:48 p.m., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125905: Make kactivitymanagerd a QApplication

2015-11-03 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/#review87946 --- Ship it! Ship It! - Ivan Čukić On Nov. 1, 2015, 1:33 a.m

Re: Review Request 125905: Make kactivitymanagerd a QApplication

2015-11-01 Thread Ivan Čukić
assert are you hitting on unity? - Ivan Čukić On Nov. 1, 2015, 1:33 a.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled

2015-10-28 Thread Ivan Čukić
boost requirement for the library first. It should not be used anywhere overly important, and people are complaining that it makes windows builds hard. - Ivan Čukić On Oct. 28, 2015, 9:48 p.m., Heiko Becker wrote: > > --- > This is an

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

2015-09-04 Thread Ivan Čukić
t: > https://git.reviewboard.kde.org/r/125044/ > --- > > (Updated Sept. 4, 2015, 1:01 p.m.) > > > Review request for KDE Frameworks and Ivan Čukić. > > > Bugs: 352207 > http://bugs.kde.org/show_bug.cgi?id=352207 >

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

2015-09-04 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125044/#review84842 --- Ship it! Ship It! - Ivan Čukić On Sept. 4, 2015, 1:01 p.m

Re: Review Request 123778: Fix crash when DBus call ends with error

2015-05-27 Thread Ivan Čukić
you submit a patch and I miss it. Thanks for the patch, though, kactivities now include code similar to this. - Ivan Čukić On May 27, 2015, 2:43 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To rep

Re: changelog for 5.10

2015-05-09 Thread Ivan Čukić
> I couldn't decrypt the commits in KActivities .. It is mostly about the currently not installed experimental new library so I'd rather keep it as 'nothing happening' until that part is properly released. Thanks! On 9 May 2015 at 00:47, David Faure wrote: > I couldn't decrypt the commits in K

Re: Making prison a framework

2015-02-17 Thread Ivan Čukić
Welcoming prison to the family of KDE Frameworks :) A few nit-picks, in no particular order: - & and * should not be touching the types, but the variables (https://techbase.kde.org/Policies/Kdelibs_Coding_Style#Whitespace) - braces for functions should be on separate lines (https://techbase.kde.or

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

2015-02-12 Thread Ivan Čukić
'virtual', as Albert mentioned) - Ivan Čukić On Feb. 12, 2015, 2:43 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 122493: Use qRound rather than C++11 std::lround.

2015-02-09 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/#review75719 --- Ship it! Seems ok to me - Ivan Čukić On Feb. 9, 2015, 3

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

2015-02-09 Thread Ivan Čukić
> On Feb. 9, 2015, 12:59 a.m., Mark Gaiser wrote: > > -1 > > > > You use C-Style casts. Oke, the frameworks coding style doesn't seem to > > explicitly forbid it (casts are not mentioned), but if i recall correctly > > we use the Qt style + some of our own which means we should obey the Qt >

Re: C++11 policy in frameworks?

2015-02-08 Thread Ivan Čukić
> older, Qt supports 10.7 though so maybe we shouldn't be using these newer > c++11 methods in frameworks just yet right? > > On Feb 8, 2015 2:04 PM, "Ivan Čukić" wrote: >> >> > thought this was clang 3.7 maybe I'm confused though >> >> This i

Re: C++11 policy in frameworks?

2015-02-08 Thread Ivan Čukić
> thought this was clang 3.7 maybe I'm confused though This is (should not) be a problem with the compiler version - this is a library function. Which version of libc++ is it using? (it might be using the old system's one instead of the latest release or something) Cheerio, Ivan On 8 February 20

Re: C++11 policy in frameworks?

2015-02-08 Thread Ivan Čukić
That page was the result of the first discussion we had on C++11. More recently, there was a discussion on raising MSVC requirement. And, I'd say it was agreed to raise it to MSVC11 (VS12). At least, it was green-lighted by Kevin, Milian (I don't recall who else). I guess I should have updated th

Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-03 Thread Ivan Čukić
> On Feb. 3, 2015, 5:40 p.m., Ivan Čukić wrote: > > This does fix the switching, but I don't agree it is the right place for it > > (I don't like that this plugin exists at all tbh). > > > > When switching the activities, there needs to be a (UI) feedback

Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-03 Thread Ivan Čukić
s the right place for it (I don't like that this plugin exists at all tbh). When switching the activities, there needs to be a (UI) feedback - the switcher needs to show up. That means either moving the switcher UI to this plugin (which I don't like), or having this in plasmashell. - Ivan

Re: Supporting MSVC2010 in ktexteditor framework

2015-01-29 Thread Ivan Čukić
the currently sanest choice (for frameworks). If the ball stops again, I'll consider this a decision well made. :) Cheers, Ivan On 29 January 2015 at 15:52, Ivan Čukić wrote: >> My opinion is still the same on this matter: VS2012 (aka MSVC11). > > I guessed as much. Just wanted to

Re: Supporting MSVC2010 in ktexteditor framework

2015-01-29 Thread Ivan Čukić
Hi all, So, the thread died out again. Who is in favour of the following: - Require MSVC10 like (aka status quo) - Require MSVC11 - Require MSVC12 (it would be nice to get the input from kde windows guys as well) Cheerio, Ivan On 17 November 2014 at 14:41, Kai Uwe Broulik wrote: > >> > > -

Re: OSX/CI: kactivities fails to build on branch master

2015-01-11 Thread Ivan Čukić
Hi, Some boost versions require exceptions (have bugs related to non-exception builds). Which version of boost is it? Ivan p.s. You can try building with -DKACTIVITIES_ENABLE_EXCEPTIONS ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: OSX/CI: QSP patch ( was "KF5 Update Meeting Minutes 2014-w28" )

2015-01-04 Thread Ivan Čukić
> Oxygen+Qt5 has inherited the "spaciousness" of breeze, which if you ask me it > does not make sense, i'd expect Oxygen+Qt5 and Oxygen+Qt4 to be the same +1 -- Cheerio, Ivan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://

Re: Baloo Framework - License Exception

2014-12-15 Thread Ivan Čukić
t be *used* as an LGPL library. Cheers, Ivan * as you said, admin overhead, though it would not be huge in this case. On 15 December 2014 at 18:13, David Edmundson wrote: > > > > On Mon, Dec 15, 2014 at 12:21 PM, Ivan Čukić wrote: >> >> > Albert is right, Baloo is LG

Re: Baloo Framework - License Exception

2014-12-15 Thread Ivan Čukić
> Albert is right, Baloo is LGPL but the resulting binaries will be GPL. Again, this serves no purpose other than 'we are using LGPL' since libbaloo clients can not be non-free - they will have to link to the GPL binary. I'd rather have an exception to the rule than having something that will con

Re: Re: Re: Baloo Framework - License Exception

2014-12-15 Thread Ivan Čukić
> well yes, that's how the blob drivers like NVIDIA do not need to be GPL - > at > least that's what the affected parties claim. > There is a difference there. The kernel modules are a bit of a special case for some reason. They are only implementing an interface, and they are not distributed as

Re: Re: Baloo Framework - License Exception

2014-12-15 Thread Ivan Čukić
> not. If there is baloo internal an abstraction allowing to easily > swap out Xapian by something different I would say it's not > derived work. But if Xapian is deeply wired into Baloo I would say > it's derived work. >From "Why you shouldn't use the Lesser GPL for your next library", a docu

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-17 Thread Ivan Čukić
> Yeah, it looks like I've been looking at the CTP from November 2012 - for > VS11 [1]. It would be awesome if somebody who has VS11 actually > investigated this. Namely, the 11.0 proper should support variadics up to > some number of arguments (yes, sounds really daft and hackish). If true, it >

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-17 Thread Ivan Čukić
On Monday, 17 November 2014 07:33:00 Kevin Ottens wrote: > On Sunday 16 November 2014 18:01:04 Ivan Čukić wrote: > > Hi, > > > > The topic of increasing the compiler versions we require might have been > > started for the specific issue one of the frameworks had, but I

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-16 Thread Ivan Čukić
Hi, The topic of increasing the compiler versions we require might have been started for the specific issue one of the frameworks had, but I think it shouldn't have died out when the issue in question got patched. IMO, this topic requires more consideration. Some of the features that we could us

Re: Review Request 121109: Use CMAKE_INSTALL_FULL_PLUGINDIR

2014-11-12 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121109/#review70295 --- Ship it! Thanks! - Ivan Čukić On Nov. 12, 2014, 7:43 p.m

Re: Non-coinstallable frameworks

2014-09-19 Thread Ivan Čukić
> is used by a component, ResourceInstance that would make more sense if it > was exposed by kactivities instead of plasma. Yes! :) -- Cheerio, Ivan KDE, ivan.cukic at kde.org, http://ivan.fomentgroup.org/ gpg key id: 850B6F76, keyserver.pgp.com ___

Re: Non-coinstallable frameworks

2014-09-19 Thread Ivan Čukić
My replies went only to Aleix: On Thursday 18 September 2014 13:15:51 you wrote: > Hi Ivan, > I've just learned that the KActivities framework is not co-installable with > kdelibs4. I guess, I ought to write a document about this. :) The libraries are coinstallable, the daemon is not. libkactiv

Re: Review Request 120214: Extend NetWinInfoTestClient::testActivities()

2014-09-15 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120214/#review66527 --- Ship it! Ship It! - Ivan Čukić On Sept. 15, 2014, 8:14

Re: Review Request 120214: Extend NetWinInfoTestClient::testActivities()

2014-09-15 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120214/#review66519 --- Looks ok, does it pass now? - Ivan Čukić On Sept. 15, 2014

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

2014-08-11 Thread Ivan Čukić
2d812a7 src/netwm.cpp 1daad1e src/netwm_p.h a201cb6 Diff: https://git.reviewboard.kde.org/r/119267/diff/ Testing --- Yes, works with the new activity switcher. Thanks, Ivan Čukić ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

2014-08-06 Thread Ivan Čukić
a201cb6 Diff: https://git.reviewboard.kde.org/r/119267/diff/ Testing --- Yes, works with the new activity switcher. Thanks, Ivan Čukić ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

2014-08-06 Thread Ivan Čukić
van --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119267/#review63939 --- On Aug. 5, 2014, 8:21 p.m., Ivan Čukić wrote: > >

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

2014-08-05 Thread Ivan Čukić
/netwm.h 2d812a7 src/netwm.cpp 1daad1e src/netwm_p.h a201cb6 Diff: https://git.reviewboard.kde.org/r/119267/diff/ Testing --- Yes, works with the new activity switcher. Thanks, Ivan Čukić ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

2014-07-31 Thread Ivan Čukić
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119267/#review63557 ------- On July 31, 2014, 10:09 a.m., Ivan Čukić wrote: > > -

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

2014-07-31 Thread Ivan Čukić
Diff: https://git.reviewboard.kde.org/r/119267/diff/ Testing (updated) --- Yes, works with the new activity switcher. Thanks, Ivan Čukić ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

2014-07-25 Thread Ivan Čukić
fb59603 Diff: https://git.reviewboard.kde.org/r/119267/diff/ Testing --- Yes :) Thanks, Ivan Čukić ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

2014-07-14 Thread Ivan Čukić
iewboard.kde.org/r/119267/#review62275 --- On July 14, 2014, 9:06 a.m., Ivan Čukić wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

2014-07-14 Thread Ivan Čukić
fb59603 src/kwindowsystem_p.h 8861844 src/kwindowsystem_p_x11.h 9baa6ae src/kwindowsystem_x11.cpp 2016820 src/netwm.h 2d812a7 src/netwm.cpp 1daad1e Diff: https://git.reviewboard.kde.org/r/119267/diff/ Testing --- Yes :) Thanks, Ivan Čukić

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Ivan Čukić
/diff/ Testing --- Yes Thanks, Ivan Čukić ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Ivan Čukić
visit: https://git.reviewboard.kde.org/r/119008/#review61256 --- On June 30, 2014, 8:22 a.m., Ivan Čukić wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Ivan Čukić
the main API. Diffs (updated) - src/kwindowinfo.h e9b7a0a src/kwindowinfo.cpp 3095932 src/kwindowinfo_p.h 4c26c62 src/kwindowinfo_p_x11.h 2acb3f8 src/kwindowinfo_x11.cpp 87a887c Diff: https://git.reviewboard.kde.org/r/119008/diff/ Testing --- Yes Thanks, Ivan Čukić

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Ivan Čukić
the main API. Diffs (updated) - src/kwindowinfo.h e9b7a0a src/kwindowinfo.cpp 3095932 src/kwindowinfo_p.h 4c26c62 src/kwindowinfo_p_x11.h 2acb3f8 src/kwindowinfo_x11.cpp 87a887c Diff: https://git.reviewboard.kde.org/r/119008/diff/ Testing --- Yes Thanks, Ivan Čukić

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-31 Thread Ivan Čukić
xcept that it is a bit different to what the kf5 version (master) has. Master checks for the option called KACTIVITIES_LIBRARY_ONLY. If it is not a bother, can you rename the option in 4.13 to match it - to avoid confusion. - Ivan Čukić On May 31, 2014, 3:42 a.m., Matthew Dawson

Re: GenerateExportHeader and clang

2014-05-18 Thread Ivan Čukić
> Ah, but what is clang's return value when there is an unrecognized option? It is 0. That is why I find the situation so strange. :) Cheers, Ivan -- A program that has not been tested does not work. -- Bjarne Stroustrup ___ Kde-frameworks-devel

Re: GenerateExportHeader and clang

2014-05-18 Thread Ivan Čukić
> Although if they fail, I think hidden visibility shouldn't be turned on, They are not for some reason. The symbol is visible through 'nm', but is marked as 't' - local symbol in text area. > Anyway, the relevant file is CMakeFiles/CMakeOutput.log in the build Yes, just finished dealing with i

Re: GenerateExportHeader and clang

2014-05-18 Thread Ivan Čukić
On Sunday 18 May 2014 18:28:00 Alex Merry wrote: > Nope, all looks fine to me when I build KCoreAddons. Configure output has: Fun. For me both 3.4 and 3.5 (trunk) fail. -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Failed -- Performing Test

GenerateExportHeader and clang

2014-05-18 Thread Ivan Čukić
Hi, When compiling libraries that use GenerateExportHeader with clang 3.5.0, I'm getting a library without any methods exported. I'm using the same CMake invocation is as kdesrc-build does, only with -DCMAKE_CXX_COMPILER=/usr/local/bin/clang++ \ -DCMAKE_C_COMPILER=/usr/local/bin/clang Generat

Re: KF5 Maintainers: Please get ready for release

2014-04-28 Thread Ivan Čukić
Hi, Should we create a new component in bko, or we can rename the existing one (kactivities -> frameworks-kactivities)? (I did the former, but wanted to check) The same question for the revboard - should the repository be renamed to frameworks-kactivities? The only thing that I'm having issues w

Re: KActivities/master is now KF5/Qt5

2014-02-28 Thread Ivan Čukić
> The metadata has now been sorted Thanks man! On 28 February 2014 21:59, Ben Cooksley wrote: > On Fri, Feb 28, 2014 at 9:50 PM, Ivan Čukić wrote: > > Hi all, > > > > Now that the 4.13 has been branched out, the master branch of > KActivities is > > for Qt

KActivities/master is now KF5/Qt5

2014-02-28 Thread Ivan Čukić
Hi all, Now that the 4.13 has been branched out, the master branch of KActivities is for Qt5/KF5 development. I have updated the branch name in kf5-frameworks-build-include (I guess David had something else in mind, so I'm CC-ing him even though he is a member of every list I'm sending this to :)

Re: KItemModels, Solid & KJS licenses

2014-02-27 Thread Ivan Čukić
> other files: Ivan Čukić. Touched by me (not enough for me to hold any > copyright, though) @Shumski : to repeat my answer on IRC, you have my permission to change to LGPL On 26 February 2014 18:42, Alex Merry wrote: > On 20/02/14 11:41, Alex Merry wrote: >

KActivities frameworks soon to become master

2014-02-27 Thread Ivan Čukić
Hi all, Now that the 4.13 has been branched out, KActivities will stop using the frameworks branch, and master will become the 'new black'. There is only a question of how to proceed. - Is it wiser just to ask the admins to move rename the branches (removing the old master) and blacklist the fra

Re: Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-27 Thread Ivan Čukić
> > Would it be possible to add some Q_PROPRERTIES to the class? E.g. > > numberOfDesktops or currentDesktop might make more sense with a property > > instead INVOKABLE. > > Ivan Čukić wrote: > My thoughts exactly. > > One thing I was thinking about

Re: Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-27 Thread Ivan Čukić
> On Feb. 27, 2014, 9:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to ad

Re: kactivities5 build failure

2014-02-26 Thread Ivan Čukić
> > Qt5.3? > > It fails for me as well with the same error. Yes, Qt 5.3. I'm not going to be able to deal with Qt 5.3 until next version of plasma is released since we are tiesd to 5.2. If anyone provides a patch, it would be appreciated. Cheerio, Ivan

Re: kactivities5 build failure

2014-02-26 Thread Ivan Čukić
On Wednesday, 26. February 2014. 13.15.51 Treeve Jelbert wrote: > doing a clean rebuild > > gcc-4.8.2 Qt5.3? ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115602: Rename kactivitymanagerd

2014-02-21 Thread Ivan Čukić
-- On Feb. 18, 2014, 9:50 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115602/ > --- > > (Updated Feb. 18,

Re: Frameworkification of kactivities and plasma-framework

2014-02-12 Thread Ivan Čukić
> The new KRunner framework depends on, among others plasma-framework, > which in turn depends on kactivities. It is already under works, thanks to dfaure and marco. Cheers -- Make your code readable. Pretend the next person who looks at your code is a psychopath and they know where you live.

Re: kf5 alpha 1 : modules, versions

2014-02-10 Thread Ivan Čukić
> the above points should be done.. > only thing, in kactivities frameworks should still be merged in master > (Ivan, would this be ok?) Fine by me :) (even more than 'fine') ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mai

Re: Review Request 115606: Ommit ontologies/ dir from installing

2014-02-10 Thread Ivan Čukić
from the ontologies dir as well. The ontologies can remain to provide documentation for the relations we create later for baloo. - Ivan Čukić On Feb. 9, 2014, 7:58 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically ge

Re: Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Ivan Čukić
> On Feb. 9, 2014, 7:12 p.m., Ivan Čukić wrote: > > This is not something I'd give a green light for. > > > > ActivityManager/KF5 is a drop-in replacement for the current one. They > > should *not* be installed side-by-side. > > > > > > Mic

Re: Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Ivan Čukić
> On Feb. 9, 2014, 7:12 p.m., Ivan Čukić wrote: > > This is not something I'd give a green light for. > > > > ActivityManager/KF5 is a drop-in replacement for the current one. They > > should *not* be installed side-by-side. > > > > > > Mic

Re: Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Ivan Čukić
t for. ActivityManager/KF5 is a drop-in replacement for the current one. They should *not* be installed side-by-side. - Ivan Čukić On Feb. 9, 2014, 6:45 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. T

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread Ivan Čukić
> more and more places - and especially all of the frameworks themselves. Ok, I'm game for the branch switch. Is there any documentation on how/what should be done to the cmake parts? p.s. > Since then, kdelibs got splitted, so as I said, KF5 stuff is "master" in The thread in question is from

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread Ivan Čukić
On Saturday, 8. February 2014. 12.58.53 David Faure wrote: > Also, kactivities is the only framework that still uses a branch named > "frameworks". > > Can we switch to master = kf5 and KDE/4.13 for the current master, assuming > a 4.13 release of it is planned? [otherwise what do we do with maste

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread Ivan Čukić
On Saturday, 8. February 2014. 13.26.41 you wrote: > On Saturday 08 February 2014 12:44:48 David Faure wrote: > > * plasma-framework depends on kactivities which is also not a proper > > framework. Shall we make it one and release it together with the others? > > It needs a bit of updating in the

Re: kactivities master becomes Qt5/KF5-based

2014-01-28 Thread Ivan Čukić
> Ping, 4.13 is looming over. If you want to make it so there's no new > releases of 4.12.x anymore and master is KF5 based, please discuss now. > > Personally I'd suggest against it since seems that even if we dicussed for > that happening to kde-workspace people did not get the memo and got ang

Re: kdesrc-build build failures

2013-11-09 Thread Ivan Čukić
On Friday 08 November 2013 18:04:08 Stefanie Dargel wrote: > Hi, > > when building kf5 in a clean directory with kdesrc-build plasma-framework > fails to build. it depends on kde-kactivities, which is scheduled to be > compiled after plasma-framework. thus plasma-framework builds fine the > second

<    1   2   3   >