D28882: Create protocol to manage video feeds

jgrulich added a comment. I have tested this and it now works as before, tested with Chromium, while checking all the values we pass to the portal and PipeWire which seem to be correct. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin,

D29121: Replace foreach with range-for

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH l-foreach-5 (branched from master) REVISION DETAIL https://phabricator.kde.org/D29121 To: ahmadsamir, #frameworks, jgrulich Cc: kde-frameworks-devel, LeGast00n,

D29093: [NetworkManager-qt] Replace foreach with range for, hopefully last pass

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH l-foreach-4 (branched from master) REVISION DETAIL https://phabricator.kde.org/D29093 To: ahmadsamir, #frameworks, jgrulich Cc: kde-frameworks-devel, LeGast00n,

D29091: [NetworkManager-qt] Replace foreach with range/index for loop, third pass

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH l-foreach-3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D29091 To: ahmadsamir, #frameworks, jgrulich Cc: kde-frameworks-devel, LeGast00n,

D29086: [NetworkManager-qt] Replace foreach with range/index for loop

jgrulich accepted this revision. REPOSITORY R282 NetworkManagerQt BRANCH l-foreach-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D29086 To: ahmadsamir, #frameworks, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29086: [NetworkManager-qt] Replace foreach with range/index for loop

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH l-foreach-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D29086 To: ahmadsamir, #frameworks, jgrulich Cc: kde-frameworks-devel, LeGast00n,

D29068: [NetworkManager-qt] replace foreach (deprecated) with range-for, first pass

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH l-foreach-1 (branched from master) REVISION DETAIL https://phabricator.kde.org/D29068 To: ahmadsamir, #frameworks, jgrulich Cc: kde-frameworks-devel, LeGast00n,

D28882: Create protocol to manage video feeds

jgrulich added a comment. In D28882#653483 , @jgrulich wrote: > Doesn't seem to build here: > > In file included from /home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7: >

D28882: Create protocol to manage video feeds

jgrulich added a comment. Doesn't seem to build here: In file included from /home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7: /home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.h:32:121: error:

D28882: Create protocol to manage video feeds

jgrulich added inline comments. INLINE COMMENTS > screencast.xml:13 > + > + > + Can we switch the values to follow xdg-desktop-portal specification? See

D28241: Check correct file for sandbox detection

This revision was automatically updated to reflect the committed changes. Closed by commit R271:7f8d778b0a05: Check correct file for sandbox detection (authored by jgrulich). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28241?vs=78362=78363 REVISION

D28241: Check correct file for sandbox detection

jgrulich created this revision. jgrulich added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jgrulich requested review of this revision. REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28241

D27932: NetworkManager-Qt: Convert license headers to SPDX expressions

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27932 To: cordlandwehr, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27769: modemmanager-qt: Convert license headers to SPDX expressions

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R281 ModemManagerQt BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27769 To: cordlandwehr, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27665: Support SAE in securityTypeFromConnectionSetting

This revision was automatically updated to reflect the committed changes. Closed by commit R282:8142b3cfa66a: Support SAE in securityTypeFromConnectionSetting (authored by Haochen Tong i...@hexchain.org, committed by jgrulich). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D27665: Support SAE in securityTypeFromConnectionSetting

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH securityTypeFromConnectionSetting-support-SAE (branched from master) REVISION DETAIL https://phabricator.kde.org/D27665 To: hexchain, jgrulich Cc:

D27327: Drop qmake pri file generation & installation, currently broken

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R281 ModemManagerQt BRANCH dropbrokenprifile REVISION DETAIL https://phabricator.kde.org/D27327 To: kossebau, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27328: Drop qmake pri file generation & installation, currently broken

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH dropbrokenprifile REVISION DETAIL https://phabricator.kde.org/D27328 To: kossebau, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27328: Drop qmake pri file generation & installation, currently broken

jgrulich added a comment. Looking at some other frameworks, they basically have same code to generate pri files, are they all broken? For example: https://cgit.kde.org/bluez-qt.git/tree/src/CMakeLists.txt#n195 REPOSITORY R282 NetworkManagerQt REVISION DETAIL

D27207: Use a less convoluted way to check if it's in flatpak

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27207 To: apol, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26461: [networkmanager-qt] Port QRegExp to QRegularExpression

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26461 To: ahmadsamir, #frameworks, jgrulich, dfaure Cc: kde-frameworks-devel,

D23766: FakeInput: add support for keyboard key press and release

jgrulich closed this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

jgrulich added a comment. In D23766#533644 , @apol wrote: > The patch looks good to me, is there a reason why it wasn't accepted? I'm not sure from the comment whether David requested some changes to be made now or whether this is good

D24689: Add support for SAE authentication used by WPA3

This revision was automatically updated to reflect the committed changes. Closed by commit R282:4a6a5e708077: Add support for SAE authentication used by WPA3 (authored by jgrulich). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24689?vs=68156=68157

D24689: Add support for SAE authentication used by WPA3

jgrulich marked an inline comment as done. REPOSITORY R282 NetworkManagerQt BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24689 To: jgrulich, #frameworks, meven Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

jgrulich updated this revision to Diff 68156. jgrulich added a comment. - Coding style REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24689?vs=68029=68156 BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24689 AFFECTED FILES

D24689: Add support for SAE authentication used by WPA3

jgrulich added a dependent revision: D24691: Add support for WPA3. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D24689 To: jgrulich, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

jgrulich updated this revision to Diff 68029. jgrulich added a comment. Compare against lowercase value REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24689?vs=68028=68029 BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24689

D24689: Add support for SAE authentication used by WPA3

jgrulich added a reviewer: Frameworks. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D24689 To: jgrulich, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

jgrulich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jgrulich requested review of this revision. REPOSITORY R282 NetworkManagerQt BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24689 AFFECTED FILES

D23713: strongswan support for custom proposals

jgrulich accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D23713 To: rrichmond, fvogt, jgrulich Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23713: strongswan support for custom proposals

jgrulich added a comment. Do not enable "Custom cipher proposals" by default, that forces everyone to uncheck it. REVISION DETAIL https://phabricator.kde.org/D23713 To: rrichmond, fvogt, jgrulich Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

jgrulich updated this revision to Diff 65600. jgrulich added a comment. Bump framework version Apparently KDE Frameworks 5.62 are already out. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23766?vs=65557=65600 BRANCH master REVISION DETAIL

D23766: FakeInput: add support for keyboard key press and release

jgrulich added a dependent revision: D23769: Add support for keyboard key press and release from fake input protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2,

D23766: FakeInput: add support for keyboard key press and release

jgrulich added inline comments. INLINE COMMENTS > jgrulich wrote in fakeinput.h:222 > I will need a little bit of help to understand what type of key event should > be used and I don't remember where I got the information it expects codes > defined from linux/input-event-codes.h (I copied it

D23766: FakeInput: add support for keyboard key press and release

jgrulich added inline comments. INLINE COMMENTS > fakeinput.h:222 > + * Request a keyboard button release. > + * @param linuxButton The button code as defined in > linux/input-event-codes.h > + * I will need a little bit of help to understand what type of key event should be used

D23766: FakeInput: add support for keyboard key press and release

jgrulich added reviewers: davidedmundson, apol, Plasma, romangg. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

jgrulich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jgrulich requested review of this revision. REVISION SUMMARY Adds support for keyboard button press and release as defined in linux/input-event-codes.h REPOSITORY R127

D23713: strongswan support for custom proposals

jgrulich added a comment. I'm not sure the "Cipher Proposals" groupbox should be inside the "Options" groupbox, imo it should be separated groupbox INLINE COMMENTS > strongswanwidget.cpp:100 > d->ui.ipComp->setChecked(dataMap[NM_STRONGSWAN_IPCOMP] == "yes"); > +

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

jgrulich added inline comments. INLINE COMMENTS > meven wrote in wirelessdevice.h:143 > I chose lastRequestScanTime to have RequestScan in the name, that is the > function, it keeps the last time called from. > > The Time suffix does not feel great indeed. > > I can make an adjustment to

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

jgrulich added inline comments. INLINE COMMENTS > wirelessdevice.h:143 > + */ > +QDateTime lastRequestScanTime() const; > /** Thinking about it now, wouldn't be this wording better? QDateTime lastScanRequestTime() const; Maybe even without the "Time" at the end so it's consistent

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

jgrulich accepted this revision. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D23576 To: meven, jgrulich Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Sorry, I missed that last one. Once it's fixed it's ready to go. INLINE COMMENTS > wirelessdevice.h:232 > + */ > +void lastScanChanged(const QDateTime timestamp); > const

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

jgrulich added inline comments. INLINE COMMENTS > utils.h:86 > + > +QDateTime clockBootTimeToQDateTime(const qlonglong ); > } 1. Missing NETWORKMANAGERQT_EXPORT 2. I would remove 'Q' from the name → clockBootTimeToDateTime 3. just qlonglong clockBoottime, no const and & REPOSITORY R282

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

jgrulich added inline comments. INLINE COMMENTS > meven wrote in wirelessdevice.cpp:250 > LastScan is in CLOCK_BOOTIME which is complicated to work with. > So I use naively the signal time rather than the LastScan value. > This will need a bit of work just to work with it: >

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

jgrulich added inline comments. INLINE COMMENTS > wirelessdevice.h:133 > + * The time when the last "LastScan" property change was received > + * @since 5.62.0 > + * @return Add something like: @note will always return invalid QDateTime when runtime NM < 1.12 > wirelessdevice.h:228

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

jgrulich added inline comments. INLINE COMMENTS > wirelessdevice.cpp:250 > +} else if (property == QLatin1String("LastScan")) { > +lastScanTime = QDateTime::currentDateTime(); > +Q_EMIT q->lastScanTimeChanged(lastScanTime); Don't use QDateTime::currentDateTime() as it might

D23576: Add property lastScan to WirelessDevice and associated change signal

jgrulich added a comment. In D23576#522340 , @meven wrote: > I am hesitant to add a second field "previousScan" that would store the previous lastScan timeStamp when a new one arrives. > This would be used to compute the time elapsed between

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich added a comment. In D18114#498642 , @romangg wrote: > @jgrulich With D22571 looking promising do you want to put the keyboard parts of this diff into a separate one? There is still the question

D20238: device: include reapplyConnection() in the interface

This revision was automatically updated to reflect the committed changes. Closed by commit R282:2d5a66004425: device: include reapplyConnection() in the interface (authored by aleksanderm, committed by jgrulich). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D22395: Allow updating default DBus timeout on every interface

This revision was automatically updated to reflect the committed changes. Closed by commit R281:a3d262f58d2f: Allow updating default DBus timeout on every interface (authored by aleksanderm, committed by jgrulich). REPOSITORY R281 ModemManagerQt CHANGES SINCE LAST UPDATE

D22395: Allow updating default DBus timeout on every interface

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R281 ModemManagerQt BRANCH aleksander/dbus-timeout REVISION DETAIL https://phabricator.kde.org/D22395 To: aleksanderm, #frameworks, jgrulich, broulik Cc: kde-frameworks-devel, LeGast00n,

D22395: Allow updating default DBus timeout on every interface

jgrulich added a comment. I think all the methods should be called timeout() and setTimeout(), you are not changing default timeout which will always be 25s if -1 is set as timeout value. Also the getters should be const methods. REPOSITORY R281 ModemManagerQt REVISION DETAIL

D21486: Don't fetch device statistics upon construction

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D21486 To: apol, #plasma, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20833: Simpler check for flatpak

jgrulich added a comment. Lookgs good to me, I'll wait for Kai to approve this since he is the maintainer. One thing to consider maybe, did /.flatpak-info always exist or is it something new? I always assumed there is just one flatpak-info file in $XDG_RUNTIME_DIR. Just to be sure it will

D20649: [Notify by Portal] Support default action and priority hints

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Works for me. I tested both like the default action and urgency. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20649 To: broulik, #frameworks,

D20238: device: include reapplyConnection() in the interface

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D20238 To: aleksanderm, jgrulich, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20238: device: include Reapply() in the interface

jgrulich added inline comments. INLINE COMMENTS > device.h:241 > + */ > +QDBusPendingReply<> reapplyInterface(NMVariantMapMap connection, > qulonglong version_id, uint flags); > /** 1. const NMVariantMapMap 2. I would maybe pick a different name, because it doesn't reapply

D18114: FakeInput: add support for pointer move with absolute coordinates

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:12b58edd254a: FakeInput: add support for pointer move with absolute coordinates (authored by jgrulich). REPOSITORY

D18762: Add support for portals in KRun

jgrulich added a comment. Looks good from the portal point of view, but I would rather wait for someone who knows KRun internally to approve this review. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18762 To: GeeXT, jgrulich, apol, dfaure, #frameworks Cc:

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich added a comment. Ping @graesslin? Martin, can you please look into this? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich added a comment. Hi, can I get please this re-approved? It's now just again about the additional mouse support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel,

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

jgrulich updated this revision to Diff 49133. jgrulich added a comment. Drop keyboard support from this review REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49087=49133 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich retitled this revision from "FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release" to "FakeInput: add support for pointer move with absolute coordinates". jgrulich edited the summary of this revision. REPOSITORY R127 KWayland REVISION

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

jgrulich updated this revision to Diff 49087. jgrulich added a comment. Fix documentation REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49082=49087 BRANCH fake-input-keyboard-key REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

jgrulich added a comment. I didn't intent to push this together, but when creating a branch from master which already had first round of changes caused my second part of changes to be pushed here. I hope you don't mind that. I'm doing this in a hurry hoping to get exception from David Faure

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

jgrulich retitled this revision from "FakeInput: add support for pointer move with absolute coordinates" to "FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release". jgrulich edited the summary of this revision. REPOSITORY R127 KWayland REVISION

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49082. jgrulich added a comment. Add support for keyboard key press and release REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49081=49082 BRANCH fake-input-keyboard-key REVISION DETAIL

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49081. jgrulich added a comment. Bump fake interface version REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49071=49081 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED FILES

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49071. jgrulich added a comment. Coding style REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49070=49071 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED FILES

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49070. jgrulich added a comment. Fix review comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49069=49070 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED FILES

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49069. jgrulich added a comment. Adress review comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49066=49069 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED FILES

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49066. jgrulich added a comment. Add information when new methods were introduced and bump version of FakeInput in registry REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49064=49066 BRANCH master

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49064. jgrulich added a comment. Revert unwanted changes in CMakeLists REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49046=49064 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich marked 4 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49046. jgrulich added a comment. Use QPointF instead of QSizeF and bump interface version REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49028=49046 BRANCH master REVISION DETAIL

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich added a dependent revision: D18115: Add support for fake pointer move with absolute coordinates. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich added a reviewer: davidedmundson. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jgrulich requested review of this revision. REVISION SUMMARY For remote desktop support, we need to move with the pointer using absolute position. TEST PLAN I tested this

D17743: Extend getExtensionFromPatternList reg exp filtering

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17743 To: davidedmundson, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17529 To: wbauer, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

jgrulich added a comment. In D17529#375913 , @wbauer wrote: > In D17529#375909 , @jgrulich wrote: > > > So maybe go with the easiest approach and just instead of defines use 0 and 1? > > >

D17529: [proxysetting] Fix build with NM 1.4

jgrulich added a comment. So maybe go with the easiest approach and just instead of defines use 0 and 1? REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17529 To: wbauer, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17529 To: wbauer, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

jgrulich added a comment. I think the easiest solution here is just to set 0 and 1 to the enum values, instead of NM defines. I'm not sure if adding/removing enum is ABI compatible change, because the enum will disapper once you build it against NM 1.6.0+. REPOSITORY R282 NetworkManagerQt

D17425: Added DCB settings

This revision was automatically updated to reflect the committed changes. Closed by commit R282:4332597370b8: Added DCB settings (authored by pranavgade, committed by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17425?vs=47338=47340#toc REPOSITORY R282 NetworkManagerQt

D17425: Added DCB settings

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D17425: Added DCB settings

jgrulich added inline comments. INLINE COMMENTS > dcbsetting.cpp:491 > + > +if (priorityFlowControl(7) > 0) { > +setting.insert(QLatin1String(NM_SETTING_DCB_PRIORITY_FLOW_CONTROL), > QVariant::fromValue(priorityFlowControl())); I think all those should be added all the time,

D17497: A minor typo in ipv4 test

This revision was automatically updated to reflect the committed changes. Closed by commit R282:7036e0ade135: A minor typo in ipv4 test (authored by jgrulich). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17497?vs=47321=47322 REVISION DETAIL

D17497: A minor typo in ipv4 test

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17497 To: pranavgade, jgrulich, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

jgrulich added a comment. This was last round, otherwise it's ready to go, just fix the remaining issues. Thanks. REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

jgrulich added inline comments. INLINE COMMENTS > dcbsettingtest.cpp:28 > +#include > +#include > + Include not needed. > dcbsetting.cpp:220 > +} else { > +return false; > +} You can remove the else branch and have just return false. > dcbsetting.cpp:254 > +} else { > +

D17425: dcb settings

jgrulich added inline comments. INLINE COMMENTS > dcbsettingtest.cpp:30 > + > +typedef QList UintList; > + Why? This type is defined in generictypes.h. > dcbsetting.h:30 > + > +typedef QList UintList; > + Again, this is defined in generictypes.h. > pranavgade wrote in dcbsetting.h:49 > I

D17425: dcb settings

jgrulich added inline comments. INLINE COMMENTS > dcbsetting.h:89 > +bool priorityFlowControl(quint32 userPriority) const; > +void setPriorityFlowControl(UintList list); > +UintList priorityFlowControl() const; const UintList > dcbsetting.h:94 > +quint32

D17474: A minor bug in ipv4 and ipv6 test

This revision was automatically updated to reflect the committed changes. Closed by commit R282:2edc30be9f3e: A minor bug in ipv4 and ipv6 test (authored by jgrulich). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17474?vs=47268=47269 REVISION

D17425: dcb settings

jgrulich added inline comments. INLINE COMMENTS > dcbsetting.h:106 > +/ > +void setPriorityFlowControlList(UintList list); > +UintList priorityFlowControlList() const; Move them please among the rest of methods, so all related methods are next to each other. Also use please

D17425: dcb settings

jgrulich added inline comments. INLINE COMMENTS > pranavgade wrote in dcbsetting.cpp:59 > Yeah, that would help. > Do you think I should do that? Yes please. REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

  1   2   3   4   >