Re: Review Request 112730: add CMake changes to knewstuff

2013-10-09 Thread Jeremy Whiting
. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112730: add CMake changes to knewstuff

2013-10-01 Thread Jeremy Whiting
dbde573e8c3a477755c8c866d0ca1fccd1a35729 Diff: http://git.reviewboard.kde.org/r/112730/diff/ Testing --- It builds and installs. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-09-24 Thread Jeremy Whiting
On Sept. 23, 2013, 4:37 a.m., Kevin Ottens wrote: I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least partly. Jeremy Whiting wrote: well, qt5_wrap_ui wasn't around when this was created (as kde4_add_ui_files iirc). All I did was copy it and rename

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-09-23 Thread Jeremy Whiting
into PREFIX/lib64/cmake/KI18N next to KI18nConfig.cmake Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-09-17 Thread Jeremy Whiting
/KI18nConfig.cmake.in 18b6e2f tier2/ki18n/cmake/KI18NMacros.cmake PRE-CREATION tier2/ki18n/cmake/ki18nuic.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112785/diff/ Testing --- Builds and installs into PREFIX/lib64/cmake/KI18N next to KI18nConfig.cmake Thanks, Jeremy

installed header includes

2013-09-09 Thread Jeremy Whiting
Hello, Apparently my commit to knewstuff broke the build. The problem is that knewstuff/src/knewstuffbutton.h includes knewstuff3/entry.h which hasn't been installed yet when building kdelibs. I looked around and saw some other frameworks install headers install directly into include (kauth.h

Re: Reviewboard

2012-08-06 Thread Jeremy Whiting
I tried adding frameworks group to the last review I posted for the cleanup task I just finished, but rb said there's no such group... Jeremy On Fri, Jul 20, 2012 at 10:04 AM, David Faure fa...@kde.org wrote: There is now a frameworks group on reviewboard, which you can use so that reviews are

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

2012-08-06 Thread Jeremy Whiting
I didn't check the make test against the result you are getting on the main branch, no. I'll remove the KAboutData from these and check that. Some of these KAboutData have quite a bit in them, is it ok to nuke them? I also found one KApplication usage in an io slave that's part of the patch, is

Re: More work available

2012-08-05 Thread Jeremy Whiting
, maybe not worth it to add to the wiki, dunno. Jeremy On Sun, Aug 5, 2012 at 5:17 AM, David Faure fa...@kde.org wrote: On Saturday 04 August 2012 09:41:28 Kevin Ottens wrote: On Saturday 04 August 2012 00:52:16 David Faure wrote: On Friday 03 August 2012 13:57:54 Jeremy Whiting wrote: Hey

Re: More work available

2012-08-03 Thread Jeremy Whiting
On Fri, Aug 3, 2012 at 6:52 PM, David Faure fa...@kde.org wrote: On Friday 03 August 2012 13:57:54 Jeremy Whiting wrote: Hey David, I started taking a stab at the KApplication - QApplication fix/conversions, then pulled and can't build currently. I can't tell from the last few commits what

Re: kdelibs partially ported to Qt5

2012-02-27 Thread Jeremy Whiting
On Thu, Feb 2, 2012 at 2:30 PM, Stephen Kelly stephen.ke...@kdab.com wrote: Hi there, I ported some of kdelibs to Qt5 (just the easy stuff). You can see the commits here: http://quickgit.kde.org/?p=kdelibs.gita=logh=894cde6ead6d9146d97e8adc7959efc907fdfe0e To try it out, you

frameworks build issues

2011-11-20 Thread Jeremy Whiting
Hello all, I took another crack at the kcolorscheme migration in frameworks branch yesterday, and got it to not depend on KGlobalSettings any longer. Unfortunately I still get warnings when I run cmake like this: -- Configuring done CMake Error: Attempt to add a custom rule to output

<    1   2   3