Re: Review Request 118270: [doc] explicitly load external entities (after CVE-2014-0191)

2014-05-28 Thread Jonathan Riddell
://bugs.launchpad.net/ubuntu/+source/kde4libs/+bug/1324066 - Jonathan Riddell On May 23, 2014, 8:24 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: [kde-frameworks-devel] Re: kdesu build problem

2014-05-08 Thread Jonathan Riddell
On Thu, May 08, 2014 at 10:59:16AM +0100, Alex Merry wrote: > On 08/05/14 09:37, Jonathan Riddell wrote: > > > > Can anyone get kdesu to build? I find it doesn't pass the DESTDIR to the > > chgrp command and gives an error > > > > -- Installing: > &g

kdesu build problem

2014-05-08 Thread Jonathan Riddell
Can anyone get kdesu to build? I find it doesn't pass the DESTDIR to the chgrp command and gives an error -- Installing: /build/buildd/kdesu-4.99.0/debian/tmp/usr/lib/x86_64-linux-gnu/libexec/kf5/kdesud -- Removed runtime path from "/build/buildd/kdesu-4.99.0/debian/tmp/usr/lib/x86_64-linux-g

KF5 Update Meeting Minutes 2014-w19

2014-05-06 Thread Jonathan Riddell
KDE Frameworks meeting was in #kde-devel at 14:00UTC agateau, arichardson, dfaure, ervin, notmart, Riddell, sebas, teo, tosky also present: PovAddictW, apol, mgraesslin < unormal> There is some work going on for new CI system for KF5 and Co. And the webpage http://community.kde.org/Frameworks/Epi

Re: Review Request 117940: rename country entry.desktop to country.desktop for ease and install into /usr/share/kf5

2014-05-02 Thread Jonathan Riddell
/entry.desktop src/l10n/yt/entry.desktop src/l10n/za/entry.desktop src/l10n/zm/entry.desktop src/l10n/zw/entry.desktop Diff: https://git.reviewboard.kde.org/r/117940/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel

Re: Review Request 117940: rename country entry.desktop to country.desktop for ease and install into /usr/share/kf5

2014-05-02 Thread Jonathan Riddell
/l10n/za/entry.desktop src/l10n/zm/entry.desktop src/l10n/zw/entry.desktop Diff: https://git.reviewboard.kde.org/r/117940/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 117940: rename country entry.desktop to country.desktop for ease and install into /usr/share/kf5

2014-05-02 Thread Jonathan Riddell
/entry.desktop src/l10n/ws/entry.desktop src/l10n/ye/entry.desktop src/l10n/yt/entry.desktop src/l10n/za/entry.desktop src/l10n/zm/entry.desktop src/l10n/zw/entry.desktop Diff: https://git.reviewboard.kde.org/r/117940/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-05-01 Thread Jonathan Riddell
9f0c055 Diff: https://git.reviewboard.kde.org/r/117148/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117150: use renamed kf5_entry.desktop file

2014-05-01 Thread Jonathan Riddell
- Jonathan Riddell On March 28, 2014, 7:24 p.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 117150: use renamed kf5_entry.desktop file

2014-05-01 Thread Jonathan Riddell
/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117907: make documentation match new values in code

2014-04-30 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/117907/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-04-30 Thread Jonathan Riddell
Diff: https://git.reviewboard.kde.org/r/117148/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117907: make documentation match new values in code

2014-04-30 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/117907/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117905: rename kdebugdialog to kdebugdialog5 in documentation

2014-04-30 Thread Jonathan Riddell
: https://git.reviewboard.kde.org/r/117905/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117907: make documentation match new values in code

2014-04-30 Thread Jonathan Riddell
Alex Merry. Repository: extra-cmake-modules Description --- make documentation match new values in code Diffs - kde-modules/KDEInstallDirs.cmake d22f7177b0df2de07f56670842c3789ee7728447 Diff: https://git.reviewboard.kde.org/r/117907/diff/ Testing --- Thanks, Jonathan

Review Request 117905: rename kdebugdialog to kdebugdialog5 in documentation

2014-04-30 Thread Jonathan Riddell
. Repository: kdelibs4support Description --- rename kdebugdialog to kdebugdialog5 in documentation Diffs - docs/kdebugdialog5/index.docbook dc7c4c4bf4c6adee2d70368bf72b655f84422bdd Diff: https://git.reviewboard.kde.org/r/117905/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 117895: rename kdebugdialog5 internally and move documentation for co-installability

2014-04-30 Thread Jonathan Riddell
/kdebugdialog/main.cpp de9baf0 Diff: https://git.reviewboard.kde.org/r/117895/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117895: rename kdebugdialog5 internally and move documentation for co-installability

2014-04-30 Thread Jonathan Riddell
/kdebugdialog5/CMakeLists.txt PRE-CREATION docs/kdebugdialog5/index.docbook PRE-CREATION src/kdebugdialog/main.cpp de9baf0 Diff: https://git.reviewboard.kde.org/r/117895/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel

Review Request 117895: rename kdebugdialog5 internally and move documentation for co-installability

2014-04-30 Thread Jonathan Riddell
/CMakeLists.txt 3d2c316 docs/kdebugdialog/index.docbook dc7c4c4 docs/kdebugdialog5/CMakeLists.txt PRE-CREATION docs/kdebugdialog5/index.docbook PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117895/diff/ Testing --- Thanks, Jonathan Riddell

Release date for plasma scheduling

2014-04-30 Thread Jonathan Riddell
Over at Plasma we'd like to do a release of our RC after the final Frameworks release. To be able to set a date could I ask for a reasonably firm date for Frameworks release? Currently Frameworks release is listed as Thursday June 1st http://community.kde.org/Frameworks/Epics is that likel

Re: Review Request 117858: don't install unused kconfig update files, clashes with kdelibs4 and unused as KF5 starts from a fresh config

2014-04-30 Thread Jonathan Riddell
s.txt a24749b48eb699689c6c6dd1d2dfc9cdf7087b3f src/ioslaves/http/kcookiejar/kcookiescfg.pl 7fef01d5c208a00987b3594411ce06799457 src/ioslaves/http/kcookiejar/kcookiescfg.upd 745f545090875d5d24e1e6bb397af9926704350f Diff: https://git.reviewboard.kde.org/r/117858/diff/ Testing --- Thanks, Jonathan Ri

keditfiletype binary

2014-04-29 Thread Jonathan Riddell
keditfiletype is in kde-cli-tools in workspace category and used to be in kde-runtime. I've submitted a review to rename it for coinstallability and noticed that it gets used in frameworks in a couple of places frameworks/kio/src/widgets/kpropertiesdialog.cpp frameworks/kwidgetsaddons/src/km

Re: Review Request 117864: Move current files from /usr/share/locale/currency/ to /usr/share/locale/currency/kf5/ This allows KF5 to be co-installed with kde-runtime from kdelibs4

2014-04-29 Thread Jonathan Riddell
/CMakeLists.txt e7ec38d src/kcurrencycode.cpp 8d6d3ce Diff: https://git.reviewboard.kde.org/r/117864/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 117864: Move current files from /usr/share/locale/currency/ to /usr/share/locale/currency/kf5/ This allows KF5 to be co-installed with kde-runtime from kdelibs4

2014-04-29 Thread Jonathan Riddell
ocale/currency/ to /usr/share/locale/currency/kf5/ This allows KF5 to be co-installed with kde-runtime from kdelibs4 Diffs (updated) - src/currency/CMakeLists.txt e7ec38d src/kcurrencycode.cpp 8d6d3ce Diff: https://git.reviewboard.kde.org/r/117864/diff/ Testing --- Thanks, Jon

Re: Review Request 117864: Move current files from /usr/share/locale/currency/ to /usr/share/locale/currency/kf5/ This allows KF5 to be co-installed with kde-runtime from kdelibs4

2014-04-29 Thread Jonathan Riddell
packagers do. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117864/#review56889 --- On April 29, 2014, 12:27 p.

Review Request 117864: Move current files from /usr/share/locale/currency/ to /usr/share/locale/currency/kf5/ This allows KF5 to be co-installed with kde-runtime from kdelibs4

2014-04-29 Thread Jonathan Riddell
8d6d3ce3229ea0bfcd4f791ad52d560097686a79 Diff: https://git.reviewboard.kde.org/r/117864/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117858: don't install unused kconfig update files, clashes with kdelibs4 and unused as KF5 starts from a fresh config

2014-04-29 Thread Jonathan Riddell
fg.pl 7fef01d5c208a00987b3594411ce06799457 src/ioslaves/http/kcookiejar/kcookiescfg.upd 745f545090875d5d24e1e6bb397af9926704350f Diff: https://git.reviewboard.kde.org/r/117858/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-04-29 Thread Jonathan Riddell
/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117151: use renamed kf5_entry.desktop file

2014-04-29 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/117151/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117151: use renamed kf5_entry.desktop file

2014-04-29 Thread Jonathan Riddell
--- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-04-29 Thread Jonathan Riddell
> On April 29, 2014, 9:22 a.m., Jonathan Riddell wrote: > > I disagree, ./src/kdecore/entry.desktop gets renamed to kf5_entry.desktop > > on install and installs into /usr/share/locale/en_US/kf5_entry.desktop so > > it is the locale entry.desktop file which has been re

Re: Review Request 117151: use renamed kf5_entry.desktop file

2014-04-29 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/117151/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117150: use renamed kf5_entry.desktop file

2014-04-29 Thread Jonathan Riddell
generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117150/#review54682 --- On March 28, 2014, 7:24 p.m., Jonathan Riddell wrote: > > --- > This is an auto

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-04-29 Thread Jonathan Riddell
kf5_entry.desktop on install and installs into /usr/share/locale/en_US/kf5_entry.desktop so it is the locale entry.desktop file which has been renamed not the country entry.desktop files. renaming them in the language packs is future work. - Jonathan Riddell On March 28, 2014, 7:22 p.m., Jonathan

Re: Review Request 117708: move kioslave docs paths for co-installability

2014-04-26 Thread Jonathan Riddell
/ioslaves/http/webdavs.protocol 7017c24 src/ioslaves/mailto/kmailservice5.desktop 03838a5 src/ioslaves/protocols/data.protocol 2a57b2e src/ioslaves/telnet/ktelnetservice5.desktop 052a9d3 Diff: https://git.reviewboard.kde.org/r/117708/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 117706: remove unused kwallet upgrade script

2014-04-25 Thread Jonathan Riddell
/runtime/kwalletd/CMakeLists.txt d9fb4b3 src/runtime/kwalletd/kwallet-4.13.upd beb51ba Diff: https://git.reviewboard.kde.org/r/117706/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review request: kdeebugdialog5 co-installability

2014-04-24 Thread Jonathan Riddell
Reviewboard does not like this patch and even my usual goto man for git help agateau can't work out why. So here's a manual review request kdelibs4support: http://starsky.19inch.net/~jr/tmp/DIFF rename kdebugdialog to kdeebugdialog5 internally and move documentation to allow for co-installab

Re: Review Request 117705: co-installability: rename kactivitymanagerd to kactivitymanagerd5

2014-04-24 Thread Jonathan Riddell
3436764 src/service/files/kactivitymanagerd.desktop 00ff557 Diff: https://git.reviewboard.kde.org/r/117705/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 117705: co-installability: rename kactivitymanagerd to kactivitymanagerd5

2014-04-23 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117705/#review56328 --- https://git.reviewboard.kde.org/r/115602/ - Jonathan Riddell

Review Request 117708: move kioslave docs paths for co-installability

2014-04-23 Thread Jonathan Riddell
/ioslaves/protocols/data.protocol 2a57b2e src/ioslaves/telnet/ktelnetservice5.desktop 052a9d3 Diff: https://git.reviewboard.kde.org/r/117708/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 117706: remove unused kwallet upgrade script

2014-04-23 Thread Jonathan Riddell
: https://git.reviewboard.kde.org/r/117706/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117705: co-installability: rename kactivitymanagerd to kactivitymanagerd5

2014-04-23 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/117705/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Frameworks Sprint 2014 etherpad

2014-04-23 Thread Jonathan Riddell
I've added a link from http://community.kde.org/Frameworks/Meetings to the etherpad for the sprint this week https://notes.kde.org/p/frameworks-sprint-2014 hope that's useful Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.or

KF5 Update Meeting Minutes 2014-w17

2014-04-22 Thread Jonathan Riddell
Chair: Riddell Reports this week: alexmerry, agateau, apol, mck182, PovAddictW, tosky Observing: markg85, MJD, notmart Announcements: - Sprint: Thursday to Monday, in Barcelona https://sprints.kde.org/sprint/224 notes page: https://notes.kde.org/p/frameworks-sprint-2014 - Beta 2, a week on Thur

Weekly meeting tomorrow

2014-04-21 Thread Jonathan Riddell
The weekly Frameworks meeting will be tomorrow at 14:00UTC (15:00 BST, 16:00 CEST) in #kde-devel. All welcome. Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kcrash test failure

2014-03-31 Thread Jonathan Riddell
Anyone seen this test failure in kcrash? I only get it on i386 http://paste.kde.org/pccpojfwd Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117147: use renamed kf5_entry.desktop file

2014-03-29 Thread Jonathan Riddell
/117147/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [kde-frameworks-devel] Regarding entry.desktop files

2014-03-28 Thread Jonathan Riddell
Thanks for the information. My main concern is that kf5 and kde-runtime can be installed alongside the kdelibs4 equivalents without overlapping files. I didn't know there were entry.desktop files in kde-runtime too but I see them now. I've committed a change to kde4support to rename the C entry

Review Request 117151: use renamed kf5_entry.desktop file

2014-03-28 Thread Jonathan Riddell
: kde4support Description --- entry.desktop got renamed, use the renamed file https://git.reviewboard.kde.org/r/117087/ Diffs - autotests/klocaletimeformattest.cpp c965cac Diff: https://git.reviewboard.kde.org/r/117151/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 117150: use renamed kf5_entry.desktop file

2014-03-28 Thread Jonathan Riddell
: kxmlgui Description --- entry.desktop got renamed, use the renamed file https://git.reviewboard.kde.org/r/117087/ Diffs - src/khelpmenu.cpp 4f6ce7b Diff: https://git.reviewboard.kde.org/r/117150/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 117148: use renamed kf5_entry.desktop file

2014-03-28 Thread Jonathan Riddell
: kconfigwidgets Description --- entry.desktop got renamed, use the renamed file https://git.reviewboard.kde.org/r/117087/ Diffs - src/klanguagebutton.cpp 9f0c055 Diff: https://git.reviewboard.kde.org/r/117148/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 117147: use renamed kf5_entry.desktop file

2014-03-28 Thread Jonathan Riddell
: kio Description --- entry.desktop got renamed, use the renamed file https://git.reviewboard.kde.org/r/117087/ Diffs - src/core/global.cpp 99ab2e7 Diff: https://git.reviewboard.kde.org/r/117147/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 117087: co-installability: rename entry.desktop to kf5_entry.desktop

2014-03-28 Thread Jonathan Riddell
> On March 28, 2014, 4:16 p.m., Commit Hook wrote: > > This review has been submitted with commit > > a33377b84b9b312cf5f1f2baae42e6e514731d64 by Jonathan Riddell to branch > > master. > > Aleix Pol Gonzalez wrote: > Why did you ignore my comment? This br

Re: Review Request 117087: co-installability: rename entry.desktop to kf5_entry.desktop

2014-03-28 Thread Jonathan Riddell
d1bedee Diff: https://git.reviewboard.kde.org/r/117087/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117087: co-installability: rename entry.desktop to kf5_entry.desktop

2014-03-26 Thread Jonathan Riddell
: kde4support Description --- stop clashing files on install with kdelibs4 and rename entry.desktop to kf5_entry.desktop Diffs - src/CMakeLists.txt 307cafa src/kdecore/klocale_kde.cpp d1bedee Diff: https://git.reviewboard.kde.org/r/117087/diff/ Testing --- Thanks, Jonathan

Re: setting SOVERSION to 5

2014-02-25 Thread Jonathan Riddell
On Tue, Feb 25, 2014 at 04:55:43PM +0100, Kevin Ottens wrote: > OK, but then the said change is either in the packaging or in our own cmake > files as we'd have to drop the SOVERSION later on when our version becomes > 5.0.0. So it's really a question of which is more error prone. No change woul

Re: [kde-frameworks-devel] Re: setting SOVERSION to 5

2014-02-25 Thread Jonathan Riddell
On Tue, Feb 25, 2014 at 03:29:16PM +0100, Kevin Ottens wrote: > Beside I still don't see a clear motive behind that change (Jonathan hinted > at > helping with packaging but it looks like not all packagers agree). It needs packaging changes whenever the soversion changes which means errors can b

Re: Review Request 115913: Rename webp.xml to kf5-imagesformats-webp.xml on installation

2014-02-24 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115913/#review50718 --- Ship it! Ship It! - Jonathan Riddell On Feb. 20, 2014, 2

setting SOVERSION to 5

2014-02-24 Thread Jonathan Riddell
In the tech preview release the libraries were all versioned 5.0.0 with SOVERSION of 5. In alpha 1 that became 4.96.0 with SOVERSION of 4. The SOVERSION will presumably go back to 5 at some point before release. It's quite hassleful to packagers to keep changing the SOVERSION so I propose chang

Re: kimageformats test fails on i386

2014-02-18 Thread Jonathan Riddell
On Tue, Feb 18, 2014 at 03:23:42PM +, Alex Merry wrote: > On 18/02/14 15:06, Jonathan Riddell wrote: > > > > I'm getting a fail for kwidgetsaddons > > > > Start 1: kimageformats-read-jp2 > > 1/13 Test #1: kimageformats-read-jp2 ...**

kimageformats test fails on i386

2014-02-18 Thread Jonathan Riddell
I'm getting a fail for kwidgetsaddons Start 1: kimageformats-read-jp2 1/13 Test #1: kimageformats-read-jp2 ...***Failed0.21 sec Only this test fails and only on i386, tried with the latest git. Any ideas? Jonathan ___ Kde-framew

Re: kde5 in [app .desktop file install] path

2014-02-12 Thread Jonathan Riddell
On Tue, Feb 11, 2014 at 09:29:24PM +, Alex Merry wrote: > > Thinking out loud: with the current efforts in making things > > co-installable, I > > wonder... it'll make .desktop files clash between kde4 and kde5. > > Already solved for kdelibs4 (by renaming the two desktop files in KF5's > >

Re: Review Request 115472: fix test for icon path

2014-02-05 Thread Jonathan Riddell
Diff: https://git.reviewboard.kde.org/r/115472/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115387: rename dbus interface file for kinit

2014-02-05 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/115387/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115472: fix test for icon path

2014-02-05 Thread Jonathan Riddell
Diff: https://git.reviewboard.kde.org/r/115472/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115387: rename dbus interface file for kinit

2014-02-04 Thread Jonathan Riddell
it: https://git.reviewboard.kde.org/r/115387/#review48715 --- On Jan. 29, 2014, 4:27 p.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 115473: information in README on each part of this framework

2014-02-04 Thread Jonathan Riddell
c798e63 Diff: https://git.reviewboard.kde.org/r/115473/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115472: fix test for icon path

2014-02-04 Thread Jonathan Riddell
nk my way is more readable but if you disagree I'll go with yours - Jonathan Riddell On Feb. 4, 2014, 4:30 p.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git

Re: Review Request 115473: information in README on each part of this framework

2014-02-04 Thread Jonathan Riddell
ME.md c798e63 Diff: https://git.reviewboard.kde.org/r/115473/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115472: fix test for icon path

2014-02-04 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/115472/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115473: information in README on each part of this framework

2014-02-04 Thread Jonathan Riddell
ME.md c798e63 Diff: https://git.reviewboard.kde.org/r/115473/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115473: information in README on each part of this framework

2014-02-04 Thread Jonathan Riddell
) - README.md c798e63 Diff: https://git.reviewboard.kde.org/r/115473/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115472: fix test for icon path

2014-02-04 Thread Jonathan Riddell
9943f Diff: https://git.reviewboard.kde.org/r/115472/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KF5 Update Meeting Minutes 2014-w6

2014-02-04 Thread Jonathan Riddell
On Tue, Feb 04, 2014 at 04:35:01PM +0100, Kevin Ottens wrote: > * he also reported that the qt4 branch of polkit-qt should be good to go; that's Qt 5 branch of polkit-qt, which Dario says is fine but needs files renamed to prevent clashing with qt4 branch. Jonathan _

Review Request 115472: fix test for icon path

2014-02-04 Thread Jonathan Riddell
: frameworkintegration Description --- QPlatformTheme::IconThemeSearchPaths is ~/.icons in this Kubuntu install so fix test to allow for this Diffs - autotests/kdeplatformtheme_unittest.cpp 2f9943f Diff: https://git.reviewboard.kde.org/r/115472/diff/ Testing --- Thanks, Jonathan

Review Request 115473: information in README on each part of this framework

2014-02-04 Thread Jonathan Riddell
, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115423: Move license information to its proper locations

2014-02-04 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115423/#review48894 --- Ship it! Ship It! - Jonathan Riddell On Feb. 1, 2014, 5

Re: Review Request 115423: Move license information to its proper locations

2014-02-04 Thread Jonathan Riddell
u can read the debian/copyright files in the kubuntu packaging to get a summary for all the packages https://launchpad.net/~kubuntu-ppa/+archive/experimental/+packages (although even this probably includes some simplifications and missed out bits) - Jonathan Riddell On Feb. 1, 2014,

Re: Authors, maintainers and licenses in apidox

2014-01-30 Thread Jonathan Riddell
A bigger problem is there's no copyright holder or licence for this framework, anyone know how to find those? Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115398: rename dbus interface to prevent clashes with khtml from kdelibs4

2014-01-30 Thread Jonathan Riddell
src/CMakeLists.txt 841edbd Diff: https://git.reviewboard.kde.org/r/115398/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115398: rename dbus interface to prevent clashes with khtml from kdelibs4

2014-01-30 Thread Jonathan Riddell
=khtml.git&a=commit&h=24c50cea9c32be8661cbc4914d8f4c2767206937 15:35 < sandsmark> seems to be a not-too-closely-looked-at leftover from dcop days - Jonathan Riddell On Jan. 30, 2014, 12:38 p.m., Jonathan Riddell wrote: > >

kde4support entry.desktop

2014-01-30 Thread Jonathan Riddell
kde4support has some files which clash with the kdelibs4 equivalents. /usr/share/locale/all_languages which I proposed to change to kf5_all_lanuages https://git.reviewboard.kde.org/r/115401/ But there's also /usr/share/locale/en_US/entry.desktop which clases with the kdelibs4 equivalent. Will

Re: Review Request 115401: rename all_languages for coinstallability in kde4support

2014-01-30 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/115401/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115401: rename all_languages for coinstallability in kde4support

2014-01-30 Thread Jonathan Riddell
--- rename all_languages at install time in kde4support for coinstallability with kdelibs4 Diffs - src/kdecore/klocale_kde.cpp 415edbf src/CMakeLists.txt 0d67011 Diff: https://git.reviewboard.kde.org/r/115401/diff/ Testing --- Thanks, Jonathan Riddell

Review Request 115398: rename dbus interface to prevent clashes with khtml from kdelibs4

2014-01-30 Thread Jonathan Riddell
/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115387: rename dbus interface file for kinit

2014-01-29 Thread Jonathan Riddell
: kinit Description --- rename the dbus interface file for kinit on install to prevent clashes with kdelibs4 equivalent. Diffs - src/klauncher/CMakeLists.txt c6cff7c Diff: https://git.reviewboard.kde.org/r/115387/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 115381: rename dbus interface file for kmediaplayer

2014-01-29 Thread Jonathan Riddell
unchanged. Diffs - src/CMakeLists.txt 299c044 Diff: https://git.reviewboard.kde.org/r/115381/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 115359: rename dbus interface files and .desktop files in kio

2014-01-29 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115359/#review48554 --- - Jonathan Riddell On Jan. 29, 2014, 3:57 p.m., Jonathan

Re: Review Request 115359: rename dbus interface files and .desktop files in kio

2014-01-29 Thread Jonathan Riddell
src/ioslaves/telnet/ktelnetservice.desktop 052a9d3 src/ioslaves/telnet/ktelnetservice5.desktop PRE-CREATION src/widgets/CMakeLists.txt 01b9483 Diff: https://git.reviewboard.kde.org/r/115359/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde

Re: Review Request 115361: use renamed kmailservice5

2014-01-29 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/115361/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115381: rename dbus interface file for kmediaplayer

2014-01-29 Thread Jonathan Riddell
://git.reviewboard.kde.org/r/115381/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115359: rename dbus interface files and .desktop files in kio

2014-01-29 Thread Jonathan Riddell
src/ioslaves/telnet/ktelnetservice5.desktop PRE-CREATION src/widgets/CMakeLists.txt 01b9483 Diff: https://git.reviewboard.kde.org/r/115359/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks

Review Request 115361: use renamed kmailservice5

2014-01-28 Thread Jonathan Riddell
: kservice Description --- fix test for renamed kmailservice5 proposed in https://git.reviewboard.kde.org/r/115359/ Diffs - autotests/kservicetest.cpp 89eb0ae Diff: https://git.reviewboard.kde.org/r/115361/diff/ Testing --- Thanks, Jonathan Riddell

Re: Review Request 115359: rename dbus interface files and .desktop files in kio

2014-01-28 Thread Jonathan Riddell
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115359/#review48486 ------- On Jan. 28, 2014, 4:03 p.m., Jonathan Riddell wrote: > > ---

Review Request 115359: rename dbus interface files and .desktop files in kio

2014-01-28 Thread Jonathan Riddell
/CMakeLists.txt 01b9483 Diff: https://git.reviewboard.kde.org/r/115359/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115353: Rename dbus interface files for solid

2014-01-28 Thread Jonathan Riddell
/114927/ doesn't? - Jonathan Riddell On Jan. 28, 2014, 2:12 p.m., Stefano Avallone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 115218: rename dbus interface file on install for kwallet

2014-01-27 Thread Jonathan Riddell
, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115186: rename dbus interface file for kjobviewer

2014-01-25 Thread Jonathan Riddell
is the same technique used for kglobalaccel. Diffs - src/CMakeLists.txt 7527a0a Diff: https://git.reviewboard.kde.org/r/115186/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 115218: rename dbus interface file on install for kwallet

2014-01-23 Thread Jonathan Riddell
7;t changed. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115218/#review48079 ------- On Jan. 22, 2014, 11:23 a.m., Jonath

Re: Authors, maintainers and licenses in apidox

2014-01-22 Thread Jonathan Riddell
On Wed, Jan 22, 2014 at 12:27:29PM +, Alex Merry wrote: > I would be tempted to ditch the current LICENSE files (all three of > them), and add (summary) license info to README.md, as The COPYING{.LIB,.DOC} files can't go away as there must be a full copy of the licence text included with any c

<    1   2   3   4   >