On 26/06/2023 17.27, Heiko Becker wrote:
On Monday, 26 June 2023 14:06:04 CEST, Jos van den Oever wrote:
On 26/06/2023 13.15, Heiko Becker wrote:
On Monday, 26 June 2023 11:13:56 CEST, Jos van den Oever wrote:
The new versions of frameworks, plasma and gear presumably all start
with '6
On 26/06/2023 13.15, Heiko Becker wrote:
On Monday, 26 June 2023 11:13:56 CEST, Jos van den Oever wrote:
The new versions of frameworks, plasma and gear presumably all start
with '6'. Following Fedora versioning for snapshots [0] gives this:
6^20230627git5328c27e3
Like Jonathan said
The new versions of frameworks, plasma and gear presumably all start
with '6'. Following Fedora versioning for snapshots [0] gives this:
6^20230627git5328c27e3
Having the commit date and the git revision in there helps with bug reports.
But this disregards the context (build options,
Hello all,
I'm packaging KF6 software in a nix flake [0]. I'm wondering what
version numbers to use for packages built from the latest git commit
from master.
Best regards,
Jos
[0] https://invent.kde.org/vandenoever/kde-nix-flake/-/tree/kf6-qt6
OpenPGP_signature
Description: OpenPGP
vandenoever added a comment.
done
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D19263
To: vandenoever, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham,
bruns, demsking, cullmann,
vandenoever added a comment.
I see that one test fails after committing this patch. The example output was
modified by `/autotests/update-reference-data.sh` but I did not submit it. I
thought it was not related to the markdown change.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:bbb5188d9e12: Add more highlighting for nested languages
in markdown. (authored by vandenoever).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
vandenoever updated this revision to Diff 52430.
vandenoever added a comment.
Increased kateversion to 5.0.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19263?vs=52410=52430
BRANCH
nested (branched from master)
REVISION DETAIL
vandenoever added a comment.
Even folding works inside fenced blocks.
After running `./autotests/update-reference-data.sh`
`autotests/folding/example.rmd.fold` changed. I did not commit that change.
The language version is now updated and I added a few more languages.
REPOSITORY
vandenoever updated this revision to Diff 52410.
vandenoever added a comment.
- added more languages,
- updated language version
- updated test files
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19263?vs=52395=52410
BRANCH
nested
vandenoever retitled this revision from "yAdd more highlighting for nested
languages in markdown." to "Add more highlighting for nested languages in
markdown.".
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D19263
To: vandenoever,
vandenoever added a reviewer: Framework: Syntax Highlighting.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D19263
To: vandenoever, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns,
demsking, cullmann,
vandenoever created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
vandenoever requested review of this revision.
REPOSITORY
R216 Syntax Highlighting
BRANCH
nested (branched from master)
REVISION DETAIL
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:2cdcd4f30666: Write valid UTF8 characters without
escaping. (authored by vandenoever).
REPOSITORY
R237 KConfig
vandenoever added a comment.
So it's accepted?
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D19107
To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago
Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns
vandenoever added inline comments.
INLINE COMMENTS
> thiago wrote in kconfigini.cpp:683
> This function does operate properly to find valid syntax UTF-8 sequences, but
> it is neither catching overlong sequences nor UTF-8 content above U+10
> (UTF-8 can encode 0x11000 in 4 bytes).
>
> See
vandenoever updated this revision to Diff 52096.
vandenoever added a comment.
Clean up test by using QTest data.
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19107?vs=52091=52096
BRANCH
utf8
REVISION DETAIL
https://phabricator.kde.org/D19107
vandenoever updated this revision to Diff 52091.
vandenoever added a comment.
Remove duplicate if statement.
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19107?vs=52090=52091
BRANCH
utf8
REVISION DETAIL
https://phabricator.kde.org/D19107
AFFECTED
vandenoever updated this revision to Diff 52090.
vandenoever added a comment.
Added tests and code fixes to deal with overlong sequences and content
above U+10.
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19107?vs=52015=52090
BRANCH
utf8
vandenoever added inline comments.
INLINE COMMENTS
> thiago wrote in kconfigini.cpp:683
> This function does operate properly to find valid syntax UTF-8 sequences, but
> it is neither catching overlong sequences nor UTF-8 content above U+10
> (UTF-8 can encode 0x11000 in 4 bytes).
>
> See
vandenoever added inline comments.
INLINE COMMENTS
> thiago wrote in kconfigini.cpp:683
> This function does operate properly to find valid syntax UTF-8 sequences, but
> it is neither catching overlong sequences nor UTF-8 content above U+10
> (UTF-8 can encode 0x11000 in 4 bytes).
>
> See
vandenoever updated this revision to Diff 52015.
vandenoever added a comment.
- Remove VALUE define.
- Spelling fix.
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19107?vs=51933=52015
BRANCH
utf8
REVISION DETAIL
https://phabricator.kde.org/D19107
vandenoever added inline comments.
INLINE COMMENTS
> dfaure wrote in kconfigtest.cpp:1774
> What's the purpose of this very short-lived define, compared to just inlining
> this into the next line?
Right, copy-paste leftover. I'll fix it.
REPOSITORY
R237 KConfig
REVISION DETAIL
vandenoever added a reviewer: thiago.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D19107
To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago
Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns
vandenoever created this revision.
vandenoever added reviewers: dfaure, arichardson, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vandenoever requested review of this revision.
REVISION SUMMARY
commit 6a18528
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:f403d09d0b49: Fix a regression introduced in 6a1852
(authored by vandenoever).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17856?vs=48363=48393
REVISION DETAIL
vandenoever added reviewers: dfaure, arichardson, apol, aacid, ngraham.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D17856
To: vandenoever, dfaure, arichardson, apol, aacid, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
vandenoever added a comment.
Sure. It's here https://phabricator.kde.org/D17856
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D17651
To: vandenoever, dfaure, arichardson, apol
Cc: ngraham, aacid, apol, kde-frameworks-devel, michaelh, bruns
vandenoever created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vandenoever requested review of this revision.
REVISION SUMMARY
Bytes from 'Strings' of type GroupString and KeyString should not be
escaped because they are valid UTF-8.
vandenoever added a comment.
Here is a patch that solves the problem:
diff --git a/src/core/kconfigini.cpp b/src/core/kconfigini.cpp
index 39e5936..b674973 100644
--- a/src/core/kconfigini.cpp
+++ b/src/core/kconfigini.cpp
@@ -673,7 +673,12 @@ QByteArray
vandenoever added a comment.
Found it. This is the failing test.
FAIL! : KConfigTest::testEncoding() Compared values are not the same
Actual (lines.first()): "[UTF-8:\\xc3\\xb6l]\n"
Expected (QByteArray("[UTF-8:\xc3\xb6l]\n")): "[UTF-8:\xC3\xB6l]\n"
vandenoever added a comment.
Can you give some more details? I see problem on Jenkins.
https://build.kde.org/job/Frameworks/job/kconfig/
Since my commits there was one more patch, but it's not related.
https://cgit.kde.org/kconfig.git/commit/?id=d90a37b5a1d892d7b0ff7cc3b56c8a6e8c4bfe1a
vandenoever marked 2 inline comments as done.
vandenoever added a comment.
I pushed two encore commits fixing the two raised issues.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D17651
To: vandenoever, dfaure, arichardson, apol
Cc: apol, kde-frameworks-devel,
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:6a185285ae44: Escape bytes that are larger than or equal
to 127 in config files (authored by vandenoever).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
vandenoever updated this revision to Diff 47790.
vandenoever added a comment.
Add a check for reading in the unit test.
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17651?vs=47788=47790
BRANCH
utf8 (branched from master)
REVISION DETAIL
vandenoever retitled this revision from "Escape bytes that are larger than 127
in config files" to "Escape bytes that are larger than or equal to 127 in
config files".
vandenoever edited the summary of this revision.
REPOSITORY
R237 KConfig
REVISION DETAIL
vandenoever updated this revision to Diff 47788.
vandenoever edited the summary of this revision.
vandenoever added a comment.
Added a unit test and changed the code so that 0x7f (DEL) is also
escaped.
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
vandenoever retitled this revision from "Escape bytes that larger than 127" to
"Escape bytes that are larger than 127 in config files".
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D17651
To: vandenoever, dfaure, arichardson
Cc: kde-frameworks-devel, michaelh,
vandenoever added reviewers: dfaure, arichardson.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D17651
To: vandenoever, dfaure, arichardson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
vandenoever edited the summary of this revision.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D17651
To: vandenoever
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
vandenoever edited the summary of this revision.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D17651
To: vandenoever
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
vandenoever created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vandenoever requested review of this revision.
REVISION SUMMARY
UserBase tells me that KDE configuration files are encoded in UTF-8.
vandenoever accepted this revision.
vandenoever added a comment.
This revision is now accepted and ready to land.
Good fixes. Just some small naming suggestions.
INLINE COMMENTS
> odfextractor.cpp:37
> +
> +QDomElement namedItemNS(const QDomNode , const QString , const
> QString )
> +{
vandenoever added a comment.
The patch looks clean, but I do not fully understand how is supposed to work.
Perhaps an explanation of the different scenarios would help future readers of
this code.
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
vandenoever added a comment.
> "X-KDE-InitialPreference": "5"
is a string
"X-KDE-InitialPreference": 5
is a number
REVISION DETAIL
https://phabricator.kde.org/D7533
To: dfaure, apol, davidedmundson, arichardson
Cc: vandenoever, elvisangelaccio, bshah, #frameworks
vandenoever added a comment.
Removing this call is in line with the advice in the dbus spec.
An improvement to the patch would be to remove `bool startfdo`.
Q_WS_WIN seems to suggest that windows always needs to start the service
manually. That case would break with this patch.
On Wednesday 28 September 2016 18:09:12 David Edmundson wrote:
> A sizable part of your argument is based on problems with NFS . SQlite
> (that tracker uses) will surely have the same problems.
> Surely If file locks don't work, then file locks don't work?
CLucene does not have the same
Hi all,
Icons in breeze are stored as uncompressed SVG. That should make diffs more
readable. In practice, diffs can be quite hard to read due to different ways of
writing out XML by different applications, application versions and settings.
A solution to this is to use XML normalization
://git.reviewboard.kde.org/r/128834/diff/
Testing
---
This detect a number of broken svg files at the moment. A patch is coming to
fix those.
Thanks,
Jos van den Oever
8b2c46469e5f68e7c8ca7cbb6d7ce5d49f69b134
Diff: https://git.reviewboard.kde.org/r/128836/diff/
Testing
---
The svg files were not wellformed because of missing namespace definitions.
Thanks,
Jos van den Oever
to
fix those.
Thanks,
Jos van den Oever
marked as submitted.
Review request for KDE Frameworks, David Faure and Milian Wolff.
Changes
---
Submitted with commit b4fea4e48455fa65c0ea530df30500a15bfd1452 by Jos van den
Oever to branch master.
Repository: kservice
Description
---
Writing KBuildSycoca is done with <&l
viewboard.kde.org/r/127770/#review94946
-----------
On apr 28, 2016, 7:01 a.m., Jos van den Oever wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
> On apr 29, 2016, 10:56 a.m., David Faure wrote:
> > This is not about trust and attacks, this is about not allocating 4 GB of
> > RAM when reading a corrupted binary file.
>
> Jos van den Oever wrote:
> That will only happen if the file or stream is 4 GB. `QData
oca/ksycocaentry.cpp 5fbd158
> src/sycoca/ksycocautils.cpp 84998b7
> src/sycoca/ksycocautils_p.h aad9d50
>
> Diff: https://git.reviewboard.kde.org/r/127786/diff/
>
>
> Testing
> ---
>
> All tests still pass.
>
>
> Thanks,
>
> Jos van den Oever
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
fbd158
src/sycoca/ksycocautils.cpp 84998b7
src/sycoca/ksycocautils_p.h aad9d50
Diff: https://git.reviewboard.kde.org/r/127786/diff/
Testing
---
All tests still pass.
Thanks,
Jos van den Oever
___
Kde-frameworks-devel mailing li
.reviewboard.kde.org/r/127770/diff/1/?file=461435#file461435line27>
> >
> > static ? But see next item.
i chose to keep it simple and stick to literals
- Jos
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127770/#review94914
---
nit tests on KService. All but one of the previously failing tests on
NixOS is now fixed.
Thanks,
Jos van den Oever
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Hi all,
A few days back dvratil reported errors in the KDE PIM unit tests. The tests
were writing
QWARN : TestBlogger1::testNetwork() kf5.kservice.sycoca: ERROR: KSycoca
database corruption!
On my laptop, I was seeing the same error when starting KF5 applications. I've
spent some time in
the first option.
Diffs
-
src/sycoca/ksycocautils.cpp 1ba75e8
Diff: https://git.reviewboard.kde.org/r/127770/diff/
Testing
---
Ran unit tests on KService. All but one of the previously failing tests on
NixOS is now fixed.
Thanks,
Jos van
kbuildsycoca =
QStandardPaths::findExecutable(KBUILDSYCOCA_EXENAME);
+const QString kbuildsycoca = QStringLiteral(KBUILDSYCOCAEXE);
QVERIFY(!kbuildsycoca.isEmpty());
QStringList args;
args << "--testmode";
- Jos van den Oever
On apr 27, 2016, 11:38 a.m., Aleix Po
directory.
Diffs
-
autotests/ksycoca_xdgdirstest.cpp f879959
Diff: https://git.reviewboard.kde.org/r/127754/diff/
Testing
---
I ran the unit tests. Some now pass for me, but on my system still some are
failing.
Thanks,
Jos van den Oever
://git.reviewboard.kde.org/r/127754/diff/
Testing
---
I ran the unit tests. Some now pass for me, but on my system still some are
failing.
Thanks,
Jos van den Oever
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
63 matches
Mail list logo
