D14154: re-add updates by Firas Kraiem

phanect added a comment. Sorry, my response is too late... I just fixed the title. Thanks for merge my commits via R175 REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D14154 To:

D14154: re-add updates by Firas Kraiem

phanect retitled this revision from "Add " to "re-add updates by Firas Kraiem". REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D14154 To: phanect, winterz, mlaurent, #kde_pim, #frameworks Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

D13828: Revert "updated Japanese holidays (in Japanese and English)"

phanect abandoned this revision. phanect added a comment. Sorry, I didn't notice that I have permission to close this. I just closed this. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13828 To: phanect, #kde_pim, #frameworks, winterz, mlaurent Cc:

D14154: Add

phanect retitled this revision from "Update substitute holidays & holidays between public holidays" to "Add ". phanect edited the summary of this revision. phanect added reviewers: winterz, mlaurent, KDE PIM, Frameworks. REPOSITORY R175 PIM: KHolidays REVISION DETAIL

D13828: Revert "updated Japanese holidays (in Japanese and English)"

phanect edited the summary of this revision. phanect added reviewers: KDE PIM, Frameworks, winterz, mlaurent. phanect added subscribers: winterz, mlaurent. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13828 To: phanect, #kde_pim, #frameworks, winterz, mlaurent

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect added a comment. Sorry, I made another code review request by mistake: https://phabricator.kde.org/D13828 Please close this request and continue with D13828 . REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13812

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect edited the summary of this revision. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13812 To: phanect, #kde_pim, #frameworks, winterz, mlaurent Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect added a comment. I found Equinox days culculated by kholidays may be wrong. For example, kholidays says March 22th is Vernal Equinox Day in 2018, but actual Japanese Vernal Equinox Day is March 21th in 2018. I think Equinox Days should be kept. I also want to know how to

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect added a comment. Fixed. Please review. I know equinox days can be automatically calculated, but in this review request I just revert the commit. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13812 To: phanect, #kde_pim, #frameworks, winterz,

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect updated this revision to Diff 36951. phanect added a comment. Revert "updated Japanese holidays (in Japanese and English)" This reverts commit 49f6abb6035f97c0a98113e3aedf5d2db135bf63 . This

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect added a comment. Sorry, something wrong. In this commit only two files should be edited (holiday_jp_en-us and holiday_jp_ja) but tons of files is edited actually. I will fix it. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13812 To: phanect,

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect edited the summary of this revision. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13812 To: phanect, #kde_pim, #frameworks, winterz, mlaurent Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect retitled this revision from "GIT_SILENT: prepare 5.5.1" to "Revert "updated Japanese holidays (in Japanese and English)"". phanect edited the summary of this revision. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13812 To: phanect, #kde_pim,

D13812: GIT_SILENT: prepare 5.5.1

phanect created this revision. phanect added reviewers: KDE PIM, Frameworks, winterz, mlaurent. phanect added a project: KDE PIM. Restricted Application added a subscriber: kde-pim. phanect requested review of this revision. REVISION SUMMARY Revert "updated Japanese holidays (in Japanese and