D27028: Switch from download.k.o to autoconfig

broulik added inline comments. INLINE COMMENTS > cache.cpp:160 > +if > (e.payload().startsWith(QLatin1String("http://download.kde.org/khotnewstuff;)) > + || > e.payload().startsWith(QLatin1String("http://autoconfig.kde.org/khotnewstuff;))) > { > //

D27025: Add signals for udev events with actions bind and unbind

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D27025 To: meven, broulik, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27025: Add signals for udev events with actions bind and unbind

broulik added a comment. I think it's "bound" REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27025 To: meven, broulik, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27025: Ignore udev monitoring notifications with actions bind and unbind

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > udevqtclient.cpp:119 > +} else if (action == "bind") { > +// ignored > +} else if (action == "unbind") { Can you instead add signals for

D27017: [KColorUtils] Add hue(), chroma() and getHcyColor()

broulik added inline comments. INLINE COMMENTS > kcolorutils.h:42 > + */ > +KGUIADDONS_EXPORT qreal hue(const QColor &); > + This doesn't mention hcy anywhere and there's `QColor::hue`. But we already have `luma` in the same way, so I guess this is alright. REPOSITORY R273 KGuiAddons

D26848: Don't assume the manager and menu have the same lifetime

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH menumanager (branched from master) REVISION DETAIL https://phabricator.kde.org/D26848 To: davidre, #frameworks, broulik Cc: anthonyfieroni, broulik,

D26960: RFC: [KWindowShadows] Check for X connection

This revision was automatically updated to reflect the committed changes. Closed by commit R278:21d67e31f718: [KWindowShadows] Check for X connection (authored by broulik). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26960?vs=74486=74489 REVISION

D26960: RFC: [KWindowShadows] Check for X connection

broulik created this revision. broulik added reviewers: Plasma, zzag. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY On teardown of plasmashell the shared pointer with shadows is unref'd quite

D26848: Don't assume the manager and menu have the same lifetime

broulik added inline comments. INLINE COMMENTS > davidre wrote in kcolorschememanager.cpp:191 > What is meant by "connecting to qApp"? Just doing the scheme switching here? > I wanted to avoid the duplication that's why I created the static helper > method. Using `qApp` as context object

D26767: [KMessageWidget] Subtract the correct margin

broulik added inline comments. INLINE COMMENTS > kmessagewidget.cpp:214 >"border-radius: 4px;" >"border: 2px solid %2;" >"margin: %3px;" Maybe instead make the width an `int` variable and use it in

D26801: Really fix the Windows backend for KNotifications

broulik added inline comments. INLINE COMMENTS > notifybysnore.cpp:89 > +KNotification *notification = m_notifications.value(id); > +if (notification == nullptr) { > qCDebug(LOG_KNOTIFICATIONS) << "Notification not found!"; `if (!notification) {` >

D26848: Don't assume the manager and menu have the same lifetime

broulik added a comment. lgtm REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26848 To: davidre, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26832: Add icon for application/sql

This revision was automatically updated to reflect the committed changes. Closed by commit R266:6be022ac5f4a: Add icon for application/sql (authored by broulik). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26832?vs=74093=74129 REVISION DETAIL

D26832: Add icon for application/sql

broulik created this revision. broulik added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This is an alias to `text/x-sql` but we don't resolve those when looking up icons.

D25698: New query mechanism for applications: KApplicationTrader

broulik added inline comments. INLINE COMMENTS > dfaure wrote in kapplicationtrader.cpp:87 > Order is very important here, it's the order of preference. > > But doesn't erase(remove_if()) preserve order? I thought it did. cppreference says it does: > Relative order of the elements that remain

D26047: Expose KConfig settings to allow registration in KCM Notification

broulik added a comment. Other than the seemingly missing `config`, looks good INLINE COMMENTS > settings.cpp:173 > -if (!s_settingsInited) { > -DoNotDisturbSettings::instance(config); > -NotificationSettings::instance(config); I still want to be able to specify what

D26066: [KProcessInfo] Add parent PID

broulik abandoned this revision. broulik added a comment. Am now using ksysguard.. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26066 To: broulik, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25743: Expose IndexerState enum to QML

broulik added inline comments. INLINE COMMENTS > baloomonitorplugin.cpp:31 > qmlRegisterType(uri, 0, 1, "Monitor"); > +qmlRegisterUncreatableMetaObject(Baloo::staticMetaObject, uri, 0, 1, > "Baloo", "Error: only enums"); > } I have to also add a qRegisterMetaType(); in order to

D26703: Add icon for text/vnd.kde.kcrash-report

broulik closed this revision. broulik added a comment. https://cgit.kde.org/breeze-icons.git/commit/?id=22286e6a67a1e46c3022d76bb2a2daf73438d646 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26703 To: broulik, #vdg, ndavis Cc: kde-frameworks-devel,

Re: Updating our coding conventions and coding style for C++11

Well, the * is completely redundant in those cases, so it doesn't bring anything. I'd be tempted to say, let's not require it. But then it raises the question of consistency (without a guideline, we'll have some places with * and some places without *). It provides useful visual

Re: Updating our coding conventions and coding style for C++11

Hi, for "auto" I think we should always annotate it with const, *, and/or & where appropriate: auto *something = new MyCustomType; auto *keyEvent = static_cast(event); const auto myList = QStringList({QLatin1String("FooThing"), QLatin1String("BarThing")}); auto = foo[bar]; The common

D26405: Add mime type for backtraces saved from DrKonqi

This revision was automatically updated to reflect the committed changes. Closed by commit R244:ae1fb551ce19: Add mime type for backtraces saved from DrKonqi (authored by broulik). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26405?vs=72716=73684

D26703: Add icon for text/vnd.kde.kcrash-report

broulik created this revision. broulik added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This is for backtraces saved from DrKonqi TEST PLAN F7858683:

D26405: Add mime type for backtraces saved from DrKonqi

broulik added a comment. > there's also text/x-apport I just noticed that Breeze had an icon for that, I don't actually find it in mime info REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26405 To: broulik, #frameworks, sitter, mpyne Cc: mpyne,

D26650: Use KService to look for Filelight

broulik added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1114 > + > d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(service->icon())); > +connect(d->m_sizeDetailsButton, ::clicked, this, > [this, service]() { > +KRun::runApplication(*service, {

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

broulik added inline comments. INLINE COMMENTS > kcoredirlister.h:595 > */ > -virtual bool doNameFilter(const QString , const QList > ) const; > +virtual bool doNameFilter(const QString , const > QVector ) const; > This class is exported, you cannot change this existing method

D26650: Use KService to look for Filelight

broulik added inline comments. INLINE COMMENTS > shubham wrote in kpropertiesdialog.cpp:1113 > I tried removing it, but I couldn't see the icon on the button then. Does this not work? d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(service->icon()); REPOSITORY R241 KIO REVISION DETAIL

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

broulik added a comment. So you can't tab around to end up focusing the text field? REPOSITORY R236 KWidgetsAddons BRANCH no-more-keyboard-selectability (branched from master) REVISION DETAIL https://phabricator.kde.org/D26649 To: ngraham, dfaure, #frameworks, #vdg, ndavis Cc:

D26650: Use KService to look for Filelight

broulik added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1113 > d->m_sizeDetailsButton = new QPushButton(i18n("Explore in > Filelight"), d->m_frame); > > d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(QStringLiteral("filelight"))); >

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

This revision was automatically updated to reflect the committed changes. Closed by commit R241:1e7a62c98f8a: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26492?vs=72972=73394#toc

D26604: Check if there is an activatable service when notification service owner changes

broulik added a comment. What again was the reason for not just sending a notification where DBus activation will do its thing? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26604 To: nicolasfella, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n,

D26484: Add a new parameter for delaying showing menu

broulik added a comment. I don't fully understand why `popupMenuAboutToShow` isn't sufficient. An alternative approach I could think would be allowing the signal handler to delay the menu as necessary rather than having to create the drop job differently? INLINE COMMENTS > dropjob.h:131

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

broulik edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26492 To: broulik, #frameworks, ngraham Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26502: [ConfigModule] Say which package is invalid

This revision was automatically updated to reflect the committed changes. Closed by commit R296:00405aacf3f6: [ConfigModule] Say which package is invalid (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26502?vs=73009=73019 REVISION

D26502: [ConfigModule] Say which package is invalid

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Makes it easier to spot mismatches between install path and about data. TEST

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

broulik updated this revision to Diff 72972. broulik added a comment. - Turns out no close on exit doesnt imply the other, old code was correcter L:) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26492?vs=72971=72972 REVISION DETAIL

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

broulik updated this revision to Diff 72971. broulik added a comment. - Simplify REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26492?vs=72970=72971 REVISION DETAIL https://phabricator.kde.org/D26492 AFFECTED FILES src/widgets/kopenwithdialog.cpp To:

D26492: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 415951 TEST PLAN - Normal case still has box - Ran with

D26490: [KMessageWidget] Use devicePixelRatioF for animation pixmap

This revision was automatically updated to reflect the committed changes. Closed by commit R236:fcc7978c7cf1: [KMessageWidget] Use devicePixelRatioF for animation pixmap (authored by broulik). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D26490: [KMessageWidget] Use devicePixelRatioF for animation pixmap

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Ensures contents stay crisp during the animation by setting the correct

D24932: Add button to open the folder in filelight to view more details

broulik requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24932 To: shubham, ngraham, #frameworks, broulik Cc: broulik, ltoscano, pino, kde-frameworks-devel, #frameworks, LeGast00n, GB_2,

D24932: Add button to open the folder in filelight to view more details

broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. Can you please look for filelight using `KService::serviceByDesktopName("org.kde.filelight")`, then you don't have hardcode the executable path, name, icon, etc. REPOSITORY R241 KIO

D26416: Kicker/Documents optimization: Lazily build KFileItem

broulik added a comment. Would be lovely in the future to cache those items and make it a proper model with backing data rather than requesting everything on demand every time `data` is called. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26416 To:

D26440: Add KSharedConfig::openStateConfig for storing state information

broulik added a comment. Nice one. Once that `XDG_STATE_HOME` discussion comes to a conclusion [1] we could then easily swap the location over, I suppose. [1] https://lists.freedesktop.org/archives/xdg/2016-December/013803.html REPOSITORY R237 KConfig REVISION DETAIL

D26448: Add KRecentFilesMenu to replace KRecentFileAction

broulik added inline comments. INLINE COMMENTS > krecentfilesmenu.cpp:150 > +// Don't restore if file doesn't exist anymore > +if (url.isLocalFile() && !QFile::exists(url.toLocalFile())) { > +continue; If we're rewriting this thing anyway, can we please make sure it

D26404: Turn application/x-ms-shortcut into an actual shortcut icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:d5d0e2668d4b: Turn application/x-ms-shortcut into an actual shortcut icon (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26404?vs=72817=72834#toc REPOSITORY R266

D26404: Turn application/x-ms-shortcut into an actual shortcut icon

broulik updated this revision to Diff 72817. broulik added a comment. - Rebase REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26404?vs=72712=72817 REVISION DETAIL https://phabricator.kde.org/D26404 AFFECTED FILES

D26331: Removed reading description from desktop files

broulik added a comment. > unfortunately it doesn't show in the treeview even after enabling the "Comments" column (bug?) Works here. F7860716: Screenshot_20200104_204817.png I think it doesn't update the view live when the comment changes

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

broulik added inline comments. INLINE COMMENTS > meven wrote in kfileitem.cpp:783 > Good point I have edited the commit message > when a network mount is unresponsive If I do a `QFileInfo` on an unresponsive mount it will still block. You already freeze before you even know it's a network

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

broulik added inline comments. INLINE COMMENTS > meven wrote in kfileitem.cpp:783 > At least the mnttab reading business in KMountPoint::currentMountPoints is > saved. Yes, but the "never blocks" claim in the commit message is misleading. REPOSITORY R241 KIO REVISION DETAIL

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

broulik added inline comments. INLINE COMMENTS > kfileitem.cpp:783 > +const auto = getMountPoints(); > +auto mp = mountPoints.findByPath(path); > +if (mp) { This creates a `QFileInfo` for `canonicalFilePath` which blocks, so the cache doesn't help at all.

D26405: Add mime type for backtraces saved from DrKonqi

broulik edited the test plan for this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26405 To: broulik, #frameworks, sitter Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26405: Add mime type for backtraces saved from DrKonqi

broulik created this revision. broulik added reviewers: Frameworks, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN There's also text/x-apport - My saved crash reports now have a nice icon

D24466: Use ECMGenerateExportHeader to manage deprecated API better

broulik added inline comments. INLINE COMMENTS > ktoolbar.cpp:908 > { > -#ifndef KXMLGUI_NO_DEPRECATED > +#if KXMLGUI_BUILD_DEPRECATED_SINCE(5, 0) > if (mainWindow() && d->enableContext) { I just realized this is false-y deprecated. The feature adds the configuration options for toolbar

D26404: Turn application/x-ms-shortcut into an actual shortcut icon

broulik created this revision. broulik added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Rather than a banknote or money symbol. Git log suggests this was added for GNU cash,

D25991: [KFilePlacesModel] Fix supported scheme check for devices

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R241:3a6e3f927111: [KFilePlacesModel] Fix supported scheme check for devices (authored by broulik). Herald added a

D26397: Change XHTML icon to be a purple HTML icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:fdaded68913f: Change XHTML icon to be a purple HTML icon (authored by broulik). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26397?vs=72693=72707 REVISION

D25991: [KFilePlacesModel] Fix supported scheme check for devices

broulik added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25991 To: broulik, #frameworks, dfaure, ngraham, bruns Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26397: Change XHTML icon to be a purple HTML icon

broulik created this revision. broulik added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Currently, XHTML is just using the XML icon, but XHTML is more of a "website" than an

D26331: Removed reading description from desktop files

broulik added a comment. In D26331#586783 , @count wrote: > I thought, the !d->isSlow() would skip that part for (fsType == KFileSystemType::Nfs || fsType == KFileSystemType::Smb) as seen in kfileitem.cpp:763. So I would leave that here.

D26331: Removed reading description from desktop files

broulik added a comment. What about the directory Comment "feature" a few lines below? It is equally as questionable and causes significant slowdowns when browsing folders on nfs mounts, cf. D13757 REPOSITORY R241 KIO REVISION DETAIL

D26326: Add application/x-audacity-project icon

broulik added a comment. The icon is the midi icon which uses those colors. Feel Fred to commandeer this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26326 To: broulik, #vdg, ndavis, ngraham Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n,

D24431: Restore cursor thumbnailer

This revision was automatically updated to reflect the committed changes. Closed by commit R320:55d370392efa: Restore cursor thumbnailer (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24431?vs=72476=72548 REVISION DETAIL

D26326: Add application/x-audacity-project icon

broulik updated this revision to Diff 72526. broulik added a comment. - Optimize - Copy to breeze dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26326?vs=72473=72526 REVISION DETAIL https://phabricator.kde.org/D26326 AFFECTED FILES

D24431: Restore cursor thumbnailer

broulik requested review of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D24431 To: broulik, #plasma, fredrik, ngraham Cc: adridg, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2,

D24431: Restore cursor thumbnailer

broulik updated this revision to Diff 72476. broulik edited the summary of this revision. broulik added a comment. This revision is now accepted and ready to land. - Find XCursor specifically REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D26313: Add application/vnd.apple.pkpass icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:eca72cb0689b: Add application/vnd.apple.pkpass icon (authored by broulik). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26313?vs=72464=72477 REVISION

D26326: Add application/x-audacity-project icon

broulik edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26326 To: broulik, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26326: Add application/x-audacity-project icon

broulik created this revision. broulik added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 415722 TEST PLAN - Takes the audacity app icon, simplifies it slightly and

D26326: Add application/x-audacity-project icon

broulik edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26326 To: broulik, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26313: Add application/vnd.apple.pkpass icon

broulik updated this revision to Diff 72464. broulik added a comment. - Fix misaligned object - Optimize SVGs (also remove unused stylesheet from monochrome icons) - Copy to breeze-dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D26313: Add application/vnd.apple.pkpass icon

broulik created this revision. broulik added reviewers: VDG, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 397987 TEST PLAN My boarding passes have nice icons now :) Since

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

broulik added a comment. F7831018: Screenshot_20191222_162523.png Works fine here. Are both branches up to date and are you clicking an empty area? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26067 To: broulik, #frameworks,

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

broulik added a comment. I added icon size context menu in dolphin REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26067 To: broulik, #frameworks, #vdg, #dolphin Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26112: Clean up unnecessary code

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Don't make this `GIT_SILENT`, please REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D26112 To: meven, #frameworks, bruns, broulik Cc: broulik,

D26113: Places: For mounted volume display mount points instead of description

broulik added a comment. Not a fan of this special handling in Places. Also I think it should stay with the remote path as the fact that it's mounted locally somewhere is only an implementation detail. > Short name (mount point) should be used or this should at least be configurable.

D26116: Reduce timeout when trying to connect to an app dbus interface

broulik added a comment. I'd say 5 seconds is optimistic. Does Kate's session selection dialog still block startup? REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D26116 To: meven, #frameworks, davidedmundson Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2,

D26017: [KKeySequenceWidget] Work around Meta modifier behavior

broulik added a reviewer: ahartmetz. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D26017 To: broulik, #frameworks, davidedmundson, ahartmetz Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26117: [solid] Clarify referencing of DeviceInterface

broulik added a reviewer: bruns. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26117 To: anthonyfieroni, broulik, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26098: Display first / in mounted storage access description

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D26098 To: meven, #frameworks, bruns, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26013: [KeySequenceHelper] Grab actual window when embedded

This revision was automatically updated to reflect the committed changes. Closed by commit R296:555a09198aef: [KeySequenceHelper] Grab actual window when embedded (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26013?vs=71586=71772

D25788: Initialise QML monitor values

broulik added inline comments. INLINE COMMENTS > monitor.h:82 > > org::kde::baloo::scheduler* m_scheduler; > org::kde::baloo::fileindexer* m_fileindexer; Might was well move the `nullptr` here, too REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25788 To:

D25716: [KPropertiesDialog] Show extra fields

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6dcd50dd1ef2: [KPropertiesDialog] Show extra fields (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25716?vs=70831=71765 REVISION DETAIL

D25999: Add optional subtitle to grid delegate

broulik added inline comments. INLINE COMMENTS > GridDelegate.qml:81 > height: Kirigami.Settings.isMobile ? Math.round((delegate.width - > Kirigami.Units.gridUnit) / 1.6) > - : > Math.min(delegate.GridView.view.implicitCellHeight -

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

broulik created this revision. broulik added reviewers: Frameworks, VDG, Dolphin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This includes: - Rendering hidden items desaturated when in

D26066: [KProcessInfo] Add parent PID

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY We basically get this information for free anyway. TEST PLAN -

D26043: Add edit mode menu item to desktop widget context menu

broulik added inline comments. INLINE COMMENTS > containmentinterface.cpp:1128 > +desktopMenu->addSeparator(); > +if (m_containment->containmentType() == > Plasma::Types::DesktopContainment) { > + >

D26047: Expose KConfig settings to allow registration in KCM Notification

broulik added inline comments. INLINE COMMENTS > settings.h:343 > > +QList configSkeletons() const; > + Not a fan of this becoming public API REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26047 To: crossi, #plasma, #frameworks, ervin, bport,

D25716: [KPropertiesDialog] Show extra fields

broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25716 To: broulik, #frameworks, #vdg, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25984: Load translations

broulik added a comment. I guess it builds the QML tree and evaluates the `qsTr` calls and then finds it needs an item from a plugin and loads the import and only then translates it. Subsequent controls are translated, only the ones on the initial item are not. Perhaps if we shoehorn a

D25984: Load translations

broulik added a comment. Ok, so turns out, it does call it when the plugin is loaded, but the translations are only installed *after* the QML has loaded and processed. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks,

D25984: Load translations

broulik added a comment. Well, whatever it is, it doesn't work. My search field isn't translated and I put breakpoints and I only get it load translations for kcoreaddons and kjobwidgets. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik,

D25984: Load translations

broulik added a comment. We don't link against Kirigami, so the startup routine stuff doesn't apply? And we're way after the QCoreApp constructor at this point. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau,

D25984: Load translations

broulik added a comment. Qt docs say "Adds a global function that will be called from the QCoreApplication constructor. " but when we at runtime somewhere load a QML plugin we're too late with that. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To:

D26000: [Plasma Dialog] Use QXcbWindowFunctions for setting window types Qt WindowFlags don't knows

This revision was automatically updated to reflect the committed changes. Closed by commit R242:192a50fe8c3c: [Plasma Dialog] Use QXcbWindowFunctions for setting window types Qt WindowFlags… (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26000?vs=71538=71606#toc

D26017: [KKeySequenceWidget] Work around Meta modifier behavior

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When I press my Meta key, I get a `Key_Super_L` *without* a Meta key confusing

D26016: [KeySequenceHelper] Work around Meta modifier behavior

broulik updated this revision to Diff 71596. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Turns out it's not QtQuick REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D26016: [KeySequenceHelper] Work around Meta modifier behavior

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY For some reason in QtQuick when I press my Meta key, I get a `Key_Super_L` *without*

D26013: [KeySequenceHelper] Grab actual window when embedded

broulik created this revision. broulik added reviewers: Plasma, davidre. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When used in a KCM which uses `QQuickWidget` it needs to enable grab on the

D25991: [KFilePlacesModel] Fix supported scheme check for devices

broulik added inline comments. INLINE COMMENTS > bruns wrote in kfileplacesmodel.cpp:758 > you have dropped the `allowedHere` check. Probably just `if (!allowedHere) > continue`. > > And for reasons unknown to me, `tags:` is not filtered per app - move the > allowedHere check to the very

<    1   2   3   4   5   6   7   8   9   10   >