Re: Review Request 129248: Distinguish between NULL and empty domain in NTLM authentication

2016-10-23 Thread Krzysztof Nowicki
038f70fbbc4daacd60fb src/kntlm/kntlm.cpp 269204e3c1d0a4615afefe385047ba54231ecaa6 Diff: https://git.reviewboard.kde.org/r/129248/diff/ Testing --- Executed autotests including updated test cases. Thanks, Krzysztof Nowicki

Re: Review Request 129248: Distinguish between NULL and empty domain in NTLM authentication

2016-10-23 Thread Krzysztof Nowicki
. - Krzysztof --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129248/#review100220 --- On Oct. 23, 2016, 9:52 p.m., Krzyszto

Review Request 129248: Distinguish between NULL and empty domain in NTLM authentication

2016-10-23 Thread Krzysztof Nowicki
1ecaa6 Diff: https://git.reviewboard.kde.org/r/129248/diff/ Testing --- Executed autotests including updated test cases. Thanks, Krzysztof Nowicki

Re: Review Request 126991: Try multiple authentication methods in case of failures

2016-03-04 Thread Krzysztof Nowicki
marked as submitted. Review request for KDE Frameworks and Dawit Alemayehu. Changes --- Submitted with commit f665dd30fcf71493b93fb979a47986aca1faf95f by Krzysztof Nowicki to branch master. Repository: kio Description --- When authenticating agains a server offering multiple

Re: Review Request 126991: Try multiple authentication methods in case of failures

2016-03-03 Thread Krzysztof Nowicki
it endlessly. With this patch authentication correctly falls back to NTLM or Basic (if NTLM fails too). Thanks, Krzysztof Nowicki ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126991: Try multiple authentication methods in case of failures

2016-03-03 Thread Krzysztof Nowicki
ally generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/#review93120 --- On March 3, 2016, 12:40 p.m., Krzysztof Nowicki wrote: > > --- > This is an automat

Re: Review Request 126991: Try multiple authentication methods in case of failures

2016-03-03 Thread Krzysztof Nowicki
correctly falls back to NTLM or Basic (if NTLM fails too). Thanks, Krzysztof Nowicki ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126991: Try multiple authentication methods in case of failures

2016-02-29 Thread Krzysztof Nowicki
falls back to NTLM or Basic (if NTLM fails too). Thanks, Krzysztof Nowicki ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126991: Try multiple authentication methods in case of failures

2016-02-21 Thread Krzysztof Nowicki
- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/#review92617 --- On Feb. 9, 2016, 10:53 p.m., Krzysztof Nowicki wrote: > > ---

Re: Review Request 126991: Try multiple authentication methods in case of failures

2016-02-09 Thread Krzysztof Nowicki
back to NTLM or Basic (if NTLM fails too). Thanks, Krzysztof Nowicki ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126982: Fix NTLMv2 stage 3 response creation

2016-02-06 Thread Krzysztof Nowicki
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 5961ac8e4713e8cb3d97108286f700b2a69e5ffc by Krzysztof Nowicki to branch master. Repository: kio Description --- The Blob structure occupies 28 bytes. Unfortunately on 64-bit architectures

Re: Review Request 126990: Try NTLMv2 authentication if the server denies NTLMv1

2016-02-05 Thread Krzysztof Nowicki
ed6f3881f3dfd0b78069368db22f7cd865261738 Diff: https://git.reviewboard.kde.org/r/126990/diff/ Testing --- Tested on an IIS 7.5 server with NTLMv1 blacklisted. Additionally executed automatic tests without regressions. Thanks, Krzysztof Nowicki

Re: Review Request 126991: Try multiple authentication methods in case of failures

2016-02-05 Thread Krzysztof Nowicki
On Feb. 4, 2016, 5:01 p.m., Krzysztof Nowicki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126991/ >

Re: Review Request 126991: Try multiple authentication methods in case of failures

2016-02-05 Thread Krzysztof Nowicki
it endlessly. With this patch authentication correctly falls back to NTLM or Basic (if NTLM fails too). Thanks, Krzysztof Nowicki ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126990: Try NTLMv2 authentication if the server denies NTLMv1

2016-02-05 Thread Krzysztof Nowicki
// current code > > #endif The strings handled here are short (usernames, passwords or domain names). I don't think it's worth the extra complexity. - Krzysztof --- This is an automatically generated e-mail. To reply, v

Re: Review Request 126990: Try NTLMv2 authentication if the server denies NTLMv1

2016-02-05 Thread Krzysztof Nowicki
r/126990/#review92081 --- On Feb. 5, 2016, 12:17 p.m., Krzysztof Nowicki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126990/ > -

Review Request 126991: Try multiple authentication methods in case of failures

2016-02-04 Thread Krzysztof Nowicki
the original code would only try Negotiate and because it failed it would retry it endlessly. With this patch authentication correctly falls back to NTLM or Basic (if NTLM fails too). Thanks, Krzysztof Nowicki ___ Kde-frameworks-devel mailing list Kde

Review Request 126990: Try NTLMv2 authentication if the server denies NTLMv1

2016-02-04 Thread Krzysztof Nowicki
/ioslaves/http/httpauthentication.cpp dcc86c2 Diff: https://git.reviewboard.kde.org/r/126990/diff/ Testing --- Tested on an IIS 7.5 server with NTLMv1 blacklisted. Additionally executed automatic tests without regressions. Thanks, Krzysztof Nowicki

Review Request 126982: Fix NTLMv2 stage 3 response creation

2016-02-03 Thread Krzysztof Nowicki
accept NTLMv2 authentication. In addition to that I have executed the automatic test suite and found no regressions. I intended to write a test case for NTLMv2, but a bug in KHttpNtlmAuthentication class blocked me from doing this (bug will be addressed shortly). Thanks, Krzysztof Nowicki