D26955: Fix background SVG colors and adjust background SVG corners

niccolove added a comment. Might the problems of not-rounded corners here be caused from the "adjust background SVG corners" part by any chance? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26955 To: ndavis, #vdg, #plasma Cc: niccolove,

D26968: Removed hardcoded values

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Alternative and more basic patch to D26955 , this aims to fix the background

D25015: Update breeze theme shadows

niccolove added a comment. I found a way to make masks that follow the current shape by copying it and making them slightly bigger than original ones. Regarding panels and tooltips: using different roundings (1px vs 3px) seemed inconsistent to me, so I tried to ask in the VDG chat if they

D25015: Update breeze theme shadows

niccolove updated this revision to Diff 74153. niccolove added a comment. Corrected masks to be more similiar to original shapes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25015?vs=73844=74153 BRANCH bettershadows (branched from

D25015: Update breeze theme shadows

niccolove added a comment. I posted the previous comment in a eccessive state of tiredness and nervousness :-) I will look into doing a better mask *before* asking to land the patch, so I can be sure it's the right patch forward. REPOSITORY R242 Plasma Framework (Library) BRANCH

D25015: Update breeze theme shadows

niccolove added a comment. Regarding the mask: I'd keep it as is right now and look more into it in the (very near) future. Currently the difference is not noticeable even on different scalings and I cannot find another working solution, so I think it should not be a blocking issue. But

D25015: Update breeze theme shadows

niccolove added a comment. In D25015#596684 , @ndavis wrote: > The masks have a rather odd shape and it's not pixel aligned, which might mean something is wrong: > F7891523: Screenshot_20200118_225818.PNG

D25015: Update breeze theme shadows

niccolove updated this revision to Diff 73844. niccolove added a comment. Fix possible bug REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25015?vs=73843=73844 BRANCH bettershadows (branched from master) REVISION DETAIL

D25015: Update breeze theme shadows

niccolove updated this revision to Diff 73843. niccolove added a comment. Resized mask to better fit rounding shape REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25015?vs=73842=73843 BRANCH bettershadows (branched from master)

D25015: Update breeze theme shadows

niccolove updated this revision to Diff 73842. niccolove added a comment. Removed unrelated tabbar change REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25015?vs=73841=73842 BRANCH bettershadows (branched from master) REVISION DETAIL

D25015: Update breeze theme shadows

niccolove added a comment. Can you please doublecheck that you see everything correctly? The mask thing was weird, but I think I fixed it REPOSITORY R242 Plasma Framework (Library) BRANCH bettershadows (branched from master) REVISION DETAIL https://phabricator.kde.org/D25015 To:

D25015: Update breeze theme shadows

niccolove updated this revision to Diff 73841. niccolove added a comment. - Merge branch 'master' into bettershadows - Changed masks REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25015?vs=69886=73841 BRANCH bettershadows (branched

D25015: Update breeze theme shadows

niccolove added a comment. Got it. Blur is not rounded either to me. The shadow was hiding it. F7819795: Screenshot_20191215_170023.png In D25015#575297 , @mart wrote: > In D25015#568865

D25015: Update breeze theme shadows

niccolove added a comment. I just compared the blur and contrast effects and the mask is used in the exact same way :-/ I have no idea what could be wrong there. REPOSITORY R242 Plasma Framework (Library) BRANCH bettershadows (branched from master) REVISION DETAIL

D25334: Added transparent blue background to tabbars

niccolove added a comment. Breeze dark highlight is currently #3daee9 in the Breeze Dark colorscheme. If that's too light, we could darken it there, right? Currently it's: F7819764: Screenshot_20191215_163924.png Darker could be (example value):

D25340: Added background colors to active and inactive icon view

niccolove added a comment. In D25340#573672 , @ndavis wrote: > @niccolove Do you mind if I commandeer this? I know dealing with these kinds of issues can be super annoying and I'm already used to it. Feel free to do that :-) REPOSITORY

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 71050. niccolove added a comment. Reset tabbar to master REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=71048=71050 BRANCH backrgound-color-iconviewer (branched from master) REVISION

D25340: Added background colors to active and inactive icon view

niccolove added a comment. In D25340#573594 , @ndavis wrote: > Wait, is a change to tabbar.svg supposed to be in this diff? Nope, I must have messed up the different arc features. Sorry. REPOSITORY R242 Plasma Framework (Library)

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#566992 , @ngraham wrote: > In D25334#566745 , @ndavis wrote: > > > Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't look right. It just

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 71048. niccolove added a comment. Changed inactive to 5% REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=70207=71048 BRANCH backrgound-color-iconviewer (branched from master) REVISION

D25015: Update breeze theme shadows

niccolove added a comment. Got it. The shape is actually rounded BUT the desktop contract effect is applied in the whole rectangle underneath, and it makes everything look like a rectangle. Here's the widget with fully transparent background, but with the contract effect on: F7788618:

D25015: Update breeze theme shadows

niccolove added a comment. In D25015#568331 , @ngraham wrote: > Actually it looks like that was due to some kind of caching issue. It's gone now. LGTM! > > Everyone else good with this? Actually, it seems to me that borders are not

D25340: Added background colors to active and inactive icon view

niccolove added a comment. > Might be too subtle, maybe more opacity would be needed This should have a 13% vs 23% opacity, what do you think? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham Cc: manueljlin,

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 70207. niccolove added a comment. Changed opacity of inactive vs non-visible application background color REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=69882=70207 BRANCH

D25334: Added transparent blue background to tabbars

niccolove added a comment. F7780227: Screenshot_20191123_130602.png I'm sorry, isn't this right? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham, ndavis Cc: ngraham,

D25015: Update breeze theme shadows

niccolove added a comment. F7780181: image.png I just can't get the padding right on angles when changing their size. What size should I change of the colored rectangles? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25340: Added background colors to active and inactive icon view

niccolove added a comment. Now that we got back the 3px line, I would say that it is recognizable. I like the idea of having the background and reinforcing the idea that line=visible. But it's such a minor change that I would be okay with any option really. F7768659:

D25015: Update breeze theme shadows

niccolove added a comment. Finally! I'm 100% this works now. In D25015#563300 , @niccolove wrote: > This is a comparison: F7766697: Screenshot_20191116_165659.png > The problem is not that you

D25015: Update breeze theme shadows

niccolove updated this revision to Diff 69886. niccolove added a comment. Updated breeze shadows REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25015?vs=69820=69886 BRANCH bettershadows (branched from master) REVISION DETAIL

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 69882. niccolove added a comment. Tweaked colors of icon view backgrounds REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=69880=69882 BRANCH backrgound-color-iconviewer (branched from

D25340: Added background colors to active and inactive icon view

niccolove added a comment. In D25340#563593 , @ndavis wrote: > Here's a cleaned up version of the file with the changes Nate and I requested: F7767647: tasks.svg Oh sorry, I missed this. I'll use

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 69880. niccolove added a comment. Changed 2px lines to 3px REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=69851=69880 BRANCH backrgound-color-iconviewer (branched from master) REVISION

D25334: Added transparent blue background to tabbars

niccolove updated this revision to Diff 69879. niccolove added a comment. Resized 2px tabbar line to 3px REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25334?vs=69841=69879 BRANCH tabbar_blue_background (branched from master)

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 69851. niccolove added a comment. Added background colors to active and inactive icon view REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=69849=69851 BRANCH backrgound-color-iconviewer

D25340: Added background colors to active and inactive icon view

niccolove added a comment. In D25340#563400 , @ndavis wrote: > This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which isn't in git master. Do I actually need that commit for this patch to work? No. My bad. Let me

D25340: Added background colors to active and inactive icon view

niccolove added a subscriber: ndavis. niccolove added a comment. > @ndavis said: > Here's what I think: > > - The line should indicate that the app is opened, the window is not minimized and the window is focused (opaque blue) or inactive (opaque gray) > - The background should

D25340: Added background colors to active and inactive icon view

niccolove edited the test plan for this revision. niccolove added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Added: - Light blue color for active window - Light gray color for inactive but not minimized window

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#563334 , @ngraham wrote: > If you wanna do that, let's split it out into a different patch though. Sure. Should this patch land first, or should I try to make two at the same time? REPOSITORY R242

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#563301 , @ngraham wrote: > If anything, I think the tab bar line should increase to be 3px to match the open app task manager highlight. If we do the reverse, the highlight for open app swill be too subtle

D25015: Update breeze theme shadows

niccolove added a comment. This is a comparison: F7766697: Screenshot_20191116_165659.png The problem is not that you don't see, it's that it doesn't show. I'll try to understand what's going on and get back to you. REPOSITORY R242 Plasma Framework

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#563285 , @ngraham wrote: > Perfect, all issues fixed, and thanks for pointing me in the direction of the cache files. Deleting those fixed a bunch of other issues I was having with applying plasma theme SVG

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#563265 , @ngraham wrote: > Did you change the SVGs for vertical tab bars as well? Uh, yes I did. Try deleting the plasma theme + svg cache in .cache > I also noticed one visual papercut in the

D25334: Added transparent blue background to tabbars

niccolove updated this revision to Diff 69841. niccolove added a comment. Fixed broken north bottom-left tabbar line REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25334?vs=69840=69841 BRANCH master REVISION DETAIL

D25334: Added transparent blue background to tabbars

niccolove added a comment. In D25334#563254 , @KonqiDragon wrote: > Something like this looks better and clearer. > F6924045: grafik.png That's because no element was selected. If you select an

D25334: Added transparent blue background to tabbars

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg Cc: #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

niccolove updated this revision to Diff 69840. niccolove edited the summary of this revision. niccolove added a comment. Resized blue line of tabbars REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25334?vs=69833=69840 BRANCH master

D25334: Added transparent blue background to tabbars

niccolove edited the summary of this revision. niccolove edited the test plan for this revision. niccolove added a reviewer: VDG. niccolove added a subscriber: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg Cc: #vdg,

D25334: Added transparent blue background to tabbars

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Used the T11124 highlight effect for breeze tabbars by editing the file

D25015: Update breeze theme shadows

niccolove added a comment. In D25015#563147 , @ngraham wrote: > Do these shadows get cached or something? When I build the diff and restart plasmashell, the shadows I see are identical, pixel-for-pixel. I don't know. But you can manually

D25015: Update breeze theme shadows

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

niccolove updated this revision to Diff 69820. niccolove added a comment. Updated to new shadows REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25015?vs=68912=69820 BRANCH breeze-shadows (branched from master) REVISION DETAIL

D25015: Update breeze theme shadows

niccolove added a comment. This is what you think ends too early (for comparison): F7762929: Screenshot_20191114_100519.png What do you think of: F7765076: Screenshot_20191115_145942.png REPOSITORY R242

D25015: Update breeze theme shadows

niccolove added a comment. In D25015#560514 , @ndavis wrote: > > Remember that there are third party desktop themes with SVG that we probably want to support. Wouldn't using KWin for shadows break those? > > If we remove the code for using

D25015: Update breeze theme shadows

niccolove added a comment. In D25015#559344 , @filipf wrote: > I'd prefer the shadows to have equal strength all around, I couldn't get used to weaker shadows in the corners. Oh! That's a pity, I really liked them. I will update it as

D25015: Update breeze theme shadows

niccolove added a comment. Any update on this? I can also upload the shadow for the panel. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg Cc: manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25015: Update breeze theme shadows

niccolove added a comment. In D25015#48 , @ngraham wrote: > If anything I wonder if we should make them bigger too, to better match the default Breeze shadows. I'd prefer to avoid them making more sparse because a) they look worse to

D25014: I have received negative feedback (and I agree with it) on the current state of breeze shadows: they are quite dark, narrow, and feel unnatural. I tried to adress that by making shadows more s

niccolove abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25014 To: niccolove Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

niccolove retitled this revision from "I have received negative feedback (and I agree with it) on the current state of breeze shadows: they are quite dark, narrow, and feel unnatural. I tried to adress that by making shadows more sparse and a bit lighter especially on the angles while..." to

D24593: Modified breeze shadows

niccolove abandoned this revision. niccolove added a comment. Let's try again https://phabricator.kde.org/D25015 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: Luwx, filipf, ngraham, davidedmundson,

D25015: I have received negative feedback (and I agree with it) on the current state of breeze shadows: they are quite dark, narrow, and feel unnatural. I tried to adress that by making shadows more s

niccolove added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: I have received negative feedback (and I agree with it) on the current state of breeze shadows: they are quite dark, narrow, and feel unnatural. I tried to adress that by making shadows more s

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY ...trying to keep it distinguishable when on white background. I received some positive feedback on these shadows

D25014: I have received negative feedback (and I agree with it) on the current state of breeze shadows: they are quite dark, narrow, and feel unnatural. I tried to adress that by making shadows more s

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY ...trying to keep it distinguishable when on white background. I received some positive feedback on these shadows

D24593: Modified breeze shadows

niccolove added a comment. In D24593#552915 , @ngraham wrote: > Needs a rebase on master. It doesn't apply for me. Does it apply now? If not, I messed up something and I will just reset to master and add the svgs again. REPOSITORY

D24593: Modified breeze shadows

niccolove updated this revision to Diff 68788. niccolove added a comment. Rebase on master - test REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24593?vs=68626=68788 BRANCH breeze-shadows (branched from master) REVISION DETAIL

D24593: Modified breeze shadows

niccolove added a comment. In D24593#551591 , @ngraham wrote: > Is this ready for formal review now or are you still tweaking and/or soliciting comments? Ready for review :-) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D24593: Modified breeze shadows

niccolove updated this revision to Diff 68626. niccolove added a comment. Made missing shadow on corners less noticeable on widgets shadows REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24593?vs=67853=68626 BRANCH breeze-shadows

D24593: Modified breeze shadows

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24593: Modified breeze shadows

niccolove added a comment. In D24593#546586 , @filipf wrote: > > b) radial gradients instead of linear on the four sides to make the center darker than the angles. > > Other than this, they look great to me. I think they should be uniformly

D24593: Modified breeze shadows

niccolove added a comment. In D24593#546309 , @ngraham wrote: > In D24593#546042 , @niccolove wrote: > > > I'm sorry, when I use scour on svg files, it looks like git does not recognize that the

D24593: Modified breeze shadows

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24593: Modified breeze shadows

niccolove updated this revision to Diff 67853. niccolove added a comment. Re-done the widgets/panel-background.svg REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24593?vs=67852=67853 BRANCH breeze-shadows (branched from master)

D24593: Modified breeze shadows

niccolove updated this revision to Diff 67852. niccolove added a comment. Re-done the dialogs/background.svg REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24593?vs=67790=67852 BRANCH breeze-shadows (branched from master) REVISION

D24593: Modified breeze shadows

niccolove added a comment. I'm sorry, when I use scour on svg files, it looks like git does not recognize that the file has changed. How can I fix that? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: davidedmundson,

D24593: Modified breeze shadows

niccolove updated this revision to Diff 67790. niccolove added a comment. Used scour on svg files REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24593?vs=67789=67790 BRANCH breeze-shadows (branched from master) REVISION DETAIL

D24593: Modified breeze shadows

niccolove edited the summary of this revision. niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24593: Modified breeze shadows

niccolove added a comment. Uhm, I probably got Scour wrong. Sorry. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

niccolove added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH breeze-shadows (branched from master) REVISION DETAIL

<    1   2   3