D29342: Implement support for notification urgency on Android

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29342 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29335: Implement notification grouping on Android

nicolasfella added inline comments. INLINE COMMENTS > vkrause wrote in NotifyByAndroid.java:171 > That seems counter-productive to me, as the Android API documentation always > speaks about API level numbers, so you'd need to do an additional translation > to/from the letters in your head. So

D29335: Implement notification grouping on Android

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Haven't tested it, but the code looks sensible INLINE COMMENTS > NotifyByAndroid.java:171 > +Notification.Builder builder; > +if (Build.VERSION.SDK_INT >= 26) {

D29021: Remove checks for notification service and fallback to KPassivePopup

nicolasfella added a dependent revision: D29336: Remove galago from method/variable naming. REPOSITORY R289 KNotifications BRANCH nofallback2 REVISION DETAIL https://phabricator.kde.org/D29021 To: nicolasfella, #frameworks, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, cblack,

D29336: Remove galago from method/variable naming

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY With D29021 the

D29323: Handle multi-line and rich-text notifications on Android

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29323 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26604: Check if there is an activatable service when notification service owner changes

nicolasfella abandoned this revision. nicolasfella added a comment. I favor of D29021 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26604 To: nicolasfella, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, cblack,

D26605: Remove fallback to KPassivePopup

nicolasfella abandoned this revision. nicolasfella added a comment. In favor of D29021 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26605 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n,

D29269: Consistently use knotify-config.h to pass in flags about Canberra/Phonon

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R305 KNotifyConfig BRANCH useconsistentlyconfigfile REVISION DETAIL https://phabricator.kde.org/D29269 To: kossebau, #frameworks, broulik, nicolasfella Cc: kde-frameworks-devel, LeGast00n,

D29079: android: include the architecture on the apk name

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D29079 To: apol, #android, #frameworks, nicolasfella Cc: vkrause, kde-frameworks-devel, kde-buildsystem,

D29021: Remove checks for notification service and fallback to KPassivePopup

nicolasfella edited the summary of this revision. nicolasfella edited the test plan for this revision. nicolasfella added reviewers: Frameworks, Plasma, broulik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29021 To: nicolasfella, #frameworks, #plasma, broulik

D29021: Remove checks for notification service and fallback to KPassivePopup

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R289 KNotifications BRANCH nofallback2 REVISION DETAIL https://phabricator.kde.org/D29021 AFFECTED FILES

D29020: Add example/test application

nicolasfella updated this revision to Diff 80685. nicolasfella added a comment. - Add license header REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29020?vs=80684=80685 BRANCH example REVISION DETAIL https://phabricator.kde.org/D29020

D29020: Add example/test application

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The purpose of this is twofold. It serves as a code

D28805: Tweak kcmcontrols docs

This revision was automatically updated to reflect the committed changes. Closed by commit R296:b8accaad1eda: Tweak kcmcontrols docs (authored by nicolasfella). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28805?vs=80044=80640 REVISION DETAIL

D22701: [kfileutils] Add isExecutableFile from KRun

nicolasfella abandoned this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D22701 To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28020: New class ProcessLauncherJob in KIOGui

nicolasfella added a comment. IIRC startup notification is still a big question mark in Wayland, but other Plasma devs know better REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28020 To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik Cc: jbbgameich,

Re: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 AndroidQt5.14 - Build # 10 - Still Failing!

Hi, this looks like a simple prison build failure to me. However, I cannot reprocuce this with the binary factory container and the current Prison Android CI builds is blue. There is a single red Android build in the Prison CI history (https://build.kde.org/job/Frameworks/

D28851: Mark KStatusBarOfflineIndicator as deprecated

This revision was automatically updated to reflect the committed changes. Closed by commit R241:cd53f10cad27: Mark KStatusBarOfflineIndicator as deprecated (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28851?vs=80190=80201 REVISION

D25705: Deprecate KIO::pixmapForUrl

nicolasfella planned changes to this revision. nicolasfella added a comment. Seems like I missed some usages REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack,

D25705: Deprecate KIO::pixmapForUrl

nicolasfella updated this revision to Diff 80199. nicolasfella added a comment. - Fix update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25705?vs=80197=80199 BRANCH arcpatch-D25705_1 REVISION DETAIL https://phabricator.kde.org/D25705 AFFECTED FILES

D25705: Deprecate KIO::pixmapForUrl

nicolasfella added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25705: Deprecate KIO::pixmapForUrl

nicolasfella updated this revision to Diff 80197. nicolasfella added a comment. - Update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25705?vs=72413=80197 BRANCH arcpatch-D25705_1 REVISION DETAIL https://phabricator.kde.org/D25705 AFFECTED FILES

D17805: Allow specifying multiple mimetypes as constraints

nicolasfella abandoned this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17805 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28851: Mark KStatusBarOfflineIndicator as deprecated

nicolasfella added a task: T12373: Move or kill KStatusBarOfflineIndicator. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28851 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28851: Mark KStatusBarOfflineIndicator as deprecated

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Conceptually it doesn't really belong to KIO and KTorrent

D26034: Replace KLocalSocket with QLocalSocket

This revision was automatically updated to reflect the committed changes. Closed by commit R241:28da79f2119e: Replace KLocalSocket with QLocalSocket (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26034?vs=71642=80188 REVISION DETAIL

D28831: Add note about porting loadMimeTypeIcon

This revision was automatically updated to reflect the committed changes. Closed by commit R302:fe3f59b27dcf: Add note about porting loadMimeTypeIcon (authored by nicolasfella). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28831?vs=80128=80186 REVISION

D25443: [chmodjob] Port away from QLinkedList

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e18ae3ea52dc: [chmodjob] Port away from QLinkedList (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25443?vs=80139=80187 REVISION DETAIL

D19913: [plasma-desktop] make it compiles without foreach

nicolasfella added a comment. The title says plasma-desktop, but this is plasma-framework? REPOSITORY R242 Plasma Framework (Library) BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19913 To: mlaurent, dfaure Cc: nicolasfella,

D25443: [chmodjob] Port away from QLinkedList

nicolasfella edited the summary of this revision. REPOSITORY R241 KIO BRANCH ll REVISION DETAIL https://phabricator.kde.org/D25443 To: nicolasfella, #frameworks, dfaure Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D28834: Add metadata properties to calendar

nicolasfella marked an inline comment as done. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, mlaurent, knauss, dvratil

D28834: Add metadata properties to calendar

nicolasfella updated this revision to Diff 80150. nicolasfella added a comment. - default to ReadWrite - rename icon to iconname to reflect that it's just the name REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28834?vs=80140=80150 BRANCH props

D24443: Add a plugin system

nicolasfella planned changes to this revision. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, dhaumann, fbampaloukas, dcaliste,

D24443: Add a plugin system

nicolasfella updated this revision to Diff 80142. nicolasfella added a comment. - Convert license headers to SPDX REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=80141=80142 BRANCH arcpatch-D24443_2 REVISION DETAIL

D24443: Add a plugin system

nicolasfella updated this revision to Diff 80141. nicolasfella added a comment. - Remove calendarentry REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=71067=80141 BRANCH arcpatch-D24443_2 REVISION DETAIL

D24443: Add a plugin system

nicolasfella edited the summary of this revision. nicolasfella added a dependency: D28834: Add metadata properties to calendar. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc: z3ntu, ognarb, kde-pim,

D28834: Add metadata properties to calendar

nicolasfella added a dependent revision: D24443: Add a plugin system. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent,

D28834: Add metadata properties to calendar

nicolasfella added reviewers: Frameworks, KDE PIM, vkrause. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

D25443: [chmodjob] Port away from QLinkedList

nicolasfella updated this revision to Diff 80139. nicolasfella added a comment. - Update comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25443?vs=70143=80139 BRANCH ll REVISION DETAIL https://phabricator.kde.org/D25443 AFFECTED FILES

D25443: [chmodjob] Port away from QLinkedList

nicolasfella marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25443 To: nicolasfella, #frameworks, dfaure Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D22554: Finer No-Dbus on Windows

nicolasfella added a comment. @brute4s99 Is this still relevant? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27704: Drop FindAccountsFileDir.cmake

nicolasfella abandoned this revision. REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27704 To: nicolasfella, #frameworks, bshah, leinir, lbeltrame Cc: lbeltrame

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ee08d0b4e56e: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a comment. In D25707#645694 , @dfaure wrote: > OK. Then let me change my comment to: please document in kiconloader.h how to port away from loadMimeTypeIcon, even if it's not actually deprecated. > > I remember wondering

D28831: Add note about porting loadMimeTypeIcon

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We're phasing out loadMimeTypeIcon in favor of

D26918: Improve KNotification API docs

nicolasfella added a comment. ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26918 To: nicolasfella, #frameworks, broulik, jucato Cc: class, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28800: Always create actioncollection

This revision was automatically updated to reflect the committed changes. Closed by commit R294:4b3fc2aedd86: Always create actioncollection (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28800?vs=80034=80051 REVISION DETAIL

D28800: Always create actioncollection

nicolasfella added a comment. In D28800#647508 , @dfaure wrote: > (but now konqueror creates another one, so the konqueror patch needs to changed to "if exactly 5.69" only, right?) makes sense REPOSITORY R294 KBookmarks BRANCH

D28805: Tweak kcmcontrols docs

nicolasfella edited the summary of this revision. nicolasfella added a reviewer: Frameworks. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D28805 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28805: Tweak kcmcontrols docs

nicolasfella added a reviewer: jucato. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D28805 To: nicolasfella, #frameworks, jucato Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28805: Tweak kcmcontrols docs

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R296 KDeclarative BRANCH tweakdocs REVISION DETAIL https://phabricator.kde.org/D28805 AFFECTED FILES

D28800: Always create actioncollection

nicolasfella added reviewers: Frameworks, dfaure, stefanocrocco. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D28800 To: nicolasfella, #frameworks, dfaure, stefanocrocco Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28800: Always create actioncollection

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Otherwise subclasses that unconditionally use m_actionCollection will get crashes. Observed in D28789

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D24443: Add a plugin system

nicolasfella planned changes to this revision. nicolasfella added a comment. - single level hierarchy with a calendargroup object - calendar entry folded into calendar - calendar::open REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To:

D28391: [pc3/busyindicator] Hide when not running

This revision was automatically updated to reflect the committed changes. Closed by commit R242:bc3ccd1782cb: [pc3/busyindicator] Hide when not running (authored by nicolasfella). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D28391: [pc3/busyindicator] Hide when not running

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY When not running the indicator should be invisible. This matches the

D28295: Introduce KNotificationJobUiDelegate

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Otherwise looks good to me INLINE COMMENTS > knotificationjobuidelegate.h:28 > + * @class KNotificationJobUiDelegate knotificationjobuidelegate.h > KNotificationJobUiDelegate

D28295: Introduce KNotificationJobUiDelegate

nicolasfella added inline comments. INLINE COMMENTS > knotificationjobuidelegate.h:29 > + * > + * A UI delegate using KMessageBox for interaction (showing errors and > warnings). > + * s/KMessageBox/KNotification/g? REPOSITORY R289 KNotifications REVISION DETAIL

D28312: Implement urls using hints

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Set the hint directly in KNotification instead of the

D26918: Improve KNotification API docs

nicolasfella updated this revision to Diff 78423. nicolasfella added a comment. - Drop user config file description since it's an implementation detail REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26918?vs=78416=78423 BRANCH docs REVISION

D26918: Improve KNotification API docs

nicolasfella updated this revision to Diff 78416. nicolasfella added a comment. - Add a dedicated main page and link to the HIG from there - Move most content to main page - Fix code example REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D26918: Improve KNotification API docs

nicolasfella added inline comments. INLINE COMMENTS > apol wrote in Mainpage.dox:9 > @class so we create a link. Doxygen should do that automatically http://www.doxygen.nl/manual/autolink.html REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26918 To:

D25660: Decouple KBookmarksMenu from KActionCollection

This revision was automatically updated to reflect the committed changes. Closed by commit R294:0c888e2f8098: Decouple KBookmarksMenu from KActionCollection (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25660?vs=73666=78402#toc REPOSITORY R294 KBookmarks

D27635: Restore kio-webdav plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R155:693d7361428e: Restore kio-webdav plugin (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27635?vs=77280=77965#toc REPOSITORY R155 KAccounts Integration CHANGES

D28110: PersonsModel: Fix PersonVCardRole

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH fix-personsmodel-vcard (branched from master) REVISION DETAIL https://phabricator.kde.org/D28110 To: jbbgameich, apol, nicolasfella Cc: nicolasfella, kde-frameworks-devel,

D28110: PersonsModel: Fix PersonVCardRole

nicolasfella added inline comments. INLINE COMMENTS > personsmodel.cpp:186 > case PersonsModel::PersonVCardRole: > -return QVariant::fromValue(person); > +return person->customProperty(QStringLiteral("vcard")); > case PersonsModel::ContactsVCardRole: Use

D27635: Restore kio-webdav plugin

nicolasfella added inline comments. INLINE COMMENTS > leinir wrote in kaccountsdplugin.h:57 > This still introduces a API break, though... Which seems especially silly > given the arguments aren't actually used. Perhaps add a new ctor, and have > the one without the arguments call the new one,

D27635: Restore kio-webdav plugin

nicolasfella updated this revision to Diff 77280. nicolasfella added a comment. - Remove whitespace change REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27635?vs=77279=77280 BRANCH arcpatch-D27635 REVISION DETAIL

D27635: Restore kio-webdav plugin

nicolasfella updated this revision to Diff 77279. nicolasfella marked an inline comment as done. nicolasfella added a comment. Rebase REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27635?vs=76416=77279 BRANCH arcpatch-D27635 REVISION

D27704: Drop FindAccountsFileDir.cmake

This revision was automatically updated to reflect the committed changes. Closed by commit R155:17ff746ba128: Drop FindAccountsFileDir.cmake (authored by nicolasfella). REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27704?vs=76561=77278

D27708: Cleanup accounts kded module

This revision was automatically updated to reflect the committed changes. Closed by commit R155:4d36ced449f2: Cleanup accounts kded module (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27708?vs=77182=77277#toc REPOSITORY R155 KAccounts Integration CHANGES

D27562: [kcmcontrols] Respect header/footer visibility

This revision was automatically updated to reflect the committed changes. Closed by commit R296:0dad857cddfb: [kcmcontrols] Respect header/footer visibility (authored by nicolasfella). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27562?vs=76136=77221

D27562: [kcmcontrols] Respect header/footer visibility

nicolasfella added a comment. ping? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27562 To: nicolasfella, #plasma, mart Cc: iasensio, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27708: Cleanup accounts kded module

nicolasfella updated this revision to Diff 77182. nicolasfella added a comment. rebase REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27708?vs=76570=77182 BRANCH arcpatch-D27708 REVISION DETAIL https://phabricator.kde.org/D27708

D27662: Rewrite nextcloud plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R495:bea001a564b1: Rewrite nextcloud plugin (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27662?vs=76421=76772 REVISION DETAIL

D27528: Adapt action numbering in Android to work like in KNotifications

nicolasfella closed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27528 To: cacahueto, #frameworks, nicolasfella, vkrause Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27740: Adapt action numbering in Android to work like in KNotifications

This revision was automatically updated to reflect the committed changes. Closed by commit R289:92f5564da771: Adapt action numbering in Android to work like in KNotifications (authored by cacahueto, committed by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D27740: Adapt action numbering in Android to work like in KNotifications

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH adapt-action-numbering-in-android (branched from master) REVISION DETAIL https://phabricator.kde.org/D27740 To: cacahueto, #frameworks, nicolasfella, vkrause Cc:

D27760: WIP | Added BatchMoveJob

nicolasfella added a comment. What's the difference to the job you get with KIO::move with a list of urls? https://api.kde.org/frameworks/kio/html/namespaceKIO.html#a20da0b04660f834de30f9440673f6d5e REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27760 To: emateli,

D27707: Use kcoreaddons_add_plugin for kded module

This revision was automatically updated to reflect the committed changes. Closed by commit R155:4ad7ceea349b: Use kcoreaddons_add_plugin for kded module (authored by nicolasfella). REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE

D27706: Random cmake cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R155:3f4fc9d4071b: Random cmake cleanup (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27706?vs=76567=76611#toc REPOSITORY R155 KAccounts Integration CHANGES SINCE

D27705: Use QStringLiteral

nicolasfella marked an inline comment as done. REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27705 To: nicolasfella, #frameworks, bshah, leinir, apol Cc: apol

D27705: Use QStringLiteral

This revision was automatically updated to reflect the committed changes. Closed by commit R155:be294dcc69e7: Use QStringLiteral (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27705?vs=76566=76610#toc REPOSITORY R155 KAccounts Integration CHANGES SINCE

D27709: Move job classes to kaccounts lib and rename to *Job

This revision was automatically updated to reflect the committed changes. Closed by commit R155:2030bb498ed3: Move job classes to kaccounts lib and rename to *Job (authored by nicolasfella). REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE

D25654: Rename actions to be consistent

nicolasfella updated this revision to Diff 76587. nicolasfella added a comment. rebase REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25654?vs=70674=76587 BRANCH arcpatch-D25654 REVISION DETAIL https://phabricator.kde.org/D25654 AFFECTED FILES

D25654: Rename actions to be consistent

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R294:dddb013871ba: Rename actions to be consistent (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE

D27709: Move job classes to kaccounts lib and rename to *Job

nicolasfella retitled this revision from "Move job classes to kaccounts lib" to "Move job classes to kaccounts lib and rename to *Job". REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27709 To: nicolasfella, #frameworks, bshah, leinir

D27709: Move job classes to kaccounts lib

nicolasfella updated this revision to Diff 76580. nicolasfella added a comment. - Rename to *Job REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27709?vs=76573=76580 BRANCH decl REVISION DETAIL https://phabricator.kde.org/D27709

D27528: Adapt action numbering in Android to work like in KNotifications

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Let's get this in. Can you please give me your full name and email address so I can merge this? REPOSITORY R289 KNotifications BRANCH

D27709: Move job classes to kaccounts lib

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, bshah, leinir. nicolasfella requested review of this revision. REVISION SUMMARY This makes including them from the qml plugin less weird and they might be interesting to use from C++ too. TEST PLAN builds, kcm

D27708: Cleanup accounts kded module

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, bshah, leinir. nicolasfella requested review of this revision. REVISION SUMMARY Rename to emphasize it's a kded module plus some random cleanup TEST PLAN builds, kded5 starts REPOSITORY R155 KAccounts

D27707: Use kcoreaddons_add_plugin for kded module

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, bshah, leinir. nicolasfella requested review of this revision. REPOSITORY R155 KAccounts Integration BRANCH plug REVISION DETAIL https://phabricator.kde.org/D27707 AFFECTED FILES src/daemon/CMakeLists.txt

D27706: Random cmake cleanup

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, bshah, leinir. nicolasfella requested review of this revision. REVISION SUMMARY Remove unneeded calls, make coding style a bit more consistent TEST PLAN builds REPOSITORY R155 KAccounts Integration BRANCH

D27705: Use QStringLiteral

nicolasfella updated this revision to Diff 76566. nicolasfella added a comment. Remove unintended change REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27705?vs=76565=76566 BRANCH arcpatch-D27705 REVISION DETAIL

D27705: Use QStringLiteral

nicolasfella updated this revision to Diff 76565. nicolasfella added a comment. Remove unintended changes REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27705?vs=76563=76565 BRANCH arcpatch-D27705 REVISION DETAIL

D27705: Use QStringLiteral

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, bshah, leinir. nicolasfella requested review of this revision. REVISION SUMMARY Don't use naked strings TEST PLAN builds REPOSITORY R155 KAccounts Integration BRANCH qsl REVISION DETAIL

D27704: Drop FindAccountsFileDir.cmake

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, bshah, leinir. nicolasfella requested review of this revision. REVISION SUMMARY no one is using it REPOSITORY R155 KAccounts Integration BRANCH cma REVISION DETAIL https://phabricator.kde.org/D27704 AFFECTED

<    1   2   3   4   5   6   7   8   9   >