D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Welp, there's nothing objectively wrong with making this patch. LGTM REPOSITORY R265 KConfigWidgets BRANCH configure-keyboard-shortcuts (branched from master) REVISION DETAIL

D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

ndavis added a comment. This doesn't seem wrong, but why is it needed? Do people get confused about the type of shortcuts? Are there non-keyboard shortcuts? If there are, would we put their configuration menu under a different menu option? REPOSITORY R265 KConfigWidgets REVISION DETAIL

D25296: [RFC] Fix Display Configuration icon margins

ndavis added a comment. In D25296#563291 , @ngraham wrote: > Never mind, I wasn't deleting the cache files properly after rebuilding. When I do that, the monochrome icons don't get used at all and it reverts to the colorful one: > F778:

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

This revision was automatically updated to reflect the committed changes. Closed by commit R265:45b6460b0c09: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items (authored by ndavis). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis marked 2 inline comments as done. REPOSITORY R265 KConfigWidgets BRANCH arcpatch-D25677 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis updated this revision to Diff 70812. ndavis added a comment. More code formatting REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25677?vs=70802=70812 BRANCH arcpatch-D25677 (branched from master) REVISION DETAIL

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis marked 3 inline comments as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis updated this revision to Diff 70802. ndavis added a comment. - [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items - fix code style REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25677?vs=70720=70802 BRANCH

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

This revision was automatically updated to reflect the committed changes. Closed by commit R265:38b02c1baa84: [KColorScheme] Add items to ColorSet and Role enums for the total number of… (authored by ndavis). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a comment. In D25677#570896 , @ngraham wrote: > > This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks. > > Seems like these changes are unrelated and should maybe be

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis added a reviewer: dfaure. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a reviewer: dfaure. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a reviewer: Frameworks. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis added a dependent revision: D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a dependency: D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks.

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis updated this revision to Diff 70718. ndavis added a comment. - Split up Effects enum REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25676?vs=70717=70718 BRANCH enum-item-counts (branched from master) REVISION DETAIL

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis retitled this revision from "Add items to ColorSet and Role enums for the total number of items" to "[KColorScheme] Add items to ColorSet and Role enums for the total number of items". REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis,

D25676: Add items to ColorSet and Role enums for the total number of items

ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

ndavis updated this revision to Diff 70717. ndavis added a comment. - Also do Effects enum REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25676?vs=70716=70717 BRANCH enum-item-counts (branched from master) REVISION DETAIL

D25676: Add items to ColorSet and Role enums for the total number of items

ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

ndavis added a reviewer: Frameworks. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY I noticed that QPalette had these, but KColorScheme didn't. Since there is no function to get the number of items in an

D25590: support for user removing background and automatic shadow

ndavis added inline comments. INLINE COMMENTS > davidedmundson wrote in configuration-icons.svg:17 > @ndavis can you review this icon change please I couldn't see any issues in the SVG code. @mart Where is `showbackground` used in the UI so that I can test it? REPOSITORY R242 Plasma

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#566992 , @ngraham wrote: > In D25334#566745 , @ndavis wrote: > > > Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't look right. It just

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#566524 , @niccolove wrote: > F7780227: Screenshot_20191123_130602.png > I'm sorry, isn't this right? > The top one was like that before, and I just edited the bottom

D25340: Added background colors to active and inactive icon view

ndavis added a comment. In that case, maybe 5% opacity for minimized? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25334: Added transparent blue background to tabbars

ndavis added a comment. Here's the fixed file: F680: tabbar.svg Unfortunately, it still doesn't look right. F681: Screenshot_20191121_160905.png REPOSITORY R242 Plasma Framework (Library) REVISION

D25334: Added transparent blue background to tabbars

ndavis added inline comments. INLINE COMMENTS > ndavis wrote in tabbar.svg:47 > Oh wait, this must be where the color problem is. It's hardcoded to a light > color. It should be ButtonFocus with semi-transparency instead. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25334: Added transparent blue background to tabbars

ndavis added inline comments. INLINE COMMENTS > tabbar.svg:47 > + > + height="12" fill="#93cee9" opacity=".34"/> > + height="12" fill="#93cee9" opacity=".34"/> Oh wait, this must be where the color problem is. It's hardcoded to a light color. REPOSITORY R242 Plasma

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#565851 , @ngraham wrote: > Are you talking about the effect itself in terms of its background color, or how it fits in the space available when displayed by widgets? The latter will require many complicated

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#565798 , @ngraham wrote: > Honestly I think this is fine to land now. We can incrementally improve things with patches to individual widgets, but for the most part I think this is a big improvement already.

D25340: Added background colors to active and inactive icon view

ndavis added a comment. F7769041: Screenshot_20191117_203818.png 15% Inactive BG opacity 10% Minimized BG opacity REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham Cc:

D25340: Added background colors to active and inactive icon view

ndavis added a comment. In D25340#563908 , @ngraham wrote: > Decreasing the opacity of the icon itself? Maybe that could work. Not the icon, the background. > A pet peeve I have with the status quo is that minimized apps/windows have

D25340: Added background colors to active and inactive icon view

ndavis added a comment. In D25340#563783 , @ngraham wrote: > I don't hate the current state, let me note. It's just not what I expected, and I feel like I would need to get used to it rather than immediately falling in love with it.

D25334: Added transparent blue background to tabbars

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham, ndavis Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel,

D25334: Added transparent blue background to tabbars

ndavis added a comment. Even if the colors are fixed, there are a number of other places that need fixes in order for this to look right, so I think we should hold off landing this until these issues are fixed: Not extending to the edge: F7768790: Screenshot_20191117_171047.png

D25334: Added transparent blue background to tabbars

ndavis added a comment. These colors don't look right F7768670: Screenshot_20191117_152000.png REPOSITORY R242 Plasma Framework (Library) BRANCH tabbar_blue_background (branched from master) REVISION DETAIL https://phabricator.kde.org/D25334

D25340: Added background colors to active and inactive icon view

ndavis added a comment. I wonder if the Light gray line on the inactive mode should be a little brighter (up to 35% opacity) or if the background for inactive and minimized should be a little darker (down to 15% opacity) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25340: Added background colors to active and inactive icon view

ndavis added a comment. Here's a cleaned up version of the file with the changes Nate and I requested: F7767647: tasks.svg F7767649: Screenshot_20191117_005703.png REPOSITORY R242 Plasma Framework (Library)

D25340: Added background colors to active and inactive icon view

ndavis added a comment. Unfortunately, InactiveText doesn't work and neither does DisabledText. I might need to change whatever library handles stylesheets for plasmashell. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove,

D25340: Added background colors to active and inactive icon view

ndavis added a comment. In D25340#563388 , @niccolove wrote: > > @ndavis said: > > Here's what I think: > > > > - The line should indicate that the app is opened, the window is not minimized and the window is focused (opaque blue) or

D25340: Added background colors to active and inactive icon view

ndavis added a comment. This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which isn't in git master. Do I actually need that commit for this patch to work? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove,

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#563295 , @niccolove wrote: > In D25334#563285 , @ngraham wrote: > > > Perfect, all issues fixed, and thanks for pointing me in the direction of the cache files.

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#563346 , @ngraham wrote: > Found the bug report tracking that requested change: https://bugs.kde.org/show_bug.cgi?id=370465 > > Based on the comments there, it's likely that this proposal would receive

D25296: [RFC] Fix Display Configuration icon margins

ndavis added a comment. I figured it out. The 22px version needs the `22-22-` prefix in its ID. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25296 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25296: [RFC] Fix Display Configuration icon margins

ndavis added inline comments. INLINE COMMENTS > preferences.svg:4 > +.ColorScheme-Text { > color:#7B7C7E; >} Wrong default colors. Just replace the whole stylesheet with this one:

D25296: [RFC] Fix Display Configuration icon margins

ndavis added a comment. It's blurry in your screenshot because you're scaling a 22px icon up to 32px. The solution is to make a 32px version named `32-32-preferences-desktop-display-randr`. BTW, the icon is not actually aligned with the grid. It's a little off here and there. You should be

D25132: Use an eyedropper for color-picker icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM, but I noticed that there is a 32px monochrome icon. Should we keep using 32px monochrome icons for now? It seems like we can't make up our minds on this issue and the amount of work

D25291: Add "all applications" category icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH all-apps-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D25291 To: ngraham, #vdg, broulik, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ndavis added a comment. In D25226#560363 , @ngraham wrote: > Or maybe should the UI be changed to show a clickable link and an "edit" button that temporarily turns it into a text field that lets you edit it? So like this?

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ndavis added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1120 > +QPushButton *goThereButton = new QPushButton(d->m_frame); > +goThereButton->setIcon(QIcon::fromTheme(QStringLiteral("go-next"))); > + `go-jump` is more semantically correct. REPOSITORY R241 KIO

D25015: Update breeze theme shadows

ndavis added a comment. In D25015#560516 , @cblack wrote: > In D25015#560515 , @ndavis wrote: > > > One thing we might need to do in order to finally stop changing the shadows is come up with a math

D25015: Update breeze theme shadows

ndavis added a comment. One thing we might need to do in order to finally stop changing the shadows is come up with a system for deciding how shadows should look based on the elevation we want certain UI elements to have. We could copy Material Design shadows, but I don't think we should.

D25015: Update breeze theme shadows

ndavis added a comment. In D25015#560498 , @niccolove wrote: > In D25015#559344 , @filipf wrote: > > > I'd prefer the shadows to have equal strength all around, I couldn't get used to weaker

D25123: [WIP] New yakuake logo/icon

ndavis added a comment. I think I prefer C the most now that I've seen it next to other icons. It has a similar level of detail to other Breeze icons. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, hein Cc: ndavis, KonqiDragon,

D25132: Use an eyedropper for color-picker icons

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I still think the lines on the side of the tube need to be a bit thicker. They're almost half a pixel thick, which is not in line with what we normally do and it makes them fuzzy

D25015: Update breeze theme shadows

ndavis added a comment. I see the difference now as well. @niccolove BTW, the top right corner is a bit messed up. It's rising above the rest of the shadow on the top edge. Rather than painstakingly making shadows by hand in Inkscape, perhaps we should be using KWin for the shadows?

D25015: Update breeze theme shadows

ndavis added a comment. I haven't said much about this idea because I just have a hard time seeing the difference from the screenshots. It seems like a good amount of effort went into this, and I know from experience that adjusting shadows in Inkscape is a major PITA, but I can't approve

D25132: Use an eyedropper for color-picker icons

ndavis added a comment. another set F7736364: Screenshot_20191104_154914.png F7736366: Screenshot_20191104_154930.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25132

D25123: [WIP] New yakuake logo/icon

ndavis added a comment. In D25123#558353 , @mglb wrote: > Breaking nice-looking proportions just to fill vertical space is not good IMO. Making the bar a bit higher might make it look more reasonably. Your second proposition (icon C) looks nice

D25132: Use an eyedropper for color-picker icons

ndavis added a comment. The chunky look works well at 16px, but I can see it sticking out at larger sizes. These ones have pointier tips: 1x F7730340: Screenshot_20191103_174917.png 4x F7730343: Screenshot_20191103_175058.png

D25132: Use an eyedropper for color-picker icons

ndavis added a comment. Here's another idea: F7730258: Screenshot_20191103_173337.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25132 To: ngraham, #vdg Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25132: Use an eyedropper for color-picker icons

ndavis added a comment. I think it needs to be a little more Breezy. Here are 2 of my attempts with the 16px version: F7730187: Screenshot_20191103_172328.png F7730173: Screenshot_20191103_172121.png F7730179:

D25123: [WIP] New yakuake logo/icon

ndavis added a comment. A or C for me. `A` looks more like how I imagine a "drop down terminal", but it's got a lot of margin below the bottom of it. I tried seeing how it would look extended down to the bottom margin: F7728707: Screenshot_20191103_135015.png

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

ndavis added a comment. I'm not sure if my review is really necessary since I lack the technical expertise to know what the right solution is, but +1 to light and dark Breeze icon support on other platforms. REPOSITORY R266 Breeze Icons REVISION DETAIL

T11950: Reduce the pain of working on monochrome Breeze icons

ndavis added a comment. I don't trust optimizers unless it's `scour`. That's the only one I know of that doesn't seem to cause problems occasionally. Inkscape's Optimized SVG save option actually uses `scour` to do the optimization. I'm somewhat open to the idea of only requiring

D24975: Change some 32px action icons to color style

ndavis added a comment. I don't have time to do all 32px icons at once, but thankfully, they're usually only used in the desktop shell (I can put 32px monochrome icons in the desktop theme), or in preferences or navigation sidebars. I suppose it also affects people who raise the toolbar

D24975: Change some 32px action icons to color style

ndavis added a subscriber: ngraham. ndavis added a comment. In D24975#554721 , @mglb wrote: > Why do you replace action icons instead of adding separate colorful icons for use in preference dialogs? Right now all action icons are "monochrome",

D24975: Change some 32px action icons to color style

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24975 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

ndavis added a comment. In D24959#554523 , @trickyricky26 wrote: > On the technical side, we usually convert everything to paths, and even though I can't imagine Qt SVG Renderer would have a problem with `circle`, it might be better to convert

D24975: Change some 32px action icons to color style

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24975 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

ndavis added a task: T10165: Large category icons should all be colorful. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24975 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY - document-open-recent, document-save-all, document-save-as, document-save,

D24652: Add folder-recent, extend hand of clock in folder-temp

This revision was automatically updated to reflect the committed changes. Closed by commit R266:2a36922a8cc4: Add folder-recent, extend hand of clock in folder-temp (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24652?vs=67939=68773

D24625: Fill middle mouse button area

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:8732c6a99ad1: Fill middle mouse button area (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST

D24476: [KPropertiesDialog] Only show volume-related info for volumes

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. In D24476#554110 , @pino wrote: > Please remember that the properties dialog is a general dialog offered by the KIO framework, and

D24476: [KPropertiesDialog] Only show volume-related info for volumes

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I agree with this change. REPOSITORY R241 KIO BRANCH only-show-volume-info-for-volumes (branched from master) REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg,

D24871: Use a more correct and appropriate visual metaphor for "get hot new stuff" icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH more-appropriate-ghns-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D24871 To: ngraham, #vdg, leinir, ndavis Cc: kde-frameworks-devel, ndavis,

D24753: Add edit-opacity icons

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D24753 REVISION DETAIL https://phabricator.kde.org/D24753 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24537: Icons for windy weather

ndavis added a comment. Oh yes, that would be a good thing. Any of these will be fine: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization REPOSITORY R266 Breeze Icons BRANCH windy-weather-icons (branched from master) REVISION DETAIL

D24537: Icons for windy weather

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I'm fine with this blue. REPOSITORY R266 Breeze Icons BRANCH windy-weather-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg, ndavis

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

ndavis added a comment. For some reason, Arc made me the committer and the author instead of just the committer. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham,

D24652: Add folder-recent, extend hand of clock in folder-temp

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24652 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24652: Add folder-recent, extend hand of clock in folder-temp

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY folder-recent is merely a symlink to folder-temp since they both normally use the same

D24627: [icons/media.svg] Add 16 & 32px icons, update style

This revision was automatically updated to reflect the committed changes. Closed by commit R242:15ed55b4cb71: [icons/media.svg] Add 16 32px icons, update style (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D24628: Fix incorrect margins in 16/22px media icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:83c8768b2a70: Fix incorrect margins in 16/22px media icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24628?vs=67887=67924 REVISION

D24627: [icons/media.svg] Add 16 & 32px icons, update style

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24627 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24628: Fix incorrect margins in 16/22px media icons

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24628 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24628: Fix incorrect margins in 16/22px media icons

ndavis added a dependent revision: D24627: [icons/media.svg] Add 16 & 32px icons, update style. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24628 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

ndavis added a dependency: D24628: Fix incorrect margins in 16/22px media icons. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24627 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24628: Fix incorrect margins in 16/22px media icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY For some reason, the margins on these icons were 1 px larger on each side than they were

D24627: [icons/media.svg] Add 16 & 32px icons, update style

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24627 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Fixes blurry icons in the desktop shell REPOSITORY R242 Plasma Framework

D24625: Fill middle mouse button area

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24625 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24625: Fill middle mouse button area

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The negative space in the middle didn't quite look right REPOSITORY R266 Breeze Icons

<    1   2   3   4   5   6   7   8   9   10   >