ofreyermuth added a comment.
In https://phabricator.kde.org/D8806#167503, @drosca wrote:
> I need your full name and e-mail to commit it (I can't get it with `arch
patch` probably because you didn't upload this review with `arc diff`).
Oliver Freyermuth <o.f
ofreyermuth added a comment.
In https://phabricator.kde.org/D8806#167483, @drosca wrote:
> Just for the record, how does Konsole inherit this fd when BluezQt is only
used in plasmashell + kded and KDE apps are afaik not forked from these
processes?
What exactly happens depends
ofreyermuth added a comment.
In https://phabricator.kde.org/D8806#167457, @bshah wrote:
> Do you have commit access?
In case you are adressing me: No.
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D8806
To: ofreyermuth, davidedmundson
Cc: drosca,
ofreyermuth added a comment.
In https://phabricator.kde.org/D8806#167404, @broulik wrote:
> If you add the following (upper-case with a colon and space) on its own
line in your commit message [...]
Many thanks, done!
REPOSITORY
R269 BluezQt
REVISION DETAIL
ofreyermuth edited the summary of this revision.
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D8806
To: ofreyermuth, davidedmundson
Cc: broulik, #frameworks
ofreyermuth added a comment.
Thanks for the quick review!
I also created a related issue report here:
https://bugs.kde.org/show_bug.cgi?id=386886
which can of course be closed once the patch has landed.
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D8806
To:
ofreyermuth created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
They may be leaked into all child processes,
including regular Konsole terminals on KDE.
I observed them showing up at all
