Hello,
A Merge Request in GitLab does not necessarily imply the need for a review by e
person. It can just run a pipeline to validate that the code isn't broken. If
the pipeline fails, the merge button is not available.
We use GitLab at work and we have it set up like this:
* Main branches
obogdan closed this revision.
obogdan added a comment.
Commited with commit e630aa985494bcfccb5b5e722a32a4e77d581271
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3568
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
obogdan added a comment.
Should I wait for more people to review this?
BRANCH
find-cmake-binary
REVISION DETAIL
https://phabricator.kde.org/D3568
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: obogdan, kfunk, #frameworks, apol
Cc: kfunk
> On my first run KSB cried that I should change *module* to *options*, so I
> did, and it runs now.
I've reverted this and updated the source of KSB. It's fine now.
*Ovidiu-Florin Bogdan*
GeekAliens.com[1]
Kubuntu Romania Representative[2]
_Kubuntu Council Member_
[1] http://ovidiu.ge
antlee.git
branch master
-end module
+end options
module-set kde-pim
repository kde-projects
Please advise.
--
*Ovidiu-Florin Bogdan*
GeekAliens.com[1]
Kubuntu Romania Representative[2]
_Kubuntu Council Member_
[1] http://ovidiu.geekaliens.