Re: Review Request 128652: Fix wording an -> one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128652/#review98307 --- Ship it! Ship It! - Ragnar Thomsen On Aug. 10, 2016, 8

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/#review97747 --- Ship it! This is much better, thanks :) - Ragnar Thomsen

Re: Review Request 128466: Rename Checksums tab to Integrity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128466/#review97484 --- Ship it! Ship It! - Ragnar Thomsen On July 16, 2016, 2

Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

marked as submitted. Review request for KDE Frameworks, Kai Uwe Broulik, David Edmundson, and Elvis Angelaccio. Changes --- Submitted with commit 981585082d2a6a79fc8c9cceb2d8cacb324930b9 by Ragnar Thomsen to branch master. Repository: kwidgetsaddons Description --- We are using

Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

/kcollapsiblegroupbox_test.h PRE-CREATION autotests/kcollapsiblegroupbox_test.cpp PRE-CREATION src/kcollapsiblegroupbox.cpp 0c3f866 Diff: https://git.reviewboard.kde.org/r/128406/diff/ Testing --- The autotests in newAddDialog branch of Ark pass with this diff. Thanks, Ragnar Thomsen

Re: Review Request 128283: Add checksums tab to the properties dialog

or not suggesting this before it was committed. - Ragnar Thomsen On July 8, 2016, 3:51 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

/kcollapsiblegroupbox_test.cpp PRE-CREATION src/kcollapsiblegroupbox.cpp 0c3f866 Diff: https://git.reviewboard.kde.org/r/128406/diff/ Testing --- The autotests in newAddDialog branch of Ark pass with this diff. Thanks, Ragnar Thomsen ___ Kde-frameworks

Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

-CREATION src/kcollapsiblegroupbox.cpp 0c3f866 Diff: https://git.reviewboard.kde.org/r/128406/diff/ Testing --- The autotests in newAddDialog branch of Ark pass with this diff. Thanks, Ragnar Thomsen ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

cally generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/#review97224 --- On July 8, 2016, 9:29 p.m., Ragnar Thomsen wrote: > > --- > This is an automa

Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

with this diff. Thanks, Ragnar Thomsen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

if it is running, before deleting the d pointer. Diffs - src/kcollapsiblegroupbox.cpp 0c3f866 Diff: https://git.reviewboard.kde.org/r/128406/diff/ Testing --- The autotests in newAddDialog branch of Ark pass with this diff. Thanks, Ragnar Thomsen

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127572/#review94244 --- Ship it! Works for me :) - Ragnar Thomsen On April 4

Re: Review Request 127548: Take content margins into account when calcuating size hints

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127548/#review94187 --- Ship it! Yes, works perfectly :) - Ragnar Thomsen

Re: date + releaseinfo in frameworks docbooks

On Thu, Jul 30, 2015 at 12:03 PM, Burkhard Lück lu...@hube-lueck.de wrote: Am Donnerstag, 30. Juli 2015, 11:18:49 schrieb Luigi Toscano: We need to be some rule for that, as I've seen the removal of releaseinfo, which I think is incorrect:

Re: Review Request 123940: Use KPluginLoader::factory() when loading KIO::DndPopupMenuPlugin

marked as submitted. Review request for Dolphin, KDE Frameworks, Emmanuel Pescosta, and Harald Hvaal. Changes --- Submitted with commit 07ea88471e5c610e3239c284875f544bef5059f8 by Ragnar Thomsen to branch master. Repository: kio Description --- This patch fixes an error when

Re: Review Request 123940: Use KPluginLoader::factory() when loading KIO::DndPopupMenuPlugin

) - src/widgets/dropjob.cpp 63beb0a Diff: https://git.reviewboard.kde.org/r/123940/diff/ Testing --- The Extract here option now appears when dragging an archive in Dolphin (current frameworks branch), and extraction works as expected. Thanks, Ragnar Thomsen

Review Request 123940: Use KPluginLoader::factory() when loading KIO::DndPopupMenuPlugin

option now appears when dragging an archive in Dolphin (current frameworks branch), and extraction works as expected. Thanks, Ragnar Thomsen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde