D26560: Fix selection printing

hoffmannrobert added a comment. In case my last comment was mistakable, I fixed this: > 1. Create a document with just one long line that wraps over two printed pages. I this case, I am not able to print only the selected text properly. but I couldn't fix this: > 2. Say you

D26560: Fix selection printing

hoffmannrobert added a comment. Here is the fix for 1. I've tried number 2, but I didn't get anywhere. I think this would need huge efforts: To remove the empty space before (and after) the selection you would have to change the layout, which is tied to the document, so basically you

D26560: Fix selection printing

hoffmannrobert updated this revision to Diff 74577. hoffmannrobert added a comment. - Fix 1: long lines wrapping over pages REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26560?vs=73197=74577 BRANCH fix_selection_printing REVISION DETAIL

D26560: Fix selection printing

hoffmannrobert added a comment. Yes, I am working on it. Now, I have a solution for 1, but 2 is more difficult to fix. Probably next week. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26560 To: hoffmannrobert, dhaumann Cc: kwrite-devel, kde-frameworks-devel,

D26560: Fix selection printing

hoffmannrobert added a reviewer: dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26560 To: hoffmannrobert, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. In D21563#584484 , @hoffmannrobert wrote: > In D21563#584218 , @dhaumann wrote: > > > @hoffmannrobert: Are you maybe also interested in looking into

D26560: Fix selection printing

hoffmannrobert created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Printing selected text only worked correctly if the lines from which text was

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. In D21563#584220 , @dhaumann wrote: > @hoffmannrobert: by the way, looking at your phabricator activity, you should get a KDE contributor account, if you don't have one already. I applied for one and added

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. In D21563#584218 , @dhaumann wrote: > @hoffmannrobert: Are you maybe also interested in looking into https://bugs.kde.org/show_bug.cgi?id=415570 ? It's again about printing, this time about the very last line

D22715: Save and load page margins

hoffmannrobert updated this revision to Diff 62475. hoffmannrobert added a comment. - Use KTextEditor::EditorPrivate::config() REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22715?vs=62470=62475 BRANCH save_and_load_page_margins REVISION DETAIL

D22715: Save and load page margins

hoffmannrobert created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Adapt and reapply former fix from

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. In D21563#487947 , @cullmann wrote: > I tried to reproduce the issue with and without this fix but I somehow fail. > Has somebody else more luck? Try with long log files like boot.log, dmesg.log or

D21959: Fix selectedNameFilter() multiple matches

hoffmannrobert added a comment. Can you please push it for me, I don't have commit access. Thanks. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH fix_selectedNameFilter REVISION DETAIL https://phabricator.kde.org/D21959 To: hoffmannrobert, #frameworks, apol, dfaure

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. It fixes this bug: https://bugs.kde.org/show_bug.cgi?id=348598 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, bruns, demsking,

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. In D21563#473734 , @ngraham wrote: > Fixes https://bugs.kde.org/show_bug.cgi?id=376270? No, that's something different. That is apparently a duplicate of https://bugs.kde.org/show_bug.cgi?id=391678 which

D21959: Fix selectedNameFilter() multiple matches

hoffmannrobert marked an inline comment as done. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D21959 To: hoffmannrobert, #frameworks, apol, dfaure Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,

D21959: Fix selectedNameFilter() multiple matches

hoffmannrobert updated this revision to Diff 60286. hoffmannrobert added a comment. - Remove redundant condition REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21959?vs=60217=60286 BRANCH fix_selectedNameFilter

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY There were errors if a page's last line is too long and needs to be wrapped into two

D20197: Fix desktop link to file or directory

hoffmannrobert added a comment. In D20197#445098 , @dfaure wrote: > Ah! So "DirOrFile" means the user can see and choose both directories and files? Maybe call this ModeWasDirAndFile. I kept reading this was "mode was dirs or mode was files"

D20197: Fix desktop link to file or directory

hoffmannrobert updated this revision to Diff 55636. hoffmannrobert marked an inline comment as done. hoffmannrobert added a comment. - Renames REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20197?vs=55630=55636 BRANCH fix_desktop_link_filter REVISION

D20197: Fix desktop link to file or directory

hoffmannrobert marked 5 inline comments as done. hoffmannrobert added inline comments. INLINE COMMENTS > dfaure wrote in kurlrequester.cpp:262 > I don't understand what this variable means. What's a DirFile? ;) > Reading the rest I guess this means DirOrFile, ok, but what else is there? Ok,

D20197: Fix desktop link to file or directory

hoffmannrobert updated this revision to Diff 55630. hoffmannrobert added a comment. - Use lambdas and helper REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20197?vs=55459=55630 BRANCH fix_desktop_link_filter REVISION DETAIL

D20197: Fix desktop link to file or directory

hoffmannrobert added a comment. Thanks, I've learned that QFileDialog only creates a well behaving directory chooser, if the QFileDialog::ShowDirsOnly option is set to true _after_ having set the fileMode to QFileDialog::Directory. If you do it the other way around, it doesn't add

D20197: Fix desktop link to file or directory

hoffmannrobert updated this revision to Diff 55459. hoffmannrobert added a comment. - Set option QFileDialog::ShowDirsOnly after setting file mode REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20197?vs=55409=55459 BRANCH fix_desktop_link_filter REVISION

D20197: Fix desktop link to file or directory

hoffmannrobert added a comment. Is there a different decided directory chooser than QFileDialog? It's the way QFileDialog handles directories. If you click a directory, it not added to the selection, other than a file, which is. So, if QFileDialog::selectedUrls() is called, nothing is

D20197: Fix desktop link to file or directory

hoffmannrobert added a comment. You need to double click the directory, so you enter the directory, then click Open. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20197 To: hoffmannrobert, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20197: Fix desktop link to file or directory

hoffmannrobert added a comment. In D20197#442358 , @ngraham wrote: > This doesn't work. Try creating a symlink to a directory. In the file picker dialog, the Open button doesn't work. > > See https://bugs.kde.org/show_bug.cgi?id=357171 for

D20197: Fix desktop link to file or directory

hoffmannrobert retitled this revision from "Fix desktop link filter" to "Fix desktop link to file or directory". hoffmannrobert edited the summary of this revision. hoffmannrobert edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20197

D20197: Fix desktop link filter

hoffmannrobert updated this revision to Diff 55409. hoffmannrobert added a comment. - Add file/directory selection REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20197?vs=55259=55409 BRANCH fix_desktop_link_filter REVISION DETAIL

D20197: Fix desktop link filter

hoffmannrobert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Set FileMode of the QFileDialog to QFileDialog::AnyFile instead of QFileDialog::Directory if

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert updated this revision to Diff 55115. hoffmannrobert added a comment. - Add KIO_VERSION check, use SkipMimeTypeFromContent REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19784?vs=54863=55115 BRANCH fix_recent_documents_kicker_hang

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert marked 3 inline comments as done. hoffmannrobert added a comment. Yes, please, and https://phabricator.kde.org/D19784 too. REPOSITORY R241 KIO BRANCH add_skipStat REVISION DETAIL https://phabricator.kde.org/D19887 To: hoffmannrobert, dfaure, #frameworks, #dolphin Cc:

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert marked 4 inline comments as done. hoffmannrobert added inline comments. INLINE COMMENTS > dfaure wrote in kfileitem.cpp:362 > There is one thing I've been wondering back and forth about: the alternative > way of doing this, which is to call init() unconditionally and testing the

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert updated this revision to Diff 55033. hoffmannrobert marked 3 inline comments as done. hoffmannrobert added a comment. - Add ensureInitialized(), entry() changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19887?vs=55025=55033 BRANCH

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert marked 4 inline comments as done. hoffmannrobert added inline comments. INLINE COMMENTS > dfaure wrote in kfileitem.cpp:361 > What about the other way around? I think this needs the symmetrical test to > call item.init() if needed > (and the corresponding unittest, write it

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19887 To: hoffmannrobert, dfaure, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert updated this revision to Diff 55025. hoffmannrobert added a comment. - Fix cmp() #3, add test for cmp()/init(), simplifications REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19887?vs=54934=55025 BRANCH add_skipStat REVISION DETAIL

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert updated this revision to Diff 54934. hoffmannrobert marked 4 inline comments as done. hoffmannrobert added a comment. - Fix cmp() #2 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19887?vs=54932=54934 BRANCH add_skipStat REVISION DETAIL

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert added a comment. KFileItemTest::testCmp() failed - fixed. JobTest also fails, but this fails in master, too. Something with FileCopyJob. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19887 To: hoffmannrobert, dfaure, #frameworks, #dolphin Cc:

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert updated this revision to Diff 54932. hoffmannrobert added a comment. - Fix cmp(), SkipMimeTypeFromContent rename, change isDir() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19887?vs=54862=54932 BRANCH add_skipStat REVISION DETAIL

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert marked 5 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19887 To: hoffmannrobert, dfaure, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert retitled this revision from "Proposal for KFileItem to skip stat()" to "KFileItem: call stat() on demand, add SkipMimeTypeDetermination option". hoffmannrobert edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19887 To:

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert updated this revision to Diff 54863. hoffmannrobert added a comment. - Use new KFileItem::SkipMimeTypeDetermination parameter REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19784?vs=54339=54863 BRANCH

D19887: Proposal for KFileItem to skip stat()

hoffmannrobert updated this revision to Diff 54862. hoffmannrobert added a comment. - On-demand stat(), helper function, SkipMimeTypeDetermination REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19887?vs=54338=54862 BRANCH add_skipStat REVISION DETAIL

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert added a comment. In D19784#437715 , @dfaure wrote: > ... > Indeed this doesn't need the stat() done by KFileItem's init(). This means the right solution is indeed for KFileItem to do that stat() on demand, and this

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert added a comment. In D19784#434564 , @hoffmannrobert wrote: > In D19784#431683 , @ngraham wrote: > > > Nice, kinda sounds like this fixes https://bugs.kde.org/show_bug.cgi?id=373352.

D19786: Fix WebDAV directory renaming if KeepAlive is off

hoffmannrobert added a comment. No, thanks, I have a sponsor, but I don't have commit access. Please push it for me. REPOSITORY R241 KIO BRANCH fix_webdav_rename_directory REVISION DETAIL https://phabricator.kde.org/D19786 To: hoffmannrobert, #frameworks, #dolphin, dfaure, sitter

D19786: Fix WebDAV directory renaming if KeepAlive is off

hoffmannrobert added a comment. In D19786#433580 , @sitter wrote: > setting server to keepalive=false? what is this? the 90's? :O Perhaps they are low on memory? I don't know, I can't change that. > wouldn't it be simpler to

D19786: Fix WebDAV directory renaming if KeepAlive is off

hoffmannrobert updated this revision to Diff 54496. hoffmannrobert added a comment. - Call resetSessionSettings() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19786?vs=53956=54496 BRANCH fix_webdav_rename_directory REVISION DETAIL

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert marked an inline comment as done. hoffmannrobert added a comment. In D19784#431683 , @ngraham wrote: > Nice, kinda sounds like this fixes https://bugs.kde.org/show_bug.cgi?id=373352. Can you confirm? No, unfortunately it

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert marked 3 inline comments as done. hoffmannrobert added a comment. See https://phabricator.kde.org/D19887 INLINE COMMENTS > dfaure wrote in recentusagemodel.cpp:261 > How do you expect isFile() and isDir() to work without a QT_LSTAT call? A document should always be a file, so

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert updated this revision to Diff 54339. hoffmannrobert added a comment. - Use new KFileItem constructor with skipStat set to true REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19784?vs=53951=54339 BRANCH

D19887: Proposal for KFileItem to skip stat()

hoffmannrobert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY This adds a KFileItem constructor for passing a boolean skipStat. If true, KFileItemPrivate::init(),

D19786: Fix WebDAV directory renaming if KeepAlive is off

hoffmannrobert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Reset m_request.isKeepAlive to true if responseCode == 301 during renaming a directory. Otherwise the

D19422: Fix upper/lower case rename on case insensitive fs

hoffmannrobert added a comment. Could you please land it for me, I don't have commit access. Thanks. REPOSITORY R241 KIO BRANCH fix_case_rename REVISION DETAIL https://phabricator.kde.org/D19422 To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr Cc: kde-frameworks-devel,

D19422: Fix upper/lower case rename on case insensitive fs

hoffmannrobert marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19422 To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19422: Fix upper/lower case rename on case insensitive fs

hoffmannrobert updated this revision to Diff 53051. hoffmannrobert added a comment. QDir not required, just add '/' REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19422?vs=52833=53051 BRANCH fix_case_rename REVISION DETAIL

D19422: Fix upper/lower case rename on case insensitive fs

hoffmannrobert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Fixes wrong temp file creation (missing '/' at relative root of mounted fs). TEST PLAN Mount a CIFS

D10343: Create containment on specified screen

hoffmannrobert updated this revision to Diff 38410. hoffmannrobert edited the test plan for this revision. hoffmannrobert added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. - Remove unnecessary Containment::setLastScreen() REPOSITORY

D10343: Create containment on specified screen

hoffmannrobert edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10343 To: hoffmannrobert Cc: #frameworks, michaelh, ngraham

D10343: Create containment on specified screen

hoffmannrobert edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10343 To: hoffmannrobert Cc: #frameworks, michaelh, ngraham

D10343: Create containment on specified screen

hoffmannrobert created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. hoffmannrobert requested review of this revision. REVISION SUMMARY Add methods used by Plasma::Containment *ShellCorona::addPanel(const QString )