Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Rolf Eike Beer
Bhushan Shah wrote: I've worked on draft "move" of the current set of the repositories in their respective subgroups at the repo-metadata project's branch [1]. You can browse the directory structure to get idea of how final structure on Gitlab would look like. No objection, just a request for

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

2018-08-20 Thread Rolf Eike Beer
dakon added inline comments. INLINE COMMENTS > CMakeLists.txt:14 > + check_function_exists(statx HAVE_STATX) > + set(HAVE_STATX ${HAVE_STATX}) > endif() This line looks needless. > file.cpp:86 > +#include > +// 332 on my system > +#define STAT(path, buf) >

Re: Review Request 128308: fix the mkspecs install directory when cross-compiling using Qt5

2016-07-02 Thread Rolf Eike Beer
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit eb5eeca609e9960d7afe3462b421bfe0a48b8e21 by Rolf Eike Beer to branch master. Repository: qca Description --- mkspecs should go in the host install prefix, not the target one. Diffs

Review Request 128309: add helper function to create "Details" button

2016-06-28 Thread Rolf Eike Beer
/ Testing --- Thanks, Rolf Eike Beer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128308: fix the mkspecs install directory when cross-compiling using Qt5

2016-06-28 Thread Rolf Eike Beer
--- mkspecs should go in the host install prefix, not the target one. Diffs - cmake/modules/QcaMacro.cmake 88ab0d0 Diff: https://git.reviewboard.kde.org/r/128308/diff/ Testing --- Puts the mkspec file in the correct directory when cross-compiling now. Thanks, Rolf Eike Beer

Re: Review Request 128295: fix base64 decoding on ARM

2016-06-27 Thread Rolf Eike Beer
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 601fd3a05141c614ae48a3ddac44194d669eaae1 by Rolf Eike Beer to branch master. Bugs: 364495 http://bugs.kde.org/show_bug.cgi?id=364495 Repository: qca Description --- This code was broken

Review Request 128295: fix base64 decoding on ARM

2016-06-27 Thread Rolf Eike Beer
t be detected. Diffs - src/qca_textfilter.cpp 9889a24 Diff: https://git.reviewboard.kde.org/r/128295/diff/ Testing --- Builds without error on newer gcc now. Thanks, Rolf Eike Beer ___ Kde-frameworks-devel mailing list Kde-framewo

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

2015-03-17 Thread Rolf Eike Beer
On März 17, 2015, 1:07 nachm., Laurent Montel wrote: src/plugins/hunspell/hunspellclient.cpp, line 27 https://git.reviewboard.kde.org/r/122987/diff/3/?file=355372#file355372line27 #include ... we use local file. No, the file is in an include path, not in the same directory as

Re: Whoopsie in KF5::WindowSystem 5.3.0

2014-10-10 Thread Rolf Eike Beer
Am Freitag, 10. Oktober 2014, 17:14:41 schrieb Martin Graesslin: Hi all, unfortunately we have an embarrassing bug [1] in KWindowSystem 5.3.0 which can crash any application making use of KWindowSystem on the X11 Platform. This is fixed with commit [2]. I recommend to either do a 5.3.1

Re: Review Request 109549: port KRun away from KProcess

2013-03-17 Thread Rolf Eike Beer
/#comment21955 Whitespacing around braces is inconsistent. kio/kio/krun.cpp http://git.reviewboard.kde.org/r/109549/#comment21954 Trailing whitespace - Rolf Eike Beer On March 17, 2013, 4:19 p.m., Martin Tobias Holmedahl Sandsmark wrote