Re: Review Request 125976: add an update() method

2015-11-07 Thread Sebastian Kügler
e API, OK, but the code here is getting really convoluted that I think another boolean trap won't help... src/kpackage/private/versionparser.cpp (line 25) <https://git.reviewboard.kde.org/r/125976/#comment60462> I think we can remove most of these includes? - S

Re: Review Request 125750: Reduce some allocations

2015-10-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125750/#review87237 --- Ship it! Ship It! - Sebastian Kügler On Oct. 22, 2015, 2

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

2015-10-06 Thread Sebastian Kügler
and I personally think it's a useful thing.) -- sebas Sebastian Kügler | http://vizZzion.org | http://kde.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125527: Add mimeTypes() to KPluginMetaData

2015-10-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125527/#review86417 --- Ship it! Ship It! - Sebastian Kügler On Oct. 6, 2015, 10

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

2015-09-18 Thread Sebastian Kügler
> On Sept. 16, 2015, 9:44 p.m., Sebastian Kügler wrote: > > autotests/kpluginmetadatatest.cpp, line 110 > > <https://git.reviewboard.kde.org/r/125261/diff/1/?file=404287#file404287line110> > > > > Should be a list, so enclosed with [ ]. > > &

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

2015-09-16 Thread Sebastian Kügler
. autotests/kpluginmetadatatest.cpp (line 110) <https://git.reviewboard.kde.org/r/125261/#comment59108> Should be a list, so enclosed with [ ]. In the header docs, you also say "string", so maybe I'm overlooking something? - Sebastian Kügler On Sept. 16, 2015,

Re: Review Request 124846: i18n: Fix untranslatable string

2015-08-24 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124846/#review84260 --- Ship it! Ship It! - Sebastian Kügler On Aug. 24, 2015, 10

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-11 Thread Sebastian Kügler
marked as submitted. Review request for KDE Frameworks, Plasma, Alex Richardson, and David Faure. Changes --- Submitted with commit 6d82a824b3a7e5e87b4691439ecba064a75fa8a1 by Sebastian Kügler to branch master. Repository: kservice Description --- Parse formfactor in KService

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-11 Thread Sebastian Kügler
robust. About ksycocathreadtest: I just pushed many fixes for it, does it pass for you now? Sebastian Kügler wrote: My primary concern was to make sure FormFactors is not lost in conversion. Adding API in KPluginInfo was more a side-effect of this (for symmetry reasons

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-06 Thread Sebastian Kügler
--- On Aug. 5, 2015, 10:41 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633

Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-05 Thread Sebastian Kügler
(also in master without this patch). Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt version requirement in KF 5.13

2015-07-29 Thread Sebastian Kügler
?), and by the fact that Qt 5.3 was released more than a year ago. +1 -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 124306: Don't choke on empty QIconItem

2015-07-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/#review82276 --- Ship it! Ship It! - Sebastian Kügler On July 9, 2015, 2

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

2015-07-06 Thread Sebastian Kügler
://git.reviewboard.kde.org/r/124066/#review82057 --- On June 29, 2015, 10:44 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

2015-06-29 Thread Sebastian Kügler
On June 22, 2015, 5:01 p.m., Sebastian Kügler wrote: ping. ping.. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124066/#review81661

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

2015-06-29 Thread Sebastian Kügler
marked as submitted. Review request for KDE Frameworks, Alex Richardson and David Faure. Changes --- Submitted with commit 499c15cccea14f97114a06a64082ac57660926bf by Sebastian Kügler to branch master. Repository: kcoreaddons Description --- This patch adds X-KDE-FormFactor

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

2015-06-22 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124066/#review81661 --- ping. - Sebastian Kügler On June 17, 2015, 11 p.m

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-20 Thread Sebastian Kügler
On June 20, 2015, 7:10 p.m., Martin Klapetek wrote: +1 for adding all that info -1 for putting it into its own tab; previously it was visible right away, now an additional click is needed. Maybe it could be stacked all under the application name? I mean it's just 2 more lines to add

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-19 Thread Sebastian Kügler
. - Sebastian Kügler On June 20, 2015, 4:30 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

2015-06-17 Thread Sebastian Kügler
, also implemented using this in the Plasma Active settings app as proof-of-concept, works like a charm. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

2015-06-17 Thread Sebastian Kügler
and every app needs to add their keys to the code :( Alex Richardson wrote: Possibly we should let desktopfileparser read a servicetype file? Was also suggested here: https://git.reviewboard.kde.org/r/121672/ Sebastian Kügler wrote: So it has to look in standardpaths and somewhere

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-17 Thread Sebastian Kügler
on the CMake foo, however. - Sebastian Kügler On June 18, 2015, 1:19 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

2015-06-17 Thread Sebastian Kügler
-mail. To reply, visit: https://git.reviewboard.kde.org/r/124066/#review81520 --- On June 11, 2015, 4:16 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

2015-06-16 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124066/#review81519 --- pingpong? :) - Sebastian Kügler On June 11, 2015, 4:16 a.m

Review Request 124066: Recognize X-KDE-FormFactor as stringlist

2015-06-10 Thread Sebastian Kügler
://git.reviewboard.kde.org/r/124066/diff/ Testing --- added autotest, also implemented using this in the Plasma Active settings app as proof-of-concept, works like a charm. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

2015-06-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124066/#review81373 --- On June 11, 2015, 4:16 a.m., Sebastian Kügler wrote

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-06-05 Thread Sebastian Kügler
QString directory, const QString pluginId)`? Do we also need the function that returns a vector for a given ID? Sebastian Kügler wrote: At least our changes in libplasma need a QVectorKPluginMetaData. Otherwise, a list seems easy enough to check if something's found. Returning a single

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-06-05 Thread Sebastian Kügler
marked as submitted. Review request for KDE Frameworks, Alex Richardson and David Faure. Changes --- Submitted with commit 42bed7bb3b9eeacfa447c110f89aa8b4e9564b11 by Sebastian Kügler to branch master. Repository: kcoreaddons Description --- Add findPluginsById convenience API It's

Re: changelog for 5.10

2015-05-11 Thread Sebastian Kügler
On Monday, May 11, 2015 00:48:37 David Faure wrote: On Saturday 09 May 2015 13:00:54 Sebastian Kügler wrote: On Saturday, May 09, 2015 13:06:57 David Faure wrote: On Saturday 09 May 2015 12:52:52 Albert Astals Cid wrote: For the notification aspect of it, I think. The text is up

Re: changelog for 5.10

2015-05-09 Thread Sebastian Kügler
On Saturday, May 09, 2015 13:06:57 David Faure wrote: On Saturday 09 May 2015 12:52:52 Albert Astals Cid wrote: Why do we need a blog if we have an announcement? https://www.kde.org/announcements/kde-frameworks-5.10.0.php For the notification aspect of it, I think. The text is up there,

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-05-07 Thread Sebastian Kügler
QString directory, const QString pluginId)`? Do we also need the function that returns a vector for a given ID? Sebastian Kügler wrote: At least our changes in libplasma need a QVectorKPluginMetaData. Otherwise, a list seems easy enough to check if something's found. Returning a single

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-07 Thread Sebastian Kügler
/plasmacomponents/qml/private/TabBarLayout.qml (line 197) https://git.reviewboard.kde.org/r/123626/#comment54913 This line may have slipped in? - Sebastian Kügler On May 7, 2015, 9:06 a.m., Marco Martin wrote: --- This is an automatically

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-05-07 Thread Sebastian Kügler
., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123669/ --- (Updated May 6, 2015, 11:21 p.m.) Review

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-05-07 Thread Sebastian Kügler
--- On May 6, 2015, 11:21 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123669

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Sebastian Kügler
? src/plasmapkg/plasmapkg.cpp (line 581) https://git.reviewboard.kde.org/r/123626/#comment54879 This can now be const - Sebastian Kügler On May 6, 2015, 5:21 p.m., Marco Martin wrote: --- This is an automatically generated e-mail

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Sebastian Kügler
On May 6, 2015, 5:38 p.m., Hrvoje Senjan wrote: I would keep this for safety until Plasma 5.4 is released, then try to remove it again First, sorry for being the bad cop, i'd just like to avoid any future (irreversible) problems, and that distros delivering monthly KF5 updates

Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-05-06 Thread Sebastian Kügler
, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Sebastian Kügler
On May 6, 2015, 10:54 p.m., Sebastian Kügler wrote: I've read and tested it, everything still works nicely. Good job! I like how the patch moves much of the query language into simple C++, avoids a lot of query parsing and moves some of the error paths to compile time. https

Re: Review Request 123570: Add a method to insert new known structures

2015-05-04 Thread Sebastian Kügler
://git.reviewboard.kde.org/r/123570/#comment54677 suck as - such as src/kpackage/packageloader.h (line 93) https://git.reviewboard.kde.org/r/123570/#comment54678 suck as :) Typos in the docs, otherwise +2. - Sebastian Kügler On April 30, 2015, 9:31 a.m., Marco Martin wrote

Re: Versioning of Frameworks

2015-04-30 Thread Sebastian Kügler
On Wednesday, April 29, 2015 21:45:14 David Faure wrote: but they don't realize when writing QSignalSpy(obj, Class::member) that this syntax wasn't available in Qt 5.2. I wasn't aware that this has been added, very useful. Thanks! :-) -- sebas http://www.kde.org | http://vizZzion.org |

Re: Review Request 123556: KPackage::findPackages with a filter callback

2015-04-29 Thread Sebastian Kügler
) https://git.reviewboard.kde.org/r/123556/#comment54489 api docs, including @since - Sebastian Kügler On April 29, 2015, 10:51 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 123478: ensure the filePath metadata is there

2015-04-23 Thread Sebastian Kügler
on metadata.desktop always being there, this changes makes my life so much easier. - Sebastian Kügler On April 23, 2015, 2:34 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 123402: Moves away from KService

2015-04-20 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123402/#review79253 --- Looks good. +1 - Sebastian Kügler On April 17, 2015, 3:45

Re: KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread Sebastian Kügler
Sebastian Kügler|http://vizZzion.org| http://kde.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123298: Add option to show metadata of an .so file to desktoptojson

2015-04-13 Thread Sebastian Kügler
/diff/ Testing --- Tested the tool on various libraries, all show the expected data Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123298: Add option to show metadata of an .so file to desktoptojson

2015-04-13 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123298/#review78752 --- On April 8, 2015, 3:17 p.m., Sebastian Kügler wrote: --- This is an automatically

Review Request 123298: Add option to show metadata of an .so file to desktoptojson

2015-04-08 Thread Sebastian Kügler
data Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122799: Simple fix for huge icon sizes on some monitors

2015-03-04 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122799/#review76986 --- Ship it! Neat and minimal! - Sebastian Kügler On March 4

Re: Review Request 122795: Fix crashes when attempting to load invalid package

2015-03-04 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122795/#review76987 --- Ship it! Ship It! - Sebastian Kügler On March 3, 2015, 7

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-03-04 Thread Sebastian Kügler
://git.reviewboard.kde.org/r/122667/#comment52955 stray space tests/helloworld/contents/ui/main.qml https://git.reviewboard.kde.org/r/122667/#comment52956 stray trailing space - Sebastian Kügler On March 3, 2015, 7:29 p.m., Marco Martin wrote

Re: Review Request 122733: Fix path traversal checks in KPackage

2015-03-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/#review76933 --- Ship it! Very nice. :) - Sebastian Kügler On Feb. 26

Re: Review Request 121317: Add JSON metadata to the kded modules

2015-02-28 Thread Sebastian Kügler
: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/ --- (Updated Feb. 27, 2015, 11:35 p.m.) Review request for KDE Frameworks, David Faure and Sebastian Kügler

Re: Review Request 121317: Add JSON metadata to the kded modules

2015-02-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/#review76764 --- Ship it! Ship It! - Sebastian Kügler On Feb. 27, 2015, 11

Re: Review Request 122706: A KCModule base for QML based KCMs

2015-02-25 Thread Sebastian Kügler
On Feb. 24, 2015, 10:59 a.m., David Edmundson wrote: src/kcmoduleqml.h, line 36 https://git.reviewboard.kde.org/r/122706/diff/3/?file=351295#file351295line36 When we do make a QML only system settings we're not going to want to use KCMModule at all, even if it's not shown?

Re: Warning: KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated

2015-02-21 Thread Sebastian Kügler
burying any useful information during the startup of Plasmashell. I think the warning is rather useless, and I'd just remove it, so 2). Cheers, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ Kde-frameworks-devel mailing

Re: Warning: KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated

2015-02-21 Thread Sebastian Kügler
. That's completely fine. We're not too much in a hurry, it's not a showstopper by any means, just some janitorial work to make Plasma a bit easier to debug. Currently, about 2/3 of its console output consists of these messages. Thanks, Alex! -- sebas Sebastian Kügler|http://vizZzion.org

Re: Review Request 122619: [KPluginMetaData] Add support for Hidden key

2015-02-20 Thread Sebastian Kügler
cases work * Tried to hide a KPackage by adding a Hidden=true to the metadata.desktop file Both work as expected with this patch. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Build failed in Jenkins: kcoreaddons_master_qt5 #217

2015-02-20 Thread Sebastian Kügler
] Error 1 make[1]: *** [autotests/CMakeFiles/kpluginmetadatatest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs Just pushed a fix for this, sorry for the noise. -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org

Review Request 122619: [KPluginMetaData] Add support for Hidden key

2015-02-18 Thread Sebastian Kügler
work as expected with this patch. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121922: support stringlists as properties

2015-02-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121922/#review75765 --- Ship it! Ship It! - Sebastian Kügler On Jan. 12, 2015, 7

Re: Fixing and regulating certain types of search fields across KF5 apps

2015-02-10 Thread Sebastian Kügler
On Monday, February 09, 2015 13:12:24 Jeremy Whiting wrote: The way I'd like to see this fixed is placing an API like isMinimumSearchableLength(QString) somewhere in KF5 and to start using it everywhere. Realistically developers won't find this on their own, but it means I could go around

Re: Fixing and regulating certain types of search fields across KF5 apps

2015-02-10 Thread Sebastian Kügler
On Monday, February 09, 2015 13:12:24 Jeremy Whiting wrote: The way I'd like to see this fixed is placing an API like isMinimumSearchableLength(QString) somewhere in KF5 and to start using it everywhere. Realistically developers won't find this on their own, but it means I could go around

Re: Review Request 120185: Look for kdesu in the correct location

2015-02-09 Thread Sebastian Kügler
any objections, please push this as it solves a real problem. - Sebastian Kügler On Oct. 4, 2014, 3:32 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 122401: KPluginInfo: delegate to KPluginMetaData for reading the .desktop files

2015-02-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122401/#review75293 --- Ship it! Ship It! - Sebastian Kügler On Feb. 3, 2015, 9

Re: reviving make uninstall?

2015-01-29 Thread Sebastian Kügler
On Thursday, January 29, 2015 00:32:08 Martin Klapetek wrote: It's only used by developers anyways, so why bother? If it makes life simpler for devs, it should be there, no? Normal users who might get confused by it won't ever run make (un)install either, no? +1. I found myself many

Re: Review Request 122235: --version: Change KDE Development Platform to KDE Frameworks

2015-01-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122235/#review74911 --- Ship it! Ship It! - Sebastian Kügler On Jan. 24, 2015, 2

Re: Review Request 121922: support stringlists as properties

2015-01-08 Thread Sebastian Kügler
to solve the same problem. - Sebastian Kügler On Jan. 8, 2015, 2:24 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121922

Re: Baloo Framework - License Exception

2015-01-05 Thread Sebastian Kügler
Hi, On Sunday, January 04, 2015 11:23:49 David Faure wrote: On Tuesday 16 December 2014 14:02:18 Sebastian Kügler wrote: - If it's effectively GPL-licensed, it should not be a proper Framework I would like to challenge this reasoning. It seems to me that the premise is: * we need baloo

Re: Baloo Framework - License Exception

2015-01-05 Thread Sebastian Kügler
On Monday, January 05, 2015 19:04:43 David Faure wrote: On Monday 05 January 2015 16:11:21 David Edmundson wrote: Maybe we could all agree to let Kevin Krammer (as I understand it, the current head of frameworks) to make a tough executive decision based on the thoughts people have had

Re: Baloo Framework - License Exception

2014-12-16 Thread Sebastian Kügler
On Monday, December 15, 2014 19:48:30 Ivan Čukić wrote: If we make Baloo GPL and then happen to change the database used we would have to relicense all of Baloo. That would be a lot of admin work contacting all developers. I'm not advocating changing the library headers to GPL*, just not

Re: KF 5.6 and Plasma 5.2

2014-12-15 Thread Sebastian Kügler
On Sunday, December 14, 2014 01:04:53 David Edmundson wrote: That's the plan. Plasma releases have already been shifted to account for that. Plasma 5.2 Beta is being tagged on the 8th of Jan, releasing on the 13th. Frameworks are released in the first week of every month. I believe we're

Re: Baloo Framework - License Exception

2014-12-15 Thread Sebastian Kügler
Hi, On Monday, December 15, 2014 10:34:46 Jonathan Riddell wrote: On Mon, Dec 15, 2014 at 09:27:48AM +0100, Martin Gräßlin wrote: Baloo is still LGPL, when you aggregate it current Xapian code the result becomes GPL, but I could write something different with the same header

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-10 Thread Sebastian Kügler
On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: Wasn't that part of the idea? Having it scale up the pixmap first when resizing and then re-rendering it later? Xuetian Weng wrote: 1. icon size (the widget size) doesn't change frequently. Usually it only happens when user

Re: Review Request 121308: Do not require KPluginMetaData::fileName() to always be absolute

2014-12-01 Thread Sebastian Kügler
for a bit so others can look over it as well. - Sebastian Kügler On Dec. 1, 2014, 12:37 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121308

Re: Review Request 121305: convert to new signal slot syntax and categorized logging

2014-12-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121305/#review71178 --- Ship it! Ship It! - Sebastian Kügler On Dec. 1, 2014, 11

Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file

2014-12-01 Thread Sebastian Kügler
: https://git.reviewboard.kde.org/r/121122/diff/ Testing --- Added an autotest which compares a KPluginMetaData object created from a desktop file. Also used this code from kpackage. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing

Re: Review Request 121313: Introduce KPluginMetaData::metaDataSource()

2014-12-01 Thread Sebastian Kügler
. src/lib/plugin/kpluginmetadata.h https://git.reviewboard.kde.org/r/121313/#comment49737 metaDataFileName() would be more synchronous with the matching ctor and the fileName() accessor - Sebastian Kügler On Dec. 1, 2014, 3:59 p.m., Alexander Richardson wrote

Re: Review Request 121314: KPluginInfo: store d-entryPath in KPluginMetaData instead

2014-12-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121314/#review71200 --- Ship it! Nice! - Sebastian Kügler On Dec. 1, 2014, 4:26

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

2014-11-18 Thread Sebastian Kügler
. Thanks! - Sebastian Kügler On Nov. 9, 2014, 4:10 p.m., Armin K. wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084

Re: Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

2014-11-18 Thread Sebastian Kügler
/121086/#comment49407 whitespace What I'm missing is migration of the setting, is that relevant, any other reason why it's missing? - Sebastian Kügler On Nov. 9, 2014, 4:09 p.m., Armin K. wrote: --- This is an automatically

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-17 Thread Sebastian Kügler
, 2014 14:13:39 Milian Wolff wrote: On Thursday 06 November 2014 03:44:58 Sebastian Kügler wrote: Hi all, especially Alex and David, tl;dr: I've done a proof-of-concept implementation of a metadata index for KPluginTrader::query(), the main entry point when it comes to finding binary

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-17 Thread Sebastian Kügler
Hi David, On Sunday, November 16, 2014 18:10:27 David Faure wrote: Cool that you're looking into this. On Thursday 06 November 2014 03:44:58 Sebastian Kügler wrote: - a small tool called kplugin-update-index collects the json metadata from the plugins, and puts the list of plugins

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-16 Thread Sebastian Kügler
On Thursday, November 06, 2014 17:06:38 Mark Gaiser wrote: Ah right, i think i missed the I/O reducing goal in your initial post. I haven't checked your draft implementation in detail, but what you might want to do is: - Monitor all plugin folders for changes - If a change in any of the

Review Request 121122: Allow loading KPluginMetaData from a .desktop file

2014-11-14 Thread Sebastian Kügler
/plugin/desktopfileparser.cpp PRE-CREATION src/lib/plugin/kpluginmetadata.h 67b68a50225e8ac82706caa849fb330567cee1d2 src/lib/plugin/kpluginmetadata.cpp f3e68c927370ad9212e8dfc07677ec17c52fdbdd Diff: https://git.reviewboard.kde.org/r/121122/diff/ Testing --- Thanks, Sebastian Kügler

Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file

2014-11-14 Thread Sebastian Kügler
://git.reviewboard.kde.org/r/121122/diff/ Testing (updated) --- Added an autotest which compares a KPluginMetaData object created from a desktop file. Also used this code from kpackage. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 121100: Add qCDebug statements back into knewstuff sources.

2014-11-11 Thread Sebastian Kügler
/#comment49100 unrelated to this patch, but this looks quite fishy, yet easy to fix. tests/knewstuff2_test.cpp https://git.reviewboard.kde.org/r/121100/#comment49101 WTF? (Unrelated, yes.) - Sebastian Kügler On Nov. 11, 2014, 2:42 a.m., Jeremy Whiting wrote

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-11 Thread Sebastian Kügler
Hi Nicolas, Sorry for my late reply, I thought I had replied, but apparently that was never sent. :/ On Thursday, November 06, 2014 16:26:01 Nicolás Alvarez wrote: 2014-11-05 23:44 GMT-03:00 Sebastian Kügler se...@kde.org: So, this code is in a bit of a draft stage, I'd very much welcome

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-06 Thread Sebastian Kügler
On Thursday, November 06, 2014 10:09:51 Mark Gaiser wrote: I'm curious about one thing. Have you done some profiling on the current KPluginMetaData to see where the actual hot spot is? In case you don't know how to do that, here are some tips: 1. Recompile Qt with debug symbols (not debug

[RFC] [kservice] KPluginMetadata indexing

2014-11-05 Thread Sebastian Kügler
Hi all, especially Alex and David, tl;dr: I've done a proof-of-concept implementation of a metadata index for KPluginTrader::query(), the main entry point when it comes to finding binary plugins. This index considerably speeds up all current use cases, but comes at the cost of having to

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

2014-10-21 Thread Sebastian Kügler
, but I've been reworking some bits to use KPluginMetaData, and in that process, it broke. I'm working on it. :) - Sebastian Kügler On Sept. 14, 2014, 2:05 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail

Re: Review Request 120586: Fix KPluginSelector not adding non .desktop file plugins

2014-10-21 Thread Sebastian Kügler
is an implementation detail that should not be reflected in the API's usage. - Sebastian Kügler On Oct. 14, 2014, 6:52 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Initial standalone Plasma::Package repository

2014-09-17 Thread Sebastian Kügler
On Wednesday, September 17, 2014 11:20:10 Marco Martin wrote: On Wednesday 17 September 2014 11:06:50 Martin Gräßlin wrote: Is the name ok for everybody? potential name clashes? as it used to be namespaces before, what about using a namespace KPackage and just call the classes:

Re: Review Request 120058: Move imagethumbnailer away from KDE4Support

2014-09-04 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120058/#review65808 --- Ship it! Ship It! - Sebastian Kügler On Sept. 4, 2014, 3

Re: Compression of SVG(Z)s in git repositories

2014-09-03 Thread Sebastian Kügler
On Tuesday, September 02, 2014 16:50:35 Elias Probst wrote: On 09/02/2014 12:48 PM, Martin Gräßlin wrote: On Tuesday 02 September 2014 12:27:11 Sebastian Kügler wrote: On Monday, September 01, 2014 12:59:04 Elias Probst wrote: Compressed SVG files are way faster to read (it's faster

Re: Compression of SVG(Z)s in git repositories

2014-09-03 Thread Sebastian Kügler
On Wednesday, September 03, 2014 13:50:01 Milian Wolff wrote: On Wednesday 03 September 2014 13:35:00 Sebastian Kügler wrote: On Tuesday, September 02, 2014 16:50:35 Elias Probst wrote: On 09/02/2014 12:48 PM, Martin Gräßlin wrote: Exactly. This might make sense to be placed in ECM

Re: Compression of SVG(Z)s in git repositories

2014-09-02 Thread Sebastian Kügler
On Monday, September 01, 2014 12:59:04 Elias Probst wrote: I've noticed, that (except of only a very few) nearly all SVG files are committed as SVGZ to our git repositories. This has IMHO several drawbacks: - every change will be stored as a single atomic blob - git's internal packfile

Re: [Kde-pim] split kdepimlibs

2014-08-28 Thread Sebastian Kügler
On Thursday, August 28, 2014 11:46:02 Kevin Krammer wrote: We also have Akademy and the sprint scheduled for November (?) at which we could sit down and methodically work through the list of everything and figure out what to do. I agree, it makes little sense to rush this before Akademy.

Re: Review Request 119884: Add cursor shape property to MouseEventListener

2014-08-22 Thread Sebastian Kügler
/mouseeventlistener.h https://git.reviewboard.kde.org/r/119884/#comment45448 ws src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp https://git.reviewboard.kde.org/r/119884/#comment45449 accolades, please - Sebastian Kügler On Aug. 21, 2014, 3:17 p.m., David Edmundson wrote

Re: How to promote less mature Frameworks?

2014-08-19 Thread Sebastian Kügler
On Tuesday, August 19, 2014 09:33:07 Kevin Ottens wrote: Wouldn't early adopters just checkout and build from git ? Well, I guess some of them might just want to grab something and run with it. Maybe not the majority indeed... I think in this case we want to encourage picking it from Git,

Re: How to promote less mature Frameworks?

2014-08-18 Thread Sebastian Kügler
On Friday, August 15, 2014 12:51:58 Kevin Ottens wrote: And that's the problem if we release them. If it's released with the rest expect people to have wrong expectations about them. A possibility would be perhaps to produce nightly tarballs for those frameworks which don't have the

<    1   2   3   4   5   >