D21855: [IdUtils] Fix aliasing warning

bruns added a reviewer: thiago. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21855 To: bruns, #baloo, ngraham, astippich, poboiko, thiago Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21855: [IdUtils] Fix aliasing warning

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY memcpy with a small fixed size is optimized by all

D21844: [WriteTransactionTest] Clear mixup of QString and QByteArray

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY touchFile expects a QString argument, not QByteArray. Use

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY All users of TermGenerator::termList do not use QStrings

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. In D20967#480338 , @bcooksley wrote: > Please note that there are very few people involved with Windows builds (despite the number of projects that make use of them in general) so people may not always have the ability

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. #windows - thanks for ignoring every review request! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: bcooksley, arrowd, #freebsd,

D21835: [PostingIterator] Move positions() method to VectorPositionInfoIterator

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The positions() method is only used inside the

D21830: Format photo exposure bias value

bruns added inline comments. INLINE COMMENTS > formatstrings.cpp:193 > +return i18nc("Exposure bias/compensation in exposure value (EV)", > "%1 EV", locale.toString(val, 'g', 3)); > +} else { > +int integral = roundedSixthParts / 6; no need for else here, you return. dito

D21830: Format photo exposure bias value

bruns added inline comments. INLINE COMMENTS > formatstrings.cpp:183 > +auto val = value.toDouble(); > +// exposure values are in steps of one third, divide by it > +auto thirds = val * 3; You obviously multiply here ... REPOSITORY R286 KFileMetaData REVISION DETAIL

D21830: Format photo exposure bias value

bruns added a comment. In D21830#480185 , @astippich wrote: > In D21830#480181 , @bruns wrote: > > > Many cameras can be switched to 1/2 EV steps. > > > Damn ;) do you know any other values?

D21830: Format photo exposure bias value

bruns added a comment. Many cameras can be switched to 1/2 EV steps. INLINE COMMENTS > formatstrings.cpp:189 > +int wholeNumber = roundedThirds / 3; > +if (wholeNumber > 0) { > +return i18nc("Exposure compensation given in thirds, with whole > number, in exposure

D21809: [PendingFileQueueTest] Verify create + delete do not emit extra events

This revision was automatically updated to reflect the committed changes. Closed by commit R293:bb011d2fc034: [PendingFileQueueTest] Verify create + delete do not emit extra events (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21807: [PendingFileQueueTest] Verify delete + create actually works

This revision was automatically updated to reflect the committed changes. Closed by commit R293:309518239d77: [PendingFileQueueTest] Verify delete + create actually works (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21807?vs=59827=59868

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

This revision was automatically updated to reflect the committed changes. Closed by commit R293:9b0ecc5d41b0: [PendingFileQueue] Avoid delete + create / create + delete race (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21709?vs=59473=59867#toc REPOSITORY R293

D21788: Make Plasma::Svg::elementRect a bit leaner

bruns added inline comments. INLINE COMMENTS > apol wrote in svg.cpp:123 > pcre2 does it, AFAIK. Benchmark tells `const static` is faster: F6890682: qre_bench.cpp REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D21807: [PendingFileQueueTest] Verify delete + create actually works

bruns added a dependent revision: D21809: [PendingFileQueueTest] Verify create + delete do not emit extra events. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21807 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson,

D21809: [PendingFileQueueTest] Verify create + delete do not emit extra events

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY When a file has been deleted, a modified event should

D21807: [PendingFileQueueTest] Verify delete + create actually works

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY A create event should not be merged with a immediately

D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b2ebaf5293f1: [PendingFileQueueTest] Use synthetic timer events to speedup test (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21707: [XAttrIndexer] Update DocumentTime when XAttrs are updated

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a58296b2aa21: [XAttrIndexer] Update DocumentTime when XAttrs are updated (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21707?vs=59471=59821

D21792: [PendingFileQueue] Refactor for easier and faster unit testing

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b359101424d8: [PendingFileQueue] Refactor for easier and faster unit testing (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21792?vs=59769=59820

D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time

This revision was automatically updated to reflect the committed changes. Closed by commit R293:25ae93a560aa: [PendingFileQueueTest] Shorten timeouts, verify tracking time (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21791?vs=59768=59819

D21790: [PendingFileQueue] Use more accurate calculation of remaining time

This revision was automatically updated to reflect the committed changes. Closed by commit R293:bf100941db29: [PendingFileQueue] Use more accurate calculation of remaining time (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21788: Make Plasma::Svg::elementRect a bit leaner

bruns added inline comments. INLINE COMMENTS > apol wrote in svg.cpp:123 > static isn't necessary, QRegularExpression already has internal regex > compilation optimisations we can leverage. > Does the assert bother you? Are you sure about this? As far as I can see:

D21788: Make Plasma::Svg::elementRect a bit leaner

bruns added inline comments. INLINE COMMENTS > svg.cpp:123 > +QRegularExpression > idExpr(QLatin1String("id\\s*?=\\s*?(['\"])(\\d+?-\\d+?-.*?)\\1")); > +Q_ASSERT(idExpr.isValid()); > Are you sure you uploaded the right diff? No const static, Q_ASSERT ... REPOSITORY R242 Plasma

D20967: [UserMetaData] Add method to query which attributes are set

This revision was automatically updated to reflect the committed changes. Closed by commit R286:bbb05dfe7f9f: [UserMetaData] Add method to query which attributes are set (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. FreeBSD and WIndows folks had their chance to speak up - Windows will just have to wait for the CI ... FreeBSD has been reviewed, @arrowd - Thanks! REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns,

D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time

bruns edited the summary of this revision. bruns added a dependency: D21790: [PendingFileQueue] Use more accurate calculation of remaining time. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21791 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel,

D21790: [PendingFileQueue] Use more accurate calculation of remaining time

bruns added a dependent revision: D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21790 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov,

D21792: [PendingFileQueue] Refactor for easier and faster unit testing

bruns added a dependent revision: D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21792 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov,

D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test

bruns edited the summary of this revision. bruns added a dependency: D21792: [PendingFileQueue] Refactor for easier and faster unit testing. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21793 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel,

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

bruns added a comment. In D21709#477608 , @ngraham wrote: > LGTM, but maybe an autotest might make sense for this case. I have submitted some preliminary changes to make this more feasible. The current autotest structure is not really

D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Waiting 5 seconds until the pending file queue has been

D21792: [PendingFileQueue] Refactor for easier and faster unit testing

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Supply the current time as an argument to the slots, so

D21790: [PendingFileQueue] Use more accurate calculation of remaining time

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY QTime::secsTo completely ignores any fractional

D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY There is no need to wait 2 seconds until the file is

D21788: Make Plasma::Svg::elementRect a bit leaner

bruns added a comment. Please put the dead code removal in a separate review. INLINE COMMENTS > svg.cpp:111 > const QString contentsAsString(QString::fromLatin1(contents)); > -QRegExp idExpr(QLatin1String("id\\s*=\\s*(['\"])(\\d+-\\d+-.*)\\1")); > +static QRegExp >

D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed

This revision was automatically updated to reflect the committed changes. Closed by commit R293:4fcbfee9b669: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D11587: [WIP] autotests: Introduce TermGeneratorTestUTF

bruns added a comment. queryparsertest.cpp and termgeneratortest.cpp no longer contain iso8859-* sequences, but only escaped UTF-8 sequences, see D17161 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11587 To: michaelh, #baloo,

D17816: Support for xattrs on kio copy/move

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks Cc: cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson,

D17816: Support for xattrs on kio copy/move

bruns added a comment. There are several comments not addressed yet ... INLINE COMMENTS > copyxattrjob.cpp:125 > +m_keyList.removeLast(); // the last item is alwys empty > +for (const auto & key : m_keyList) { > +// get the size of key value `qAsConst(m_keyList)` >

D8532: [WIP] Restrict file extractor with Seccomp

bruns added a comment. I totally agree with fvogt here - the extractors should just receive a readonly file descriptor. For this, there are several steps required: 1. let the extractors work with file descriptors (KFileMetaData) 2. make sure the extractor plugins are fully

D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed

bruns marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21706 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed

bruns updated this revision to Diff 59564. bruns marked an inline comment as done. bruns added a comment. update comment REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21706?vs=59470=59564 REVISION DETAIL https://phabricator.kde.org/D21706 AFFECTED FILES

D21731: [NewFileIndexer] Omit symlinks from the index

This revision was automatically updated to reflect the committed changes. Closed by commit R293:7b93ced321fc: [NewFileIndexer] Omit symlinks from the index (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21731?vs=59546=59563 REVISION DETAIL

D21731: [NewFileIndexer] Omit symlinks from the index

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REPOSITORY R293 Baloo BRANCH cleanup REVISION DETAIL

D21708: [ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes

This revision was automatically updated to reflect the committed changes. Closed by commit R293:00c75845ba43: [ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21705: [NewFileIndexer] Use correct mimetype for folders, check excludeFolders

This revision was automatically updated to reflect the committed changes. Closed by commit R293:287d88c8becf: [NewFileIndexer] Use correct mimetype for folders, check excludeFolders (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21680: [UnindexedFileIndexer] Pick up comment, tags and rating changes

This revision was automatically updated to reflect the committed changes. Closed by commit R293:0760b1261237: [UnindexedFileIndexer] Pick up comment, tags and rating changes (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

This revision was automatically updated to reflect the committed changes. Closed by commit R293:ecc28c314e1a: [UnindexedFileIndexer] Skip filetime checks for new files (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21577?vs=59147=59541

D21694: [DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename

This revision was automatically updated to reflect the committed changes. Closed by commit R293:7edec3499cbc: [DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21693: [DocumentUrlDB] Catch invalid URLs early

This revision was automatically updated to reflect the committed changes. Closed by commit R293:8e7b54c54764: [DocumentUrlDB] Catch invalid URLs early (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21693?vs=59451=59539 REVISION DETAIL

D21692: [DocumentUrlDB] Remove unused 'rename' method

This revision was automatically updated to reflect the committed changes. Closed by commit R293:4883ac516d5f: [DocumentUrlDB] Remove unused rename method (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21692?vs=59448=59538 REVISION DETAIL

D21674: [balooctl] Streamline indexer control commands

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b54f8ec94ac2: [balooctl] Streamline indexer control commands (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21674?vs=59411=59537 REVISION

D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > poboiko wrote in modifiedfileindexer.cpp:68 > Does it also changes behavior of ModifiedFileIndexer? What happened to > symlinks before? It depends on the state of the PendingFileQueue: - when an item is not

D21671: [FileIndexScheduler] Stop the indexer when quit() is called via DBus

bruns added a comment. Yes, mostly - the "after the current batch" caveat applies, so there may be still some delay. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21671 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson,

D21703: [Transaction] Replace template for functor with std::function

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5b6fd8fe88b7: [Transaction] Replace template for functor with std::function (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21703?vs=59467=59512

D21703: [Transaction] Replace template for functor with std::function

bruns added a comment. In D21703#477158 , @poboiko wrote: > I thought about it myself. I googled it a bit (i.e. here ) and saw that there might be some quite unwanted runtime

D20967: [UserMetaData] Add method to query which attributes are set

bruns marked 6 inline comments as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: arrowd, #freebsd, #windows, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun,

D20967: [UserMetaData] Add method to query which attributes are set

bruns updated this revision to Diff 59509. bruns added a comment. initialize pos REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20967?vs=59505=59509 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 AFFECTED FILES

D21704: [FirstRunIndexer] Use correct mimetype for folders

This revision was automatically updated to reflect the committed changes. Closed by commit R293:cb5621bb0dd7: [FirstRunIndexer] Use correct mimetype for folders (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21704?vs=59468=59508 REVISION

D21698: Move invariant IndexingLevel out of the loop

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b41afe1dc243: Move invariant IndexingLevel out of the loop (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21698?vs=59455=59507 REVISION DETAIL

D21697: [BasicIndexingJob] Skip lookup of baloo document type for directories

This revision was automatically updated to reflect the committed changes. Closed by commit R293:9283a7e06cae: [BasicIndexingJob] Skip lookup of baloo document type for directories (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D20967: [UserMetaData] Add method to query which attributes are set

bruns updated this revision to Diff 59505. bruns added a comment. add and use split helper for BSD REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20967?vs=59502=59505 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 AFFECTED

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. In D20967#477318 , @arrowd wrote: > PASS : UserMetaDataWriterTest::initTestCase() > QDEBUG : UserMetaDataWriterTest::test() extattr_list size: 14 > QDEBUG : UserMetaDataWriterTest::test() extattr_list size: 14

D21720: Enable usermetadatawritertest for all UNIXes, not only Linux.

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Also matches Linux REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D21720 To: arrowd, #frameworks, bruns Cc: kde-frameworks-devel, #baloo,

D20967: [UserMetaData] Add method to query which attributes are set

bruns added inline comments. INLINE COMMENTS > xattr_p.h:206 > +#endif > + > +if (size == 0) { @arrowd - please add a `qDebug() << "extattr_list size:" << size;` here > xattr_p.h:232 > +const ssize_t r = extattr_list_file(encodedPath, > EXTATTR_NAMESPACE_USER, data.data(),

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. Apparently, the usermetadatawritertest was not executed on *BSD before, can you check if the test succeeds on the old code? Please submit a PR with the Linux -> UNIX change, and make this one a dependency of it. REPOSITORY R286 KFileMetaData REVISION DETAIL

D20967: [UserMetaData] Add method to query which attributes are set

bruns updated this revision to Diff 59502. bruns added a comment. update since REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20967?vs=59500=59502 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 AFFECTED FILES

D20967: [UserMetaData] Add method to query which attributes are set

bruns marked 2 inline comments as done. bruns added inline comments. INLINE COMMENTS > arrowd wrote in xattr_p.h:231 > Ditto. > > Also, `size` should be `r`, probably, see below. Why ditto? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns,

D20967: [UserMetaData] Add method to query which attributes are set

bruns updated this revision to Diff 59500. bruns added a comment. fix BSD code REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20967?vs=57390=59500 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 AFFECTED FILES

D21673: [FileIndexScheduler] Ensure indexer is not run in suspended state

This revision was automatically updated to reflect the committed changes. Closed by commit R293:dfefd66e6e75: [FileIndexScheduler] Ensure indexer is not run in suspended state (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21673?vs=59410=59499#toc REPOSITORY R293

D21672: [PowerStateMonitor] Be conservative when determining power state

This revision was automatically updated to reflect the committed changes. Closed by commit R293:0e6f1c923782: [PowerStateMonitor] Be conservative when determining power state (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21671: [FileIndexScheduler] Stop the indexer when quit() is called via DBus

This revision was automatically updated to reflect the committed changes. Closed by commit R293:d74d1cbb65db: [FileIndexScheduler] Stop the indexer when quit() is called via DBus (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21004: [UserMetaData] Shortcut attribute queries for the common case

bruns added a comment. Ping! REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D21004 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: domson, ashaposhnikov, astippich, spoorun, abrahams

D20967: [UserMetaData] Add method to query which attributes are set

bruns added subscribers: Windows, FreeBSD. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: #freebsd, #windows, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun,

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. Ping! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21002: Remove kde4 migration agent completely

bruns added a comment. Ping! REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham Cc: kde-frameworks-devel, damjang, LeGast00n, michaelh, ngraham, bruns

D21002: Remove kde4 migration agent completely

bruns added a reviewer: ngraham. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham Cc: kde-frameworks-devel, damjang, LeGast00n, michaelh, ngraham, bruns

D21708: [ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes

bruns edited the summary of this revision. bruns added a dependency: D21694: [DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21708 To: bruns, #baloo, ngraham, astippich, poboiko Cc:

D21694: [DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename

bruns added a dependent revision: D21708: [ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21694 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson,

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY When the 'delete' flag is set, the file was removed from

D21708: [ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The ModifiedFileIndexer updates the timestamps, which has

D21694: [DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename

bruns added a dependent revision: D21707: [XAttrIndexer] Update DocumentTime when XAttrs are updated. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21694 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov,

D21707: [XAttrIndexer] Update DocumentTime when XAttrs are updated

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY After modifying a files attributes (like ownership,

D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY mimeTypeForFile is quite expensive (much more than

D21705: [NewFileIndexer] Use correct mimetype for folders, check excludeFolders

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY mimeTypeForFile yields the wrong type for folders,

D21704: [FirstRunIndexer] Use correct mimetype for folders

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY mimeTypeForFile yields an incorrect mimetype for folders,

D21703: [Transaction] Replace template for functor with std::function

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The callback parameter has a specific type, it accepts a

D21698: Move invariant IndexingLevel out of the loop

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The IndexingLevel is constant, no need to fetch it on each

D21697: [BasicIndexingJob] Skip lookup of baloo document type for directories

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY typesForMimeType("inode/directory") returns an empty list,

D21694: [DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename

bruns retitled this revision from "[DocuementUrlDB] Avoid manipulation of the whole tree on trivial rename" to "[DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21694 To: bruns, #baloo, ngraham,

D21693: [DocumentUrlDB] Catch invalid URLs early

bruns updated this revision to Diff 59451. bruns edited the summary of this revision. bruns edited the test plan for this revision. bruns added a comment. split replace into private helper and wrapper REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21692: [DocumentUrlDB] Remove unused 'rename' method

bruns added a comment. In D21692#476804 , @shubham wrote: > Does this function had any use when it was first implemented? Or may it come to use later? Its last use was removed with commit 23f9a65c215b068dc87dddf7e81a74415d5cfb10

D21694: [DocuementUrlDB] Avoid manipulation of the whole tree on trivial rename

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case a file or folder is renamed, only the "name" in

D21693: [DocumentUrlDB] Catch invalid URLs early

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY DocumentUrlDB::replace calls DocumentUrlDB::put, which

D21692: [DocumentUrlDB] Remove unused 'rename' method

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY It is not used anywhere, so remove it. TEST PLAN still

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

bruns added a dependent revision: D21680: [UnindexedFileIndexer] Pick up comment, tags and rating changes. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21577 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov,

D21680: [UnindexedFileIndexer] Pick up comment, tags and rating changes

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY A folder should be reindexed (i.e. the terms should be

D21533: Format photo exposure time as rational when applicable

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH photo_time REVISION DETAIL https://phabricator.kde.org/D21533 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh,

<    1   2   3   4   5   6   7   8   9   10   >