D17071: Don't include any directory sizes in DirectorySizeJob

bruns added a comment. In D17071#461613 , @dfaure wrote: > I don't object to the patch, but maybe the properties dialog (and other users of this job) should indicate that the number being shown is "sum of file sizes, not actual disk space

D20995: [Fstab] Add support for non-network filesystems

bruns added inline comments. INLINE COMMENTS > hallas wrote in fstabhandling.cpp:126 > Yes indeed :D I was just wondering why it was made the way it is? Is there a > reason for the limit or was it just because we were only targeting vault type > mounts? fuse filesystems are just to different

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

bruns marked 2 inline comments as done. bruns added inline comments. INLINE COMMENTS > hallas wrote in fstabdevice.cpp:62 > Would it make sense to wrap this in a function with a more expressive name > like: isEncryptedFilesystem or isValutFilesystem? Then we could use the same > function in

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

bruns added a comment. In D21041#461446 , @broulik wrote: > Looks like we need a symbolic icon for that in breeze #vdg ^ Preferably yes, though thats orthogonal to this change. REPOSITORY

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

bruns added a comment. F6810948: Screenshot_20190506_000345.png REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21041 To: bruns, #frameworks, ngraham, hallas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

bruns created this revision. bruns added reviewers: Frameworks, ngraham, hallas. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY When Vaults are mounted and show up in the mtab, use the matching icon.

D20995: [Fstab] Add support for non-network filesystems

This revision was automatically updated to reflect the committed changes. Closed by commit R245:116c805ba461: [Fstab] Add support for non-network filesystems (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20995?vs=57478=57620 REVISION

D20995: [Fstab] Add support for non-network filesystems

bruns added a comment. In D20995#460439 , @ngraham wrote: > Nice! Can we make the Places panel display the product rather than the description? I don't think it's necessary to have the fs type listed there in the label. Interested parties can

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

bruns added a comment. I think this is the wrong way round: man mount.cifs: > The mount.cifs utility attaches the UNC name (exported network resource) specified as service (using //server/share syntax, where "server" is the server name or IP address and "share" is the name of the

D20991: [FsTab] Add cache for device file system type

This revision was automatically updated to reflect the committed changes. Closed by commit R245:a0320ae774fe: [FsTab] Add cache for device file system type (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20991?vs=57474=57509 REVISION DETAIL

D20991: [FsTab] Add cache for device file system type

bruns marked an inline comment as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20991 To: bruns, #frameworks, ngraham, hallas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20991: [FsTab] Add cache for device file system type

bruns added inline comments. INLINE COMMENTS > ngraham wrote in fstabhandling.cpp:144 > Only network mounts? Others are added in D20995 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20991 To: bruns, #frameworks, ngraham, hallas

D21004: [UserMetaData] Shortcut attribute queries for the common case

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added a project: Baloo. bruns requested review of this revision. REVISION SUMMARY Optimize the common case of only a few or no attributes set, no functional changes. TEST PLAN ctest

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a dependent revision: D21004: [UserMetaData] Shortcut attribute queries for the common case. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, gennad, domson,

D20990: [Fstab] Preparatory work for enabling filesystems beyond NFS/SMB

This revision was automatically updated to reflect the committed changes. Closed by commit R245:7aad0e183b3d: [Fstab] Preparatory work for enabling filesystems beyond NFS/SMB (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE

D16116: [KPropertiesDialog] Show a filename for the / directory

bruns added a comment. Is this still relevant - for me, the properties dialog has "Properties for /". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16116 To: thsurrel, #frameworks, ngraham Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D21002: Remove kde4 migration agent completely

bruns created this revision. bruns added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The migration agent is some quite weird mechanism: - it starts the KDE4

D20995: [Fstab] Add support for non-network filesystems

bruns added a comment. F6806745: Screenshot_20190503_180519.png REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20995 To: bruns, #frameworks, ngraham, hallas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

bruns edited the summary of this revision. bruns added a dependency: D20991: [FsTab] Add cache for device file system type. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20995 To: bruns, #frameworks, ngraham, hallas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20991: [FsTab] Add cache for device file system type

bruns added a dependent revision: D20995: [Fstab] Add support for non-network filesystems. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20991 To: bruns, #frameworks, ngraham, hallas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

bruns created this revision. bruns added reviewers: Frameworks, ngraham, hallas. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. TEST PLAN solid-hardware list details: udi =

D20990: [Fstab] Preparatory work for enabling filesystems beyond NFS/SMB

bruns added a dependent revision: D20991: [FsTab] Add cache for device file system type. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20990 To: bruns, #frameworks, ngraham, hallas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20991: [FsTab] Add cache for device file system type

bruns created this revision. bruns added reviewers: Frameworks, ngraham, hallas. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY This is required for efficient lookup of the device filesystem

D20990: [Fstab] Preparatory work for enabling filesystems beyond NFS/SMB

bruns created this revision. bruns added reviewers: Frameworks, ngraham, hallas. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Currently, the fstab backend only lists NFS and SMB share, although

D20967: [UserMetaData] Add method to query which attributes are set

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Many files have no UserMetaData attributes set at all,

D20938: Add Mounts Backend

bruns added a comment. In D20938#459627 , @hallas wrote: > In D20938#459218 , @bruns wrote: > > > Solid already has a working implementation for reading from /proc/mounts, the fstab backend. > >

D20940: [baloo_file] Wait for extractor process to start

bruns added a comment. You better had fixed the commit message ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20940 To: nicolasfella, #baloo, bruns Cc: bruns, apol, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D20940: [baloo_file] Wait for extractor process to start

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH waitForStart REVISION DETAIL https://phabricator.kde.org/D20940 To: nicolasfella, #baloo, bruns Cc: bruns, apol, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh,

D20940: [baloo_file] Wait for extractor process to start

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > extractorprocess.cpp:64 > { > Q_ASSERT(m_extractorProcess.state() == QProcess::Running); > Q_ASSERT(!fileIds.isEmpty()); This assert is just

D20938: Add Mounts Backend

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20938 To: hallas, #frameworks, ngraham, elvisangelaccio, broulik, bruns Cc: svuorela, nicolasfella, ivan, kde-frameworks-devel,

D20938: Add Mounts Backend

bruns added a comment. Solid already has a working implementation for reading from /proc/mounts, the fstab backend. Contrary to this code, the fstab backend does not poll every second using a timer, but correctly uses /proc/mounts changes notification via blocking read. The only

D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

This revision was automatically updated to reflect the committed changes. Closed by commit R286:c14869f1b9af: [TaglibExtractor] Feed non-ogg *.spx file into extractor test (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D20913: [TagLibExtractor] Fix crash on invalid Speex files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:61b1916c3e87: [TagLibExtractor] Fix crash on invalid Speex files (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20913?vs=57229=57281

D20918: [balooctl] Add command to show files failed to index

This revision was automatically updated to reflect the committed changes. Closed by commit R293:74c8fcf5bb0d: [balooctl] Add command to show files failed to index (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20918?vs=57251=57280 REVISION

D20918: [balooctl] Add command to show files failed to index

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Baloo was missing any means to retrieve the list of

D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Binary files with .spx extension are detected as

D20913: [TagLibExtractor] Fix crash on invalid Speex files

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY TagLib::Ogg::Speex::File::isValid() returns true even

D20877: Fix exivextractor crash with malformed files

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH fix_exiv_crash REVISION DETAIL https://phabricator.kde.org/D20877 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,

D20877: Fix exivextractor crash with malformed files

bruns added a comment. Otherwise, LGTM INLINE COMMENTS > astippich wrote in exiv2extractor.cpp:303 > Yep, forgot Can you add a line break here as well? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20877 To: astippich, bruns Cc: kde-frameworks-devel,

D20877: Fix exivextractor crash with malformed files

bruns added inline comments. INLINE COMMENTS > astippich wrote in exiv2extractor.cpp:299 > Unfortunately, empty() does not exist. Same was done in > https://phabricator.kde.org/D16165 Yes, probably as `count()` is O(1). > exiv2extractor.cpp:303 > it =

D20877: Fix exivextractor crash with malformed files

bruns added inline comments. INLINE COMMENTS > exiv2extractor.cpp:299 > Exiv2::ExifData::const_iterator it = > data.findKey(Exiv2::ExifKey("Exif.GPSInfo.GPSAltitude")); > -if (it != data.end() && (it->value().typeId() == Exiv2::unsignedRational > || it->value().typeId() ==

D20525: [InformationPanel] Use the new inline configuration mode

This revision was automatically updated to reflect the committed changes. Closed by commit R318:ecf1ae6d0b16: [InformationPanel] Use the new inline configuration mode (authored by bruns). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20525?vs=56732=56808

D20525: [InformationPanel] Use the new inline configuration mode

bruns added inline comments. INLINE COMMENTS > elvisangelaccio wrote in informationpanelcontent.cpp:122-124 > These 3 lines could go in a dedicated function which we could call from both > lambdas, to avoid code duplication. Or it could even be a private slot > connected to

D20525: [InformationPanel] Use the new inline configuration mode

bruns updated this revision to Diff 56732. bruns marked 3 inline comments as done. bruns added a comment. coding style, rebase REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20525?vs=56405=56732 BRANCH cleanup REVISION DETAIL

D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layoutThe Baloo::MetaDataWidget is now able to stretch in a meaningful wayby itself, remove the wrapper.

This revision was automatically updated to reflect the committed changes. Closed by commit R318:832fd0965594: [InformationPanel] Remove obsolete intermediate wrapper widget/layout (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20668?vs=56538=56730#toc REPOSITORY

D20667: Make the FileMetadataWidget stretch vertically in a sensible way

This revision was automatically updated to reflect the committed changes. Closed by commit R824:380dc4037c10: Make the FileMetadataWidget stretch vertically in a sensible way (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20667?vs=56537=56726#toc REPOSITORY R824

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

This revision was automatically updated to reflect the committed changes. Closed by commit R824:c36d6b26eb3f: [FileMetaDataWidget] Allow inline configuration of visible properties (authored by bruns). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE

D20620: [balooctl] Switch multiline output to new helper

This revision was automatically updated to reflect the committed changes. Closed by commit R293:812523dfd960: [balooctl] Switch multiline output to new helper (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20620?vs=56403=56548 REVISION

D20619: [balooctl] Use new helper in json output

This revision was automatically updated to reflect the committed changes. Closed by commit R293:d0057aebd715: [balooctl] Use new helper in json output (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20619?vs=56402=56547 REVISION DETAIL

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns updated this revision to Diff 56545. bruns added a comment. reset column stretch REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20524?vs=56536=56545 BRANCH metadata_config_inline REVISION DETAIL https://phabricator.kde.org/D20524

D20667: Make the FileMetadataWidget stretch vertically in a sensible way

bruns retitled this revision from "Make the FileMetadataWidget vertical stretch in a sensible way" to "Make the FileMetadataWidget stretch vertically in a sensible way". REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D20667 To: bruns, #dolphin, #baloo,

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns added a dependent revision: D20667: Make the FileMetadataWidget vertical stretch in a sensible way. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D20524 To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich Cc: elvisangelaccio, gennad, domson,

D20667: Make the FileMetadataWidget vertical stretch in a sensible way

bruns edited the summary of this revision. bruns added a dependency: D20524: [FileMetaDataWidget] Allow inline configuration of visible properties. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D20667 To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich

D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layoutThe Baloo::MetaDataWidget is now able to stretch in a meaningful wayby itself, remove the wrapper.

bruns created this revision. bruns added reviewers: Dolphin, Baloo, Frameworks, ngraham, astippich. bruns added a project: Dolphin. bruns requested review of this revision. REVISION SUMMARY Depends on D20667 REPOSITORY R318 Dolphin BRANCH cleanup

D20667: Make the FileMetadataWidget vertical stretch in a sensible way

bruns added a dependent revision: D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layout The Baloo::MetaDataWidget is now able to stretch in a meaningful way by itself, remove the wrapper.. REPOSITORY R824 Baloo Widgets REVISION DETAIL

D20667: Make the FileMetadataWidget vertical stretch in a sensible way

bruns created this revision. bruns added reviewers: Dolphin, Baloo, Frameworks, ngraham, astippich. Herald added a project: Baloo. bruns requested review of this revision. REVISION SUMMARY When the widget size is larger than the required size, the QGridLayout distributes the extra space

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns updated this revision to Diff 56536. bruns added a comment. Layout cleanup - remove extra spacer - keep checkbox near label (align right) REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20524?vs=56337=56536 BRANCH

D20617: [balooctl] Factor out file index status collection from output

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a9c230f64519: [balooctl] Factor out file index status collection from output (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20617?vs=56400=56520

D20618: [balooctl] Use new helper for simple format output

This revision was automatically updated to reflect the committed changes. Closed by commit R293:634e490b58a4: [balooctl] Use new helper for simple format output (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20618?vs=56401=56521 REVISION

D20620: [balooctl] Switch multiline output to new helper

bruns added inline comments. INLINE COMMENTS > ngraham wrote in statuscommand.cpp:150 > Do we have to use `auto` here and below? We hardly ever have to, but I see no reason why an explicit type would be helpful here. You wouldn't have objected if I had used `auto filenameIt =

D20529: add license to python test files

bruns added a comment. In D20529#451614 , @bcooksley wrote: > In D20529#451561 , @bruns wrote: > > > In D20529#451147 , @bcooksley wrote: > > > > >

D20608: Declare properties as meta type

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH enum_meta REVISION DETAIL https://phabricator.kde.org/D20608 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,

D20529: add license to python test files

bruns added a comment. In D20529#451147 , @bcooksley wrote: > can we get the full command it's running? `ctest -V -R externalextractortest` REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20529 To:

D20529: add license to python test files

bruns added a comment. In D20529#451147 , @bcooksley wrote: > The Python installation on the CI nodes is most definitely complete (the CI Tooling itself used to perform the builds is written entirely in Python) > > I'd therefore suggest

D20525: [InformationPanel] Use the new inline configuration mode

bruns updated this revision to Diff 56405. bruns added a comment. disable configure action when in configuration mode REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20525?vs=56287=56405 BRANCH cleanup REVISION DETAIL

D20617: [balooctl] Factor out file index status collection from output

bruns added a dependent revision: D20620: [balooctl] Switch multiline output to new helper. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20617 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov,

D20620: [balooctl] Switch multiline output to new helper

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Output is mostly unchanged, but symlinks are

D20619: [balooctl] Use new helper in json output

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The output is mostly the same, save for the

D20617: [balooctl] Factor out file index status collection from output

bruns added a dependent revision: D20619: [balooctl] Use new helper in json output. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20617 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh,

D20617: [balooctl] Factor out file index status collection from output

bruns added a dependent revision: D20618: [balooctl] Use new helper for simple format output. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20617 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov,

D20618: [balooctl] Use new helper for simple format output

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Symlinks are no longer reported as "Basic

D20617: [balooctl] Factor out file index status collection from output

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The three output formats (singleline,

D20525: [InformationPanel] Use the new inline configuration mode

bruns added a comment. In D20525#449801 , @bruns wrote: > In D20525#449788 , @ngraham wrote: > > > +1, this is a much nicer UI. Some of the text gets cut off horizontally though when the panel is

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns marked an inline comment as done. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D20524 To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns updated this revision to Diff 56337. bruns added a comment. correct since version REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20524?vs=56206=56337 BRANCH metadata_config_inline REVISION DETAIL https://phabricator.kde.org/D20524

D20525: [InformationPanel] Use the new inline configuration mode

bruns added inline comments. INLINE COMMENTS > elvisangelaccio wrote in informationpanelcontent.cpp:237 > Coding style: brace should go to next line (the function below is also > wrong...) The glory of copy and paste ;-) REPOSITORY R318 Dolphin REVISION DETAIL

D20525: [InformationPanel] Use the new inline configuration mode

bruns updated this revision to Diff 56287. bruns marked 3 inline comments as done. bruns added a comment. bump baloo widgets version cleanup REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20525?vs=56194=56287 BRANCH cleanup REVISION DETAIL

D20556: Keep empty Json metadata docs out of DocumentData DB

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5a8f402b56de: Keep empty Json metadata docs out of DocumentData DB (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20556?vs=56241=56278 REVISION

D20556: Keep empty Json metadata docs out of DocumentData DB

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case a document is marked for content

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns marked 4 inline comments as done. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D20524 To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns updated this revision to Diff 56206. bruns added a comment. add apidox, cleanup REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20524?vs=56166=56206 BRANCH metadata_config_inline REVISION DETAIL https://phabricator.kde.org/D20524 AFFECTED

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns added a comment. In D20524#449784 , @ngraham wrote: > In D20524#449668 , @elvisangelaccio wrote: > > > Hmm, it seems you need to rebase this patch: > > > Worked for me: > >INFO

D20525: [InformationPanel] Use the new inline configuration mode

bruns added a comment. In D20525#449788 , @ngraham wrote: > +1, this is a much nicer UI. Some of the text gets cut off horizontally though when the panel is narrow: > > F6771538: Screenshot_20190414_081327.png

D20526: fix extracting of some properties to match what was writen

bruns added a comment. In D20526#449560 , @astippich wrote: > IMHO for searching, the separation from a single string into multiple entries is the best thing to do, from a metadata editing point of view not so much. > How about inserting

D20529: add license to python test files

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH py_license REVISION DETAIL https://phabricator.kde.org/D20529 To: astippich, bruns Cc: bcooksley, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,

D19445: Handle variant list in formatting functions

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > propertyinfotest.cpp:91 > { Property::BitRate, true, 1470, > QStringLiteral("14.7 Mbit/s")}, > +{ Property::BitRate,

D20528: Change properties attributes for consistency

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. 10 lines removed, 1 added, 10 times more functionality  REPOSITORY R286 KFileMetaData BRANCH properties_consistency REVISION DETAIL https://phabricator.kde.org/D20528 To: astippich,

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns edited the summary of this revision. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D20524 To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns added inline comments. INLINE COMMENTS > elvisangelaccio wrote in filemetadatawidget.h:47-49 > Can you add some apidox for this enum? In particular, it's not so clear what > `ReStart` is used for. Sure, just wanted to see if the (UI) design itself is deemed appropriate. REPOSITORY

D20525: [InformationPanel] Use the new inline configuration mode

bruns edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20525 To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich Cc: meven, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20529: add license to python test files

bruns added a subscriber: bcooksley. bruns added a comment. @bcooksley - these tests currently fail to run under Windows: https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5 WindowsMSVCQt5.11/149/testReport > "C:/CI/workspace/Frameworks/kfilemetadata/kf5-qt5

D20513: Remove last traces of KFileMetaDataWidget from information panel

bruns added inline comments. INLINE COMMENTS > elvisangelaccio wrote in filemetadataconfigurationdialog.h:35 > Can you please also update this comment? It should mention > `Baloo::FileMetaDataWidget`. Good catch ... REPOSITORY R318 Dolphin REVISION DETAIL

D20525: [InformationPanel] Use the new inline configuration mode

bruns updated this revision to Diff 56194. bruns added a comment. rebase REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20525?vs=56168=56194 BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D20525 AFFECTED FILES src/CMakeLists.txt

D20513: Remove last traces of KFileMetaDataWidget from information panel

This revision was automatically updated to reflect the committed changes. Closed by commit R318:05a4d27813e3: Remove last traces of KFileMetaDataWidget from information panel (authored by bruns). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE

D20513: Remove last traces of KFileMetaDataWidget from information panel

bruns updated this revision to Diff 56192. bruns added a comment. remove one more reference in comments REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20513?vs=56152=56192 BRANCH arcpatch-D20513 REVISION DETAIL https://phabricator.kde.org/D20513

D20513: Remove last traces of KFileMetaDataWidget from information panel

bruns marked an inline comment as done. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20513 To: bruns, #frameworks, apol, ngraham, #dolphin Cc: elvisangelaccio, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20523: Remove a dead declaration

This revision was automatically updated to reflect the committed changes. Closed by commit R824:c51ec36cee75: Remove a dead declaration (authored by bruns). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20523?vs=56165=56186 REVISION DETAIL

D20525: [InformationPanel] Use the new inline configuration mode

bruns added a comment. After selecting "Configure ..." from the context menu: F6771063: Screenshot_20190414_061013.png REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20525 To: bruns, #dolphin, #baloo, #frameworks,

D20525: [InformationPanel] Use the new inline configuration mode

bruns updated this revision to Diff 56168. bruns added a comment. remove obsolete include REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20525?vs=56167=56168 BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D20525 AFFECTED FILES

D20525: [InformationPanel] Use the new inline configuration mode

bruns added a comment. F6771060: simplescreenrecorder-(2).mkv REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20525 To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich Cc: kfm-devel, alexde, feverfew, meven, spoorun,

<    3   4   5   6   7   8   9   10   11   12   >