This revision was automatically updated to reflect the committed changes.
Closed by commit R241:cb33e9478e58: Embed protocol data also for Windows
version of trash ioslave. (authored by tfry).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26365?vs=72614=72644
tfry added reviewers: cullmann, vonreth.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26365
To: tfry, cullmann, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
tfry created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
tfry requested review of this revision.
REVISION SUMMARY
trash:/-protocol is currently broken on Windows:
https://bugs.kde.org/show_bug.cgi?id=414430
The cause seems to be that
tfry closed this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D19635
To: tfry, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh,
ngraham, bruns, demsking, sars, dhaumann
tfry created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
tfry requested review of this revision.
REVISION SUMMARY
If the texteditor window is on a secondary screen of a multi-screen desktop,
*and* the argument hint has
I'll shuffle the bits in this mail a bit, in an attempt to get the
discussion back to the main topic (or at least the thing that I
intended to be the main topic):
On Thu, 03 May 2018 23:11:56 +0200
René J.V. Bertin <rjvber...@gmail.com> wrote:
> On Thursday May 03 2018 21:57:
On Thu, 03 May 2018 21:09:03 +0200
René J.V. Bertin <rjvber...@gmail.com> wrote:
> >On Fri, May 4, 2018 at 2:38 AM, Thomas Friedrichsmeier
>
> >> homebrew, craft). It is also about the fact that this installation
> >> option causes problems, e.g. if users are
Hi,
I'll just answer a few select points, because, yes I am aware this has
a tiny bit of a history, and I don't want to see a repeat. The master
plan is actually to get David Faure to champion a solution (whichever
one) into Qt. So before getting lost in the detail of the various
approaches, I'd
Hi,
On Thu, 03 May 2018 16:01:46 +0200
René J.V. Bertin <rjvber...@gmail.com> wrote:
> On Thursday May 03 2018 15:19:33 Thomas Friedrichsmeier wrote:
> >plan is actually to get David Faure to champion a solution (whichever
> >one) into Qt.
>
> I can be wrong, but
Hi!
Quick summary, first:
KF5 relies on storing data in QStandardPaths::GenericDataLocation, but
that location is problematic on Mac because it refers to absolute,
non-customizable system paths, only. We'd like to avoid patching Qt, so
we are looking to come up with a solution that has a chance
tfry added a comment.
@devillemereuil This was meant to replace calcMismatchIndent(), or at least
the upper part of it. But don't let me distract you, here, this is
non-essential. Just focus on the unit tests for now.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
tfry added a comment.
Regarding the unit tests: Take a look at e.g.
https://cgit.kde.org/ktexteditor.git/tree/autotests/input/indent/cmake/enter1 .
You start with an initial text "origin", then emulate some input "input.js", an
specify the expected state at the end "expected".
Again, I
tfry added a comment.
Looks good to me.
This place is talking about how to get icon themes working, and so it should
list the most relevant approaches. Arguably, this is not the place where I
would have looked for an answer to that question, first, but since it does
provide an answer,
tfry added a comment.
Much clearer, now, IMO.
Your osx-integration plugin is what I was thinking of, when writing about
"patched libs". See, that's how confused I am, I just can't seem to remember
any of this...
How about adding that detail, too, e.g.:
... provided that the
tfry added a comment.
It's difficult to explain a confusing situation, clearly, but I don't think
you succeeded. AFAIU, there are //three// distinct approaches:
a) embedded icons
b) QIcon::setThemeSearchPaths()
c) patched libs
From the current wording I'm not sure, whether you do
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:e48e34bd0288: Add since tags. (authored by tfry).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6122?vs=15226=15376
REVISION DETAIL
tfry added a comment.
In https://phabricator.kde.org/D6122#114655, @cfeck wrote:
> Since this frameworks is new as of 5.28, should we really mark each class
this way? We did not do this for other "new" frameworks, such as prison or
kwayland.
You mean, if I'm not sure whether the
tfry created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
I hate having to look up when interesting new classes were added.
Patch is straight-forward (I think), but:
- should @since be added on all memebers, when it's already on the class?
- would
tfry added inline comments.
INLINE COMMENTS
> dfaure wrote in krandomtest.cpp:168
> variable size array, which is not in the standard.
> https://stackoverflow.com/questions/1887097/why-arent-variable-length-arrays-part-of-the-c-standard
>
> Make size static to fix it.
Sorry. Should have waited
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:26a262180155: Ensure proper per thread seeding in
KRandom. (authored by tfry).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5966?vs=14863=14952#toc
REPOSITORY
R244 KCoreAddons
CHANGES
tfry updated this revision to Diff 14863.
tfry added a comment.
Switch to QThreadStorage, use quintptr as suggested, add auto-test.
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5966?vs=14831=14863
BRANCH
master
REVISION DETAIL
tfry added a comment.
In https://phabricator.kde.org/D5966#111878, @rjvbb wrote:
> but I also didn't verify if QSet::insert is thread-safe.
Ouch, you're right, it isn't. QThreadStorage it shall be, then (until we can
use thread_local). That also handles thread-destruction,
tfry updated this revision to Diff 14831.
tfry added a comment.
Ensure proper per-thread random-seeding in KRandom::random().
As commented, the problem is somewhat different, than I though, originally:
qsrand() and qrand() keep random seeds per QThread, and each thread needs a
tfry added a comment.
On further investigation, I see that qsrand() would probably have to be
called for //each// thread, in any case. So that would mean keeping track of
initialization state in a QThreadStorage?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
tfry created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Consider the following scenario: Thread A calls KRandom::random(), for the
first time.
It will now go through a (relatively) expensive
tfry added a comment.
Hi thanks for adding me in CC. My use case was saving and restoring a certain
scroll position. Thus, what I am missing, immediately, is a way to retrieve the
current scroll position. The proposed startLine() goes some length, here, but
does not provide columns (in case
marked as submitted.
Review request for KDE Frameworks and kdewin.
Changes
---
Submitted with commit 8f58ddf1cfb053147d6d12a3e13ea33b079072ef by Thomas
Friedrichsmeier to branch master.
Repository: khtml
Description
---
Fix building with MinGW on Windows, by removing conflicting
om.cpp e3fedad
src/ecma/kjs_html.cpp cc3c08a
src/html/html_baseimpl.cpp 539681c
src/html/html_elementimpl.cpp 7569192
src/html/htmlparser.cpp 064b99b
src/xml/dom_docimpl.cpp 4f0be5c
Diff: https://git.reviewboard.kde.org/r/127266/diff/
Testing
---
Now builds with MinGW.
Thank
-
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127187/#review92909
---
On Feb. 29, 2016, 1:54 p.m., Thomas Friedrichsmeier wrote:
>
> --
compiles with MSVC 2013 on Windows.
Thanks,
Thomas Friedrichsmeier
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
af30f59
src/lib/activitiesmodel_p.h dfa861b
src/utils/model_updaters.h ae8e279
Diff: https://git.reviewboard.kde.org/r/127187/diff/
Testing
---
Now compiles with MSVC 2013 on Windows.
Thanks,
Thomas Friedrichsmeier
___
Kde-frameworks-devel
://git.reviewboard.kde.org/r/127187/diff/
Testing
---
Now compiles with MSVC 2013 on Windows.
Thanks,
Thomas Friedrichsmeier
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks
hold... Further ideas
still welcome!
- Thomas
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127187/#review92814
-------
On Feb. 2
marked as submitted.
Review request for KDE Frameworks and kdewin.
Changes
---
Submitted with commit 1c2aa25fb179fe3350bee166f2d8e69404d0cc7f by Thomas
Friedrichsmeier to branch master.
Repository: ki18n
Description
---
Fix compilation on Windows with MSVC.
a) MSVC accepts
/activitiesmodel.h 7258b73
Diff: https://git.reviewboard.kde.org/r/127187/diff/
Testing
---
Now compiles with MSVC 2013 on Windows.
Thanks,
Thomas Friedrichsmeier
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
for this patch.
Thanks,
Thomas Friedrichsmeier
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
36 matches
Mail list logo
