Re: KDE Frameworks with failing CI (master) (10 March 2024)

Moin moin I'll rebuild the package repo to use Qt 6.6.2 -- I'll ping you once the repo is updated. mfg Tobias On Tue, 12 Mar 2024 at 10:50, Ben Cooksley wrote: > > On Mon, Mar 11, 2024 at 12:46 PM Albert Astals Cid wrote: >> >> Please work on fixing them, otherwise i will remove the failing

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.15 - Build # 291 - Unstable!

Moin moin I will update the installation in around 8 hours mfg Tobias On Mon, 5 Apr 2021 at 21:52, Christoph Cullmann wrote: > > Hi, > > On 2021-04-05 21:40, Adriaan de Groot wrote: > > On Monday, 5 April 2021 19:20:08 CEST Ben Cooksley wrote: > >> On Tue, Apr 6, 2021 at 3:33 AM Christoph

Re: Shift for parts of the CI system to Qt 5.15

Moin moin On Sat, 20 Jun 2020 at 10:13, Volker Krause wrote: > > On Saturday, 20 June 2020 08:20:18 CEST Ben Cooksley wrote: > > Hi all, > > > > This weekend parts of our CI system shifted to using Qt 5.15, with all > > FreeBSD builds now being based on Qt 5.15. We also shifted all Linux > >

D28407: Fix configure when xmllint is not present

This revision was automatically updated to reflect the committed changes. Closed by commit R266:23b32c25f0be: Fix configure when xmllint is not present (authored by tcberner). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28407?vs=78796=78801 REVISION

D28407: Fix configure when xmllint is not present

tcberner created this revision. tcberner added a reviewer: kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcberner requested review of this revision. REVISION SUMMARY The breeze-validate-svg target is only generated when xmllint is found.

D27927: Use more flexible shebang

tcberner created this revision. tcberner added reviewers: FreeBSD, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcberner requested review of this revision. REVISION SUMMARY `bash` is in `${LOCALBASE}` in FreeBSD, which defaults to `/usr/local`.

Re: Does FreeBSD have HAL?

Moin moin We will replace (ancient) hal with Gleb's implementation of usdisks2 "bsdisks2" in the near future by default. Hald is likely not enabled on the CI hosts -- I could enable it :) -- or we could push the switch and make bsdisks2 the default in master, which I would prefer. What is your

D17863: Add ecm_check_linker_flags function

tcberner abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit R244:b1d27cabc2a9: KProcessInfoList -- add proclist backend for FreeBSD (authored by tcberner). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21146?vs=68138=68151

D21146: KProcessInfoList -- add proclist backend for FreeBSD

tcberner added a comment. @adridg I've addressed your comments [finally]. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21146 To: tcberner, #freebsd, adridg, davidedmundson Cc: pino, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

tcberner updated this revision to Diff 68138. tcberner added a comment. - procstat: add FindProcstat.cmake - procstat: add procstat backend - procstat: add procstat option - procstat: add linkage for procstat backend REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D21146: KProcessInfoList -- add proclist backend for FreeBSD

tcberner marked an inline comment as done. tcberner added a comment. Gargh, the code `kdelibs` code formatter changed a lot more in `kprocesslist_unix_proc.cpp` than wanted :/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21146 To: tcberner, #freebsd, adridg,

D21146: KProcessInfoList -- add proclist backend for FreeBSD

tcberner updated this revision to Diff 57921. tcberner added a comment. - Switch to 2-Clause - Move procstat backend into its own file - Remove now unnecessary config-kprocesslist.cmake REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D21146: KProcessInfoList -- add proclist backend for FreeBSD

tcberner updated this revision to Diff 57915. tcberner added a comment. Remove commented line. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21146?vs=57913=57915 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21146 AFFECTED FILES

D21146: KProcessInfoList -- add proclist backend for FreeBSD

tcberner added inline comments. INLINE COMMENTS > FindProcstat.cmake:18 > +#documentation and/or other materials provided with the distribution. > +# 3. Neither the name of the University nor the names of its contributors > +#may be used to endorse or promote products derived from this

D21146: KProcessInfoList -- add proclist backend for FreeBSD

tcberner created this revision. tcberner added reviewers: FreeBSD, adridg, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcberner requested review of this revision. REVISION SUMMARY This adds - unixProcessListKinfoProcStat() to

D19075: Fix FindEGL

This revision was automatically updated to reflect the committed changes. Closed by commit R240:7c64db956829: Fix FindEGL (authored by tcberner). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19075?vs=51847=52057 REVISION DETAIL

D19075: Fix FindEGL

tcberner updated this revision to Diff 51847. tcberner added a comment. Simply set `NAMES EGL/egl.h` and fixup the header version check. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19075?vs=51842=51847 BRANCH master REVISION DETAIL

D19075: Fix FindEGL

tcberner added a comment. In D19075#413462 , @hausmann wrote: > I think that it should be NAMES EGL/egl.h Yeah, then it might actuayll work without redefining the path -- but in both cases we are kind of assuming that all install egl.h

D19075: Fix FindEGL

tcberner updated this revision to Diff 51842. tcberner added a comment. Store the path gathered via pkgconfig in `COMPLETE_EGL_INCLUDE_DIR` and use its parent directory for `EGL_INCLUDE_DIR`. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D19075: Fix FindEGL

tcberner added a comment. Possibly the returend `EGL_INCLUDE_DIR` should possibly be stripped of the suffix too, as most will proably include 'EGL/egl.h', and not 'egl.h', I guess? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19075 To: tcberner,

D19075: Fix FindEGL

tcberner added a reviewer: FreeBSD. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19075 To: tcberner, #automotive, hausmann, #freebsd Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19075: Fix FindEGL

tcberner created this revision. tcberner added reviewers: Automotive, hausmann. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. tcberner requested review of this revision. REVISION SUMMARY ${EGL_INCLUDE_DIR} is the path up to

D19075: Fix FindEGL

tcberner added a dependency: D18960: Add compile check to FindEGL. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19075 To: tcberner, #automotive, hausmann Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18960: Add compile check to FindEGL

tcberner added a dependent revision: D19075: Fix FindEGL. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18960 To: hausmann, vkrause, apol Cc: bcooksley, tcberner, kossebau, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18960: Add compile check to FindEGL

tcberner added a comment. In D18960#411562 , @kossebau wrote: > Seems this is sadly breaking something for FreeBSD though, see > https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console I'll look into

D17863: Add ecm_check_linker_flags function

tcberner added a comment. In D17863#384145 , @cgiboudeaux wrote: > Why not fixing kstars instead? include(ECMCheckLinkerFlags) [...] # Check for nodump support SET(NODUMP_FLAGS "-Wl,-z,nodump")

D17863: Add ecm_check_linker_flags function

tcberner added a comment. See: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230603 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17863: Add ecm_check_linker_flags function

tcberner edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17863: Add ecm_check_linker_flags function

tcberner created this revision. tcberner added reviewers: FreeBSD, dfaure, apol. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. tcberner requested review of this revision. REVISION SUMMARY kstars appends '-Wl,-z,nodump' to the

D17015: Fix the Qt doc creation with Qt 5.12.

tcberner added inline comments. INLINE COMMENTS > ECMQueryQmake.cmake:9 > +# We need to look for the executable directly. > +find_program(_qmake_executable_default NAMES qmake-qt5) > endif() ^ on FreeBSD qmake-qt5 is just called qmake (which is in fact qtchooser). REPOSITORY R240

Re: ktextwidgets on FreeBSD

I can read speech-dispatcher, which had the hanging processes, if you want. mfg Tobias On Sun, 5 Aug 2018 at 01:41, Ben Cooksley wrote: > On Sat, Aug 4, 2018 at 11:06 PM, David Faure wrote: > > Anyone running FreeBSD, who could to try and debug this hanging unittest > from the ktextwidgets

D12231: Reduce the number of zombies to a minimum

tcberner abandoned this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12231 To: tcberner, #freebsd, sitter, apol Cc: adridg, anthonyfieroni, #frameworks, michaelh, ngraham, bruns

D12226: balooshow: Colorize only when attached to terminal

tcberner accepted this revision. tcberner added a comment. This revision is now accepted and ready to land. Works as intended on FreeBSD. REPOSITORY R293 Baloo BRANCH no-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D12226 To: michaelh, #baloo, bruns,

D12231: Reduce the number of zombies to a minimum

tcberner updated this revision to Diff 32216. tcberner added a comment. Simplify the diff. REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12231?vs=32210=32216 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12231 AFFECTED FILES

D12231: Reduce the number of zombies to a minimum

tcberner added inline comments. INLINE COMMENTS > build-pofiles.cmake:64 > set(i 0) > +set(commands "") > endif() ^ this is probalby the only required change. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12231 To: tcberner, #freebsd, sitter,

D12231: Reduce the number of zombies to a minimum

tcberner created this revision. tcberner added reviewers: FreeBSD, sitter, apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. tcberner requested review of this revision. REVISION SUMMARY With Frameworks 5.45 [1] when building for

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, poboiko, bruns Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D10450: Generate a custom target in kcoreaddons_desktop_to_json

tcberner abandoned this revision. tcberner added a comment. Works for me REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10450 To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco Cc: bcooksley, rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

tcberner added a comment. I think as @adridg points out that it should be a target, this should go in -- and the @kossebau already committed the proper workaround in D10485 , right? REPOSITORY R244 KCoreAddons REVISION DETAIL

D10450: Generate a custom target in kcoreaddons_desktop_to_json

tcberner added reviewers: bshah, dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10450 To: tcberner, #freebsd, mpyne, bshah, dfaure Cc: #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

tcberner created this revision. tcberner added reviewers: FreeBSD, mpyne. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. tcberner requested review of this revision. REVISION SUMMARY This creates a custom target 'desktop_to_json_X'

D6253: Use FindInotify.cmake to decide wheter inotify is available.

This revision was automatically updated to reflect the committed changes. Closed by commit R244:59db8a5ea224: Use FindInotify.cmake to decide wheter inotify is available. (authored by tcberner). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D6253: Use FindInotify.cmake to decide wheter inotify is available.

tcberner updated this revision to Diff 15532. tcberner added a comment. Fix identation. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6253?vs=15531=15532 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6253 AFFECTED FILES

D6253: Use FindInotify.cmake to decide wheter inotify is available.

tcberner edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D6253 To: tcberner, #freebsd, dfaure Cc: #frameworks

D6253: Use FindInotify.cmake to decide wheter inotify is available.

tcberner created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY FreeBSD also as sys/inotify.h available, but it is a library. We added FindInotify.cmake to ecm a while a go for this, but never got

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

tcberner updated this revision to Diff 15116. tcberner added a comment. Add find_programm(SH_EXE sh) REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6076?vs=15115=15116 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6076 AFFECTED

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

tcberner updated this revision to Diff 15115. tcberner added a comment. - Fix cmake - find_program call for xmllint REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6076?vs=15114=15115 BRANCH master REVISION DETAIL

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

tcberner added a reviewer: winterz. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D6076 To: tcberner, #freebsd, winterz Cc: #frameworks

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

tcberner created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY I don't think it makes sense, that the icons are xmllint'ed every time someone builds the icons. This is an action that should take

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner updated this revision to Diff 14965. tcberner added a comment. Use QStorageInfo. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5784?vs=14334=14965 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5784 AFFECTED FILES

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner added a comment. Ok, I think I found the issue in QStorageInfo -- it calls getmntinfo() with `flags=0` [1] . Instead one of the valid arguments 1-4 [2]. [1] https://github.com/qt/qtbase/blob/dev/src/corelib/io/qstorageinfo_unix.cpp#L199 [2]

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner planned changes to this revision. tcberner added a comment. I agree. I'll try and figure out whats wrong inside QStorageInfo, and then update the review here to be using it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd Cc:

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner added a comment. Hm, QStorageInfo does not seem to return anything sensible on FreeBSD: "" name: "" fileSystemType: "" size: 0 MB availableSize: 0 MB This is the output from the `QStorageInfo::root()` example. REPOSITORY R293 Baloo REVISION DETAIL

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This is not really needed at the moment, as it only seems to be needed to check if the filesystem is btrfs. I'm however not sure, if

D5766: Change default pkgconfig install path for FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit R240:416c7e9facf9: Change default pkgconfig install path for FreeBSD (authored by tcberner). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D5766: Change default pkgconfig install path for FreeBSD

tcberner marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5766 To: tcberner, #freebsd, apol, kfunk Cc: kfunk, #frameworks, #build_system

D5766: Change default pkgconfig install path for FreeBSD

tcberner updated this revision to Diff 14296. tcberner added a comment. - Turn around cases of the if-clause. - Fix cmake `matches` -> `MATCHES`. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5766?vs=14285=14296 BRANCH master REVISION

D5766: Change default pkgconfig install path for FreeBSD

tcberner updated this revision to Diff 14285. tcberner added a comment. Drop space after `if`. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5766?vs=14284=14285 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5766 AFFECTED

D5766: Change default pkgconfig install path for FreeBSD

tcberner created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY FreeBSD, opposed to most other sytems, does not install pkgconfig files to lib/pkgconfig, but to

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner added a comment. We talked about it some more, and think that it is maybe better to not do any cmake magic. #ifdef st_birthtime if (buff.st_birthtime > 0) { entry.insert(KIO::UDSEntry::UDS_CREATION_TIME, buff.st_birthtime); } #endif

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner updated this revision to Diff 12745. tcberner added a comment. Fix typo. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5138?vs=12744=12745 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 AFFECTED FILES

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner updated this revision to Diff 12744. tcberner added a comment. Add `#cmakedefine01 HAVE_ST_BIRTHTIME` to `config-kioslave-file.h.cmake` REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5138?vs=12743=12744 BRANCH master REVISION DETAIL

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner updated this revision to Diff 12743. tcberner added a comment. Use cmake to check for `st_birthime`. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5138?vs=12704=12743 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 AFFECTED

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner added a comment. F3114620: dolphin2.png REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, adridg, arrowdodger, rakuco, dfaure Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner added reviewers: rakuco, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, adridg, arrowdodger, rakuco, dfaure Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner added reviewers: adridg, arrowdodger. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, adridg, arrowdodger Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY It seems UDS_CREATION_TIME is never filled at all (as far as I could find in the short time I invested :D ). From the manpage: