pajamapants3000 added a comment.
@cfeck - I was referring to `SpellingMenu::addWordToDictionary` and
`SpellingMenu::ignoreWord` being inconsistent with the documentation of that
(brand new) class. I don't think there should be any ABI considerations there,
since it is a new class, but
pajamapants3000 added inline comments.
INLINE COMMENTS
> spellingmenu.h:44
> + * are handled internally, without any extra effort required from the parent.
> + * Slots are available to facilitate these actions on-demand if needed.
> + *
Reviewing, I noticed that these slots are actually
pajamapants3000 edited the test plan for this revision.
REPOSITORY
R310 KTextWidgets
REVISION DETAIL
https://phabricator.kde.org/D24993
To: pajamapants3000, #vdg, #frameworks, cullmann, cfeck
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
pajamapants3000 created this revision.
pajamapants3000 added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pajamapants3000 requested review of this revision.
REVISION SUMMARY
Adds a new option to the KTextEdit control in KTextWidgets to
pajamapants3000 added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in krichtextwidget.cpp:638
> Ah of course. I didn't notice it was `exec()` that was being called.
Coming back after two months, even I thought this looked wrong at first. I will
endeavor to make my intent clearer,
pajamapants3000 added a comment.
Thank you for the feedback and approval! I don't have the access needed to
land a change, what should I do next? I would certainly appreciate someone else
landing it for me. Let me know, thanks!
REPOSITORY
R310 KTextWidgets
BRANCH
krazy-50b2564
pajamapants3000 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pajamapants3000 requested review of this revision.
REVISION SUMMARY
Resolved all issues discovered by the krazy plugins: crashy, explicit.
Other issues remain; I left
