D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun abandoned this revision. ZaWertun added a comment. No problem. I'm closing revision then. Thanks for the feedback. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: ngraham, rikmills, kde-frameworks-devel,

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun added a comment. Just found another bug on the KDE bugzilla related to this: https://bugs.kde.org/show_bug.cgi?id=410357. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: rikmills, kde-frameworks-devel, LeGast00n,

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun added a comment. Wrong. Still present in KF frameworks 5.61: KIO’s FTP connection feature is now more tolerant of broken FTP server implementations (Enes Selim, KDE Frameworks 5.61) (from https://pointieststick.com/2019/07/28/kde-usability-productivity-week-81/)

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun added a comment. Bug still present in plasma 5.16.4. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: rikmills, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun added a comment. In D22528#497803 , @sitter wrote: > Looks good to me. The slave indeed must issue an exit state there. > > What email address would you like to have associated with the git commit? zawer...@gmail.com

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun added a comment. Patch was made against version 5.60.0 (rev 8513ca9 ). Sorry that I didn't mention it earlier. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun,

D22528: KIO FTP: File copy hangs when copying to existing file - fix

ZaWertun retitled this revision from "KIO FTP: File copy hangs when copying to existing file" to "KIO FTP: File copy hangs when copying to existing file - fix". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure Cc: kde-frameworks-devel,

D22528: KIO FTP: File copy hangs when copying to existing file

ZaWertun added a comment. One more small thing: it's better replace `sCopyFile` in call to `error` with something like `dest.path()`, to display server path rather than local source. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure

D22528: KIO FTP: File copy hangs when copying to existing file

ZaWertun added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22528: KIO FTP: File copy hangs when copying to existing file

ZaWertun created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ZaWertun requested review of this revision. REVISION SUMMARY Subj. TEST PLAN Before patch: 1. kioclient5 cp f30.png ftp://127.0.0.1/Public/f30.png 2. kioclient5 cp