[Differential] [Changed Subscribers] D3702: kconfig_compiler: Use nullptr in generated code

aacid added subscribers: graesslin, aacid. aacid added a comment. Are you sure about that? https://build.kde.org/job/kconfig%20master%20kf5-qt5/132/ says it's @graesslin that broke it. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D3702 EMAIL PREFERENCES

[Differential] [Accepted] D3912: kdoctools_install: match the full path for the program

aacid accepted this revision. aacid added a reviewer: aacid. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D3912 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D3689: KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

aacid accepted this revision. aacid added a reviewer: aacid. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel BRANCH kglobalaccel-test-mode REVISION DETAIL https://phabricator.kde.org/D3689 EMAIL PREFERENCES

[Differential] [Commented On] D3689: KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

aacid added a comment. > We can adjust the shortcuts without having side effects on other tests. Why not just delete the test file on start of each test? REVISION DETAIL https://phabricator.kde.org/D3689 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

aacid added a comment. Again we have a patch against no repo, so i don't even know how to read this patch because i can't read the rest of the file. INLINE COMMENTS > kfiledialog.cpp:879 > +return 0; > +} > return d->w->okButton(); nullptr here and in other places

[Differential] [Commented On] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

aacid added a comment. Is this another patch that doesn't say to which repository it applies? Or am i just too stupid to find it in phabricator? REVISION DETAIL https://phabricator.kde.org/D3386 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D3544: Small optimization

aacid added a comment. Can we please stop having patches on phabricator that don't reference the repository they are supposed to be applied to? REVISION DETAIL https://phabricator.kde.org/D3544 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol,

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

aacid added a comment. In https://phabricator.kde.org/D3530#66090, @mart wrote: > In https://phabricator.kde.org/D3530#65734, @aacid wrote: > > > > Dolphin in other environments currently gives a big error until you install plasma-workspace, which defeats the point of the split. >

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

aacid added a comment. In https://phabricator.kde.org/D3530#65733, @davidedmundson wrote: > > These don't seem very "core" to me, maybe material for kio-extras ? > > Summarising the mailing list thread/bug report where this happened: > > The reason this came up is because Dolphin

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

aacid added a comment. These don't seem very "core" to me, maybe material for kio-extras ? I'll let dfaure decide though :D REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, dfaure,

[Differential] [Commented On] D1861: Fix name of QDialogButtonBox's enumerator "StandardButtons"

aacid added a comment. Is it me or phabricator doesn't say for which repo this patch is for? REVISION DETAIL https://phabricator.kde.org/D1861 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: aspotashev, #frameworks Cc: aacid

[Differential] [Accepted] D1465: KFileItem: remove separate storage of times, use UDSEntry instead.

aacid accepted this revision. aacid added a reviewer: aacid. aacid added a comment. This revision is now accepted and ready to land. Looks good :) BRANCH master REVISION DETAIL https://phabricator.kde.org/D1465 EMAIL PREFERENCES

[Differential] [Updated] D1489: Disable new_delete_type_mismatch temporarily

aacid added reviewers: graesslin, bcooksley, scarlettclark. aacid added a subscriber: Frameworks. aacid added a project: build.kde.org. REPOSITORY rCONFBUILD build.kde.org jenkins build configuration REVISION DETAIL https://phabricator.kde.org/D1489 EMAIL PREFERENCES

[Differential] [Updated, 2 lines] D1489: Disable new_delete_type_mismatch temporarily

aacid updated this revision to Diff 3511. aacid added a comment. fix syntax REPOSITORY rCONFBUILD build.kde.org jenkins build configuration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1489?vs=3510=3511 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1489