Re: LibKF6Breeze Icons and KIconLoader

On 2024-05-27 16:00, Jonathan Riddell wrote: I neon me and David R tracked it down to some optimization probably with the dh_dwz tool from Debian packaging tools, this is the "DWARF optimization and duplicate removal tool" part of the toolchain. And with the discussion here Chr

Re: LibKF6Breeze Icons and KIconLoader

d live with the bit longer compile time, I have no problem with changing that. Greetings Christoph Cheers, Fabian ttyl bero

Re: LibKF6Breeze Icons and KIconLoader

an rcc or toolchain bug though (and qrc_breeze-iconstmp.cpp.o looks ok), so it may not be related to the problem you're seeing. That is an issue with qt_add_bigresource. That doesn't like lto. Greetings Christoph ttyl bero

Re: LibKF6Breeze Icons and KIconLoader

=false Did you turn on KICONTHEMES_REGISTER_ICON_PLUGIN via CMake? If not my commit can be ignored. Than it is rather just the BreezeIcons::initIcons(); but that is strange, that only should load the resource and set the fallback theme. Greetings Christoph Jonathan

Re: LibKF6Breeze Icons and KIconLoader

n't revert but uses the master state) Greetings Christoph Jonathan

Re: KatePart causes Konqueror to crash when using the :q! Vi command

mit/e9ea498d0e9f938510ae35612266097587a03746 Greetings Christoph Thanks in advance Stefano [1] https://bugs.kde.org/show_bug.cgi?id=482436

Re: KDE Frameworks with failing CI (kf5) (3 March 2024)

-highlighting/-/commit/680c90ba438b7df3447222058a541424c9c91dbd for kf5. Should be fixed again. And thanks for the notice, would not have seen that. Greetings Christoph Cheers, Albert

Re: KDE Frameworks with failing CI (kf5) (3 March 2024)

On 2024-03-04 00:03, Albert Astals Cid wrote: Please work on fixing them, otherwise i will remove the failing CI jobs on their 4th failing week, it is very important that CI is passing for multiple reasons. Good news: 1 repository was fixed Bad news: 1 NEW repository is failing

Re: Frameworks 6.0.0 is out!

should. Hi, big thanks to all people that helped to get this done! Greetings Christoph Jonathan

Re: KDE Frameworks 6.0.0 tars

! Greetings Christoph

Re: KDE Frameworks 6.0.0 tars

loo/-/merge_requests/188 Greetings Christoph

Re: KDE Frameworks 6.0.0 tars

ttp://embra.edinburghlinux.co.uk/~jr/tmp/ktexteditor-6.0.0-changes_report.html Thanks, that looks correct. Greetings Christoph On Wed, 21 Feb 2024 at 11:44, Jonathan Riddell wrote: Tars for KDE Frameworks 6.0.0 are now available for packagers, release due next Wednesday http://embra.edinburghlinux.co

Re: Fwd: KDE Frameworks 6.0.0 tars

some small things we would add tomorrow. Just added the stuff now, current master branch state is ok. Greetings Christoph

Re: Fwd: KDE Frameworks 6.0.0 tars

Christoph

Re: KDE Frameworks with failing CI (kf5) (11 February 2024)

* Tests fail on FreeBSD * Should we backport the fix made in KF6? Christoph? Yes, it should be backported, otherwise the metadata features are broken on FreeBSD 14+ for users. I can take a look in the next days. https://invent.kde.org/frameworks/kfilemetadata/-/merge_requests/127 Greetings

Re: KDE Frameworks with failing CI (kf5) (11 February 2024)

in KF6? Christoph? Yes, it should be backported, otherwise the metadata features are broken on FreeBSD 14+ for users. I can take a look in the next days. Greetings Christoph Cheers, Albert Cheers, Ben

Re: KDE Frameworks with failing CI (master) (4 February 2024)

. kfilemetadata - 2nd week * https://invent.kde.org/frameworks/kfilemetadata/-/pipelines/598257 * FreeBSD tests are failing This one has been debugged by Christoph and there is a pending MR to fix this. See https://invent.kde.org/frameworks/kfilemetadata/-/merge_requests/126 Caused by differences

Re: KDE Frameworks with failing CI (kf5) (4 February 2024)

On 2024-02-04 13:34, Albert Astals Cid wrote: Please work on fixing them, otherwise i will remove the failing CI jobs on their 4th failing week, it is very important that CI is passing for multiple reasons. Good news: 9 repositories were fixed Bad news: 2 repositories are still failing, 1

Re: KDE Frameworks with failing CI (master) (29 January 2024)

UAGE had been set in our FreeBSD containers. That has now been rectified, and the tests in several more Frameworks now pass. (Leaving just Baloo and KFileMetaData as broken I believe) Hi, could it be that extended attributes don't work? I think these tests rely on them. Greetings Christoph

Re: Transitioning to Qt 6.6 for Windows builds - Syndication build failure

, it already passed at least the syndication step. Greetings Christoph Thanks, Ben

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

myself to write some tracker based variant https://invent.kde.org/cullmann/baloo-tbaloo It never took of, but yes, tracker has at least more contributors. Greetings Christoph HS

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

e that one should just stay away from using it, if we can't get more manpower to fix at least the most prominent cashes. I don't say that people working on it miss skills or passion, just that not enough people work on it to get this fixed. But that is naturally just my opinion. Greetings

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

. And one would always use the variant Windows uses. Hi, any more feedback about this? Greetings Christoph Greetings Christoph Nate

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

. Greetings Christoph Nate

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

, if we are atm moving stuff, might it make sense to move Baloo, too, given it only is usable with the daemon inside Plasma more or less, too? Greetings Christoph Baloo is linked by some apps, e.g. Elisa, and I wouldn't like to make them haul in Plasma stuff. Hi, some applications link

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

is usable with the daemon inside Plasma more or less, too? Greetings Christoph Without any de-KF-ication though this will break things though for building consumers soonish. Example --- 8< --- find_package(KF6 ${KF_MIN_VERSION} REQUIRED COMPONENTS CoreAddons Plasma ) --

Re: Frameworks / Plasma/ Gear Release Schedule Plan

quot;) set(QT_MAJOR_VERSION "6") set(KF_MIN_VERSION "5.240.0") set(KF_MAJOR_VERSION "6") in the first step and start later to remove the version ifs. Greetings Christoph

Re: Frameworks / Plasma/ Gear Release Schedule Plan

ot;, "stable": "none", "stable_kf5": "release/23.08", "trunk_kf5": "master"} Would it be something like: {"trunk": "master", "stable": "none", "stable_kf5": "release/23.08", "trunk_kf5": "none"} Greetings Christoph

Re: Frameworks / Plasma/ Gear Release Schedule Plan

me in. Let's make our Qt 6 based 'bundled' release next year a good one ;) Greetings Christoph Cheers, Albert Greetings Christoph >> - The KDE Gear release will move by 2 months to allow for the extra >> >> time needed for testing initial Qt6 changes >> >>

Re: Frameworks / Plasma/ Gear Release Schedule Plan

://invent.kde.org/utilities/kate/-/blob/master/.gitlab-ci.yml?ref_type=heads and require KF 6 + Qt 6 in the CMake files or is there additional stuff that needs updates to avoids one breaks stuff? Greetings Christoph - The KDE Gear release will move by 2 months to allow for the extra time needed

Re: These frameworks need new maintainers

on for all Frameworks. I second that, makes a lot more sense. Greetings Christoph Cheers Nico

KUserFeedback as framework for KF6

Hi, several of our projects use it, like Plasma and Kate. Can we make it a framework for KF6? Then we have finally regular releases that include bug fixes. Is there some opposition to do that? I asked in the past but there was just no reaction. Greetings Christoph

Re: portings aids in kf6?

Greetings Christoph -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

Re: KF5 branches

elease out this year. Greetings Christoph Regards David -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

Re: Please fix failing unit tests with Windows platform

(and wasting CI resources). I can take a look at some tests on Windows. But I would prefer to do so after we actually use the new GitLab CI. And yes, I agree, that it should be the goal to have no failing tests on all platforms we have a CI for. Greetings Christoph Cheers Friedrich

Re: Gitlab CI for Windows

On 2022-01-04 20:23, Ben Cooksley wrote: On Wed, Jan 5, 2022 at 6:36 AM Christoph Cullmann (cullmann.io [1]) wrote: On 2022-01-04 18:24, Ben Cooksley wrote: Hi all, Next update in this saga appears to be a defect in KDeclarative, which apparently has a hard dependency on KGlobalAccel

Re: Gitlab CI - Inbound

, too. Greetings Christoph -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

Raising required Qt version to 5.15.2

this, Qt 5.15.0 + .1 have a that broken QJSEngine that even the trivial KTextEditor JS unit tests random fail with GC crashs, I think it would make sense to really require at least some "working" version. Greetings Christoph -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

Re: Re KIO workers

ny suspicious reports in the next weeks, one can still turn it back off before the next release tagging. Greetings Christoph -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.15 - Build # 291 - Unstable!

Hi, On 2021-04-05 21:40, Adriaan de Groot wrote: On Monday, 5 April 2021 19:20:08 CEST Ben Cooksley wrote: On Tue, Apr 6, 2021 at 3:33 AM Christoph Cullmann > I reverted my test commit to see if we have still some unpatched 5.15 > with a broken QJSEngine around again. > > St

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.15 - Build # 291 - Unstable!

patch release? Greetings Christoph On 2021-04-05 17:27, CI System wrote: BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.15/291/ Project: kf5-qt5 FreeBSDQt5.15

Re: Requiring Qt 5.15 for KDE Frameworks 5?

. Greetings Christoph -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

Re: Should syntax-higlighting get 5.79.1 released with the control flow color fix?

5.79.1 out so we don't get complains that we changed black to Orange and the complains that we changed Orange to black next month. I would have no issues with a .1, guess I am just to ignorant for color changes. Greetings Christoph Cheers, Albert -- Ignorance is bliss... https

Re: Need xcb/xkb help for severe kglobalaccel_x11 issue

yet another timer ;=) Greetings Christoph -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

Re: KDE Frameworks 6 - Virtual Sprint setup

erred, any weekend starting from w6 should be possible. Count me in, too ;=) European hours preferred. Greetings Christoph -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann abandoned this revision. cullmann added a comment. I have now a working version that handles palette changes, too. https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/79 + usage in Kate https://invent.kde.org/utilities/kate/-/merge_requests/204 We

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. I need to finalize this, people start to complain more and more about this missing on Windows for Kate/etc... ;( REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart,

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. Hmm, I don't think you need a theme chooser, we just need to watch for the palette change signal and then trigger again the theme name setting based on the background palette. That would be enough to detect bright/dark mode. REPOSITORY R266 Breeze Icons

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. I think exporting some namespaced function or such that will do the setting of the theme and calling it would be ok for me. This is anyways an "opt-in" approach people must decide to use. Hannah, what do you think? REPOSITORY R266 Breeze Icons REVISION DETAIL

D25339: update lineHeight if boundingRect indicates a larger value.

cullmann commandeered this revision. cullmann edited reviewers, added: xuetianweng; removed: cullmann. cullmann added a comment. I think the solution we have in current master is ok enough. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: cullmann,

D25339: update lineHeight if boundingRect indicates a larger value.

cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: cullmann, #ktexteditor, dhaumann, #frameworks, rjvbb, xuetianweng Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, kde-frameworks-devel, kwrite-devel,

Re: KUserFeedback => Frameworks?

On 2020-09-26 21:52, Christoph Cullmann wrote: Hi, is there any real reason why KUserFeedback is yet no official framework? I just stumbled over this during my try to add it as dependency for the Windows builds of Kate. Given at least the Plasma Desktop itself and Kate uses this now

KUserFeedback => Frameworks?

releases? Greetings Christoph -- Ignorance is bliss... https://cullmann.io | https://kate-editor.org

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

On 2020-08-22 00:25, David Faure wrote: Hi Christoph, As part of my continuous effort to keep the KF5 CI "green", I submitted a MR for skipping the crashing tests if Qt is <= 5.15.0 : https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/18 The question is: does that

D23410: improve word completion to use highlighting to detect word boundaries

cullmann abandoned this revision. cullmann added a comment. At the moment no idea how to fix that without regressions. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23410 To: cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack,

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann closed this revision. cullmann added a comment. For my 2 wanted changes, I created a new merge request https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/20 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To:

D24826: Enforce 100 chars line width

cullmann added a comment. As said above, I think 100 is a bad idea. Can we close this? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24826 To: romangg, #frameworks, cullmann Cc: winterz, zzag, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack,

D25339: update lineHeight if boundingRect indicates a larger value.

cullmann added a comment. I think we went with the solution in https://phabricator.kde.org/D29789, could we close this? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb Cc: ahmadsamir,

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

On 2020-07-09 10:03, Christoph Cullmann wrote: On 2020-07-08 00:07, David Faure wrote: On mardi 7 juillet 2020 17:58:26 CEST Christoph Cullmann wrote: On 2020-07-07 12:16, David Faure wrote: > Yep :( > > You'll tell Simon and/or QTBUG-*? I will take a look if I can find some exi

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

On 2020-07-08 00:07, David Faure wrote: On mardi 7 juillet 2020 17:58:26 CEST Christoph Cullmann wrote: On 2020-07-07 12:16, David Faure wrote: > Yep :( > > You'll tell Simon and/or QTBUG-*? I will take a look if I can find some existing bug or open a new. Simon left Qt, or? Yes bu

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

On 2020-07-07 12:16, David Faure wrote: Yep :( You'll tell Simon and/or QTBUG-*? I will take a look if I can find some existing bug or open a new. Simon left Qt, or? Greetings Christoph On lundi 6 juillet 2020 16:28:27 CEST Christoph Cullmann wrote: Hi, this shows again a different V4

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

+0x1ca0f0) #6 0x7f58bc65b06d (/memfd:JITCode:QtQml (deleted)+0x6d) :( Thought 5.15 would have all needed fixes. Greetings Christoph On 2020-07-05 15:47, CI System wrote: BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. That depends. If somebody else would test this and we can agree that this is a nicer way to hard-code breeze icons compared to having that code in kiconthemes it would make sense. REPOSITORY R266 Breeze Icons REVISION DETAIL

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

On 2020-05-25 16:34, Christoph Cullmann wrote: On 2020-05-25 16:29, David Faure wrote: Isn't this fixed by https://codereview.qt-project.org/c/qt/qtdeclarative/+/300911 ? (This fix happened because I reported this ktexteditor CI ASAN failure to Simon Haussman, who fixed qtdeclarative) IIUC

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

, too. I have at the moment here no 5.15 compile/install to test that out. Greetings Christoph Cheers, David. On samedi 23 mai 2020 15:08:28 CEST Christoph Cullmann wrote: Hi, I did a bit research, I think this might be https://bugreports.qt.io/browse/QTBUG-84363 => This makes actually Qt 5

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

ere, will need to investigate that more. Seems other users stumble on this for all parts of our products, e.g. https://bugs.kde.org/show_bug.cgi?id=415872 https://bugs.kde.org/show_bug.cgi?id=414768 Greetings Christoph On 2020-05-21 13:09, CI System wrote: BUILD UNSTABLE Build

D28235: Add a simpler example

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. ;=) Actually, I just missed this request, sorry. I think there is no issue with have an extra example. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL

D29050: WIP KRunner fix prepare/teardown signals

cfeck added a project: Plasma. cfeck added a comment. If this is no longer Work-In-Progress, please remove "WIP" from the title. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: cfeck, kde-frameworks-devel, Orage,

D29793: Rename Perl6 syntax to Raku

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think it makes sense to have just "Raku", the world at large (like me) only recognizes Perl 5 as Perl .P REPOSITORY R216 Syntax Highlighting BRANCH rename-perl6-raku REVISION

D29795: Add collaboration guide

cullmann added a comment. I think this is very good thing to have. But perhaps we just should add that to the README.md that is prominently shown on e.g. https://invent.kde.org/frameworks/syntax-highlighting The README anyways already contains a "Adding unit tests for a syntax

D29789: Make text always align with font base line

cullmann closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D29789 To: xuetianweng, rjvbb, dhaumann, cullmann Cc: brauch, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

D29789: Make text always align with font base line

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Hmm, looks better for me, too. Let's go with this at the moment. If it creates issues, we can still revert it again. Thanks for taking care of this. For the option: some

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

cullmann added a comment. Sure, thanks for the improvement! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D29735 To: bewuethr, #framework_syntax_highlighting, dhaumann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n,

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

This revision was automatically updated to reflect the committed changes. Closed by commit R216:f804af905ef3: Assign Identifier attribute to opening double quote instead of Comment (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D27844: Store and fetch complete view config in and from session config

cullmann added a comment. Hmm, right, didn't think about that :( Guess if we want to have this, we need to improve the read/writeConfig functions. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27844 To: kossebau, #kate, loh.tar, cullmann, dhaumann Cc:

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

cfeck added a comment. Sorry if I don't understand the scope, but does this mean I am forced to install systemsettings to be able to use KCMs? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: cfeck, kde-frameworks-devel,

D25339: update lineHeight if boundingRect indicates a larger value.

cullmann added a comment. F8304597: lineheight.patch see e.g. here for a start of using the right heights inside the renderer. for a dynamically wrapped line, the lines before the last one get now the right height for me. But there are a

D25339: update lineHeight if boundingRect indicates a larger value.

cullmann added a comment. In D25339#666877 , @rjvbb wrote: > > Looking at the code, might it make more sense to just move away from the fixed height we have? > > It isn't used that often and in most cases one could just query the height

D29354: Bash: fix comments after escapes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:1e8466029c82: Bash: fix comments after escapes (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D29354: Bash: fix comments after escapes

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Same here ;=) Thanks a lot for the work on all this issues! REPOSITORY R216 Syntax Highlighting BRANCH fix-comments-bash REVISION DETAIL https://phabricator.kde.org/D29354 To:

D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-folding-latex REVISION DETAIL https://phabricator.kde.org/D29521 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0b6c88cfc167: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

cullmann added a comment. Looks fine for me, thanks for improvement! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D29521 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack,

D25339: update lineHeight if boundingRect indicates a larger value.

cullmann added a comment. Looking at the code, might it make more sense to just move away from the fixed height we have? It isn't used that often and in most cases one could just query the height of the current line. That would solve this issue without needing any hacks for the rendering

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

cfeck added inline comments. INLINE COMMENTS > kcolorcombo.cpp:89 > +int unused, v; > +innercolor.getHsv(, , ); > +textColor = v > 128 ? Qt::black : Qt::white; Please don't use "value" component to calculate the brightness of a color. #81 is much darker

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

cfeck added a comment. Does the delegate ensure the text is rendered in a color visible over the colored background? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: cfeck,

D25814: [KColorScheme] Add SeparatorColor

cfeck added a comment. There is QPalette::Button, but I don't see any hover/focus colors in QPalette. If we want more roles, we seriously need to contribute them upstream. Qt 6 is a chance to avoid diverging more. REPOSITORY R265 KConfigWidgets REVISION DETAIL

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

cullmann added a reviewer: Frameworks. cullmann added a comment. I tried the current version. For me this looks OK now. Thought I would like to have more people trying this out before we merge. Some volunteers? Beside this: Thanks for working on this issue. REPOSITORY R39

D28870: Updated test file for Logtalk syntax highlighting

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28870 To: pmoura, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns,

D28870: Updated test file for Logtalk syntax highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:559cda73cf57: Updated test file for Logtalk syntax highlighting (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D28796: Update Logtalk language syntax support

This revision was automatically updated to reflect the committed changes. Closed by commit R216:bf2664ea7907: Update Logtalk language syntax support (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28796?vs=80017=81172

D28796: Update Logtalk language syntax support

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, I see, there is an extra request for the new hl test file. Then let's approve this one. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28796

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

cullmann added a comment. Hmm, after applying this patch, for me, no text is visible at all. By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of ktexteditor toplevel dir). F8246692: kwrite_no_text.png REPOSITORY R39

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

cullmann added a comment. I appreciate work on this issue. I am not sure about how well this "hack" will solve the issue, thought. I will give it a try here in any case. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: xuetianweng, #ktexteditor,

D28814: TypeScript: add the "awaited" type operator

This revision was automatically updated to reflect the committed changes. Closed by commit R216:1f1f03198aa7: TypeScript: add the awaited type operator (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D28814: TypeScript: add the "awaited" type operator

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks ;=) Even with test. REPOSITORY R216 Syntax Highlighting BRANCH add-awaited-typescript REVISION DETAIL https://phabricator.kde.org/D28814 To: nibags,

D28796: Update Logtalk language syntax support

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Change looks reasonable, but could that testfile be added to our autotests directory? (or the file we have there extended) The current auto test file is

D25267: Improve XCF support

cfeck added a comment. Thanks for your work, Martin! Could you please add a note (or resolve) bug 360821? REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D25267 To: sandsmark, aacid, cfeck, apol, vkrause Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack,

D27844: Store and fetch complete view config in and from session config

cullmann added a comment. Yes, please push, thanks! REPOSITORY R39 KTextEditor BRANCH fullviewconfigsessionsupport REVISION DETAIL https://phabricator.kde.org/D27844 To: kossebau, #kate, loh.tar, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack,

D28303: LaTeX: fix math parentheses in optional labels

This revision was automatically updated to reflect the committed changes. Closed by commit R216:213d4bb197a3: LaTeX: fix math parentheses in optional labels (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

  1   2   3   4   5   6   7   8   9   10   >