D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

patrickelectric accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH named_color_support REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: cblack, broulik,

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

patrickelectric added inline comments. INLINE COMMENTS > kcolorcombo.cpp:67 > // inner color > +QVariant tv = index.data(Qt::DisplayRole); > QVariant cv = index.data(ColorRole); Missing const. > kcolorcombo.cpp:69 > QVariant cv = index.data(ColorRole); > +QColor

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

patrickelectric added a comment. Just some small tips. INLINE COMMENTS > kcolorcombo.cpp:74 > bool paletteBrush = (k_colorcombodelegate_brush(index, > Qt::BackgroundRole).style() == Qt::NoBrush); > -if (isSelected) { > -innercolor =

D29511: Label: Add ping-pong logic

patrickelectric added a comment. Thanks @davidedmundson and @ognarb, I was able to replicate the issue, I'll think a bit more in my approach REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29511 To: patrickelectric, #plasma, #vdg, ognarb,

D29511: Label: Add ping-pong logic

patrickelectric added a comment. Outoput: F8294587: deepin-screen-recorder_qmlscene_20200507124715.gif REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29511 To: patrickelectric, #plasma, #vdg Cc: cblack,

D29511: Label: Add ping-pong logic

patrickelectric updated this revision to Diff 82218. patrickelectric added a comment. Update style REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29511?vs=82217=82218 BRANCH ping_pong_text REVISION DETAIL

D29511: Label: Add ping-pong logic

patrickelectric created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. patrickelectric requested review of this revision. REVISION SUMMARY Add friendly ping-pong animation to allow visibility of full text in an animated way

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

This revision was automatically updated to reflect the committed changes. Closed by commit R240:e8abb9601c7d: ECMAddAppIcon: Add sc in regex to extract extension from valid names (authored by patrickelectric). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

patrickelectric added a comment. @apol I did update the commit body to explain why. For the text I used https://regex101.com with the icon in the commit body and printing the variables of CMAKE_MATCH_1 and CMAKE_MATCH_2 Let me know if you agree with this to land the patch, this is

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

patrickelectric updated this revision to Diff 73927. patrickelectric added a comment. Add commit body REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26751?vs=73830=73927 BRANCH sc_appicon REVISION DETAIL https://phabricator.kde.org/D26751

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

patrickelectric added a comment. Hi @cgiboudeaux, thanks for the explanation, I'll take a look and get back here. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26752 To: patrickelectric, apol, tcanabrava, cgiboudeaux, bcooksley Cc: bcooksley,

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

patrickelectric added a comment. Hi @cgiboudeaux and @bcooksley, there is a reason of why this patch is valid. Have you read the commit message ? In #kirogi we provide a valid icon (svg) with a valid prefix (sc), as you probably know *sc* stands

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

patrickelectric retitled this revision from "ECMAddAppIcon: Do not warn about mac icons if isnt a mac build" to "ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build". REPOSITORY R240 Extra CMake Modules BRANCH warning_icons REVISION DETAIL

D26752: ECMAddAppIcon: Do not warn about mac icons if isnt a mac build

patrickelectric added reviewers: apol, tcanabrava. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26752 To: patrickelectric, apol, tcanabrava Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26752: ECMAddAppIcon: Do not warn about mac icons if isnt a mac build

patrickelectric created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. patrickelectric requested review of this revision. REVISION SUMMARY KSVG2ICNS will not exist if the program is not being compiled to APPLE

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

patrickelectric added a reviewer: apol. REPOSITORY R240 Extra CMake Modules BRANCH sc_appicon REVISION DETAIL https://phabricator.kde.org/D26751 To: patrickelectric, tcanabrava, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

patrickelectric added a comment. From ECMInstallIcons: is a numeric pixel size (typically 16, 22, 32, 48, 64, 128 or 256) or sc for scalable (SVG) files, is one of the standard FreeDesktop.org icon groups (actions, animations, apps, categories, devices, emblems, emotes, intl,

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

patrickelectric created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. patrickelectric requested review of this revision. REVISION SUMMARY Signed-off-by: Patrick José Pereira REPOSITORY R240 Extra CMake

D26130: Simplify return logic

patrickelectric added a comment. In D26130#582447 , @ervin wrote: > In D26130#582391 , @tcanabrava wrote: > > > In D26130#582343 , @ervin wrote: > > >

D26130: Simplify return logic

patrickelectric accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH simplifyVarPath REVISION DETAIL https://phabricator.kde.org/D26130 To: tcanabrava, patrickelectric Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26131: Braces around for, break early.

patrickelectric added inline comments. INLINE COMMENTS > kconfig_compiler.cpp:619 > bool isAscii = true; > -for (int i = s.length(); i--;) > +for (int i = s.length(); i--;) { > if (s[i].unicode() > 127) { std::any_of ? REPOSITORY R237 KConfig REVISION DETAIL

D19965: kactivities: remove unused variable

This revision was automatically updated to reflect the committed changes. Closed by commit R6:cfdb14b01898: kactivities: remove unused variable (authored by carneirogustavo, committed by patrickelectric). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE

D6103: scan the whole install folder for qml dependencies

patrickelectric added a comment. I don't know if is related to this commit, but when compiling my application via kirigami with `make create-*` and uploading to my cellphone, a white screen appears. Using adb to debug with logcat, this error took my attention: `libatcore-gui.so:

D5646: Solve problem with microphone-sensitivity-medium

patrickelectric abandoned this revision. patrickelectric added a comment. Problem solved with https://phabricator.kde.org/R266:2b49fafc60235a83ffd8b92a24f800d622cc3050 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D5646 To: patrickelectric, #kate, andreaska

D5645: Add Arduino extension

This revision was automatically updated to reflect the committed changes. Closed by commit R216:ba8ed1f28885: Add Arduino extension (authored by patrickelectric). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5645?vs=13945=13985 REVISION DETAIL

D5646: Solve problem with microphone-sensitivity-medium

patrickelectric created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY error: Namespace prefix inkscape for connector-curvature on path is not defined class="ColorScheme-Text" />

D5645: Add Arduino extension

patrickelectric created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Signed-off-by: Patrick José Pereira REPOSITORY R216 Syntax Highlighting BRANCH arduino REVISION