shumski added inline comments.

INLINE COMMENTS

> CMakeLists.txt:82
>  
> +ecm_install_qch_export(
> +    TARGETS KF5JobWidgets_QCH

I wonder about the reasoning behind the existence of this export, and 
installation of it...

> CMakeLists.txt:98
> +    TAGFILE_INSTALL_DESTINATION ${KDE_INSTALL_FULL_DATADIR}/qch
> +    QCH_INSTALL_DESTINATION ${KDE_INSTALL_FULL_DATADIR}/qch
> +)

Is this really the right place?

REVISION DETAIL
  https://phabricator.kde.org/D3439

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks, ochurlaud
Cc: shumski

Reply via email to