ltoscano added a comment.
Created and added the KConfig repository.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D3386
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #frameworks, dfaure, mdawson
Cc: ltoscano,
aacid added a comment.
Is this another patch that doesn't say to which repository it applies? Or am
i just too stupid to find it in phabricator?
REVISION DETAIL
https://phabricator.kde.org/D3386
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
graesslin added a comment.
ping!
REVISION DETAIL
https://phabricator.kde.org/D3386
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #frameworks
Cc: apol
apol added a comment.
Then please include a test with your new feature.
REVISION DETAIL
https://phabricator.kde.org/D3386
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #frameworks
Cc: apol
graesslin added a comment.
Just checked: the only test with a combination of arg="true" and singleton is
signals_test_singleton.kcfgc which is used by kconfigcompiler_test_signals.cpp,
but there is no code comparison in that test.
The only other arg="true" case is test8a.kcfg, but that
graesslin added a comment.
In https://phabricator.kde.org/D3386#63201, @apol wrote:
> How can tests still pass? they compare the generated code.
eh no idea. I did a make clean, make, make test in the folder. Maybe there is
no test for the singleton + arg="true" combination?
apol added a comment.
How can tests still pass? they compare the generated code.
REVISION DETAIL
https://phabricator.kde.org/D3386
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #frameworks
Cc: apol
