kossebau added a comment.
Okay, thanks for fixing for Qt 5.8. Cherry-picked your commit also for the
Plasma/5.8 branch now for upcoming Plasma 5.8.4 release, given Plasma 5.9.0
will only appear after Qt 5.8.0 (by schedules at least), so chances are people
will want to run 5.8 with 5.8 :)
dfaure added a comment.
git log says this is qtbase commit 1a42124, from before v5.8.0-alpha1.
So I'll check for 5.8 and use clone, thanks for the information.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D3796
EMAIL PREFERENCES
kossebau added inline comments.
INLINE COMMENTS
> dfaure wrote in kdeplatformfiledialoghelper.cpp:368
> This does NOT build for me.
>
> qplatformdialoghelper.h:295:5: error:
> ‘QFileDialogOptions::QFileDialogOptions(const QFileDialogOptions&)’ is private
>
dfaure added inline comments.
INLINE COMMENTS
> kdeplatformfiledialoghelper.cpp:368
> +// like file://, so we have to do it ourselves
> +QSharedPointer opt(new
> QFileDialogOptions(*options()));
> +opt->setInitialDirectory(m_dialog->directory());
This does NOT build for me.
