[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

nalvarez added a comment. This might be better solved by a krazy-like check, instead of making the compilation fail... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. I start to agree that it's probably better to revert this patch, for the simple reason: We might break compilation of a project using boost if boost decides to add code which uses alternative tokens to any of its headers. This is not under our control. On the

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

elvisangelaccio added a comment. In https://phabricator.kde.org/D3850#72081, @kfunk wrote: > In https://phabricator.kde.org/D3850#72077, @elvisangelaccio wrote: > > > What about adding a way (cmake variable?) to opt-in if one wants to use the alternative operators? Personally I like

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. Note: I'll push this after the imminent KF5 release if no-one objects. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. In https://phabricator.kde.org/D3850#72308, @rakuco wrote: > Isn't it better to use `check_cxx_compiler_flag` to see if the flag is supported and enable it in case it is? -fno-operator-names is an ancient compiler flag, supported by GCC since at least 2000

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

rakuco added a comment. Isn't it better to use `check_cxx_compiler_flag` to see if the flag is supported and enable it in case it is? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. In https://phabricator.kde.org/D3850#72077, @elvisangelaccio wrote: > What about adding a way (cmake variable?) to opt-in if one wants to use the alternative operators? Personally I like and use them whenever I start something from scratch... Hmm... You

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

elvisangelaccio added a comment. What about adding a way (cmake variable?) to opt-in if one wants to use the alternative operators? Personally I like and use them whenever I start something from scratch... REPOSITORY R240 Extra CMake Modules REVISION DETAIL

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. Note: Just refreshing my complete KF5 build to test the change. kactivities fails: /home/kfunk/devel/src/kf5/kactivities/autotests/common/test.h:143:25: error: token is not a valid binary operator in a preprocessor subexpression #if defined(Q_NO_DEBUG)