[Differential] [Commented On] D4510: Python bindings: Restore handling of deprecated constructs.

2017-02-12 Thread Shaheed Haque
shaheed added inline comments. INLINE COMMENTS > skelly wrote in sip_generator.py:172 > It was possible to handle exports without looking for the text EXPORT in the > MACRO NAME. Why is deprecated different? Because the expansion of the attribute in this case contains not a string, but a

[Differential] [Commented On] D4510: Python bindings: Restore handling of deprecated constructs.

2017-02-12 Thread Stephen Kelly
skelly added inline comments. INLINE COMMENTS > sip_generator.py:172 > """ > +if member.kind == CursorKind.UNEXPOSED_ATTR and > text.find("_DEPRECATED") != -1: > +sip["annotations"].add("Deprecated") It was possible to handle exports without looking for the text