Re: [kcoreaddons] src/lib: Revert "Warning--"

2018-04-23 Thread Ivan Čukić
Sorry for the noise, saw that the patch was fixed and committed again. Gah...

Re: [kcoreaddons] src/lib: Revert "Warning--"

2018-04-23 Thread Ivan Čukić
Hi Ben, Is it possible to have cgit.kde.org show commit hashes in the 'log' tab (for example [1])? As for the Laurent's patch, it looks quite sane, so I guess the failed compilation for other platforms should be investigated further (I've put Laurent in the TO: field because of this). Cheers,

[kcoreaddons] src/lib: Revert "Warning--"

2018-04-20 Thread Ben Cooksley
Git commit bf353edc42fdecf9fda34a024ba7cabcd0efaf68 by Ben Cooksley. Committed on 20/04/2018 at 08:47. Pushed by bcooksley into branch 'master'. Revert "Warning--" The changes in these commits fail on all platforms aside from Linux, breaking the FreeBSD, Android and Windows builds. CCMAIL: