Re: [knewstuff] src/kmoretools: Use pimpl for KMoreToolsMenuFactory

2015-06-18 Thread Gregor Mi
Am 01.06.2015 09:48 schrieb David Faure: On Thursday 21 May 2015 14:41:27 Gregor Mi wrote: private: -// Note that this object must live long enough in case the user opens -// the "Configure..." dialog -KMoreTools* m_kmt = nullptr; - -QMenu* m_menu = nullptr; +KMoreToolsM

Re: [knewstuff] src/kmoretools: Use pimpl for KMoreToolsMenuFactory

2015-06-01 Thread David Faure
On Monday 01 June 2015 10:22:19 Gregor Mi wrote: > Am 01.06.2015 09:48 schrieb David Faure: > > On Thursday 21 May 2015 14:41:27 Gregor Mi wrote: > >> private: > >> -// Note that this object must live long enough in case the user > >> opens > >> -// the "Configure..." dialog > >> -KMor

Re: [knewstuff] src/kmoretools: Use pimpl for KMoreToolsMenuFactory

2015-06-01 Thread David Faure
On Thursday 21 May 2015 14:41:27 Gregor Mi wrote: > private: > -// Note that this object must live long enough in case the user opens > -// the "Configure..." dialog > -KMoreTools* m_kmt = nullptr; > - > -QMenu* m_menu = nullptr; > +KMoreToolsMenuFactoryPrivate* d; > }; > E