On Sat, Mar 30, 2019 at 10:46 PM Volker Krause wrote:
>
> On Friday, 29 March 2019 20:54:54 CET Ben Cooksley wrote:
> > On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl
> > > I fear that a mandatory reviews would add too juch strain on smaller
> > > teams. If there's just one person with an
Am 29.03.19 um 21:01 schrieb Ben Cooksley:
> With the shift to Gitlab we should be able to provide this hopefully.
>
> We're still figuring out how to be able to provide CI in an easy to
> maintain manner (in terms of controlling platforms builds are done
> for, which branches, etc).
In case, an
On Friday, 29 March 2019 20:54:54 CET Ben Cooksley wrote:
> On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl
> > I fear that a mandatory reviews would add too juch strain on smaller
> > teams. If there's just one person with an intimate knowledge of the
> > code-base, plus two co-developers,
On Fri, Mar 29, 2019 at 9:56 PM Kevin Ottens wrote:
>
> Hello,
>
> On Thursday, 28 March 2019 20:35:11 CET Dr.-Ing. Christoph Cullmann wrote:
> > I and others tried to get more reviews done in the past, but actually I
> > merged more than once stuff that I reviewed but it did break the CI.
>
>
On Fri, Mar 29, 2019 at 10:35 PM David Faure wrote:
>
> On jeudi 28 mars 2019 16:56:33 CET laurent Montel wrote:
> > CI: sometime I look at it, sometime not, sometime some guys informs me that
> > it's broken (I remember that Luca told me some days ago that a package
> > didn't compile, so I
On Fri, Mar 29, 2019 at 10:33 PM Friedrich W. H. Kossebau
wrote:
>
> Am Donnerstag, 28. März 2019, 23:06:17 CET schrieb laurent Montel:
> > Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit :
> > > Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel:
> > > > Le
On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl
wrote:
>
> Hi,
Hi,
>
> (Sorry for top-posting)
>
> I fear that a mandatory reviews would add too juch strain on smaller teams.
> If there's just one person with an intimate knowledge of the code-base, plus
> two co-developers, then who
+1 for this. I think running tests before merging is more acceptable than
having mandatory reviews.
On 29 March 2019 11:10:52 GMT+00:00, Ovidiu-Florin Bogdan
wrote:
>Hello,
>
>A Merge Request in GitLab does not necessarily imply the need for a
>review by e person. It can just run a pipeline to
Hello,
On Thursday, 28 March 2019 20:35:11 CET Dr.-Ing. Christoph Cullmann wrote:
> I and others tried to get more reviews done in the past, but actually I
> merged more than once stuff that I reviewed but it did break the CI.
That I hope we'll get fixed at some point. It's a big big advantage
Hello,
A Merge Request in GitLab does not necessarily imply the need for a review by e
person. It can just run a pipeline to validate that the code isn't broken. If
the pipeline fails, the merge button is not available.
We use GitLab at work and we have it set up like this:
* Main branches
On jeudi 28 mars 2019 16:56:33 CET laurent Montel wrote:
> CI: sometime I look at it, sometime not, sometime some guys informs me that
> it's broken (I remember that Luca told me some days ago that a package
> didn't compile, so I fixed it).
I think the solution to all this is quite simple. If
Am Donnerstag, 28. März 2019, 23:06:17 CET schrieb laurent Montel:
> Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit :
> > Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel:
> > > Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit :
> > > >
Hello,
On Friday, 29 March 2019 09:43:44 CET Volker Krause wrote:
> On Friday, 29 March 2019 08:59:59 CET Kevin Ottens wrote:
> > On Thursday, 28 March 2019 21:53:06 CET Alexander Neundorf wrote:
> > > Having mandatory reviews for a central and complex component like
> > > akonadi
> > > looks
On Friday, 29 March 2019 08:59:59 CET Kevin Ottens wrote:
> On Thursday, 28 March 2019 21:53:06 CET Alexander Neundorf wrote:
> > Having mandatory reviews for a central and complex component like akonadi
> > looks like a very good and obvious idea.
>
> Yep.
Looking at the 18.12 -> 19.04
Hello,
On Thursday, 28 March 2019 21:53:06 CET Alexander Neundorf wrote:
> On 2019 M03 28, Thu 16:04:01 CET Boudhayan Gupta wrote:
> > As a user, I simply do not want unreviewed crap running on my computer.
> > Yes, crap, because no software engineer writes bug-free code all the time,
> > and if
Hi,
(Sorry for top-posting)
I fear that a mandatory reviews would add too juch strain on smaller teams. If
there's just one person with an intimate knowledge of the code-base, plus two
co-developers, then who should do the reviews?
How about a distinction based on importance of a project
On Thu, Mar 28, 2019, 6:36 AM Friedrich W. H. Kossebau
wrote:
> Am Donnerstag, 28. März 2019, 09:29:22 CET schrieb Kevin Ottens:
> > Hello,
> >
> > On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote:
> > > Please note that the commits in this instance were pushed without
> > > review, so
Hi,
On Thu, 28 Mar 2019 at 15:21, Kevin Ottens wrote:
> Hello,
>
> On Thursday, 28 March 2019 14:33:59 CET laurent Montel wrote:
> > I am against to force mandatory review, as it will create a lot of lose
> of
> > time,
>
> As I said, unpopular.
>
I don't get why mandatory code reviews are so
With regards to the discussion about mandatory code review, I think it's
important to avoid immediately rushing to create new policy as a result of a
particular event or abuse. It's always tempting to try to put in place a rule
that would have avoided the problem if it had existed and was being
On Thu, Mar 28, 2019 at 10:09 AM Luca Beltrame wrote:
>
> In data giovedì 28 marzo 2019 09:50:47 CET, Kevin Ottens ha scritto:
> > I'd argue we're loosing more with the current state of PIM than we'd loose
> > with mandatory reviews.
>
> Perhaps, instead of an all-or-nothing approach, why not a
On 28 March 2019 13:33:59 GMT, laurent Montel wrote:
> Le jeudi 28 mars 2019, 09:29:22 CET Kevin Ottens a écrit :
> > Hello,
> >
> > On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote:
> > > Please note that the commits in this instance were pushed without
> > > review, so
On Чт, Mar 28, 2019 at 19:40, Ben Cooksley wrote:
Hi all,
We currently have a rather substantial issue, in that the CI system
has been once again left in a position where it isn't possible to make
any changes to the system.
This means we can't update to newer versions of packages, add new
Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit :
> Thanks for reply. More below:
>
> Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel:
> > Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit :
> > > Hi Laurent,
> > >
> > > Am Donnerstag,
Hi,
On 2019 M03 28, Thu 16:04:01 CET Boudhayan Gupta wrote:
> Hi,
>
> On Thu, 28 Mar 2019 at 15:21, Kevin Ottens wrote:
> > Hello,
> >
> > On Thursday, 28 March 2019 14:33:59 CET laurent Montel wrote:
> > > I am against to force mandatory review, as it will create a lot of lose
> >
> > of
> >
Hi,
> Hi,
>
> On Thu, 28 Mar 2019 at 15:21, Kevin Ottens wrote:
>
>> Hello,
>>
>> On Thursday, 28 March 2019 14:33:59 CET laurent Montel wrote:
>> > I am against to force mandatory review, as it will create a lot of lose
>> of
>> > time,
>>
>> As I said, unpopular.
>>
>
> I don't get why
Kevin Ottens schrieb am Do., 28. März 2019, 09:29:
> Hello,
>
> On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote:
> > Please note that the commits in this instance were pushed without
> > review, so restrictions on merge requests wouldn't make a difference
> > in this case
Thanks for reply. More below:
Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel:
> Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit :
> > Hi Laurent,
> >
> > Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel:
> > > For example I works all days
Am Donnerstag, 28. März 2019, 16:04:01 CET schrieb Boudhayan Gupta:
> I don't care if you lose time. I don't want the guys building my house to
> cut corners mixing my concrete because it's going to save time.
There is a difference here though, no? The people building your house will
not live in
On Thursday, 28 March 2019 16:11:12 CET Friedrich W. H. Kossebau wrote:
> Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel:
> > For example I works all days on kde (pim or other) when I wake up, or at
> > noon after my lunch or the evening, I will not wait several days for a
> >
On Thu, Mar 28, 2019 at 3:57 PM David Jarvie wrote:
> I agree. Mandatory reviews might work if there is a team of active people
> working on a project, but if there is only one person with real knowledge of
> the code
We do have common ownership of code, so if there is only one person
with
On Thursday, 28 March 2019 16:32:34 CET Luca Beltrame wrote:
> In data giovedì 28 marzo 2019 15:15:23 CET, Nate Graham ha scritto:
> > In this case, it seems like the problem is that there are certain
> > individuals or teams that are pushing risky, breaking changes without code
> > review, and
Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit :
> Hi Laurent,
>
> Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel:
> > For example I works all days on kde (pim or other) when I wake up, or at
> > noon after my lunch or the evening, I will not wait several
On Thursday, March 28, 2019 3:39:54 PM CET Friedrich W. H. Kossebau wrote:
> Am Donnerstag, 28. März 2019, 11:27:44 CET schrieb Daniel Vrátil:
> > I'm completely fine with mandatory code review for everything and I'd be
> > happy to have this in PIM. I think the biggest problem in PIM to overcome
Hello,
On Thursday, 28 March 2019 16:11:12 CET Friedrich W. H. Kossebau wrote:
> Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel:
> > For example I works all days on kde (pim or other) when I wake up, or at
> > noon after my lunch or the evening, I will not wait several days for
In data giovedì 28 marzo 2019 15:15:23 CET, Nate Graham ha scritto:
> In this case, it seems like the problem is that there are certain
> individuals or teams that are pushing risky, breaking changes without code
> review, and then ignoring failures in the CI. I think we might do well to
> try to
In data giovedì 28 marzo 2019 16:04:01 CET, Boudhayan Gupta ha scritto:
> I don't get why mandatory code reviews are so unpopular.
It's not "unpopular". As far as the discussion goes, the opinions (from
several parties) say that they're not a silver bullet, and that some projects
benefit from
Hi Laurent,
Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel:
> For example I works all days on kde (pim or other) when I wake up, or at
> noon after my lunch or the evening, I will not wait several days for a
> review because nobody has time to do it.
>
> (For example I make ~
Am Donnerstag, 28. März 2019, 11:27:44 CET schrieb Daniel Vrátil:
> I'm completely fine with mandatory code review for everything and I'd be
> happy to have this in PIM. I think the biggest problem in PIM to overcome
> will be finding the reviewers - I dare say I'm currently the only one who
> has
Hello,
On Thursday, 28 March 2019 14:33:59 CET laurent Montel wrote:
> I am against to force mandatory review, as it will create a lot of lose of
> time,
As I said, unpopular.
> and we will not be sure that review is correct (see comment from
> Volker about "transaction lock regression")
This
Le jeudi 28 mars 2019, 09:29:22 CET Kevin Ottens a écrit :
> Hello,
>
> On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote:
> > Please note that the commits in this instance were pushed without
> > review, so restrictions on merge requests wouldn't make a difference
> > in this case
Hello,
On Thursday, 28 March 2019 11:27:44 CET Daniel Vrátil wrote:
> I'm completely fine with mandatory code review for everything and I'd be
> happy to have this in PIM. I think the biggest problem in PIM to overcome
> will be finding the reviewers - I dare say I'm currently the only one who
>
Am Donnerstag, 28. März 2019, 09:29:22 CET schrieb Kevin Ottens:
> Hello,
>
> On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote:
> > Please note that the commits in this instance were pushed without
> > review, so restrictions on merge requests wouldn't make a difference
> > in this case
On Thursday, March 28, 2019 9:50:47 AM CET Kevin Ottens wrote:
> Hello,
>
> On Thursday, 28 March 2019 09:41:29 CET Luca Beltrame wrote:
> > In data giovedì 28 marzo 2019 09:29:22 CET, Kevin Ottens ha scritto:
> > > at your screen or pair with you" in the past. Clearly this compromise
> > > gets
On Thursday, 28 March 2019 09:50:47 CET Kevin Ottens wrote:
> Hello,
>
> On Thursday, 28 March 2019 09:41:29 CET Luca Beltrame wrote:
> > In data giovedì 28 marzo 2019 09:29:22 CET, Kevin Ottens ha scritto:
> > > at your screen or pair with you" in the past. Clearly this compromise
> > > gets
> >
Hello,
On Thursday, 28 March 2019 10:35:37 CET Luca Beltrame wrote:
> In data giovedì 28 marzo 2019 10:32:39 CET, Kevin Ottens ha scritto:
> > OK, to be fair not 100% today's situation because of the above. It was
> > based on best judgment maybe we're missing such a set of guidelines. I
> >
In data giovedì 28 marzo 2019 10:32:39 CET, Kevin Ottens ha scritto:
> OK, to be fair not 100% today's situation because of the above. It was based
> on best judgment maybe we're missing such a set of guidelines. I admit I'm
> slightly doubtful though.
I can't claim it may work 100%, but I've
Hello,
On Thursday, 28 March 2019 10:08:54 CET Luca Beltrame wrote:
> In data giovedì 28 marzo 2019 09:50:47 CET, Kevin Ottens ha scritto:
> > I'd argue we're loosing more with the current state of PIM than we'd loose
> > with mandatory reviews.
>
> Perhaps, instead of an all-or-nothing
In data giovedì 28 marzo 2019 10:17:18 CET, Tomaz Canabrava ha scritto:
> The problem is that a git comit is a git commit, there's no way that a
> typo will be treated differently then another commit.
It's a "social" problem and not a technical one: you can see it across
repositories managed by
In data giovedì 28 marzo 2019 09:50:47 CET, Kevin Ottens ha scritto:
> I'd argue we're loosing more with the current state of PIM than we'd loose
> with mandatory reviews.
Perhaps, instead of an all-or-nothing approach, why not a minimal set of
"requirements" that would require a review? Yes, it
Hello,
On Thursday, 28 March 2019 09:41:29 CET Luca Beltrame wrote:
> In data giovedì 28 marzo 2019 09:29:22 CET, Kevin Ottens ha scritto:
> > at your screen or pair with you" in the past. Clearly this compromise gets
> > somewhat exploited and that's especially bad in the case of a fragile and
>
In data giovedì 28 marzo 2019 09:29:22 CET, Kevin Ottens ha scritto:
> at your screen or pair with you" in the past. Clearly this compromise gets
> somewhat exploited and that's especially bad in the case of a fragile and
> central component like KDE PIM.
I'm not sure I agree. I can't speak for
Hello,
On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote:
> Please note that the commits in this instance were pushed without
> review, so restrictions on merge requests wouldn't make a difference
> in this case unfortunately.
Maybe it's about time to make reviews mandatory... I know
On Thu, Mar 28, 2019 at 7:56 PM Konstantin Kharlamov wrote:
>
>
>
> On Чт, Mar 28, 2019 at 19:40, Ben Cooksley wrote:
> > Hi all,
> >
> > We currently have a rather substantial issue, in that the CI system
> > has been once again left in a position where it isn't possible to make
> > any changes
Hi all,
We currently have a rather substantial issue, in that the CI system
has been once again left in a position where it isn't possible to make
any changes to the system.
This means we can't update to newer versions of packages, add new
packages or correct for binary incompatible changes
54 matches
Mail list logo
