D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

2018-02-19 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:03be39f3709e: [KUrlNavigatorPlacesSelector] Put categories into submenus (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10329?vs=26598=27522

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

2018-02-19 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10329 To: broulik, #vdg, #frameworks, dfaure Cc: abetts, michaelh, ngraham

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

2018-02-15 Thread Kai Uwe Broulik
broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10329 To: broulik, #vdg, #frameworks, dfaure Cc: abetts, michaelh, ngraham

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

2018-02-12 Thread Nathaniel Graham
ngraham added a comment. The Places panel items are always visible without a submenu, so there should never be a situation where the menu consists entirely of submenus. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10329 To: broulik, #vdg, #frameworks, dfaure Cc:

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

2018-02-12 Thread Andres Betts
abetts added a comment. Will this hide "All" menu items or will it hide after a certain amount of them are in the menu? For example, it will turn into a sub menu after 3 items? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10329 To: broulik, #vdg, #frameworks, dfaure

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

2018-02-12 Thread Michael Heidelbach
michaelh added a comment. +1 Looking forward to it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10329 To: broulik, #vdg, #frameworks, dfaure Cc: michaelh, ngraham

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

2018-02-12 Thread Kai Uwe Broulik
broulik added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10329 To: broulik, #vdg, #frameworks, dfaure Cc: ngraham, michaelh

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

2018-02-05 Thread Nathaniel Graham
ngraham accepted this revision as: VDG. ngraham added a comment. Strongly approve. This improves organization, prevents the menu from becoming huge when there are a lot of items, and also eliminates one objection to https://phabricator.kde.org/D10245. REPOSITORY R241 KIO REVISION DETAIL

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

2018-02-05 Thread Kai Uwe Broulik
broulik updated this revision to Diff 26598. broulik added a comment. - Install middle click for new tab event filter also on sub menu REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10329?vs=26595=26598 REVISION DETAIL https://phabricator.kde.org/D10329

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

2018-02-05 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: VDG, Frameworks. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY Avoids letting the menu get huge. This is a straight port from Plasma's task manager