D10409: In linux don't use abstract socket to share file descriptor

This revision was automatically updated to reflect the committed changes. Closed by commit R241:89275d0d1450: In linux dont use abstract socket to share file descriptor (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10409?vs=32413=35320

D10409: In linux don't use abstract socket to share file descriptor

chinmoyr removed a dependency: D10273: Create proper SocketAddress. Restricted Application added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr, #frameworks, ossi Cc: kde-frameworks-devel, dfaure,

D10409: In linux don't use abstract socket to share file descriptor

ossi accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr, #frameworks, ossi Cc: dfaure, michaelh, ngraham, bruns

D10409: In linux don't use abstract socket to share file descriptor

chinmoyr updated this revision to Diff 32413. chinmoyr added a comment. Fix compilation error REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10409?vs=32412=32413 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10409 AFFECTED FILES

D10409: In linux don't use abstract socket to share file descriptor

chinmoyr updated this revision to Diff 32412. chinmoyr edited the summary of this revision. chinmoyr added a comment. Removed dependency on D10273 Rebased on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D10409: In linux don't use abstract socket to share file descriptor

ossi added a comment. not sure why; the changes are semantically separate. my suggestion was to put this before D10273 , thus reducing the latter's size. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr,

D10409: In linux don't use abstract socket to share file descriptor

chinmoyr added a comment. Sorry, I meant D10411 . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr, #frameworks, ossi Cc: dfaure, michaelh

D10409: In linux don't use abstract socket to share file descriptor

ossi added a comment. that contradicts the comments i added to both reviews. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr, #frameworks, ossi Cc: dfaure, michaelh

D10409: In linux don't use abstract socket to share file descriptor

chinmoyr added a comment. @ossi I think the changes in file_unix.cpp from D9966 also belong here(?) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr, #frameworks, ossi Cc: dfaure, michaelh

D10409: In linux don't use abstract socket to share file descriptor

ossi added a comment. the idea is that you can do directory-based access controls on file-based sockets, while the abstract namespace has no controls. otoh, only linux has the abstract namespace, and it supports peer credential verification as well, so this doesn't actually add any

D10409: In linux don't use abstract socket to share file descriptor

dfaure added a comment. Can you explain a bit more in the commit log why this is better? I guess it comes from a discussion elsewhere, but better have the info here and in git in the end. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr, #frameworks,

D10409: In linux don't use abstract socket to share file descriptor

chinmoyr added a dependent revision: D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr, #frameworks, ossi Cc: michaelh, ngraham

D10409: In linux don't use abstract socket to share file descriptor

chinmoyr updated this revision to Diff 26830. chinmoyr added a comment. Added back "/tmp/" prefix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10409?vs=26828=26830 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10409 AFFECTED FILES

D10409: In linux don't use abstract socket to share file descriptor

chinmoyr created this revision. chinmoyr added reviewers: Frameworks, ossi. Restricted Application added a project: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY Use pathname socket for better security. The socket path will be provided by file ioslave. Depends