D10494: update handle- icons for kirigami

andreaska added a comment. In D10494#220993 , @mart wrote: > As discussed on the channel, the icon should be one of these forms, for me are both ok > F5744901: handle-right.png I am for this

D10494: update handle- icons for kirigami

mart added a comment. As discussed on the channel, the icon should be one of these forms, for me are both ok F5744901: handle-right.png F5744903: handle-left.png REPOSITORY R266 Breeze Icons REVISION

D10494: update handle- icons for kirigami

mart reopened this revision. mart added a comment. -1, I don't like it at all REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: matheusm, mmustac, ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

colomar added a comment. Now it has the same icon as the handle for the Context Drawer. On the one hand that's good because they do very similar things, but on the other hand if an app uses both, it could be a bit confusing REPOSITORY R266 Breeze Icons REVISION DETAIL

D10494: update handle- icons for kirigami

mart added a comment. i'm fine with simplifying it, but i still want a visual distinction between left and right, which suggests the sliding action (and if on some platform we would decide to make it something else than a slide, we would adapt using a different icon.. just in that case)

D10494: update handle- icons for kirigami

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:55b56d236e9b: update handle- icons for kirigami (authored by andreask). REPOSITORY R266 Breeze Icons CHANGES SINCE

D10494: update handle- icons for kirigami

andreask added a comment. submitted REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: matheusm, mmustac, ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

alex-l added a comment. +1 for 3-dots icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: matheusm, mmustac, ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

matheusm added a comment. The current icon reminds me of a phone dialer. +1 for the new icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: matheusm, mmustac, ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

ngraham added a comment. In D10494#205867 , @andreask wrote: > it doesn't matter where the element in kirigami swap it's for settings and have an dotted icon would only increase publicity like here in discover have three dot's in each line will

D10494: update handle- icons for kirigami

mmustac added a comment. I agree with Andreas and think that the new icon is a huge improvement. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: mmustac, ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

andreask added a comment. it doesn't matter where the element in kirigami swap it's for settings and have an dotted icon would only increase publicity like here in discover have three dot's in each line will give you the information that you can do something, but the focus is more on the

D10494: update handle- icons for kirigami

ngraham added a comment. Same thing, though. The icons on the left don't scream "Swipe me to the left!" It's a tough one. I have trouble imagining //any// icon that could communicate that, but of course I'm not an icon designer. REPOSITORY R266 Breeze Icons REVISION DETAIL

D10494: update handle- icons for kirigami

andreask added a comment. F5710546: Screenshot_20180213_230517.png sorry wrong screenshot left new right old REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: ngraham,

D10494: update handle- icons for kirigami

ngraham added a comment. Thanks! I hate to throw cold water on your hard work here, but is the new one really any better? I'm not sure either the old or the new icon convey "swipe left here". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To:

D10494: update handle- icons for kirigami

andreask added a comment. F5710538: photo5773697838952328398.jpg left after right before REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

ngraham added a comment. needs moar screenshots REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

andreask added a comment. the old icon with 12 dots are a bit of a overkill now with three dot's compare to three lines. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: #frameworks, michaelh

D10494: update handle- icons for kirigami

andreask added reviewers: alex-l, mart. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: #frameworks, michaelh

D10494: update handle- icons for kirigami

andreask created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. andreask requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10494 AFFECTED