dfaure added a comment.
(btw what I did earlier this week was to introduce ANDROID_COMPILER_PREFIX in
the first place, also for an x86 build...)
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D10599
To: vkrause, #build_system, apol
Cc: apol, dfaure,
dfaure added a comment.
True I've been editing the toolchain file too, probably for the same reason...
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D10599
To: vkrause, #build_system, apol
Cc: apol, dfaure, #frameworks, michaelh
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:16844390dab7: Fix include path for x86 targets (authored
by vkrause).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10599?vs=27392=27396
REVISION
vkrause added a comment.
Interesting, @dfaure, does setting a different ABI/compiler via the command
line actually work for you? Here the command-line parameters are not propagated
to compiler runs for configure checks, so they run with the defaults from the
toolchain file, which fails at
apol added subscribers: dfaure, apol.
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
LGTM.
@dfaure was looking into this as well earlier this week, he may have feedback.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION
vkrause created this revision.
vkrause added a reviewer: Build System.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Frameworks.
vkrause requested review of this revision.
REVISION SUMMARY
ANDROID_TOOLCHAIN is "x86" there, while the
