This revision was automatically updated to reflect the committed changes.
Closed by commit R280:361ca88e13c5: Make DMTX dependency optional (authored by
vkrause).
REPOSITORY
R280 Prison
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10603?vs=27458=27912
REVISION DETAIL
svuorela accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R280 Prison
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10603
To: vkrause, #frameworks, svuorela
Cc: michaelh
vkrause updated this revision to Diff 27458.
vkrause added a comment.
Address review comments.
REPOSITORY
R280 Prison
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10603?vs=27400=27458
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10603
AFFECTED FILES
svuorela added a comment.
Thanks. The ability to cleanly do something like that was one of the reasons
for the api changes I did between qt4 and qt5.
INLINE COMMENTS
> prison.cpp:44
> +#ifdef HAVE_DMTX
> case Prison::DataMatrix:
> return new DataMatrixBarcode;
I'm
vkrause created this revision.
vkrause added reviewers: Frameworks, svuorela.
Restricted Application added a project: Frameworks.
vkrause requested review of this revision.
REVISION SUMMARY
This simplifies deployment on Android, a platform that libdmtx doesn't
seem to support out of the box.
