D10629: Avoid a double emitResult()

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4b68374192ac: Avoid a double emitResult() (authored by jtamate). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10629?vs=27523=27571 REVISION DETAIL

D10629: Avoid a double emitResult()

broulik added a comment. Okay, nevermind. Go for it then! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10629 To: jtamate, #frameworks, #plasma, broulik Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10629: Avoid a double emitResult()

jtamate added a comment. In D10629#209358 , @broulik wrote: > I did a objdump -d to be sure: > dataengines/places/setupdevicejob.cpp setError is from KJob and it only sets a member value (d->error = errorCode;) >

D10629: Avoid a double emitResult()

broulik added a comment. dataengines/places/setupdevicejob.cpp dataengines/mpris2/playeractionjob.cpp dataengines/applicationjobs/jobaction.cpp REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10629 To: jtamate, #frameworks, #plasma, broulik Cc: broulik,

D10629: Avoid a double emitResult()

jtamate updated this revision to Diff 27523. jtamate added a comment. I haven't found more instances of setResult followed by emitResult. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10629?vs=27456=27523 REVISION DETAIL

D10629: Avoid a double emitResult()

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. A quick search through plasma codebase reveals that `setResult` followed by `emitResult` is done quite often. Care to fix these, too? :) REPOSITORY R120 Plasma Workspace BRANCH

D10629: Avoid a double emitResult()

jtamate created this revision. jtamate added reviewers: Frameworks, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY ServiceJob::setResult already does a emitResult.