D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

2018-02-23 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R244:2af64ee1e295: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

2018-02-23 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH removeeffectlessOBJECT_DEPENDS REVISION DETAIL https://phabricator.kde.org/D10665 To: kossebau, #frameworks, apol Cc: michaelh

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

2018-02-22 Thread Friedrich W . H . Kossebau
kossebau added a comment. @apol So +1 on this for pushing? (sorry for possibly confusing you with all the many related review requests :) ) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10665 To: kossebau, #frameworks, apol Cc: michaelh

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

2018-02-19 Thread Friedrich W . H . Kossebau
kossebau added a comment. In D10665#209765 , @apol wrote: > :P could you look into an actual fix? :/ The fix seems needed in automoc AFAICT. Nothing I have ever looked at, and no resources spare to do now. At least I invested so far

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

2018-02-19 Thread Aleix Pol Gonzalez
apol added a comment. :P could you look into an actual fix? :/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10665 To: kossebau, #frameworks, apol Cc: michaelh

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

2018-02-19 Thread Friedrich W . H . Kossebau
kossebau edited the test plan for this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10665 To: kossebau, #frameworks, apol Cc: michaelh

D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file

2018-02-19 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, apol. Restricted Application added a project: Frameworks. kossebau requested review of this revision. REVISION SUMMARY The JSON file argument passed to K_PLUGIN_FACTORY_WITH_JSON ends up being used with the macro